From nobody Mon Sep 15 21:10:56 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5551C5479D for ; Tue, 10 Jan 2023 02:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbjAJCPr (ORCPT ); Mon, 9 Jan 2023 21:15:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbjAJCPn (ORCPT ); Mon, 9 Jan 2023 21:15:43 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B175E48 for ; Mon, 9 Jan 2023 18:15:43 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id e12-20020a25500c000000b007b48c520262so11185539ybb.14 for ; Mon, 09 Jan 2023 18:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=42F60C+bhrH6FdlXo69kMxONv+FtXk0R9aSJOqnDb3o=; b=D65TIw1r6/vVcii8yneiRVwuv4HZR7dZ0GpJ47tt0fzrGJkkfTfRnR+aKQxXYKVfY3 lGyKgWYx6ODAo63+LfGbxhQzK21/e2099zJg1UycyZZ8CzcGGLWWAmLcR3nAA2wzYJ/O i5Rjxp2ZPHJKd3gPkeNJiCYZyNLNPtfxAre166fc1woXsLjGGDjl8hhO5UgSEzBL0Uku +i+6aA4Hjaf4j7g5dmS2Qma8wJrqsVGjqf8LZ3ucM8pyL/hs4rA85EpFxb25zta5tE5a AEOXb8eJsmFvyhfAgTjdC8cAmDYoyvOgcF5fROp2/QTwLC13ZOAr52GME259uRIuVq62 b0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=42F60C+bhrH6FdlXo69kMxONv+FtXk0R9aSJOqnDb3o=; b=4hXAQn+QKAkU/m7zx1Bd8uLjVY8NlV1xbkwSlWMyuyEZf4OacUs/r8FiMsWBuaIvOT I1fwAVDQ6crA3oTMirBf6bVf+NxjAGb8QAfif6Ra8u3++KRs3y9HFgeiXYj2kR4csgjy S9SEd7nq7HDoyUa1HLfB+SjuMYblXbYcRtDXJma4Jx4oGLkDVkafY4nCgr0APHNXdmEx IxaWfSB+15KWe4XxDEU6YtZc1HbQoNS2CChqCSIms6e5WDUSgH5OZDV/7ItkdOQpNggJ eETBoNCRy4bgSSozKTFBN/Lre5lg6UKLVLyAXt1Xa1WztQcO2l1xiqN0NsIYgWlZrO93 L6GQ== X-Gm-Message-State: AFqh2krzGP6I7uHJ24EYLBl51b96ubSfCxSMYiWTpC22Ip8qXNw5FIE9 kUFkzUQO0n3PtnOISQoy3E4hOzMMLI3spyywN8IhoQ== X-Google-Smtp-Source: AMrXdXsPot540It71PJmlWz/rhfw/FchQBUvtGk7/X2jq0XCIHntTag/Zn0MjrHA9Rrc4oCSfFEKrTh3zvTti9q/VUivKA== X-Received: from isaacmanjarres.irv.corp.google.com ([2620:15c:2d:3:3990:5e50:b0f8:bcdd]) (user=isaacmanjarres job=sendgmr) by 2002:a25:ad85:0:b0:7c0:10d2:437 with SMTP id z5-20020a25ad85000000b007c010d20437mr141966ybi.330.1673316942398; Mon, 09 Jan 2023 18:15:42 -0800 (PST) Date: Mon, 9 Jan 2023 18:15:36 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230110021536.1347134-1-isaacmanjarres@google.com> Subject: [PATCH stable-4.14] driver core: Fix bus_type.match() error handling in __driver_attach() From: "Isaac J. Manjarres" To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Marek Szyprowski , Tomeu Vizoso , Russell King , Ulf Hansson Cc: "Isaac J. Manjarres" , stable@vger.kernel.org, Saravana Kannan , kernel-team@android.com, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 27c0d217340e47ec995557f61423ef415afba987 upstream. When a driver registers with a bus, it will attempt to match with every device on the bus through the __driver_attach() function. Currently, if the bus_type.match() function encounters an error that is not -EPROBE_DEFER, __driver_attach() will return a negative error code, which causes the driver registration logic to stop trying to match with the remaining devices on the bus. This behavior is not correct; a failure while matching a driver to a device does not mean that the driver won't be able to match and bind with other devices on the bus. Update the logic in __driver_attach() to reflect this. Fixes: 656b8035b0ee ("ARM: 8524/1: driver cohandle -EPROBE_DEFER from bus_t= ype.match()") Cc: stable@vger.kernel.org Cc: Saravana Kannan Signed-off-by: Isaac J. Manjarres --- drivers/base/dd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index a7bcbb99e820..0f006cad2be7 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -785,8 +785,12 @@ static int __driver_attach(struct device *dev, void *d= ata) */ return 0; } else if (ret < 0) { - dev_dbg(dev, "Bus failed to match device: %d", ret); - return ret; + dev_dbg(dev, "Bus failed to match device: %d\n", ret); + /* + * Driver could not match with device, but may match with + * another device on the bus. + */ + return 0; } /* ret > 0 means positive match */ =20 if (dev->parent) /* Needed for USB */ --=20 2.39.0.314.g84b9a713c41-goog