From nobody Tue Sep 16 05:16:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA368C677F1 for ; Sun, 8 Jan 2023 19:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236598AbjAHS6e (ORCPT ); Sun, 8 Jan 2023 13:58:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235956AbjAHS6C (ORCPT ); Sun, 8 Jan 2023 13:58:02 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51601E00C for ; Sun, 8 Jan 2023 10:58:02 -0800 (PST) Received: from dslb-188-096-147-053.188.096.pools.vodafone-ip.de ([188.96.147.53] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pEari-0003b8-UQ; Sun, 08 Jan 2023 19:57:55 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 06/13] staging: r8188eu: make rtl8188eu_inirp_init a void function Date: Sun, 8 Jan 2023 19:57:31 +0100 Message-Id: <20230108185738.597105-7-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230108185738.597105-1-martin@kaiser.cx> References: <20230108185738.597105-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtl8188eu_inirp_init's return value is not checked by its caller. Make rtl8188eu_inirp_init a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_halinit.c | 14 +++----------- drivers/staging/r8188eu/include/hal_intf.h | 2 +- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index d28b4dc2a767..afa24a59fbb3 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -851,29 +851,21 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter) return _SUCCESS; } =20 -unsigned int rtl8188eu_inirp_init(struct adapter *Adapter) +void rtl8188eu_inirp_init(struct adapter *Adapter) { u8 i; struct recv_buf *precvbuf; - uint status; struct recv_priv *precvpriv =3D &Adapter->recvpriv; =20 - status =3D _SUCCESS; - /* issue Rx irp to receive data */ precvbuf =3D (struct recv_buf *)precvpriv->precv_buf; for (i =3D 0; i < NR_RECVBUFF; i++) { - if (!rtw_read_port(Adapter, (unsigned char *)precvbuf)) { - status =3D _FAIL; - goto exit; - } + if (!rtw_read_port(Adapter, (unsigned char *)precvbuf)) + return; =20 precvbuf++; precvpriv->free_recv_buf_queue_cnt--; } - -exit: - return status; } =20 /* */ diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r= 8188eu/include/hal_intf.h index ac6e3f95c5b7..767f97c5f85d 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -26,7 +26,7 @@ void UpdateHalRAMask8188EUsb(struct adapter *adapt, u32 m= ac_id, u8 rssi_level); int rtl8188e_IOL_exec_cmds_sync(struct adapter *adapter, struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt); =20 -unsigned int rtl8188eu_inirp_init(struct adapter *Adapter); +void rtl8188eu_inirp_init(struct adapter *Adapter); =20 uint rtw_hal_init(struct adapter *padapter); uint rtw_hal_deinit(struct adapter *padapter); --=20 2.30.2