From nobody Tue Sep 16 10:49:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF0EBC46467 for ; Wed, 4 Jan 2023 13:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239210AbjADNHP (ORCPT ); Wed, 4 Jan 2023 08:07:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239347AbjADNGa (ORCPT ); Wed, 4 Jan 2023 08:06:30 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C72537517 for ; Wed, 4 Jan 2023 05:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672837575; x=1704373575; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LJMM7gEaI2hxsNih1EgB3wunRnyqdXlkoKPFLMX6xOs=; b=UO1yZ01+5nbitr12vWZYauAH/6Ljxa3nXkVhQhZSFT6OTx6RB9jsSg17 QSafmfDtxDaWzu+Vxso+fgVjVYMm422iwcn87TVl5mRiLGKPrqS3qkl5M QlHNHEHbyk+tH5nryNJp40dzmiIxjZWX1TNLCsQHhvLxMYOmqZ67mTKG4 fOi/39F85+u+WvEWyey1/zqAvapBFYmDt6qCaW0Ru1XAaqoGV36Ow7Zcd C7YqjqHijPzUAyUXyprhe6WQdSvn67Xrr3asUNXiqRlua5eIxUeWfgTM0 XsK8hU8bG6IecRKTe9pRmaATCpur+8jD7eXw3STATGcrmw7o38OqrVZTJ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="320639875" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="320639875" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 05:06:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="797529076" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="797529076" Received: from allen-box.sh.intel.com ([10.239.159.48]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2023 05:06:08 -0800 From: Lu Baolu To: Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Kevin Tian , Will Deacon , Robin Murphy , Jean-Philippe Brucker Cc: Suravee Suthikulpanit , Hector Martin , Sven Peter , Rob Clark , Marek Szyprowski , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Yong Wu , Matthias Brugger , Heiko Stuebner , Matthew Rosato , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Thierry Reding , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH v4 08/19] iommu/sprd: Remove detach_dev callback Date: Wed, 4 Jan 2023 20:57:14 +0800 Message-Id: <20230104125725.271850-9-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230104125725.271850-1-baolu.lu@linux.intel.com> References: <20230104125725.271850-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The IOMMU driver supports default domain, so the detach_dev op will never be called. Remove it to avoid dead code. Reviewed-by: Jason Gunthorpe Acked-by: Chunyan Zhang Signed-off-by: Lu Baolu --- drivers/iommu/sprd-iommu.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c index 219bfa11f7f4..ae94d74b73f4 100644 --- a/drivers/iommu/sprd-iommu.c +++ b/drivers/iommu/sprd-iommu.c @@ -255,21 +255,6 @@ static int sprd_iommu_attach_device(struct iommu_domai= n *domain, return 0; } =20 -static void sprd_iommu_detach_device(struct iommu_domain *domain, - struct device *dev) -{ - struct sprd_iommu_domain *dom =3D to_sprd_domain(domain); - struct sprd_iommu_device *sdev =3D dom->sdev; - size_t pgt_size =3D sprd_iommu_pgt_size(domain); - - if (!sdev) - return; - - dma_free_coherent(sdev->dev, pgt_size, dom->pgt_va, dom->pgt_pa); - sprd_iommu_hw_en(sdev, false); - dom->sdev =3D NULL; -} - static int sprd_iommu_map(struct iommu_domain *domain, unsigned long iova, phys_addr_t paddr, size_t pgsize, size_t pgcount, int prot, gfp_t gfp, size_t *mapped) @@ -414,7 +399,6 @@ static const struct iommu_ops sprd_iommu_ops =3D { .owner =3D THIS_MODULE, .default_domain_ops =3D &(const struct iommu_domain_ops) { .attach_dev =3D sprd_iommu_attach_device, - .detach_dev =3D sprd_iommu_detach_device, .map_pages =3D sprd_iommu_map, .unmap_pages =3D sprd_iommu_unmap, .iotlb_sync_map =3D sprd_iommu_sync_map, --=20 2.34.1