From nobody Tue Sep 16 14:08:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FAFC3DA7D for ; Tue, 3 Jan 2023 18:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238612AbjACSCd (ORCPT ); Tue, 3 Jan 2023 13:02:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238527AbjACSC1 (ORCPT ); Tue, 3 Jan 2023 13:02:27 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A72A11A2A for ; Tue, 3 Jan 2023 10:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672768944; x=1704304944; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ksdr92gH6DZ8dyITiXCe+MBzgbUi62N2nRt+rCqGjeE=; b=U47aOgG99MHa+KoPh5oq37PvW/zwKn/8w2g/HoY1b/2kOqYLWB+nBY21 NgGKLb57YQCAaKMxhTQWSe7ed6uGkIkmE0ccT+85RMBFQHgw/J5h2xT9f t1N4WqUXgqnhBEJMl/zl0rQOWUTcXMusZcdQ3N+AdGVnGu563NBkoDHNf qUEA7LgXahVoMjy1Gsg1zdXQOYt8GSx5fV131RZfzCtwRgdHDLyqonoe1 L6bQLIFT3WLF5VM06ajQC+EFyQn4oekejpHGMkIzP1jcqx1XXk8XpNnja yBX6Z8H9+SJhXCrvTuDM6oPFgXc19nrt3h+m60WD7DrLWOpWcPLXS7vSp g==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="384010646" X-IronPort-AV: E=Sophos;i="5.96,297,1665471600"; d="scan'208";a="384010646" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2023 10:02:22 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="654876885" X-IronPort-AV: E=Sophos;i="5.96,297,1665471600"; d="scan'208";a="654876885" Received: from araj-ucode.jf.intel.com ([10.23.0.19]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2023 10:02:24 -0800 From: Ashok Raj To: Borislav Petkov , Thomas Gleixner Cc: X86-kernel , LKML Mailing List , Ashok Raj , Dave Hansen , Tony Luck , Alison Schofield , Reinette Chatre , Tom Lendacky Subject: [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful Date: Tue, 3 Jan 2023 10:02:09 -0800 Message-Id: <20230103180212.333496-4-ashok.raj@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230103180212.333496-1-ashok.raj@intel.com> References: <20230103180212.333496-1-ashok.raj@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Right now, microcode loading failures and successes print the same message "Reloading completed". This is misleading to users. Display the updated revision number only if an update was successful. Suggested-by: Thomas Gleixner Signed-off-by: Ashok Raj Reviewed-by: Tony Luck Link: https://lore.kernel.org/lkml/874judpqqd.ffs@tglx/ Cc: LKML Cc: x86 Cc: Tony Luck Cc: Dave Hansen Cc: Alison Schofield Cc: Reinette Chatre Cc: Thomas Gleixner Cc: Tom Lendacky --- arch/x86/kernel/cpu/microcode/core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index 14d9031ed68a..e67f8923f119 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -455,11 +455,12 @@ static int microcode_reload_late(void) microcode_store_cpu_caps(&info); =20 ret =3D stop_machine_cpuslocked(__reload_late, NULL, cpu_online_mask); - if (ret =3D=3D 0) - microcode_check(&info); =20 - pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n", - old, boot_cpu_data.microcode); + if (ret =3D=3D 0) { + pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n", + old, boot_cpu_data.microcode); + microcode_check(&info); + } =20 return ret; } --=20 2.34.1