From nobody Tue Sep 16 15:57:02 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABBFC3DA7A for ; Mon, 2 Jan 2023 18:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236264AbjABSBv (ORCPT ); Mon, 2 Jan 2023 13:01:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233748AbjABSB2 (ORCPT ); Mon, 2 Jan 2023 13:01:28 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FA423896 for ; Mon, 2 Jan 2023 10:01:27 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id bn26so7549717wrb.0 for ; Mon, 02 Jan 2023 10:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3POAW24Ia6Q6A+aQpi4Ruj0SmwaygTczZXF7y8o1qdY=; b=HTYIjR510LBjsWbfxE9VaopKOa5/Xr077RkfF8WnFgFGDU8JLmuRws9sjNaQ4PWy4g +NqPU3DAkmPBR9NLjN9clgGhgu5WTMu+iq/sMhKryWNqKNwJU9oS7CBYLN8yXgJex2Nv RXaN3kkfM3kRNIeDQ0ULuLPIM1870Q+EbFVAI8at7YtU0TD0W2yLYU9PXNZjZHV7VxiC fM7Phn92mVdsMaL6Y33b7OawzHZyjBcdJvk2Q0I+m8m6GaZ71LzBLVhvX2pztvLSmbiv pwUlgZB9YBSj0OsbdsaCqzuSuNkM0EV/3WHTBUGk35koMjUceQvkDyZ2ze5NVr1e+CfP SFSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3POAW24Ia6Q6A+aQpi4Ruj0SmwaygTczZXF7y8o1qdY=; b=LYoN7i6IpG9+kgj9kRUKsVDLKJ+O/+0tmOeOKw8/lrPtH7pUPTjpLNDCOs4FOxCj/H TFPEmMgDXrl71h3Knh96yOda/4kf8TBAy69DYm1Y+QOHzRx54ZZ9+jNkvSzWokkuOm1c pCs40Qcsv6lMySME+X1kZGZvkEPzI1ctd7S/KVQUsD8j/LzGWoi2ugQZ0Zc0IVmQEITc roAbGhbCZO+xDH9zw64GQQUXdd7VjoP14gvvJL4SfFAmT+Qr6EV/0TOJm/AqN43NsrWU zHNi/Xzb85L28OTkkdGsl5dv1yeX1mhz9Vzu9ywPoAZAPFrr3EwAZ6j5+ADLvP1glfjp 04ZQ== X-Gm-Message-State: AFqh2koC2RvF1qYJqzAOkwam+LDPwvg9GFnXBaSMqyVz63Xdw89Q/U1S yYqZucf1r7GE0Mw77v5mCoErvw== X-Google-Smtp-Source: AMrXdXstrEmEY5GESCPVDDdHHvZcc3FS3MM/lfrjVSY0rg9P4mTlz1JvVcFUp7droAgj/omnG9C7fw== X-Received: by 2002:adf:f00c:0:b0:242:63e5:fdaa with SMTP id j12-20020adff00c000000b0024263e5fdaamr23363745wro.62.1672682485581; Mon, 02 Jan 2023 10:01:25 -0800 (PST) Received: from mai.. (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b0027cb20605e3sm21375588wrs.105.2023.01.02.10.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 10:01:25 -0800 (PST) From: Daniel Lezcano X-Google-Original-From: Daniel Lezcano To: daniel.lezcano@linaro.org, rafael@kernel.org, srinivas.pandruvada@linux.intel.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rui.zhang@intel.com, Amit Kucheria Subject: [PATCH v2 2/3] thermal/drivers/intel: Use generic trip points for intel_pch Date: Mon, 2 Jan 2023 19:01:11 +0100 Message-Id: <20230102180112.1954082-3-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102180112.1954082-1-daniel.lezcano@kernel.org> References: <20230102180112.1954082-1-daniel.lezcano@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daniel Lezcano The thermal framework gives the possibility to register the trip points with the thermal zone. When that is done, no get_trip_* ops are needed and they can be removed. Convert the ops content logic into generic trip points and register them with the thermal zone. In order to consolidate the code, use the ACPI thermal framework API to fill the generic trip point from the ACPI tables. It has been tested on a Intel i7-8650U - x280 with the INT3400, the PCH, ACPITZ, and x86_pkg_temp. No regression observed so far. Signed-off-by: Daniel Lezcano --- drivers/thermal/intel/intel_pch_thermal.c | 88 +++++------------------ 1 file changed, 19 insertions(+), 69 deletions(-) diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/in= tel/intel_pch_thermal.c index dabf11a687a1..530fe9b38381 100644 --- a/drivers/thermal/intel/intel_pch_thermal.c +++ b/drivers/thermal/intel/intel_pch_thermal.c @@ -65,6 +65,8 @@ #define WPT_TEMP_OFFSET (PCH_TEMP_OFFSET * MILLIDEGREE_PER_DEGREE) #define GET_PCH_TEMP(x) (((x) / 2) + PCH_TEMP_OFFSET) =20 +#define PCH_MAX_TRIPS 3 /* critical, hot, passive */ + /* Amount of time for each cooling delay, 100ms by default for now */ static unsigned int delay_timeout =3D 100; module_param(delay_timeout, int, 0644); @@ -82,12 +84,7 @@ struct pch_thermal_device { const struct pch_dev_ops *ops; struct pci_dev *pdev; struct thermal_zone_device *tzd; - int crt_trip_id; - unsigned long crt_temp; - int hot_trip_id; - unsigned long hot_temp; - int psv_trip_id; - unsigned long psv_temp; + struct thermal_trip trips[PCH_MAX_TRIPS]; bool bios_enabled; }; =20 @@ -102,33 +99,22 @@ static void pch_wpt_add_acpi_psv_trip(struct pch_therm= al_device *ptd, int *nr_trips) { struct acpi_device *adev; - - ptd->psv_trip_id =3D -1; + int ret; =20 adev =3D ACPI_COMPANION(&ptd->pdev->dev); - if (adev) { - unsigned long long r; - acpi_status status; - - status =3D acpi_evaluate_integer(adev->handle, "_PSV", NULL, - &r); - if (ACPI_SUCCESS(status)) { - unsigned long trip_temp; - - trip_temp =3D deci_kelvin_to_millicelsius(r); - if (trip_temp) { - ptd->psv_temp =3D trip_temp; - ptd->psv_trip_id =3D *nr_trips; - ++(*nr_trips); - } - } - } + if (!adev) + return; + =09 + ret =3D thermal_acpi_trip_psv(adev, &ptd->trips[*nr_trips]); + if (ret) + return; + + ++(*nr_trips); } #else static void pch_wpt_add_acpi_psv_trip(struct pch_thermal_device *ptd, int *nr_trips) { - ptd->psv_trip_id =3D -1; =20 } #endif @@ -163,21 +149,19 @@ static int pch_wpt_init(struct pch_thermal_device *pt= d, int *nr_trips) } =20 read_trips: - ptd->crt_trip_id =3D -1; trip_temp =3D readw(ptd->hw_base + WPT_CTT); trip_temp &=3D 0x1FF; if (trip_temp) { - ptd->crt_temp =3D GET_WPT_TEMP(trip_temp); - ptd->crt_trip_id =3D 0; + ptd->trips[*nr_trips].temperature =3D GET_WPT_TEMP(trip_temp); + ptd->trips[*nr_trips].type =3D THERMAL_TRIP_CRITICAL; ++(*nr_trips); } =20 - ptd->hot_trip_id =3D -1; trip_temp =3D readw(ptd->hw_base + WPT_PHL); trip_temp &=3D 0x1FF; if (trip_temp) { - ptd->hot_temp =3D GET_WPT_TEMP(trip_temp); - ptd->hot_trip_id =3D *nr_trips; + ptd->trips[*nr_trips].temperature =3D GET_WPT_TEMP(trip_temp); + ptd->trips[*nr_trips].type =3D THERMAL_TRIP_HOT; ++(*nr_trips); } =20 @@ -298,39 +282,6 @@ static int pch_thermal_get_temp(struct thermal_zone_de= vice *tzd, int *temp) return ptd->ops->get_temp(ptd, temp); } =20 -static int pch_get_trip_type(struct thermal_zone_device *tzd, int trip, - enum thermal_trip_type *type) -{ - struct pch_thermal_device *ptd =3D tzd->devdata; - - if (ptd->crt_trip_id =3D=3D trip) - *type =3D THERMAL_TRIP_CRITICAL; - else if (ptd->hot_trip_id =3D=3D trip) - *type =3D THERMAL_TRIP_HOT; - else if (ptd->psv_trip_id =3D=3D trip) - *type =3D THERMAL_TRIP_PASSIVE; - else - return -EINVAL; - - return 0; -} - -static int pch_get_trip_temp(struct thermal_zone_device *tzd, int trip, in= t *temp) -{ - struct pch_thermal_device *ptd =3D tzd->devdata; - - if (ptd->crt_trip_id =3D=3D trip) - *temp =3D ptd->crt_temp; - else if (ptd->hot_trip_id =3D=3D trip) - *temp =3D ptd->hot_temp; - else if (ptd->psv_trip_id =3D=3D trip) - *temp =3D ptd->psv_temp; - else - return -EINVAL; - - return 0; -} - static void pch_critical(struct thermal_zone_device *tzd) { dev_dbg(&tzd->device, "%s: critical temperature reached\n", tzd->type); @@ -338,8 +289,6 @@ static void pch_critical(struct thermal_zone_device *tz= d) =20 static struct thermal_zone_device_ops tzd_ops =3D { .get_temp =3D pch_thermal_get_temp, - .get_trip_type =3D pch_get_trip_type, - .get_trip_temp =3D pch_get_trip_temp, .critical =3D pch_critical, }; =20 @@ -423,8 +372,9 @@ static int intel_pch_thermal_probe(struct pci_dev *pdev, if (err) goto error_cleanup; =20 - ptd->tzd =3D thermal_zone_device_register(bi->name, nr_trips, 0, ptd, - &tzd_ops, NULL, 0, 0); + ptd->tzd =3D thermal_zone_device_register_with_trips(bi->name, ptd->trips, + nr_trips, 0, ptd, + &tzd_ops, NULL, 0, 0); if (IS_ERR(ptd->tzd)) { dev_err(&pdev->dev, "Failed to register thermal zone %s\n", bi->name); --=20 2.34.1