From nobody Tue Sep 16 14:03:11 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 486AAC3DA7A for ; Mon, 2 Jan 2023 11:12:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232065AbjABLMX (ORCPT ); Mon, 2 Jan 2023 06:12:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbjABLMU (ORCPT ); Mon, 2 Jan 2023 06:12:20 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCF4296 for ; Mon, 2 Jan 2023 03:12:18 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 9643132008FA; Mon, 2 Jan 2023 06:12:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 02 Jan 2023 06:12:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= tom-fitzhenry.me.uk; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm2; t=1672657934; x=1672744334; bh=Q4 jkeKlxInSpmYKiriM5hlWL/XAXcD0E9o2hKjrYh20=; b=J8PeGCvU8c4eObKh3+ bNGsv051SDJEla1S5Pj1pZS+4oiBeiPA/WUNzbh4KnaKQAKBpSP6wCeXH6/M8PNz PA2lN6MxKizG6PBWpVEGSVIs3hNUxJOLjyTMxXrrHlNMdUgclBz9Y61T2BvOv4/5 4J1e3EoF+aHlJelSnoZVeAZML/IUMLwkUp+il29KbwtNMa6vqXJluxOQmz/xJ94m 7gmworcqDkAGhIY+NoGUpQyHIvvD9J2FKoiblJgBXjLGXnVgM7FhFGwMyjWjS/9F dDeSytUO3uq2HAzQdJEJ4ST7gVCzOWM2sotAVKHL+ZrwrFJMPPBWUVdu9ZKpgH5n srhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672657934; x=1672744334; bh=Q4jkeKlxInSpmYKiriM5hlWL/XAXcD0E9o2 hKjrYh20=; b=nvG1VVEmsRKsRIRYJX0fXBI5yMqFNBWpzfDL6xA5dRSLI/h2AFX 1o5UgATbL8qK4jwbWgK/0W97QQ4k8S1KtSNhh3bDZZW8XXCwKNHmiTIPlVCutezl egc+hi6N7cD2PlUA6CP4n1mtlwCV6yce8Pkki8FXuHfftR1siP9wWrnEo0rVs52/ EhxBmpCaA9kKYVZoq+HxywwZaZ18z93ETAocp/fWfwsK+qWCoPyH/90ZC0ztRnRL VHP11QLjJvUyDeLWB3BsPa7E8oEE0Idrje55mXHG5kn51sQ12Mzholnj+iuiidY7 d9MolemNJG81h9qpT9DLCG1S7QMJVRGzIOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvohhmucfhihht iihhvghnrhihuceothhomhesthhomhdqfhhithiihhgvnhhrhidrmhgvrdhukheqnecugg ftrfgrthhtvghrnhepfeeivdegffeftefhkeeugfdvudetfedtieejuddugfejueektddv vdefueetgeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhomhesthhomhdqfhhithiihhgvnhhrhidrmhgvrdhukh X-ME-Proxy: Feedback-ID: iefc945ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jan 2023 06:12:10 -0500 (EST) From: Tom Fitzhenry To: Lee Jones , Neil Armstrong Cc: Ondrej Jirman , Javier Martinez Canillas , Martijn Braam , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Fitzhenry Subject: [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818 Date: Mon, 2 Jan 2023 22:11:47 +1100 Message-Id: <20230102111147.2580861-1-tom@tom-fitzhenry.me.uk> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. This line was removed in commit 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. Changes in v2: - Add a Fixes tag (Javier Martinez Canillas). - Add Javier Martinez Canillas's Reviewed-by tag. - Add Neil Armstrong's Acked-by tag. Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") Signed-off-by: Tom Fitzhenry Reviewed-by: Javier Martinez Canillas Acked-by: Neil Armstrong --- drivers/mfd/rk808.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index f44fc3f080a8..0f22ef61e817 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] =3D { }; =20 static const struct mfd_cell rk818s[] =3D { + { .name =3D "rk808-clkout", .id =3D PLATFORM_DEVID_NONE, }, { .name =3D "rk808-regulator", .id =3D PLATFORM_DEVID_NONE, }, { .name =3D "rk808-rtc", base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5 --=20 2.38.1