From nobody Tue Sep 16 16:06:11 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8F9C3DA7A for ; Mon, 2 Jan 2023 09:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232139AbjABJxt (ORCPT ); Mon, 2 Jan 2023 04:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjABJxr (ORCPT ); Mon, 2 Jan 2023 04:53:47 -0500 Received: from forwardcorp1b.mail.yandex.net (forwardcorp1b.mail.yandex.net [178.154.239.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFDE997; Mon, 2 Jan 2023 01:53:43 -0800 (PST) Received: from iva8-3a65cceff156.qloud-c.yandex.net (iva8-3a65cceff156.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:2d80:0:640:3a65:ccef]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 539D95FC74; Mon, 2 Jan 2023 12:53:39 +0300 (MSK) Received: from d-tatianin-nix.yandex-team.ru (unknown [2a02:6b8:b081:b5b0::1:24]) by iva8-3a65cceff156.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id ZrRZJ61QeqM1-lKOQdv3c; Mon, 02 Jan 2023 12:53:38 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1672653218; bh=OSlF1FBWmkQTxMIdjkbxUlju+doziQNLf7JrpXASqbc=; h=Message-Id:Date:Cc:Subject:To:From; b=LyiSZrvSa+tfY9OMVqJhxhL9NYKAnJVi8LKwzb1RDWBPoiNxAnuK4HNew46qojdla M1MbO7KFtHWV1rNxGScUPZPFGFUWAPEtsvHG9oDGIoV0KMDT8dYruHrudG5potoWGW b9S3wbfAG6bRSsJMl/CKNEJ2lJWj3FUEMQf5HcHo= Authentication-Results: iva8-3a65cceff156.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Daniil Tatianin To: netdev@vger.kernel.org Cc: Daniil Tatianin , linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator Date: Mon, 2 Jan 2023 12:53:35 +0300 Message-Id: <20230102095335.94249-1-d-tatianin@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Otherwise we would dereference a NULL aggregator pointer when calling __set_agg_ports_ready on the line below. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Daniil Tatianin Reviewed-by: Jiri Pirko --- Changes since v1: - Added a fixes tag --- drivers/net/bonding/bond_3ad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index acb6ff0be5ff..320e5461853f 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c @@ -1520,6 +1520,7 @@ static void ad_port_selection_logic(struct port *port= , bool *update_slave_arr) slave_err(bond->dev, port->slave->dev, "Port %d did not find a suitable aggregator\n", port->actor_port_number); + return; } } /* if all aggregator's ports are READY_N =3D=3D TRUE, set ready=3DTRUE --=20 2.25.1