From nobody Tue Sep 16 16:01:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8BAC4332F for ; Sat, 31 Dec 2022 08:27:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbiLaI1y (ORCPT ); Sat, 31 Dec 2022 03:27:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbiLaI1u (ORCPT ); Sat, 31 Dec 2022 03:27:50 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B5E565EF; Sat, 31 Dec 2022 00:27:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C522960187; Sat, 31 Dec 2022 08:27:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5162C433EF; Sat, 31 Dec 2022 08:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672475267; bh=iBc1fAUXSFsIQMuhYma5C4ygbhkz87Qy8UNKiWljms4=; h=From:To:Cc:Subject:Date:From; b=qmwyJtYd4iMHwutdnAzXAsUJB5k52lpIU6QVX3ZUFbLJO+BPzI9guqkTi0tgHbARO uUNlkptiQd65qB/hZlImV3GG4pMb18FLb7frnWMX1yxsE3hl4F5D1dKOEE5AYub9yY JAVnnrjHVp+C2MA9jOg00BsSbjaCOQ3iqt4wF2zs1FjJrj0Ft/REN69BFJ5vBh1cJ4 bWdGxdPUdeiBqAwldT1LFiaS/Kp/KgEQUgQPjL7iqcjevY+SlujhNs8OvaQf4ITZW0 TQYikGYCMn607q9aM7vxdGQUpLyHxmNo5KYvUJMVAhYMBniE4fkSGVNIvu+EI5qMfH hDZbo74sT3U+g== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org, Miguel Ojeda , rust-for-linux@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Tom Rix , llvm@lists.linux.dev Subject: [PATCH] kbuild: rust: remove -v option of scripts/rust_is_available.sh Date: Sat, 31 Dec 2022 17:27:39 +0900 Message-Id: <20221231082739.1629735-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The -v option is passed when this scripts is invoked from Makefile, but not when invoked from Kconfig. As you can see in scripts/Kconfig.include, the 'success' macro suppresses stdout and stderr anyway, so this script does not need to be quiet. Signed-off-by: Masahiro Yamada Reviewed-by: Miguel Ojeda Tested-by: Miguel Ojeda --- Makefile | 4 +- scripts/rust_is_available.sh | 94 +++++++++++++++--------------------- 2 files changed, 42 insertions(+), 56 deletions(-) diff --git a/Makefile b/Makefile index 8daf1be6a2e4..6b2a65f1aeaf 100644 --- a/Makefile +++ b/Makefile @@ -1280,7 +1280,7 @@ prepare0: archprepare # All the preparing.. prepare: prepare0 ifdef CONFIG_RUST - $(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh -v + $(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh $(Q)$(MAKE) $(build)=3Drust endif =20 @@ -1806,7 +1806,7 @@ $(DOC_TARGETS): # "Is Rust available?" target PHONY +=3D rustavailable rustavailable: - $(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh -v && echo "R= ust is available!" + $(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh && echo "Rust= is available!" =20 # Documentation target # diff --git a/scripts/rust_is_available.sh b/scripts/rust_is_available.sh index aebbf1913970..eaeafebf8572 100755 --- a/scripts/rust_is_available.sh +++ b/scripts/rust_is_available.sh @@ -23,21 +23,17 @@ get_canonical_version() =20 # Check that the Rust compiler exists. if ! command -v "$RUSTC" >/dev/null; then - if [ "$1" =3D -v ]; then - echo >&2 "***" - echo >&2 "*** Rust compiler '$RUSTC' could not be found." - echo >&2 "***" - fi + echo >&2 "***" + echo >&2 "*** Rust compiler '$RUSTC' could not be found." + echo >&2 "***" exit 1 fi =20 # Check that the Rust bindings generator exists. if ! command -v "$BINDGEN" >/dev/null; then - if [ "$1" =3D -v ]; then - echo >&2 "***" - echo >&2 "*** Rust bindings generator '$BINDGEN' could not be found." - echo >&2 "***" - fi + echo >&2 "***" + echo >&2 "*** Rust bindings generator '$BINDGEN' could not be found." + echo >&2 "***" exit 1 fi =20 @@ -53,16 +49,14 @@ rust_compiler_min_version=3D$($min_tool_version rustc) rust_compiler_cversion=3D$(get_canonical_version $rust_compiler_version) rust_compiler_min_cversion=3D$(get_canonical_version $rust_compiler_min_ve= rsion) if [ "$rust_compiler_cversion" -lt "$rust_compiler_min_cversion" ]; then - if [ "$1" =3D -v ]; then - echo >&2 "***" - echo >&2 "*** Rust compiler '$RUSTC' is too old." - echo >&2 "*** Your version: $rust_compiler_version" - echo >&2 "*** Minimum version: $rust_compiler_min_version" - echo >&2 "***" - fi + echo >&2 "***" + echo >&2 "*** Rust compiler '$RUSTC' is too old." + echo >&2 "*** Your version: $rust_compiler_version" + echo >&2 "*** Minimum version: $rust_compiler_min_version" + echo >&2 "***" exit 1 fi -if [ "$1" =3D -v ] && [ "$rust_compiler_cversion" -gt "$rust_compiler_min_= cversion" ]; then +if [ "$rust_compiler_cversion" -gt "$rust_compiler_min_cversion" ]; then echo >&2 "***" echo >&2 "*** Rust compiler '$RUSTC' is too new. This may or may not work= ." echo >&2 "*** Your version: $rust_compiler_version" @@ -82,16 +76,14 @@ rust_bindings_generator_min_version=3D$($min_tool_versi= on bindgen) rust_bindings_generator_cversion=3D$(get_canonical_version $rust_bindings_= generator_version) rust_bindings_generator_min_cversion=3D$(get_canonical_version $rust_bindi= ngs_generator_min_version) if [ "$rust_bindings_generator_cversion" -lt "$rust_bindings_generator_min= _cversion" ]; then - if [ "$1" =3D -v ]; then - echo >&2 "***" - echo >&2 "*** Rust bindings generator '$BINDGEN' is too old." - echo >&2 "*** Your version: $rust_bindings_generator_version" - echo >&2 "*** Minimum version: $rust_bindings_generator_min_version" - echo >&2 "***" - fi + echo >&2 "***" + echo >&2 "*** Rust bindings generator '$BINDGEN' is too old." + echo >&2 "*** Your version: $rust_bindings_generator_version" + echo >&2 "*** Minimum version: $rust_bindings_generator_min_version" + echo >&2 "***" exit 1 fi -if [ "$1" =3D -v ] && [ "$rust_bindings_generator_cversion" -gt "$rust_bin= dings_generator_min_cversion" ]; then +if [ "$rust_bindings_generator_cversion" -gt "$rust_bindings_generator_min= _cversion" ]; then echo >&2 "***" echo >&2 "*** Rust bindings generator '$BINDGEN' is too new. This may or = may not work." echo >&2 "*** Your version: $rust_bindings_generator_version" @@ -110,13 +102,11 @@ bindgen_libclang_min_version=3D$($min_tool_version ll= vm) bindgen_libclang_cversion=3D$(get_canonical_version $bindgen_libclang_vers= ion) bindgen_libclang_min_cversion=3D$(get_canonical_version $bindgen_libclang_= min_version) if [ "$bindgen_libclang_cversion" -lt "$bindgen_libclang_min_cversion" ]; = then - if [ "$1" =3D -v ]; then - echo >&2 "***" - echo >&2 "*** libclang (used by the Rust bindings generator '$BINDGEN') = is too old." - echo >&2 "*** Your version: $bindgen_libclang_version" - echo >&2 "*** Minimum version: $bindgen_libclang_min_version" - echo >&2 "***" - fi + echo >&2 "***" + echo >&2 "*** libclang (used by the Rust bindings generator '$BINDGEN') i= s too old." + echo >&2 "*** Your version: $bindgen_libclang_version" + echo >&2 "*** Minimum version: $bindgen_libclang_min_version" + echo >&2 "***" exit 1 fi =20 @@ -125,21 +115,19 @@ fi # # In the future, we might be able to perform a full version check, see # https://github.com/rust-lang/rust-bindgen/issues/2138. -if [ "$1" =3D -v ]; then - cc_name=3D$($(dirname $0)/cc-version.sh "$CC" | cut -f1 -d' ') - if [ "$cc_name" =3D Clang ]; then - clang_version=3D$( \ - LC_ALL=3DC "$CC" --version 2>/dev/null \ - | sed -nE '1s:.*version ([0-9]+\.[0-9]+\.[0-9]+).*:\1:p' - ) - if [ "$clang_version" !=3D "$bindgen_libclang_version" ]; then - echo >&2 "***" - echo >&2 "*** libclang (used by the Rust bindings generator '$BINDGEN')" - echo >&2 "*** version does not match Clang's. This may be a problem." - echo >&2 "*** libclang version: $bindgen_libclang_version" - echo >&2 "*** Clang version: $clang_version" - echo >&2 "***" - fi +cc_name=3D$($(dirname $0)/cc-version.sh "$CC" | cut -f1 -d' ') +if [ "$cc_name" =3D Clang ]; then + clang_version=3D$( \ + LC_ALL=3DC "$CC" --version 2>/dev/null \ + | sed -nE '1s:.*version ([0-9]+\.[0-9]+\.[0-9]+).*:\1:p' + ) + if [ "$clang_version" !=3D "$bindgen_libclang_version" ]; then + echo >&2 "***" + echo >&2 "*** libclang (used by the Rust bindings generator '$BINDGEN')" + echo >&2 "*** version does not match Clang's. This may be a problem." + echo >&2 "*** libclang version: $bindgen_libclang_version" + echo >&2 "*** Clang version: $clang_version" + echo >&2 "***" fi fi =20 @@ -150,11 +138,9 @@ rustc_sysroot=3D$("$RUSTC" $KRUSTFLAGS --print sysroot) rustc_src=3D${RUST_LIB_SRC:-"$rustc_sysroot/lib/rustlib/src/rust/library"} rustc_src_core=3D"$rustc_src/core/src/lib.rs" if [ ! -e "$rustc_src_core" ]; then - if [ "$1" =3D -v ]; then - echo >&2 "***" - echo >&2 "*** Source code for the 'core' standard library could not be f= ound" - echo >&2 "*** at '$rustc_src_core'." - echo >&2 "***" - fi + echo >&2 "***" + echo >&2 "*** Source code for the 'core' standard library could not be fo= und" + echo >&2 "*** at '$rustc_src_core'." + echo >&2 "***" exit 1 fi --=20 2.34.1