From nobody Tue Sep 16 20:00:19 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B47C4167B for ; Fri, 30 Dec 2022 18:07:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235434AbiL3SHT (ORCPT ); Fri, 30 Dec 2022 13:07:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235405AbiL3SHN (ORCPT ); Fri, 30 Dec 2022 13:07:13 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31C426248 for ; Fri, 30 Dec 2022 10:07:12 -0800 (PST) Received: from dslb-188-097-208-179.188.097.pools.vodafone-ip.de ([188.97.208.179] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pBJmc-0004rR-KE; Fri, 30 Dec 2022 19:07:06 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 01/20] staging: r8188eu: make xmitframe_swencrypt a void function Date: Fri, 30 Dec 2022 19:06:27 +0100 Message-Id: <20221230180646.91008-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221230180646.91008-1-martin@kaiser.cx> References: <20221230180646.91008-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" xmitframe_swencrypt always returns _SUCCESS and the caller does not check the return value. We can remove the return value and make xmitframe_swencrypt a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r818= 8eu/core/rtw_xmit.c index 34494f08c0cd..4cd457cfb791 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -761,7 +761,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, s= truct xmit_frame *pxmitfr return _SUCCESS; } =20 -static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame= *pxmitframe) +static void xmitframe_swencrypt(struct adapter *padapter, struct xmit_fram= e *pxmitframe) { struct pkt_attrib *pattrib =3D &pxmitframe->attrib; =20 @@ -781,8 +781,6 @@ static s32 xmitframe_swencrypt(struct adapter *padapter= , struct xmit_frame *pxmi break; } } - - return _SUCCESS; } =20 s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib = *pattrib) --=20 2.30.2