From nobody Tue Sep 16 17:52:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B7BC4332F for ; Fri, 30 Dec 2022 06:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234441AbiL3G3o (ORCPT ); Fri, 30 Dec 2022 01:29:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbiL3G3j (ORCPT ); Fri, 30 Dec 2022 01:29:39 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 244F965FE for ; Thu, 29 Dec 2022 22:29:37 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id bj12so49459388ejb.13 for ; Thu, 29 Dec 2022 22:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CUtBC29RnUwaoeYV0vES6XTh4g9FzCYRz5OdufIfOhg=; b=yYitSniTvjeQRhVimVN+FPInjYa5pmqRCEW+3cXECKtHvauKCI39aaGTAWbXbEwaoQ 0syqcsil4KsHV5MNoA4sTSCYSIQfjPTNAoQ0qT4mmNU+bBwq3L/cf+Rv2aKsbKQqolnJ snceasG2i8OGsEPSDwKLONIX/YK92p+BXGIAvdV0rJYeiKgdbOnqrkJ0NZIt6LusRIQv Jrp2jLLuq6JBXGSeRvfRS1WwVgnQ+nHD2DaNOSPBgJLKOONTQp63s3iWEY1NWjWvgIsT pDIebcp/92j6AuEwEvENpcspbx5hDgUtXUgxRJUHmTc+wvD2ye4zGzTOq8Ehfz8jCO9w Khcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CUtBC29RnUwaoeYV0vES6XTh4g9FzCYRz5OdufIfOhg=; b=4WMJ8NAvJ0SO4wUzGvbFi3IiSEZI8g4WGMzKQNax+iHDLTMfDxZ0ujKzk1/or/+J0w 1zSAJahvp5HJ08nE7jI3K8hzo+6Zr+lOgBu2gsKeBjdCDMVApd759E8Ywjem+Q0gD8Sk yElKmaJ6zJZOP9OaVbqM2NVXyt63QrhWuBz012EfcxzLil3rzcIYpvP6gh/9SViiz4Yy eSVZDQxATsHWtZCv9PFK4fgbx05r0aIBuiSY9uqXpefzhpypD6dyiGk1fViuxMCdKw2c QbZ9U9s9VFFyb9Ez6G5qwYURrDOTbEzPt4RkUTe+wP1cuu8/PGuJOD9uf+t7pSTUhUX9 HrGQ== X-Gm-Message-State: AFqh2kq54F01ONBjKOUyboxqbFEltYCVbcCwaTquVCOfYa2LmZNxjgnu Nr21RYymH89mZkakSJk6Ti9q/Griq2ieAFam X-Google-Smtp-Source: AMrXdXs1UZrpLLkZ5ZmlfkTjJq5g6i/yWopFxpcADP6xLPPSM3mD12zBDvjytJWXrXfkZOquEYFpRA== X-Received: by 2002:a17:907:a0cc:b0:78d:f454:37a6 with SMTP id hw12-20020a170907a0cc00b0078df45437a6mr26722795ejc.73.1672381775733; Thu, 29 Dec 2022 22:29:35 -0800 (PST) Received: from alba.. ([82.77.81.131]) by smtp.gmail.com with ESMTPSA id p25-20020aa7cc99000000b004678b543163sm8941370edt.0.2022.12.29.22.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 22:29:35 -0800 (PST) From: Tudor Ambarus To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, joneslee@google.com, Tudor Ambarus , syzbot+0827b4b52b5ebf65f219@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH v2] ext4: Fix possible use-after-free in ext4_find_extent Date: Fri, 30 Dec 2022 08:29:31 +0200 Message-Id: <20221230062931.2344157-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1780; h=from:subject; bh=U6sdxC4dljuI9QHvwdLKmBfCri/ltD6JexhZ1sawArg=; b=owGbwMvMwMXoHervvrRX5CXjabUkhuR1rd4lPclfDqqtPpObd6vlb2WaJMduq8rbJy9pc4bsexob xvakk9GYhYGRi0FWTJFF1knr1Hm+E7lxsv/uwwxiZQKZwsDFKQATKf/M/j+oIyo8U8zc7YtfI+tLx6 Uv++7NDy1vf3IuQ0D4cln0RTHXBYcvKJxNif96wuXWn1Nv4mouxj/c4Ni+PGBOwH9WdXMmRVPDj0zt ck8XmFdr/JuReqGM8ZYk9/ptvzilc0/6zylN6fJcFiYV4czaaX6JZU56n9xCO16jiFAVMYsmYa1tPP UtNQaJUf/V1Bpknp6Zb6MyX3RtZdiCz1N45n9bdkyiikV7Tp7W50uv3FMn/lCdxLlvR3dNxhflwrik 3+8SHbn1CyfoLJHwLlFLqf6y+FP2lPMM72I7lbfrNkn9ORF8oZf355kaDXabB2vX/7b4Is7ArLmeWc rA5taTzpwLS/elTl3wLfi1RNtJAA== X-Developer-Key: i=tudor.ambarus@linaro.org; a=openpgp; fpr=280B06FD4CAAD2980C46DDDF4DB1B079AD29CF3D Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" syzbot reported a use-after-free Read in ext4_find_extent that is hit when using a corrupted file system. The bug was reported on Android 5.15, but using the same reproducer triggers the bug on v6.2-rc1 as well. Fix the use-after-free by checking the extent header magic. An alternative would be to check the values of EXT4_{FIRST,LAST}_{EXTENT,INDEX} used in ext4_ext_binsearch() and ext4_ext_binsearch_idx(), so that we make sure that pointers returned by EXT4_{FIRST,LAST}_{EXTENT,INDEX} don't exceed the bounds of the extent tree node. But this alternative will not squash the bug for the cases where eh->eh_entries fit into eh->eh_max. We could also try to check the sanity of the path, but costs more than checking just the header magic, so stick to the header magic sanity check. Link: https://syzkaller.appspot.com/bug?id=3Dbe6e90ce70987950e6deb3bac84183= 44ca8b96cd Reported-by: syzbot+0827b4b52b5ebf65f219@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Tudor Ambarus --- v2: drop wrong/uneeded le16_to_cpu() conversion for eh->eh_magic fs/ext4/extents.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 9de1c9d1a13d..bedc8c098449 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -894,6 +894,12 @@ ext4_find_extent(struct inode *inode, ext4_lblk_t bloc= k, gfp_flags |=3D __GFP_NOFAIL; =20 eh =3D ext_inode_hdr(inode); + if (eh->eh_magic !=3D EXT4_EXT_MAGIC) { + EXT4_ERROR_INODE(inode, "Extent header has invalid magic."); + ret =3D -EFSCORRUPTED; + goto err; + } + depth =3D ext_depth(inode); if (depth < 0 || depth > EXT4_MAX_EXTENT_DEPTH) { EXT4_ERROR_INODE(inode, "inode has invalid extent depth: %d", --=20 2.34.1