From nobody Sun Apr 12 12:51:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D8EC6FD1D for ; Wed, 15 Mar 2023 23:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232957AbjCOXVM (ORCPT ); Wed, 15 Mar 2023 19:21:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbjCOXVE (ORCPT ); Wed, 15 Mar 2023 19:21:04 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 845BBA2245 for ; Wed, 15 Mar 2023 16:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678922462; x=1710458462; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=hTHmFfjOsB4OVepCRKtPKTfrpQQ+NPJymzD64IX4dgI=; b=j84el0Et30dv55z0cKnzYgVjBQN+nGGW64ldo7wtjL2Ma29CY6xBif0Y ZfVO4z3COXY6EJ0nbRjkjai2YndGMt7LcchZFtm7efC3+JIBMHWZ4Eox1 LvEf+IJWB5bUNndP0UNWQH0ewN/2W1FVhHwdRClBcTDscpbixw70c87/H vtjTcG5+0c0hliPbHMfK7k7bzskLyc9K6AXGFbc4PM6910JeQmgmpD7yt DVoDxi9CgsYNqUwdGbglk/1VF5fPX83JHUuiD8lrFHkW8ymVvOtnqfhcW No4yEQAdyWLz75DOnDL1Jq030KgE+Th3kApzfC+fuUmYhImeb5Gs5OckU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="365527041" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="365527041" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 16:21:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="672915091" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="672915091" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.196.133]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 16:21:01 -0700 From: Ira Weiny Date: Wed, 15 Mar 2023 16:20:54 -0700 Subject: [PATCH 1/3] x86, uaccess: Remove memcpy_page_flushcache() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221230-kmap-x86-v1-1-15f1ecccab50@intel.com> References: <20221230-kmap-x86-v1-0-15f1ecccab50@intel.com> In-Reply-To: <20221230-kmap-x86-v1-0-15f1ecccab50@intel.com> To: Dave Hansen , Thomas Gleixner , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Catalin Marinas , Will Deacon , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: Dan Williams , Al Viro , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Ira Weiny X-Mailer: b4 0.13-dev-ada30 X-Developer-Signature: v=1; a=ed25519-sha256; t=1678922459; l=1867; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=hTHmFfjOsB4OVepCRKtPKTfrpQQ+NPJymzD64IX4dgI=; b=R22Wk9eXfxke9PcTFFNPFdA1VAjkKHUHCkHh1AmhPOofA7NfgRUw0cVsSIqTFK5KdEdll3UM1 g6ReFh5l0vcC3FUcAcbPNkHsO4AUXpCGvxlsHRQDHtFWxKTP8cIfI60 X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 21b56c847753 ("iov_iter: get rid of separate bvec and xarray callbacks") removed the calls to memcpy_page_flushcache(). kmap_atomic() is deprecated and used in memcpy_page_flushcache(). Remove the unnecessary memcpy_page_flushcache() call. Cc: Al Viro Cc: "Dan Williams" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x86@kernel.org Cc: "H. Peter Anvin" Signed-off-by: Ira Weiny --- arch/x86/include/asm/uaccess_64.h | 2 -- arch/x86/lib/usercopy_64.c | 9 --------- 2 files changed, 11 deletions(-) diff --git a/arch/x86/include/asm/uaccess_64.h b/arch/x86/include/asm/uacce= ss_64.h index d13d71af5cf6..c6b1dcded364 100644 --- a/arch/x86/include/asm/uaccess_64.h +++ b/arch/x86/include/asm/uaccess_64.h @@ -62,8 +62,6 @@ extern long __copy_user_nocache(void *dst, const void __u= ser *src, unsigned size, int zerorest); =20 extern long __copy_user_flushcache(void *dst, const void __user *src, unsi= gned size); -extern void memcpy_page_flushcache(char *to, struct page *page, size_t off= set, - size_t len); =20 static inline int __copy_from_user_inatomic_nocache(void *dst, const void __user *src, diff --git a/arch/x86/lib/usercopy_64.c b/arch/x86/lib/usercopy_64.c index 6c1f8ac5e721..f515542f017f 100644 --- a/arch/x86/lib/usercopy_64.c +++ b/arch/x86/lib/usercopy_64.c @@ -136,13 +136,4 @@ void __memcpy_flushcache(void *_dst, const void *_src,= size_t size) } } EXPORT_SYMBOL_GPL(__memcpy_flushcache); - -void memcpy_page_flushcache(char *to, struct page *page, size_t offset, - size_t len) -{ - char *from =3D kmap_atomic(page); - - memcpy_flushcache(to, from + offset, len); - kunmap_atomic(from); -} #endif --=20 2.39.2 From nobody Sun Apr 12 12:51:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCA3C61DA4 for ; Wed, 15 Mar 2023 23:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbjCOXVO (ORCPT ); Wed, 15 Mar 2023 19:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232948AbjCOXVF (ORCPT ); Wed, 15 Mar 2023 19:21:05 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 291599F077 for ; Wed, 15 Mar 2023 16:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678922464; x=1710458464; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=nw/5j1jSpLgBUUzdvXc7MsautacAZY58cIXNBbOwElk=; b=l2HFb/N6H2JdNC4Cp+Nim9fPw1hg4OnWFAT9+utysgshSLsVnpCd1EbF a+iARunBhVtlmV8oBoWhpfrnWTzdWwYLjKdxKG+3ckRRXXKoggHcMhfhe 7ng/b6ggYH+aXijKXNjZkDpf6Gik+4P0waDwlv1rpfoTAS977vBtNGFhb 3OmSpI3ioLXubtVYZY8NG7xF7dgSM6ryVnPSSG4CqiFiJD2jaECuze6/t bXGOwSUTSm9ByDPWZNMDdLc8WghWGvIwjeY1t8BquzfxcIdbEogxF/3B1 8qJuZDiug5+8E0EUDenBMix4ykLozlkw2WV/aQ/rkSFwkco/MaTixc9XC g==; X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="365527055" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="365527055" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 16:21:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="672915100" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="672915100" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.196.133]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 16:21:02 -0700 From: Ira Weiny Date: Wed, 15 Mar 2023 16:20:55 -0700 Subject: [PATCH 2/3] powerpc: Remove memcpy_page_flushcache() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221230-kmap-x86-v1-2-15f1ecccab50@intel.com> References: <20221230-kmap-x86-v1-0-15f1ecccab50@intel.com> In-Reply-To: <20221230-kmap-x86-v1-0-15f1ecccab50@intel.com> To: Dave Hansen , Thomas Gleixner , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Catalin Marinas , Will Deacon , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: Dan Williams , Al Viro , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Ira Weiny X-Mailer: b4 0.13-dev-ada30 X-Developer-Signature: v=1; a=ed25519-sha256; t=1678922459; l=1774; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=nw/5j1jSpLgBUUzdvXc7MsautacAZY58cIXNBbOwElk=; b=I19fBOZllVPuww2XPYb6Yj7SCTP0c5VvdEc1+udYFhYFeIDcPWfYUR9BHff5pGr5NQfrq/2HP Ku062ohYTaOB3XapC/cKDnTRLhJb/UBQCJE0wd6lYwaIKHy2W6KvNCQ X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 21b56c847753 ("iov_iter: get rid of separate bvec and xarray callbacks") removed the calls to memcpy_page_flushcache(). Remove the unnecessary memcpy_page_flushcache() call. Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Al Viro Cc: "Dan Williams" Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ira Weiny --- arch/powerpc/include/asm/uaccess.h | 2 -- arch/powerpc/lib/pmem.c | 7 ------- 2 files changed, 9 deletions(-) diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/= uaccess.h index 3ddc65c63a49..52378e641d38 100644 --- a/arch/powerpc/include/asm/uaccess.h +++ b/arch/powerpc/include/asm/uaccess.h @@ -361,8 +361,6 @@ copy_mc_to_user(void __user *to, const void *from, unsi= gned long n) =20 extern long __copy_from_user_flushcache(void *dst, const void __user *src, unsigned size); -extern void memcpy_page_flushcache(char *to, struct page *page, size_t off= set, - size_t len); =20 static __must_check inline bool user_access_begin(const void __user *ptr, = size_t len) { diff --git a/arch/powerpc/lib/pmem.c b/arch/powerpc/lib/pmem.c index eb2919ddf9b9..4e724c4c01ad 100644 --- a/arch/powerpc/lib/pmem.c +++ b/arch/powerpc/lib/pmem.c @@ -85,10 +85,3 @@ void memcpy_flushcache(void *dest, const void *src, size= _t size) clean_pmem_range(start, start + size); } EXPORT_SYMBOL(memcpy_flushcache); - -void memcpy_page_flushcache(char *to, struct page *page, size_t offset, - size_t len) -{ - memcpy_flushcache(to, page_to_virt(page) + offset, len); -} -EXPORT_SYMBOL(memcpy_page_flushcache); --=20 2.39.2 From nobody Sun Apr 12 12:51:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C150C6FD1D for ; Wed, 15 Mar 2023 23:21:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233002AbjCOXVQ (ORCPT ); Wed, 15 Mar 2023 19:21:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbjCOXVH (ORCPT ); Wed, 15 Mar 2023 19:21:07 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 302C09B9AA for ; Wed, 15 Mar 2023 16:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678922465; x=1710458465; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=oUNGwFKGfCNeFmEzlWbIjgeX9cjyVruIm7Nzwqf6dqc=; b=auhUUXaOe0ygPY+iguRGPZEcpI1d3Hc7HaAYqodTtli+OOOzydjGNm4Y 2VIWouPa8DdtakXVsID3wUeLvSLf5sJxjTrGTJNCLd8Y9qV8uldm1TQ/0 MFyAhD5lhsMJ8njzh97PxacSQ+VoqXIURIoZmN6fLd0oS88f4RJJqXa6i wDRwsy5xJFgSkamrYc9HWTGNMFgCC973NGQ2BzIesXCwlqcGO6FOmWBVa AV07Pv+ORRewWTYDNEujjvEBtsKOypEPzvJaNSX7P8beCSE0y5uG4/Lju 75RwOXmIMkglvzI/UAKwHy09+PWhw7ex0H2SA1/xY1hkzzjaD2Fi2vDn6 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="365527073" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="365527073" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 16:21:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="672915107" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="672915107" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.196.133]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 16:21:03 -0700 From: Ira Weiny Date: Wed, 15 Mar 2023 16:20:56 -0700 Subject: [PATCH 3/3] arm: uaccess: Remove memcpy_page_flushcache() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221230-kmap-x86-v1-3-15f1ecccab50@intel.com> References: <20221230-kmap-x86-v1-0-15f1ecccab50@intel.com> In-Reply-To: <20221230-kmap-x86-v1-0-15f1ecccab50@intel.com> To: Dave Hansen , Thomas Gleixner , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Catalin Marinas , Will Deacon , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: Dan Williams , Al Viro , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Ira Weiny X-Mailer: b4 0.13-dev-ada30 X-Developer-Signature: v=1; a=ed25519-sha256; t=1678922459; l=1951; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=oUNGwFKGfCNeFmEzlWbIjgeX9cjyVruIm7Nzwqf6dqc=; b=029LLrpbd7VMZrAQfKYKO6kviK6io7TXxDI1OO3rXTtKEVFcqP25qXdcWxYdxjw/HbQDbRkgI tKmFt4wL/zHCVE+R+u24nRdfFvw80JCiCHp6v+2+M42Wcom5uYjWOyD X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 21b56c847753 ("iov_iter: get rid of separate bvec and xarray callbacks") removed the calls to memcpy_page_flushcache(). Remove the unnecessary memcpy_page_flushcache() call. Cc: Al Viro Cc: "Dan Williams" Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Ira Weiny --- arch/arm64/include/asm/uaccess.h | 2 -- arch/arm64/lib/uaccess_flushcache.c | 6 ------ 2 files changed, 8 deletions(-) diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uacc= ess.h index 5c7b2f9d5913..4bf2c0975a82 100644 --- a/arch/arm64/include/asm/uaccess.h +++ b/arch/arm64/include/asm/uaccess.h @@ -449,8 +449,6 @@ extern long strncpy_from_user(char *dest, const char __= user *src, long count); extern __must_check long strnlen_user(const char __user *str, long n); =20 #ifdef CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE -struct page; -void memcpy_page_flushcache(char *to, struct page *page, size_t offset, si= ze_t len); extern unsigned long __must_check __copy_user_flushcache(void *to, const v= oid __user *from, unsigned long n); =20 static inline int __copy_from_user_flushcache(void *dst, const void __user= *src, unsigned size) diff --git a/arch/arm64/lib/uaccess_flushcache.c b/arch/arm64/lib/uaccess_f= lushcache.c index baee22961bdb..7510d1a23124 100644 --- a/arch/arm64/lib/uaccess_flushcache.c +++ b/arch/arm64/lib/uaccess_flushcache.c @@ -19,12 +19,6 @@ void memcpy_flushcache(void *dst, const void *src, size_= t cnt) } EXPORT_SYMBOL_GPL(memcpy_flushcache); =20 -void memcpy_page_flushcache(char *to, struct page *page, size_t offset, - size_t len) -{ - memcpy_flushcache(to, page_address(page) + offset, len); -} - unsigned long __copy_user_flushcache(void *to, const void __user *from, unsigned long n) { --=20 2.39.2