From nobody Sun Feb 8 17:59:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF35C54EBF for ; Thu, 29 Dec 2022 18:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234052AbiL2Ses (ORCPT ); Thu, 29 Dec 2022 13:34:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233978AbiL2SeP (ORCPT ); Thu, 29 Dec 2022 13:34:15 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A862F5A0 for ; Thu, 29 Dec 2022 10:34:15 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id kw15so46758406ejc.10 for ; Thu, 29 Dec 2022 10:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IXKNJ1J6Lsp8k0SIwGKGS7Q0ipF67IrwBVbQHNzAoBU=; b=M8Pk7N/H2os6BSaRPHa/SnYYrwf5fCOP2GVc/7uz1AbklBGyEeT8f9DAV6tvTzDxAE 75e+BDfLdkLCFCdRcPoaiPaqC2E0maYIV3sczUgSWJkB+HJf0AJsq9yll2uF1QxseR7m MJFxYgMLJpbDkEsCGdv5DbADCu8+FapDvVpiaEnQaAKOj80MHTnLmN6aZS8QBLLCrYpU 7Nab3O4U++tj4XWSBANo6s1X17KFWk50+khhKmw9AuF8NubcgMsYyYgPQO+fhXecK/fZ XmzWDnH0Wd2MzijMXsRZbHz64BgdGtR8Ft+AcfxXv0Ch9Ypnqq/w6hlgIdBIxd4QQQ/A wGCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IXKNJ1J6Lsp8k0SIwGKGS7Q0ipF67IrwBVbQHNzAoBU=; b=e+FJhT+ZP1jTP9TOKgx9BUCiHMPqPuDIpNqK6V5o3c5jDbt+brKxz/5gw7ivpk8lvZ cjTJieU7ZWC3BliYXz0jmbtNx0kaFbv8i5DN42oWZj60OUgicb9sbMQ3jylMM7k2lYKA p7t0YMGQcT7r2aW9OvXVcZ2ZrbbvynN1gWG0dydCYEgl/CSK51cYTK9aSlhGOFZc2pBZ pBwJVy6U9pootKsTrCofKO3cBhZ657l4bZxMqJDh/1cPm9j2CrtFlN/Wjq4Hnsx8wE7X +ALEmuZRppInF4aTCTjbAQtGus0GmxmnPJVCqe/lT7HcQ6FKRiTNhx/6pS/b9N2BQlx9 2vWQ== X-Gm-Message-State: AFqh2kqGnJQwmtjOjQhL4WczAZ9gJC5L4AObl9wdtXTRZemC+I0lLbpg w1j2npzAHtXQeWzhboPxfOpXVA== X-Google-Smtp-Source: AMrXdXtPbNLhLa24gVerdkNtAMJWqBLZdt11LDIbsHOmT54yzYbO2XvTuSa6HT8CKAZmDMOqFhLmNQ== X-Received: by 2002:a17:907:a08d:b0:7c0:dac7:36d8 with SMTP id hu13-20020a170907a08d00b007c0dac736d8mr25614107ejc.10.1672338853657; Thu, 29 Dec 2022 10:34:13 -0800 (PST) Received: from planet9.chello.ie (2001-1c06-2302-5600-12a8-8cf4-e3f6-f90f.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:12a8:8cf4:e3f6:f90f]) by smtp.gmail.com with ESMTPSA id g22-20020a1709064e5600b007c0688a68cbsm9013936ejw.176.2022.12.29.10.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 10:34:13 -0800 (PST) From: Bryan O'Donoghue To: agross@kernel.org, andersson@kernel.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, bryan.odonoghue@linaro.org Subject: [PATCH v2 1/2] dt-bindings: phy: Add qcom,dp-manual-pullup description Date: Thu, 29 Dec 2022 18:34:09 +0000 Message-Id: <20221229183410.683584-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221229183410.683584-1-bryan.odonoghue@linaro.org> References: <20221229183410.683584-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The original Qualcomm driver for the HighSpeed USB PHY contains a flag which tells the driver that the controller and PHY do not connect to VBUS. In this case an external IC such as a Type-C port manager supplies VBUS and the VBUS signal is not routed to the SoC. This means we cannot detect the presence or absence of VBUS and cannot take action based on it. Document the downstream boolean qcom,dp-manual-pullup to allow the HS PHY implement the necessary logic. Signed-off-by: Bryan O'Donoghue --- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/D= ocumentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index aa97478dd0161..c55a59df71ad0 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -80,6 +80,13 @@ properties: the address is offset from the ULPI_EXT_VENDOR_SPECIFIC address - description: value =20 + qcom,dp-manual-pullup: + type: boolean + description: This flag indicates to the HS USB PHY driver that it shou= ld + enable or disable an internal pullup when powering on or + powering off the HS PHY instead of toggling the value whe= n VBUS + is absent or present. + required: - clocks - clock-names --=20 2.34.1 From nobody Sun Feb 8 17:59:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE54FC54EBE for ; Thu, 29 Dec 2022 18:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234073AbiL2Sev (ORCPT ); Thu, 29 Dec 2022 13:34:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233994AbiL2SeQ (ORCPT ); Thu, 29 Dec 2022 13:34:16 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E710FE00 for ; Thu, 29 Dec 2022 10:34:15 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id fc4so46784038ejc.12 for ; Thu, 29 Dec 2022 10:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qOwNzTdUKlF0YVErH+m4Hrlu8Y/CqgzRzrTuhq10EAc=; b=RpPdq2z8ewpQAJ+Pq0zFsE+golr0XOyCeAmQ8xF4SnuhD4fy8ggns0HkMbA9lvQlAp aVnP0Dxbo/eGyNh2LUIz/M06a2X1mMCyh9d/nKEIqcueDwVj1n/ADSztLB6cGDJcEtBr yeaC241RtYWYMMM2RuU3I0ONfM54CJEgGfnrvMXDiScWPqMn36xAXArGcG4uOFJO77nX zJQTj/7gPqJ+P7c++wPIcLhUk2wojbzpnIEn/Ijy4FW4RMuTMc9TxmSE+x3cP2zZ4OzF qlIkuB+/1eHikr40668fcd4xOaSd9shwA6grac+jhojdIWVB2HkgGCcn5xJSyUzLcOC9 4mzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qOwNzTdUKlF0YVErH+m4Hrlu8Y/CqgzRzrTuhq10EAc=; b=3GOBwu//Mg61NjRW64Jz7XjDyO5EpFaGYMkpvnHNbTP3zLQRbxAPwyrdMJsrPDhyUj afcNEgBV+gdOjyV058T50MlljmSIy07emH3WkpkUlL38IoRfGwhkTLZfkQNpYk7TcwO8 BXjLs/Ua5g+NrsMA68qcwCxP4SloLxALjdMiqAL74s0XAHojFIhxfTxRaN4s9Ai0Zaho wG44ZTUhPr6RMuNvdfQXPGnjvjf3Z7aeoDIDX+HnOamRloroyd7SfgVdXRT58uzoh0ut hPE/EZ47YcytU/Nf1Z0xJ9kPViYNgYLzccx+552vmgxah+3MAzDyQ6Ee7oqYtj+67KLi Wtgg== X-Gm-Message-State: AFqh2kojAyPKG+/Hca3gp+Aw1mrEDu6Wpa0rXFCdiYpVIWCrBjilvl9W tsSMsYid0t9zsTrhzdfxbZSRMg== X-Google-Smtp-Source: AMrXdXvVMq4b7/E7hSZxnG5HN5oB/9/neiMONpxkkMMUQmt2TjO7i8r2qUhnlCxDRnksiZpVIL3ulg== X-Received: by 2002:a17:907:c70c:b0:81e:9027:dedc with SMTP id ty12-20020a170907c70c00b0081e9027dedcmr25356911ejc.39.1672338854528; Thu, 29 Dec 2022 10:34:14 -0800 (PST) Received: from planet9.chello.ie (2001-1c06-2302-5600-12a8-8cf4-e3f6-f90f.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:12a8:8cf4:e3f6:f90f]) by smtp.gmail.com with ESMTPSA id g22-20020a1709064e5600b007c0688a68cbsm9013936ejw.176.2022.12.29.10.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 10:34:14 -0800 (PST) From: Bryan O'Donoghue To: agross@kernel.org, andersson@kernel.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, bryan.odonoghue@linaro.org Subject: [PATCH v2 2/2] phy: qcom-usb-hs: Add qcom,dp-manual-pullup logic Date: Thu, 29 Dec 2022 18:34:10 +0000 Message-Id: <20221229183410.683584-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221229183410.683584-1-bryan.odonoghue@linaro.org> References: <20221229183410.683584-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Downstream has a flag called qcom,dp-manual-pullup which informs the downstream driver if it should toggle ULPI_MISC_A_VBUSVLDEXTSEL and ULPI_MISC_A_VBUSVLDEXT. Downstream states: "qcom,dp-manual-pullup: If present, vbus is not routed to USB controller/phy and controller driver therefore enables pull-up explicitly before starting controller using usbcmd run/stop bit." Working with a system that has both an external Type-C port controller and an internal USB Hub results in a situation where VBUS is not connected to the SoC. In this case we still need to set the DP pullup. This patch enables and disables the DP pullup on PHY power_on and power_off respectively if the DT has declared the bool "qcom,enable-vbus-pullup" effectively replicating the downstream logic to the same effect. Signed-off-by: Bryan O'Donoghue --- drivers/phy/qualcomm/phy-qcom-usb-hs.c | 36 ++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hs.c b/drivers/phy/qualcomm/= phy-qcom-usb-hs.c index 53e46c220a3aa..45c94f6722c66 100644 --- a/drivers/phy/qualcomm/phy-qcom-usb-hs.c +++ b/drivers/phy/qualcomm/phy-qcom-usb-hs.c @@ -37,6 +37,7 @@ struct qcom_usb_hs_phy { struct ulpi_seq *init_seq; struct extcon_dev *vbus_edev; struct notifier_block vbus_notify; + u8 enable_dp_pullup:1; }; =20 static int qcom_usb_hs_phy_set_mode(struct phy *phy, @@ -105,6 +106,23 @@ qcom_usb_hs_phy_vbus_notifier(struct notifier_block *n= b, unsigned long event, return ulpi_write(uphy->ulpi, addr, ULPI_MISC_A_VBUSVLDEXT); } =20 +static int qcom_usb_hs_phy_enable_dp_pullup(struct ulpi *ulpi, bool enable) +{ + u8 addr; + int ret; + + if (enable) + addr =3D ULPI_SET(ULPI_MISC_A); + else + addr =3D ULPI_CLR(ULPI_MISC_A); + + ret =3D ulpi_write(ulpi, addr, ULPI_MISC_A_VBUSVLDEXTSEL); + if (ret) + return ret; + + return ulpi_write(ulpi, addr, ULPI_MISC_A_VBUSVLDEXT); +} + static int qcom_usb_hs_phy_power_on(struct phy *phy) { struct qcom_usb_hs_phy *uphy =3D phy_get_drvdata(phy); @@ -154,6 +172,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy) goto err_ulpi; } =20 + if (uphy->enable_dp_pullup) { + ret =3D qcom_usb_hs_phy_enable_dp_pullup(ulpi, true); + if (ret) + goto err_ulpi; + } + if (uphy->vbus_edev) { state =3D extcon_get_state(uphy->vbus_edev, EXTCON_USB); /* setup initial state */ @@ -180,10 +204,19 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy) static int qcom_usb_hs_phy_power_off(struct phy *phy) { struct qcom_usb_hs_phy *uphy =3D phy_get_drvdata(phy); + struct ulpi *ulpi =3D uphy->ulpi; + int ret; =20 if (uphy->vbus_edev) extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB, &uphy->vbus_notify); + + if (uphy->enable_dp_pullup) { + ret =3D qcom_usb_hs_phy_enable_dp_pullup(ulpi, false); + if (ret) + return ret; + } + regulator_disable(uphy->v3p3); regulator_disable(uphy->v1p8); clk_disable_unprepare(uphy->sleep_clk); @@ -229,6 +262,9 @@ static int qcom_usb_hs_phy_probe(struct ulpi *ulpi) /* NUL terminate */ uphy->init_seq[size / 2].addr =3D uphy->init_seq[size / 2].val =3D 0; =20 + if (of_property_read_bool(ulpi->dev.of_node, "qcom,dp-manual-pullup")) + uphy->enable_dp_pullup =3D 1; + uphy->ref_clk =3D clk =3D devm_clk_get(&ulpi->dev, "ref"); if (IS_ERR(clk)) return PTR_ERR(clk); --=20 2.34.1