From nobody Wed Sep 17 00:07:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 930BAC4167B for ; Tue, 27 Dec 2022 19:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231464AbiL0TYF (ORCPT ); Tue, 27 Dec 2022 14:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbiL0TX5 (ORCPT ); Tue, 27 Dec 2022 14:23:57 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0576572 for ; Tue, 27 Dec 2022 11:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672169036; x=1703705036; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RGIUoDUWMennNq2BZ7d/bh2PdiZqgI1/L+XCRzyCHqE=; b=jznyb4w5iIJ2SmzUetS3e6lPFSMafkRTHLlThFjWn9ilcA0f6mcXvWVZ ne4c4yVSV8DByxod4vXd7+htqwyCNzFbfsjtYk81WSzQR2r/DrII/rkhf eJ+1JrtUVXe2OQciWt+3v0oFrlkAV+4wXjBDTzqOg6y6NQgDR3hXqHdaN UFWhS0VVjxtBptH8R7XH9N7NLTo8L2+1bST21NEBesg41N2aZLVyxdcA6 x6jfJelQ8KDjGphrPBuMhGZf8p2PFSkellTzsXXxfM13HvK68l5SKCFnG MD0mtaSRZYJizFWlhqjDBO8QXEDYfZVEncK5Ps2SO1ZuqrUBEr2nrNeqU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="407011170" X-IronPort-AV: E=Sophos;i="5.96,279,1665471600"; d="scan'208";a="407011170" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2022 11:23:54 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="777234197" X-IronPort-AV: E=Sophos;i="5.96,279,1665471600"; d="scan'208";a="777234197" Received: from araj-ucode.jf.intel.com ([10.23.0.19]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2022 11:23:54 -0800 From: Ashok Raj To: Borislav Petkov , Thomas Gleixner Cc: X86-kernel , LKML Mailing List , Ashok Raj , Dave Hansen , Tony Luck , Alison Schofield , Reinette Chatre , Tom Lendacky Subject: [PATCH v2 3/6] x86/microcode: Display revisions only when update is successful Date: Tue, 27 Dec 2022 11:23:37 -0800 Message-Id: <20221227192340.8358-4-ashok.raj@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221227192340.8358-1-ashok.raj@intel.com> References: <20221227192340.8358-1-ashok.raj@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Right now, microcode loading failures and successes print the same message "Reloading completed". This is misleading to users. Display the updated revision number only if an update was successful. Suggested-by: Thomas Gleixner Signed-off-by: Ashok Raj Reviewed-by: Tony Luck Link: https://lore.kernel.org/lkml/874judpqqd.ffs@tglx/ Cc: LKML Cc: x86 Cc: Tony Luck Cc: Dave Hansen Cc: Alison Schofield Cc: Reinette Chatre Cc: Thomas Gleixner Cc: Tom Lendacky --- arch/x86/kernel/cpu/microcode/core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index e2cdf3e989e7..e60cf0f66bf5 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -500,11 +500,12 @@ static int microcode_reload_late(void) store_cpu_caps(&info); =20 ret =3D stop_machine_cpuslocked(__reload_late, NULL, cpu_online_mask); - if (ret =3D=3D 0) - microcode_check(&info); =20 - pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n", - old, boot_cpu_data.microcode); + if (ret =3D=3D 0) { + pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n", + old, boot_cpu_data.microcode); + microcode_check(&info); + } =20 return ret; } --=20 2.34.1