From nobody Tue Sep 16 23:48:52 2025
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 350E1C3DA79
	for <linux-kernel@archiver.kernel.org>; Mon, 26 Dec 2022 13:50:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230477AbiLZNuS (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 26 Dec 2022 08:50:18 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60966 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229836AbiLZNuL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Dec 2022 08:50:11 -0500
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E764910FF
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1672062565;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=xnmpfwprauaUCwVK5aSahrYvb5fYhAWL3JqdEXrkVS0=;
        b=bNf/zSY8tui24blLHbUnEjRCJbHZQ8ha86Izh6MPt+2Trp38SClyt3n+y9FKzhhlXX4vDz
        y9krwI21DdQ5tn4AN1x8+M0v8Wmf9RnlsRgpESPiqMWVfrOCeRn033VJtyY6LF0/lqAeqZ
        a+zWja8L/IgKK1r+guhGiEyyH6K5Cxo=
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-359-algMiUg7ONW1RjqolLL3WQ-1; Mon, 26 Dec 2022 08:49:23 -0500
X-MC-Unique: algMiUg7ONW1RjqolLL3WQ-1
Received: by mail-wm1-f70.google.com with SMTP id
 n8-20020a05600c294800b003d1cc68889dso2592395wmd.7
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:23 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=xnmpfwprauaUCwVK5aSahrYvb5fYhAWL3JqdEXrkVS0=;
        b=U85M3HZlRO/uSKxyni9xAK3gW0qdTvuI8Fi9PCVKclOAYfPymFTLR6vewpneDqzKv2
         9FxwPtJEnQ1ExEVNQ8SxuU2S25hmQehfZarEkQ5FyPCFNV3P+4m7PH4jZOy936urLmyD
         qFzYo9liERlraAdRskm9rcKvncNWXZdzShLFEVyB8BReWrJhVNtJ7ex+DCjLCcFOK4/k
         BhXTyillMMKtnSUIWOCBHkqdGaXCVWAlbOSAZdygOId68DrJmFbkWUYmK7AaDZkGBgff
         oh27g8zZ/YIr2CCWWuVO/LbhVG0lmTTP9R5lgJE2CoWHAaytBVycMBNILnEwoy9tRxAr
         haiA==
X-Gm-Message-State: AFqh2krX0+k9Vy7XSQrofV/0Hun55cafuPZuYtloIv/M50BuuMOmoPFo
        oCiiUIWL3ErAccBLSkFGOednHvvz/pLg+ZCXy1HgN5WqCrrKcZZtTFzJaiFF4e4OHFUk4OQ1SAB
        +CiWzNLdGKtUEswuPCchVuWpeox/p8df3bTmW9Bu+XwHzsv5Kt1ob1vPT7GtIhgtrxwR9UHqXwW
        I=
X-Received: by 2002:a5d:6e8e:0:b0:242:1e12:e594 with SMTP id
 k14-20020a5d6e8e000000b002421e12e594mr11213277wrz.22.1672062562380;
        Mon, 26 Dec 2022 05:49:22 -0800 (PST)
X-Google-Smtp-Source: 
 AMrXdXv12L4KRucrbcMlTM4VM0qkSaIJgIykdELNphWEd3wYzVmoVyoMxIQFKqSU6wW2Za+SCk5IGA==
X-Received: by 2002:a5d:6e8e:0:b0:242:1e12:e594 with SMTP id
 k14-20020a5d6e8e000000b002421e12e594mr11213252wrz.22.1672062561865;
        Mon, 26 Dec 2022 05:49:21 -0800 (PST)
Received: from minerva.home (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205])
        by smtp.gmail.com with ESMTPSA id
 a18-20020adfed12000000b0027cfd9463d7sm3340947wro.110.2022.12.26.05.49.20
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 26 Dec 2022 05:49:21 -0800 (PST)
From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Ondrej Jirman <megi@xff.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Robert Mader <robert.mader@posteo.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maya Matuszczyk <maccraft123mc@gmail.com>,
        =?UTF-8?q?Kamil=20Trzci=C5=84ski?= <ayufan@ayufan.eu>,
        Martijn Braam <martijn@brixit.nl>,
        Peter Robinson <pbrobinson@gmail.com>,
        Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        dri-devel@lists.freedesktop.org
Subject: [PATCH v2 1/4] drm: panel: Add Himax HX8394 panel controller driver
Date: Mon, 26 Dec 2022 14:49:05 +0100
Message-Id: <20221226134909.2822179-2-javierm@redhat.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221226134909.2822179-1-javierm@redhat.com>
References: <20221226134909.2822179-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Kamil Trzci=C5=84ski <ayufan@ayufan.eu>

The driver is for panels based on the Himax HX8394 controller, such as the
HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface.

Signed-off-by: Kamil Trzci=C5=84ski <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Co-developed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---

Changes in v2:
- Add year to driver's copyright notice (Sam Ravnborg)
- Remove unused <video/display_timing.h> header include (Sam Ravnborg).
- Use mipi_dsi_dcs_write_seq() helper and drop custom macro (Sam Ravnborg).
- Drop unnecessary info messages and move useful one to debug (Sam Ravnborg=
).

 drivers/gpu/drm/panel/Kconfig              |  12 +
 drivers/gpu/drm/panel/Makefile             |   1 +
 drivers/gpu/drm/panel/panel-himax-hx8394.c | 446 +++++++++++++++++++++
 3 files changed, 459 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-himax-hx8394.c

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 737edcdf9eef..7ee9c83f09a7 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -154,6 +154,18 @@ config DRM_PANEL_FEIYANG_FY07024DI26A30D
 	  Say Y if you want to enable support for panels based on the
 	  Feiyang FY07024DI26A30-D MIPI-DSI interface.
=20
+config DRM_PANEL_HIMAX_HX8394
+	tristate "HIMAX HX8394 MIPI-DSI LCD panels"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y if you want to enable support for panels based on the
+	  Himax HX8394 controller, such as the HannStar HSD060BHW4
+	  720x1440 TFT LCD panel that uses a MIPI-DSI interface.
+
+	  If M is selected the module will be called panel-himax-hx8394.
+
 config DRM_PANEL_ILITEK_IL9322
 	tristate "Ilitek ILI9322 320x240 QVGA panels"
 	depends on OF && SPI
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index f8f9d9f6a307..84c01adafd4c 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_DRM_PANEL_EBBG_FT8719) +=3D panel-ebbg-ft871=
9.o
 obj-$(CONFIG_DRM_PANEL_ELIDA_KD35T133) +=3D panel-elida-kd35t133.o
 obj-$(CONFIG_DRM_PANEL_FEIXIN_K101_IM2BA02) +=3D panel-feixin-k101-im2ba02=
.o
 obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) +=3D panel-feiyang-fy07024=
di26a30d.o
+obj-$(CONFIG_DRM_PANEL_HIMAX_HX8394) +=3D panel-himax-hx8394.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) +=3D panel-ilitek-ili9322.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) +=3D panel-ilitek-ili9341.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) +=3D panel-ilitek-ili9881c.o
diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/p=
anel/panel-himax-hx8394.c
new file mode 100644
index 000000000000..fc7a2c299f8d
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c
@@ -0,0 +1,446 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Driver for panels based on Himax HX8394 controller, such as:
+ *
+ * - HannStar HSD060BHW4 5.99" MIPI-DSI panel
+ *
+ * Copyright (C) 2021 Kamil Trzci=C5=84ski
+ *
+ * Based on drivers/gpu/drm/panel/panel-sitronix-st7703.c
+ * Copyright (C) Purism SPC 2019
+ */
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/media-bus-format.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/regulator/consumer.h>
+
+#include <video/mipi_display.h>
+
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+
+#define DRV_NAME "panel-himax-hx8394"
+
+/* Manufacturer specific commands sent via DSI, listed in HX8394-F datashe=
et */
+#define HX8394_CMD_SETSEQUENCE	  0xb0
+#define HX8394_CMD_SETPOWER	  0xb1
+#define HX8394_CMD_SETDISP	  0xb2
+#define HX8394_CMD_SETCYC	  0xb4
+#define HX8394_CMD_SETVCOM	  0xb6
+#define HX8394_CMD_SETTE	  0xb7
+#define HX8394_CMD_SETSENSOR	  0xb8
+#define HX8394_CMD_SETEXTC	  0xb9
+#define HX8394_CMD_SETMIPI	  0xba
+#define HX8394_CMD_SETOTP	  0xbb
+#define HX8394_CMD_SETREGBANK	  0xbd
+#define HX8394_CMD_UNKNOWN1	  0xc0
+#define HX8394_CMD_SETDGCLUT	  0xc1
+#define HX8394_CMD_SETID	  0xc3
+#define HX8394_CMD_SETDDB	  0xc4
+#define HX8394_CMD_UNKNOWN2	  0xc6
+#define HX8394_CMD_SETCABC	  0xc9
+#define HX8394_CMD_SETCABCGAIN	  0xca
+#define HX8394_CMD_SETPANEL	  0xcc
+#define HX8394_CMD_SETOFFSET	  0xd2
+#define HX8394_CMD_SETGIP0	  0xd3
+#define HX8394_CMD_UNKNOWN3	  0xd4
+#define HX8394_CMD_SETGIP1	  0xd5
+#define HX8394_CMD_SETGIP2	  0xd6
+#define HX8394_CMD_SETGPO	  0xd6
+#define HX8394_CMD_SETSCALING	  0xdd
+#define HX8394_CMD_SETIDLE	  0xdf
+#define HX8394_CMD_SETGAMMA	  0xe0
+#define HX8394_CMD_SETCHEMODE_DYN 0xe4
+#define HX8394_CMD_SETCHE	  0xe5
+#define HX8394_CMD_SETCESEL	  0xe6
+#define HX8394_CMD_SET_SP_CMD	  0xe9
+#define HX8394_CMD_SETREADINDEX	  0xfe
+#define HX8394_CMD_GETSPIREAD	  0xff
+
+struct hx8394 {
+	struct device *dev;
+	struct drm_panel panel;
+	struct gpio_desc *reset_gpio;
+	struct regulator *vcc;
+	struct regulator *iovcc;
+	bool prepared;
+
+	const struct hx8394_panel_desc *desc;
+};
+
+struct hx8394_panel_desc {
+	const struct drm_display_mode *mode;
+	unsigned int lanes;
+	unsigned long mode_flags;
+	enum mipi_dsi_pixel_format format;
+	int (*init_sequence)(struct hx8394 *ctx);
+};
+
+static inline struct hx8394 *panel_to_hx8394(struct drm_panel *panel)
+{
+	return container_of(panel, struct hx8394, panel);
+}
+
+static int hsd060bhw4_init_sequence(struct hx8394 *ctx)
+{
+	struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev);
+
+	/* 5.19.8 SETEXTC: Set extension command (B9h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETEXTC,
+			       0xff, 0x83, 0x94);
+
+	/* 5.19.2 SETPOWER: Set power (B1h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETPOWER,
+			  0x48, 0x11, 0x71, 0x09, 0x32, 0x24, 0x71, 0x31, 0x55, 0x30);
+
+	/* 5.19.9 SETMIPI: Set MIPI control (BAh) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETMIPI,
+			  0x63, 0x03, 0x68, 0x6b, 0xb2, 0xc0);
+
+	/* 5.19.3 SETDISP: Set display related register (B2h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETDISP,
+			  0x00, 0x80, 0x78, 0x0c, 0x07);
+
+	/* 5.19.4 SETCYC: Set display waveform cycles (B4h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETCYC,
+			  0x12, 0x63, 0x12, 0x63, 0x12, 0x63, 0x01, 0x0c, 0x7c, 0x55,
+			  0x00, 0x3f, 0x12, 0x6b, 0x12, 0x6b, 0x12, 0x6b, 0x01, 0x0c,
+			  0x7c);
+
+	/* 5.19.19 SETGIP0: Set GIP Option0 (D3h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGIP0,
+			  0x00, 0x00, 0x00, 0x00, 0x3c, 0x1c, 0x00, 0x00, 0x32, 0x10,
+			  0x09, 0x00, 0x09, 0x32, 0x15, 0xad, 0x05, 0xad, 0x32, 0x00,
+			  0x00, 0x00, 0x00, 0x37, 0x03, 0x0b, 0x0b, 0x37, 0x00, 0x00,
+			  0x00, 0x0c, 0x40);
+
+	/* 5.19.20 Set GIP Option1 (D5h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGIP1,
+			  0x19, 0x19, 0x18, 0x18, 0x1b, 0x1b, 0x1a, 0x1a, 0x00, 0x01,
+			  0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x20, 0x21, 0x18, 0x18,
+			  0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+			  0x24, 0x25, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+			  0x18, 0x18, 0x18, 0x18, 0x18, 0x18);
+
+	/* 5.19.21 Set GIP Option2 (D6h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGIP2,
+			  0x18, 0x18, 0x19, 0x19, 0x1b, 0x1b, 0x1a, 0x1a, 0x07, 0x06,
+			  0x05, 0x04, 0x03, 0x02, 0x01, 0x00, 0x25, 0x24, 0x18, 0x18,
+			  0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+			  0x21, 0x20, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+			  0x18, 0x18, 0x18, 0x18, 0x18, 0x18);
+
+	/* 5.19.25 SETGAMMA: Set gamma curve related setting (E0h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGAMMA,
+			  0x00, 0x04, 0x0c, 0x12, 0x14, 0x18, 0x1a, 0x18, 0x31, 0x3f,
+			  0x4d, 0x4c, 0x54, 0x65, 0x6b, 0x70, 0x7f, 0x82, 0x7e, 0x8a,
+			  0x99, 0x4a, 0x48, 0x49, 0x4b, 0x4a, 0x4c, 0x4b, 0x7f, 0x00,
+			  0x04, 0x0c, 0x11, 0x13, 0x17, 0x1a, 0x18, 0x31,
+			  0x3f, 0x4d, 0x4c, 0x54, 0x65, 0x6b, 0x70, 0x7f,
+			  0x82, 0x7e, 0x8a, 0x99, 0x4a, 0x48, 0x49, 0x4b,
+			  0x4a, 0x4c, 0x4b, 0x7f);
+
+	/* 5.19.17 SETPANEL (CCh) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETPANEL, 0x0b);
+
+	/* Unknown command, not listed in the HX8394-F datasheet */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN1, 0x1f, 0x31);
+
+	/* 5.19.5 SETVCOM: Set VCOM voltage (B6h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETVCOM,
+			  0x7d, 0x7d);
+
+	/* Unknown command, not listed in the HX8394-F datasheet */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN3,
+			  0x02);
+
+	/* 5.19.11 Set register bank (BDh) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETREGBANK, 0x01);
+
+	/* 5.19.2 SETPOWER: Set power (B1h) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETPOWER, 0x00);
+
+	/* 5.19.11 Set register bank (BDh) */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETREGBANK, 0x00);
+
+	/* Unknown command, not listed in the HX8394-F datasheet */
+	mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN3,
+			  0xed);
+
+	return 0;
+}
+
+static const struct drm_display_mode hsd060bhw4_mode =3D {
+	.hdisplay    =3D 720,
+	.hsync_start =3D 720 + 40,
+	.hsync_end   =3D 720 + 40 + 46,
+	.htotal	     =3D 720 + 40 + 46 + 40,
+	.vdisplay    =3D 1440,
+	.vsync_start =3D 1440 + 9,
+	.vsync_end   =3D 1440 + 9 + 7,
+	.vtotal	     =3D 1440 + 9 + 7 + 7,
+	.clock	     =3D 74250,
+	.flags	     =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+	.width_mm    =3D 68,
+	.height_mm   =3D 136,
+};
+
+static const struct hx8394_panel_desc hsd060bhw4_desc =3D {
+	.mode =3D &hsd060bhw4_mode,
+	.lanes =3D 4,
+	.mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST,
+	.format =3D MIPI_DSI_FMT_RGB888,
+	.init_sequence =3D hsd060bhw4_init_sequence,
+};
+
+static int hx8394_enable(struct drm_panel *panel)
+{
+	struct hx8394 *ctx =3D panel_to_hx8394(panel);
+	struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev);
+	int ret;
+
+	ret =3D ctx->desc->init_sequence(ctx);
+	if (ret) {
+		dev_err(ctx->dev, "Panel init sequence failed: %d\n", ret);
+		return ret;
+	}
+
+	ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi);
+	if (ret) {
+		dev_err(ctx->dev, "Failed to exit sleep mode: %d\n", ret);
+		return ret;
+	}
+
+	/* Panel is operational 120 msec after reset */
+	msleep(120);
+
+	ret =3D mipi_dsi_dcs_set_display_on(dsi);
+	if (ret) {
+		dev_err(ctx->dev, "Failed to turn on the display: %d\n", ret);
+		goto sleep_in;
+	}
+
+	return 0;
+
+sleep_in:
+	/* This will probably fail, but let's try orderly power off anyway. */
+	ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi);
+	if (!ret)
+		msleep(50);
+
+	return ret;
+}
+
+static int hx8394_disable(struct drm_panel *panel)
+{
+	struct hx8394 *ctx =3D panel_to_hx8394(panel);
+	struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev);
+	int ret;
+
+	ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi);
+	if (ret) {
+		dev_err(ctx->dev, "Failed to enter sleep mode: %d\n", ret);
+		return ret;
+	}
+
+	msleep(50); /* about 3 frames */
+
+	return 0;
+}
+
+static int hx8394_unprepare(struct drm_panel *panel)
+{
+	struct hx8394 *ctx =3D panel_to_hx8394(panel);
+
+	if (!ctx->prepared)
+		return 0;
+
+	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
+	regulator_disable(ctx->iovcc);
+	regulator_disable(ctx->vcc);
+
+	ctx->prepared =3D false;
+
+	return 0;
+}
+
+static int hx8394_prepare(struct drm_panel *panel)
+{
+	struct hx8394 *ctx =3D panel_to_hx8394(panel);
+	int ret;
+
+	if (ctx->prepared)
+		return 0;
+
+	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
+	ret =3D regulator_enable(ctx->vcc);
+	if (ret) {
+		dev_err(ctx->dev, "Failed to enable vcc supply: %d\n", ret);
+		return ret;
+	}
+
+	ret =3D regulator_enable(ctx->iovcc);
+	if (ret) {
+		dev_err(ctx->dev, "Failed to enable iovcc supply: %d\n", ret);
+		goto disable_vcc;
+	}
+
+	gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+
+	msleep(180);
+
+	ctx->prepared =3D true;
+
+	return 0;
+
+disable_vcc:
+	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+	regulator_disable(ctx->vcc);
+	return ret;
+}
+
+static int hx8394_get_modes(struct drm_panel *panel,
+			    struct drm_connector *connector)
+{
+	struct hx8394 *ctx =3D panel_to_hx8394(panel);
+	struct drm_display_mode *mode;
+
+	mode =3D drm_mode_duplicate(connector->dev, ctx->desc->mode);
+	if (!mode) {
+		dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
+			ctx->desc->mode->hdisplay, ctx->desc->mode->vdisplay,
+			drm_mode_vrefresh(ctx->desc->mode));
+		return -ENOMEM;
+	}
+
+	drm_mode_set_name(mode);
+
+	mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+	connector->display_info.width_mm =3D mode->width_mm;
+	connector->display_info.height_mm =3D mode->height_mm;
+	drm_mode_probed_add(connector, mode);
+
+	return 1;
+}
+
+static const struct drm_panel_funcs hx8394_drm_funcs =3D {
+	.disable   =3D hx8394_disable,
+	.unprepare =3D hx8394_unprepare,
+	.prepare   =3D hx8394_prepare,
+	.enable	   =3D hx8394_enable,
+	.get_modes =3D hx8394_get_modes,
+};
+
+static int hx8394_probe(struct mipi_dsi_device *dsi)
+{
+	struct device *dev =3D &dsi->dev;
+	struct hx8394 *ctx;
+	int ret;
+
+	ctx =3D devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return -ENOMEM;
+
+	ctx->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(ctx->reset_gpio))
+		return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
+				     "Failed to get reset gpio\n");
+
+	mipi_dsi_set_drvdata(dsi, ctx);
+
+	ctx->dev =3D dev;
+	ctx->desc =3D of_device_get_match_data(dev);
+
+	dsi->mode_flags =3D ctx->desc->mode_flags;
+	dsi->format =3D ctx->desc->format;
+	dsi->lanes =3D ctx->desc->lanes;
+
+	ctx->vcc =3D devm_regulator_get(dev, "vcc");
+	if (IS_ERR(ctx->vcc))
+		return dev_err_probe(dev, PTR_ERR(ctx->vcc),
+				     "Failed to request vcc regulator\n");
+
+	ctx->iovcc =3D devm_regulator_get(dev, "iovcc");
+	if (IS_ERR(ctx->iovcc))
+		return dev_err_probe(dev, PTR_ERR(ctx->iovcc),
+				     "Failed to request iovcc regulator\n");
+
+	drm_panel_init(&ctx->panel, dev, &hx8394_drm_funcs,
+		       DRM_MODE_CONNECTOR_DSI);
+
+	ret =3D drm_panel_of_backlight(&ctx->panel);
+	if (ret)
+		return ret;
+
+	drm_panel_add(&ctx->panel);
+
+	ret =3D mipi_dsi_attach(dsi);
+	if (ret < 0) {
+		dev_err_probe(dev, ret, "mipi_dsi_attach failed\n");
+		drm_panel_remove(&ctx->panel);
+		return ret;
+	}
+
+	dev_dbg(dev, "%ux%u@%u %ubpp dsi %udl - ready\n",
+		ctx->desc->mode->hdisplay, ctx->desc->mode->vdisplay,
+		drm_mode_vrefresh(ctx->desc->mode),
+		mipi_dsi_pixel_format_to_bpp(dsi->format), dsi->lanes);
+
+	return 0;
+}
+
+static void hx8394_shutdown(struct mipi_dsi_device *dsi)
+{
+	struct hx8394 *ctx =3D mipi_dsi_get_drvdata(dsi);
+	int ret;
+
+	ret =3D drm_panel_disable(&ctx->panel);
+	if (ret < 0)
+		dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret);
+
+	ret =3D drm_panel_unprepare(&ctx->panel);
+	if (ret < 0)
+		dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret);
+}
+
+static void hx8394_remove(struct mipi_dsi_device *dsi)
+{
+	struct hx8394 *ctx =3D mipi_dsi_get_drvdata(dsi);
+	int ret;
+
+	hx8394_shutdown(dsi);
+
+	ret =3D mipi_dsi_detach(dsi);
+	if (ret < 0)
+		dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
+
+	drm_panel_remove(&ctx->panel);
+}
+
+static const struct of_device_id hx8394_of_match[] =3D {
+	{ .compatible =3D "hannstar,hsd060bhw4", .data =3D &hsd060bhw4_desc },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, hx8394_of_match);
+
+static struct mipi_dsi_driver hx8394_driver =3D {
+	.probe	=3D hx8394_probe,
+	.remove =3D hx8394_remove,
+	.shutdown =3D hx8394_shutdown,
+	.driver =3D {
+		.name =3D DRV_NAME,
+		.of_match_table =3D hx8394_of_match,
+	},
+};
+module_mipi_dsi_driver(hx8394_driver);
+
+MODULE_AUTHOR("Kamil Trzci=C5=84ski <ayufan@ayufan.eu>");
+MODULE_DESCRIPTION("DRM driver for Himax HX8394 based MIPI DSI panels");
+MODULE_LICENSE("GPL");
--=20
2.38.1

From nobody Tue Sep 16 23:48:52 2025
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8E820C3DA7D
	for <linux-kernel@archiver.kernel.org>; Mon, 26 Dec 2022 13:50:50 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231766AbiLZNub (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 26 Dec 2022 08:50:31 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60974 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230325AbiLZNuR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Dec 2022 08:50:17 -0500
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7212110D
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1672062566;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=mw7xpxVI9Q/Jnt3L05urCEGaaPOXvycGiSQd0FrpIik=;
        b=KjEJJa3exCPgBlZhn11G2jOupsf4SsmtnhfK0NZ93TUfRuUL3f4EryYBIH0W5QFkT2rAo/
        l036xHm13WKPiEkhZH7ree+8K0DH+lTGUM+ENz6rzLz+obLc+4iMZ3MpAxJku2x1nSMO5r
        wYckTZwllqzgRamJ1dFNUM+DpY7HUn4=
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-517-OUKp_NuVOkCU1ahXR8Gcbw-1; Mon, 26 Dec 2022 08:49:25 -0500
X-MC-Unique: OUKp_NuVOkCU1ahXR8Gcbw-1
Received: by mail-wm1-f71.google.com with SMTP id
 m38-20020a05600c3b2600b003d1fc5f1f80so8116676wms.1
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=mw7xpxVI9Q/Jnt3L05urCEGaaPOXvycGiSQd0FrpIik=;
        b=IlRPVFWU5FIB/ZzEBHJ/zqKpMbxhiyKrdFsE3Q/z4SrhT0D7gQa2WJHZeXkbTFcL8p
         kQXhOZCNWjM20L5clc6q4VllxVvCWwYIpJOc+36zjuRgbVTvIg8BkUxA0vXCJdYoLDe/
         S4XNSyiZiCENKTv/dJdtzIuQh+quNsiWiRz0up2LulZRuBlkRj94ypv4VWi3aFeSeV5x
         L60rS5nrIumhwbKPeOmRzznwL0SOLu44rlbqqESkCFx+CLsEvlpiNXM5Sfa12QAImMWq
         2YIHI4c8nqgCzAF9Z2seOAAM+l23B9yI581kxv5igrbnoGIf8xpbH6zlQlQZEoF5jeU/
         gnhg==
X-Gm-Message-State: AFqh2koxmqa5cde+YTFGEXeodPyLGEa1D2o4Tx9Mzg0CDfx2QBhrEHv+
        M9EEK6j1EaZSyaCmM830SnKk0CC1YkazphwAkQ+fQi4a3uIhLhVwmbWdwM3xgDrnlue4idFCMD2
        KxF3F1CZtULDFhtbvdjp/XRPD8bl5Y20CJl1zB9TB/Mshl8QWn1LvZn4TkeJLOA9oL33dHyVv8X
        M=
X-Received: by 2002:a05:6000:1246:b0:24f:869a:6c13 with SMTP id
 j6-20020a056000124600b0024f869a6c13mr11747365wrx.2.1672062563948;
        Mon, 26 Dec 2022 05:49:23 -0800 (PST)
X-Google-Smtp-Source: 
 AMrXdXvUvZdjNR7Fa8fpKiew/GyjwBoEhaZv2N568YBi4HBO08rtzrVuxhbL312QdhdG1u5YjDEtcA==
X-Received: by 2002:a05:6000:1246:b0:24f:869a:6c13 with SMTP id
 j6-20020a056000124600b0024f869a6c13mr11747344wrx.2.1672062563708;
        Mon, 26 Dec 2022 05:49:23 -0800 (PST)
Received: from minerva.home (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205])
        by smtp.gmail.com with ESMTPSA id
 a18-20020adfed12000000b0027cfd9463d7sm3340947wro.110.2022.12.26.05.49.22
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 26 Dec 2022 05:49:23 -0800 (PST)
From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Ondrej Jirman <megi@xff.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Robert Mader <robert.mader@posteo.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maya Matuszczyk <maccraft123mc@gmail.com>,
        =?UTF-8?q?Kamil=20Trzci=C5=84ski?= <ayufan@ayufan.eu>,
        Martijn Braam <martijn@brixit.nl>,
        Peter Robinson <pbrobinson@gmail.com>,
        Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel
 controller
Date: Mon, 26 Dec 2022 14:49:06 +0100
Message-Id: <20221226134909.2822179-3-javierm@redhat.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221226134909.2822179-1-javierm@redhat.com>
References: <20221226134909.2822179-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"

Add device tree bindings for panels based on the Himax HX8394 controller,
such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
through a MIPI-DSI video interface.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Changes in v2:
- Drop redundant "bindings" in subject (Krzysztof Kozlowski).
- Drop "device tree bindings" in title (Krzysztof Kozlowski).
- Put port next to other "true" properties (Krzysztof Kozlowski).
- Add Krzysztof Kozlowski's Reviewed-by tag.

 .../bindings/display/panel/himax,hx8394.yaml  | 65 +++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/himax,h=
x8394.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.y=
aml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
new file mode 100644
index 000000000000..bead3f0b05c5
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/himax,hx8394.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax HX8394 MIPI-DSI LCD panel controller
+
+maintainers:
+  - Javier Martinez Canillas <javierm@redhat.com>
+
+description:
+  Device tree bindings for panels based on the Himax HX8394 controller,
+  such as the HannStar HSD060BHW4 720x1440 TFT LCD panel connected with
+  a MIPI-DSI video interface.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel
+      - hannstar,hsd060bhw4
+
+  vcc-supply:
+    description: Panel power supply
+
+  iovcc-supply:
+    description: I/O voltage supply
+
+  port: true
+
+  reset-gpios: true
+
+  backlight: true
+
+required:
+  - compatible
+  - vcc-supply
+  - iovcc-supply
+  - port
+  - reset-gpios
+  - backlight
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells =3D <1>;
+        #size-cells =3D <0>;
+        panel@0 {
+            compatible =3D "hannstar,hsd060bhw4";
+            reg =3D <0>;
+            vcc-supply =3D <&reg_2v8_p>;
+            iovcc-supply =3D <&reg_1v8_p>;
+            reset-gpios =3D <&gpio3 13 GPIO_ACTIVE_LOW>;
+            backlight =3D <&backlight>;
+        };
+    };
+
+...
--=20
2.38.1
From nobody Tue Sep 16 23:48:52 2025
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBE9C3DA79
	for <linux-kernel@archiver.kernel.org>; Mon, 26 Dec 2022 13:51:27 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229657AbiLZNvZ (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 26 Dec 2022 08:51:25 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60992 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229532AbiLZNuy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Dec 2022 08:50:54 -0500
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFCEB111E
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1672062568;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=wH+4HRZ1zZ0UoFhrYTYu15fArLuO/swgT/BBXQ1MINU=;
        b=aUIleuIX0TbFIoOxpf3Rqo2HRkY6Rt5AgF54Sxuf26OJcp3uRiicMutyl8Gpdn7UNlJMlR
        CvWRvbO8sdC7cmp7qdcbq/93yaBij4OSarc/sRg/mr5oOFZ9qx1hLMK6M4VlAAeyyQzhX9
        teIGCyOEUuyH6NCpYY8dWkC9AkzMbVw=
Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com
 [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-523-xUIHL28nNE6ZigAMb7rhdw-1; Mon, 26 Dec 2022 08:49:26 -0500
X-MC-Unique: xUIHL28nNE6ZigAMb7rhdw-1
Received: by mail-wm1-f69.google.com with SMTP id
 bi19-20020a05600c3d9300b003cf9d6c4016so8095582wmb.8
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:26 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=wH+4HRZ1zZ0UoFhrYTYu15fArLuO/swgT/BBXQ1MINU=;
        b=PsMmEWGR6luD7BiFh7g1RqsEmUTVTPRxmmB+tuH3aGW/Y4ZkTGVjHI1o0h2a56mk3P
         zvquuM91tdnttUIK5m8C262h2HacHrjRG1jsa0NA5N8huvGmgSfTR+KM+7k0ztN2LQ6N
         qbt++2qnfV4ggpSwyuFdtjKPQiLMqmJgzYGtyv3lshHaXJ6FI+zD/i+5nL9T8X3ronwZ
         IAZn9y9gvcV2iBl/nZ7fIP//wAmJg/VC2SF0j3J+b/XWEKmGtmbOvI6hbHKdjA4H1ibJ
         BQhZR60rdFpoK0yKj9aJ3Y41PatKKSLwUTERS4m/mNuLcpPYeOMY7+r5gE3ioezFor0t
         qusg==
X-Gm-Message-State: AFqh2koybBJrR0tI7qJyJkYsF5SeB0zbXCmUjNh6Qbs4DirFIDa4/1YN
        XRzapys1gGVEHZDAyPefxxsQ1iqRLtQEu9/Aln5ps3xv65kt2/5SM/T9QUxKTZhqYQCYj7hWy8u
        gZMMxopIXehup+2pxSyUJdn2KbH65BzQBDiAIyy06sptdqOWGWcwgvyueKYZ1jt5O8kpwx+TcI5
        Q=
X-Received: by 2002:a5d:6509:0:b0:27c:73d7:775d with SMTP id
 x9-20020a5d6509000000b0027c73d7775dmr2659180wru.60.1672062565471;
        Mon, 26 Dec 2022 05:49:25 -0800 (PST)
X-Google-Smtp-Source: 
 AMrXdXtpHQibN8nOsFA2BcVaDhWa1Viff9G8V2BP8MQaeg1nZxmxCbYRcBtYRDmgyMhnTyv8I7rSUw==
X-Received: by 2002:a5d:6509:0:b0:27c:73d7:775d with SMTP id
 x9-20020a5d6509000000b0027c73d7775dmr2659166wru.60.1672062565254;
        Mon, 26 Dec 2022 05:49:25 -0800 (PST)
Received: from minerva.home (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205])
        by smtp.gmail.com with ESMTPSA id
 a18-20020adfed12000000b0027cfd9463d7sm3340947wro.110.2022.12.26.05.49.23
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 26 Dec 2022 05:49:24 -0800 (PST)
From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Ondrej Jirman <megi@xff.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Robert Mader <robert.mader@posteo.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maya Matuszczyk <maccraft123mc@gmail.com>,
        =?UTF-8?q?Kamil=20Trzci=C5=84ski?= <ayufan@ayufan.eu>,
        Martijn Braam <martijn@brixit.nl>,
        Peter Robinson <pbrobinson@gmail.com>,
        Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
        Javier Martinez Canillas <javierm@redhat.com>
Subject: [PATCH v2 3/4] MAINTAINERS: Add entry for Himax HX8394 panel
 controller driver
Date: Mon, 26 Dec 2022 14:49:07 +0100
Message-Id: <20221226134909.2822179-4-javierm@redhat.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221226134909.2822179-1-javierm@redhat.com>
References: <20221226134909.2822179-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"

Add myself as maintainer for the driver and devicetree bindings schema.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

(no changes since v1)

 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2e832cf29bec..175d72203fb6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6480,6 +6480,13 @@ S:	Maintained
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 F:	drivers/gpu/drm/tiny/gm12u320.c
=20
+DRM DRIVER FOR HIMAX HX8394 MIPI-DSI LCD panels
+M:	Javier Martinez Canillas <javierm@redhat.com>
+S:	Maintained
+T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
+F:	drivers/gpu/drm/panel/panel-himax-hx8394.c
+
 DRM DRIVER FOR HX8357D PANELS
 M:	Emma Anholt <emma@anholt.net>
 S:	Maintained
--=20
2.38.1
From nobody Tue Sep 16 23:48:52 2025
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C10FAC3DA79
	for <linux-kernel@archiver.kernel.org>; Mon, 26 Dec 2022 13:51:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229713AbiLZNv2 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 26 Dec 2022 08:51:28 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60998 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229641AbiLZNuz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Dec 2022 08:50:55 -0500
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B870271B
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1672062569;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=gw4YKyE6m3dvm+AI9a6ZkGYjDJAM63OXGslSUuAlLo8=;
        b=U8wRbb1XCOV2x17MxYeUvJ46Q+VYOBpkrNKt1jOHEmfXIs4rl31yLfYGXV/lFGozkTwwPL
        gqNawRh5aLKiHggFTG3O9DjUP6oOBl7N+aVFM4zJCt4w6TdxcfXIBRG6HFWmUyrWkyLC5a
        zhK84Z/o8SGxgJzuNHHvNPxa9lr5J3o=
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-591-B0sCD1xoMaqWY9RIyEoShQ-1; Mon, 26 Dec 2022 08:49:28 -0500
X-MC-Unique: B0sCD1xoMaqWY9RIyEoShQ-1
Received: by mail-wm1-f70.google.com with SMTP id
 b47-20020a05600c4aaf00b003d031aeb1b6so8095435wmp.9
        for <linux-kernel@vger.kernel.org>;
 Mon, 26 Dec 2022 05:49:28 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=gw4YKyE6m3dvm+AI9a6ZkGYjDJAM63OXGslSUuAlLo8=;
        b=p6ez+LNrH/cUpBZN9BP0t7eCUMDFBRIHbwdj7YQOvMYWJEtjDidq081tSoCosWy9Zv
         99aEZ+dlllJXjL0mNiNQqs00/zJ3bIGcl+xpiEl5R5ExZFap7GlCm1AI/SPn/czh2UzF
         1Rt/9+RnVDpY4QwsG6zZWUDSTUF0cfjkgb8U2LmOYEbkrVh54SIhA/WxTQ1jhOimLvhX
         9h32KAfb8MBCbEt63fBrxep5olsm87TPp9SvJd/0XL4tXpmMXpvyKDifCjBX8PhYAdIv
         ig/skxiPrcCjXvklI3/Gc+lnGb7A1H9JAnpG5vnE4siVDnujxMtMLq7y8LgZBSkTp2zo
         ko1A==
X-Gm-Message-State: AFqh2krWf1TrlUg6htB3ifv9i/XYOtlh5SAPsWRmogBvuTS6LxRVJcr5
        nukK/lxBqqKaVoZp4GjId9p6lB6iHKz1PpWo8c+RwTIgD9gvN0skZnbfWEL+inKdooFtX5KVLx/
        G4qouQIc6PMQy7tObjz3dWq7s+D3aHONOwexbR6UDB7RMIxhmqB1rVssW22o/2AskdmCJqMiQ7t
        I=
X-Received: by 2002:a7b:c7d6:0:b0:3d1:ee3a:62ae with SMTP id
 z22-20020a7bc7d6000000b003d1ee3a62aemr15855545wmk.8.1672062567111;
        Mon, 26 Dec 2022 05:49:27 -0800 (PST)
X-Google-Smtp-Source: 
 AMrXdXsSXL0Ns8UFml4pgFquWr3xql1Chfes3jlMi8ynWpv2K9/OhcnWWzORV78VW6XaRzrrIKwXrg==
X-Received: by 2002:a7b:c7d6:0:b0:3d1:ee3a:62ae with SMTP id
 z22-20020a7bc7d6000000b003d1ee3a62aemr15855517wmk.8.1672062566819;
        Mon, 26 Dec 2022 05:49:26 -0800 (PST)
Received: from minerva.home (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205])
        by smtp.gmail.com with ESMTPSA id
 a18-20020adfed12000000b0027cfd9463d7sm3340947wro.110.2022.12.26.05.49.25
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 26 Dec 2022 05:49:26 -0800 (PST)
From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Ondrej Jirman <megi@xff.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Robert Mader <robert.mader@posteo.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maya Matuszczyk <maccraft123mc@gmail.com>,
        =?UTF-8?q?Kamil=20Trzci=C5=84ski?= <ayufan@ayufan.eu>,
        Martijn Braam <martijn@brixit.nl>,
        Peter Robinson <pbrobinson@gmail.com>,
        Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Subject: [PATCH v2 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display
 support
Date: Mon, 26 Dec 2022 14:49:08 +0100
Message-Id: <20221226134909.2822179-5-javierm@redhat.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221226134909.2822179-1-javierm@redhat.com>
References: <20221226134909.2822179-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Ondrej Jirman <megi@xff.cz>

The phone's display is using Hannstar LCD panel, and Goodix based
touchscreen. Support it.

Signed-off-by: Ondrej Jirman <megi@xff.cz>
Co-developed-by: Martijn Braam <martijn@brixit.nl>
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzci=C5=84ski <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzci=C5=84ski <ayufan@ayufan.eu>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

Changes in v2:
- Fix regulator node names (Maya Matuszczyk).
- Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk).
- Remove unnecessary comments in panel node (Maya Matuszczyk).

 .../dts/rockchip/rk3399-pinephone-pro.dts     | 123 ++++++++++++++++++
 1 file changed, 123 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a=
rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 0e4442b59a55..55048236eef7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -29,6 +29,12 @@ chosen {
 		stdout-path =3D "serial2:1500000n8";
 	};
=20
+	backlight: backlight {
+		compatible =3D "pwm-backlight";
+		pwms =3D <&pwm0 0 1000000 0>;
+		pwm-delay-us =3D <10000>;
+	};
+
 	gpio-keys {
 		compatible =3D "gpio-keys";
 		pinctrl-names =3D "default";
@@ -81,6 +87,32 @@ vcc1v8_codec: vcc1v8-codec-regulator {
 		regulator-max-microvolt =3D <1800000>;
 		vin-supply =3D <&vcc3v3_sys>;
 	};
+
+	/* MIPI DSI panel 1.8v supply */
+	vcc1v8_lcd: vcc1v8-lcd-regulator {
+		compatible =3D "regulator-fixed";
+		enable-active-high;
+		regulator-name =3D "vcc1v8_lcd";
+		regulator-min-microvolt =3D <1800000>;
+		regulator-max-microvolt =3D <1800000>;
+		vin-supply =3D <&vcc3v3_sys>;
+		gpio =3D <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>;
+		pinctrl-names =3D "default";
+		pinctrl-0 =3D <&display_pwren1>;
+	};
+
+	/* MIPI DSI panel 2.8v supply */
+	vcc2v8_lcd: vcc2v8-lcd-regulator {
+		compatible =3D "regulator-fixed";
+		enable-active-high;
+		regulator-name =3D "vcc2v8_lcd";
+		regulator-min-microvolt =3D <2800000>;
+		regulator-max-microvolt =3D <2800000>;
+		vin-supply =3D <&vcc3v3_sys>;
+		gpio =3D <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>;
+		pinctrl-names =3D "default";
+		pinctrl-0 =3D <&display_pwren>;
+	};
 };
=20
 &cpu_l0 {
@@ -111,6 +143,11 @@ &emmc_phy {
 	status =3D "okay";
 };
=20
+&gpu {
+	mali-supply =3D <&vdd_gpu>;
+	status =3D "okay";
+};
+
 &i2c0 {
 	clock-frequency =3D <400000>;
 	i2c-scl-rising-time-ns =3D <168>;
@@ -193,6 +230,9 @@ vcc3v0_touch: LDO_REG2 {
 				regulator-name =3D "vcc3v0_touch";
 				regulator-min-microvolt =3D <3000000>;
 				regulator-max-microvolt =3D <3000000>;
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
 			};
=20
 			vcca1v8_codec: LDO_REG3 {
@@ -326,6 +366,25 @@ opp07 {
 	};
 };
=20
+&i2c3 {
+	i2c-scl-rising-time-ns =3D <450>;
+	i2c-scl-falling-time-ns =3D <15>;
+	status =3D "okay";
+
+	touchscreen@14 {
+		compatible =3D "goodix,gt917s";
+		reg =3D <0x14>;
+		interrupt-parent =3D <&gpio3>;
+		interrupts =3D <RK_PB5 IRQ_TYPE_EDGE_RISING>;
+		irq-gpios =3D <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>;
+		reset-gpios =3D <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>;
+		AVDD28-supply =3D <&vcc3v0_touch>;
+		VDDIO-supply =3D <&vcc3v0_touch>;
+		touchscreen-size-x =3D <720>;
+		touchscreen-size-y =3D <1440>;
+	};
+};
+
 &io_domains {
 	bt656-supply =3D <&vcc1v8_dvp>;
 	audio-supply =3D <&vcca1v8_codec>;
@@ -334,6 +393,40 @@ &io_domains {
 	status =3D "okay";
 };
=20
+&mipi_dsi {
+	status =3D "okay";
+	clock-master;
+
+	ports {
+		mipi_out: port@1 {
+			#address-cells =3D <0>;
+			#size-cells =3D <0>;
+			reg =3D <1>;
+
+			mipi_out_panel: endpoint {
+				remote-endpoint =3D <&mipi_in_panel>;
+			};
+		};
+	};
+
+	panel@0 {
+		compatible =3D "hannstar,hsd060bhw4";
+		reg =3D <0>;
+		backlight =3D <&backlight>;
+		reset-gpios =3D <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
+		vcc-supply =3D <&vcc2v8_lcd>;
+		iovcc-supply =3D <&vcc1v8_lcd>;
+		pinctrl-names =3D "default";
+		pinctrl-0 =3D <&display_rst_l>;
+
+		port {
+			mipi_in_panel: endpoint {
+				remote-endpoint =3D <&mipi_out_panel>;
+			};
+		};
+	};
+};
+
 &pmu_io_domains {
 	pmu1830-supply =3D <&vcc_1v8>;
 	status =3D "okay";
@@ -360,6 +453,20 @@ vsel2_pin: vsel2-pin {
 		};
 	};
=20
+	dsi {
+		display_rst_l: display-rst-l {
+			rockchip,pins =3D <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+
+		display_pwren: display-pwren {
+			rockchip,pins =3D <3 RK_PA1 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+
+		display_pwren1: display-pwren1 {
+			rockchip,pins =3D <3 RK_PA5 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+	};
+
 	sound {
 		vcc1v8_codec_en: vcc1v8-codec-en {
 			rockchip,pins =3D <3 RK_PA4 RK_FUNC_GPIO &pcfg_pull_down>;
@@ -367,6 +474,10 @@ vcc1v8_codec_en: vcc1v8-codec-en {
 	};
 };
=20
+&pwm0 {
+	status =3D "okay";
+};
+
 &sdmmc {
 	bus-width =3D <4>;
 	cap-sd-highspeed;
@@ -396,3 +507,15 @@ &tsadc {
 &uart2 {
 	status =3D "okay";
 };
+
+&vopb {
+	status =3D "okay";
+	assigned-clocks =3D <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>,
+			  <&cru ACLK_VOP0>, <&cru HCLK_VOP0>;
+	assigned-clock-rates =3D <0>, <0>, <400000000>, <100000000>;
+	assigned-clock-parents =3D <&cru PLL_CPLL>, <&cru DCLK_VOP0_FRAC>;
+};
+
+&vopb_mmu {
+	status =3D "okay";
+};
--=20
2.38.1