From nobody Wed Sep 17 01:52:43 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE03C4332F for ; Fri, 23 Dec 2022 14:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236419AbiLWOwU (ORCPT ); Fri, 23 Dec 2022 09:52:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236432AbiLWOwM (ORCPT ); Fri, 23 Dec 2022 09:52:12 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC3332BA8 for ; Fri, 23 Dec 2022 06:52:11 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.184]) by gnuweeb.org (Postfix) with ESMTPSA id 248447E2AF; Fri, 23 Dec 2022 14:52:07 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671807131; bh=oJEfdxT5/bQz94HuPnh6KWVv4Q97ynYQ98e0q4+hCvk=; h=From:To:Cc:Subject:Date:From; b=YygV2RW5JSy8TgXFKoGe+8Pt6f9MiEHg6IF2tCDLhe479MO+TbQsF1/9aX1wZ9o0O nY7GFdrGJ/BaUVoVpHhlcUmp8RhOvMZkQ7FsQC6eHKvrVG5qSfB9n1BynklsdNosqr DdQ4U+pNKyxtpOot4oyZJ1u6aOpCZ8o5w7oBRmE5HsaMkKFV8BjIeGoiwe7qiEcyr0 eRj97WcTkCp2t9XAceRnW2Edg3W/uPklIEruJuKhpZDi7DkQ8hNRvyCoRExyfNbrsZ 7Ui8LJlUu7GLArHNgXo7ZvWsBEkqqvrHZNKVi7P94mE5P/5RVQYygSBmMAjQnbCTXI 6MfQNp5Rz73bg== From: Ammar Faizi To: Greg Kroah-Hartman Cc: Ammar Faizi , "Rafael J. Wysocki" , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Tom Rix , LLVM Mailing List Subject: [PATCH v1] driver core: Silence 'unused-but-set variable' warning Date: Fri, 23 Dec 2022 21:51:37 +0700 Message-Id: <20221223145137.3786601-1-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Ammar Faizi Compiling with clang-16: drivers/base/module.c:36:6: error: variable 'no_warn' set but not \ used [-Werror,-Wunused-but-set-variable] int no_warn; ^ 1 error generated. A reason the @no_warn variable exists is: sysfs_create_link() return value needs not be ignored to silence another warning. So don't remove @no_warn, but add a '(void)no_warn;'. Cc: LLVM Mailing List Signed-off-by: Ammar Faizi --- drivers/base/module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/module.c b/drivers/base/module.c index 46ad4d636731..42f0b3b9e7f8 100644 --- a/drivers/base/module.c +++ b/drivers/base/module.c @@ -59,22 +59,23 @@ void module_add_driver(struct module *mod, struct devic= e_driver *drv) return; =20 /* Don't check return codes; these calls are idempotent */ no_warn =3D sysfs_create_link(&drv->p->kobj, &mk->kobj, "module"); driver_name =3D make_driver_name(drv); if (driver_name) { module_create_drivers_dir(mk); no_warn =3D sysfs_create_link(mk->drivers_dir, &drv->p->kobj, driver_name); kfree(driver_name); } + (void)no_warn; } =20 void module_remove_driver(struct device_driver *drv) { struct module_kobject *mk =3D NULL; char *driver_name; =20 if (!drv) return; =20 sysfs_remove_link(&drv->p->kobj, "module"); base-commit: 8395ae05cb5a2e31d36106e8c85efa11cda849be --=20 Ammar Faizi