From nobody Wed Sep 17 06:26:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708C9C4167B for ; Fri, 23 Dec 2022 00:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235380AbiLWA6d (ORCPT ); Thu, 22 Dec 2022 19:58:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235598AbiLWA6C (ORCPT ); Thu, 22 Dec 2022 19:58:02 -0500 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E0362188A for ; Thu, 22 Dec 2022 16:57:57 -0800 (PST) Received: by mail-pl1-x649.google.com with SMTP id h2-20020a170902f54200b0018e56572a4eso2370989plf.9 for ; Thu, 22 Dec 2022 16:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=8k64KFPY2FFl58dlOKiSt/6ffoasCJxRfQQP/flk2s8=; b=ADGdSRhE19CpKn3Mx8Gw1o4OLrTbUVUIoTOjSZyGWqJNQL1SN7v8qQsh4q5cXqj6ZL hD6fxxwCTl4y/NNCwu4uuodODhWf/UAdCQYUzyxbDjQPykN+rUTv5icpILVoRgxBnOw/ yeOcWPtNLNwR3Y/uk6j76NAwfZg7MRzWvFz7ko8kkCzO6CB+8LvhG1Xfv7qgN06BwTPR tE+2BbMHDSCHA/Y16iC2bZMsqqlYWqoBvXSOH7eVW1O1/dc8s+Fc+brkRiaAncEhUjUu kRfRqXhHbJkZXcp9gW5MeZZhEQ+HG6DbvBb/0kC1i/PgW4/d5vbzVWUhK143REl6RJgm KT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8k64KFPY2FFl58dlOKiSt/6ffoasCJxRfQQP/flk2s8=; b=fquzQ/qleWfUEhAF3k9VjARt3Ut26dpFxVA2Z8j/NKGvQ9zjN7Razu818osZ6IwI9t aC3MHqCPnr+3MsXm++ISmUGwXDG40WF4eoG7AzgCWh4aeEuoGZ9Wkm3yQuap1ituCjke MdUaR2R/gxHhR2zJ8fSpQ2cfR2jfFic+cImOqRXRq56NTNgU/KXHiwBhlEGMy5hEPfAK pNGzbRQ78tlBXVqH526BXEbeNBjM2AjOCn7U6Zai70vUwHdOF8gKXmKRAx+1vdGgWTWg eNZc0ph1O23A2/4QUI/uTyRpBzkOBdW7u/nSIJv8d9Y3CixItLsjj2rGhiaL+WbfoFGq r/eg== X-Gm-Message-State: AFqh2koWGish/fEb3OR9GpBrCPcLLRv/DTzNwb6DbWmMQFWfYVmTsDQ0 +yjlZfec26jIC4FEpBk/aIoNmJtx/V8= X-Google-Smtp-Source: AMrXdXtZzqXSfhAfIWlCK+WT2T5JZRV5LJOH9tPTZxKT6bo1HSjiqq3ll6wCTHVFE26Ee59g4OXn+ZR2sNc= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:7794:b0:189:6936:7031 with SMTP id o20-20020a170902779400b0018969367031mr457317pll.31.1671757077092; Thu, 22 Dec 2022 16:57:57 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 23 Dec 2022 00:57:19 +0000 In-Reply-To: <20221223005739.1295925-1-seanjc@google.com> Mime-Version: 1.0 References: <20221223005739.1295925-1-seanjc@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221223005739.1295925-8-seanjc@google.com> Subject: [PATCH 07/27] drm/i915/gvt: Use an "unsigned long" to iterate over memslot gfns From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Zhenyu Wang , Zhi Wang Cc: kvm@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yan Zhao , Ben Gardon Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use an "unsigned long" instead of an "int" when iterating over the gfns in a memslot. The number of pages in the memslot is tracked as an "unsigned long", e.g. KVMGT could theoretically break if a KVM memslot larger than 16TiB were deleted (2^32 * 4KiB). Signed-off-by: Sean Christopherson --- drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kv= mgt.c index 6f358b4fe406..5d0e029d60d7 100644 --- a/drivers/gpu/drm/i915/gvt/kvmgt.c +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c @@ -1635,7 +1635,7 @@ static void kvmgt_page_track_flush_slot(struct kvm *k= vm, struct kvm_memory_slot *slot, struct kvm_page_track_notifier_node *node) { - int i; + unsigned long i; gfn_t gfn; struct intel_vgpu *info =3D container_of(node, struct intel_vgpu, track_node); --=20 2.39.0.314.g84b9a713c41-goog