From nobody Wed Sep 17 03:38:17 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C89C4332F for ; Thu, 22 Dec 2022 22:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbiLVWC4 (ORCPT ); Thu, 22 Dec 2022 17:02:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiLVWCw (ORCPT ); Thu, 22 Dec 2022 17:02:52 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 982D7DED0 for ; Thu, 22 Dec 2022 14:02:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671746571; x=1703282571; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=XzRcH9xIgofCN1Fx2C1/9Imdy13Q/iYG8/kotrsmBok=; b=kAvYFwULYAC9OXS8hhKKvvLgBHpKv0OLWtKzSblIjG0/mn/bLgS7leMI cwDHdFN+BQ1V3I8oqvlboHU7dOqv4gtJbG01v7G4+A4RODBZJkYBXuKdj D2vuxvXAdqbywBV7BJNjf8PIRMt2El2tJrNoVePB/k3SvwQ/nq8LItuKC pziDdOgkHEU37bl+euiVyuXTBdbtanHuMbw1pUJKpuRpgcSGsdX2wN4/p E8oTfk9GRHi3EDYNrm7GLGgwN6FJwU0RpRrupEVvU7P3KCIXQtkDQbGRM eOaCKOJk0ZbnBjZHKezU3h2uv9et+8HhvwI6pjRm4XqCtVcW6ilxeXSJo w==; X-IronPort-AV: E=McAfee;i="6500,9779,10569"; a="320282402" X-IronPort-AV: E=Sophos;i="5.96,266,1665471600"; d="scan'208";a="320282402" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2022 14:02:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10569"; a="602009621" X-IronPort-AV: E=Sophos;i="5.96,266,1665471600"; d="scan'208";a="602009621" Received: from twinkler-lnx.jer.intel.com ([10.12.87.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2022 14:02:26 -0800 From: Tomas Winkler To: Greg Kroah-Hartman Cc: Alexander Usyskin , Vitaly Lubart , linux-kernel@vger.kernel.org, Tomas Winkler Subject: [char-misc-next] mei: gsc_proxy: add gsc proxy driver Date: Fri, 23 Dec 2022 00:02:14 +0200 Message-Id: <20221222220214.3688774-1-tomas.winkler@intel.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Alexander Usyskin Add GSC proxy driver. It to allows messaging between GSC component on Intel on board graphics card and CSME device. GSC and MEI Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- MAINTAINERS | 2 +- drivers/misc/mei/Kconfig | 1 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/gsc_proxy/Kconfig | 13 ++ drivers/misc/mei/gsc_proxy/Makefile | 7 + drivers/misc/mei/gsc_proxy/mei_gsc_proxy.c | 205 +++++++++++++++++++++ 6 files changed, 228 insertions(+), 1 deletion(-) create mode 100644 drivers/misc/mei/gsc_proxy/Kconfig create mode 100644 drivers/misc/mei/gsc_proxy/Makefile create mode 100644 drivers/misc/mei/gsc_proxy/mei_gsc_proxy.c diff --git a/MAINTAINERS b/MAINTAINERS index 5490b1f94803..01473c039412 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10561,7 +10561,7 @@ M: Tomas Winkler L: linux-kernel@vger.kernel.org S: Supported F: Documentation/driver-api/mei/* -F: drivers/misc/mei/ +F: drivers/misc/mei/* F: drivers/watchdog/mei_wdt.c F: include/linux/mei_aux.h F: include/linux/mei_cl_bus.h diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index d21486d69df2..92baed17a50b 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers/misc/mei/Kconfig @@ -62,4 +62,5 @@ config INTEL_MEI_GSC =20 source "drivers/misc/mei/hdcp/Kconfig" source "drivers/misc/mei/pxp/Kconfig" +source "drivers/misc/mei/gsc_proxy/Kconfig" =20 diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile index fb740d754900..14aee253ae48 100644 --- a/drivers/misc/mei/Makefile +++ b/drivers/misc/mei/Makefile @@ -30,3 +30,4 @@ CFLAGS_mei-trace.o =3D -I$(src) =20 obj-$(CONFIG_INTEL_MEI_HDCP) +=3D hdcp/ obj-$(CONFIG_INTEL_MEI_PXP) +=3D pxp/ +obj-$(CONFIG_INTEL_MEI_GSC_PROXY) +=3D gsc_proxy/ diff --git a/drivers/misc/mei/gsc_proxy/Kconfig b/drivers/misc/mei/gsc_prox= y/Kconfig new file mode 100644 index 000000000000..9bc4486a6dad --- /dev/null +++ b/drivers/misc/mei/gsc_proxy/Kconfig @@ -0,0 +1,13 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2022, Intel Corporation. All rights reserved. +# +config INTEL_MEI_GSC_PROXY + tristate "Intel GSC Proxy services of ME Interface" + select INTEL_MEI_ME + depends on DRM_I915 + help + MEI Support for GSC Proxy Services on Intel platforms. + + MEI GSC proxy enables messaging between GSC service on + Intel graphics on-board card and services on CSE (MEI) + firmware residing SoC or PCH. diff --git a/drivers/misc/mei/gsc_proxy/Makefile b/drivers/misc/mei/gsc_pro= xy/Makefile new file mode 100644 index 000000000000..fd7da77ad90a --- /dev/null +++ b/drivers/misc/mei/gsc_proxy/Makefile @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (c) 2022, Intel Corporation. All rights reserved. +# +# Makefile - GSC Proxy client driver for Intel MEI Bus Driver. + +obj-$(CONFIG_INTEL_MEI_GSC_PROXY) +=3D mei_gsc_proxy.o diff --git a/drivers/misc/mei/gsc_proxy/mei_gsc_proxy.c b/drivers/misc/mei/= gsc_proxy/mei_gsc_proxy.c new file mode 100644 index 000000000000..4be6dc3ffdff --- /dev/null +++ b/drivers/misc/mei/gsc_proxy/mei_gsc_proxy.c @@ -0,0 +1,205 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2022 Intel Corporation + */ + +/** + * DOC: MEI_GSC_PROXY Client Driver + * + * The mei_gsc_proxy driver acts as a translation layer between + * user (I915) and CSE FW services. + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +/** + * mei_gsc_proxy_send - Sends a proxy message to ME FW. + * @dev: device corresponding to the mei_cl_device + * @buf: a message buffer to send + * @size: size of the message + * Return: bytes sent on Success, <0 on Failure + */ +static int mei_gsc_proxy_send(struct device *dev, const void *buf, size_t = size) +{ + ssize_t ret; + + if (!dev || !buf) + return -EINVAL; + + ret =3D mei_cldev_send(to_mei_cl_device(dev), buf, size); + if (ret < 0) + dev_dbg(dev, "mei_cldev_send failed. %zd\n", ret); + + return ret; +} + +/** + * mei_gsc_proxy_recv - Receives a proxy message from ME FW. + * @dev: device corresponding to the mei_cl_device + * @buf: a message buffer to contain the received message + * @size: size of the buffer + * Return: bytes received on Success, <0 on Failure + */ +static int mei_gsc_proxy_recv(struct device *dev, void *buf, size_t size) +{ + ssize_t ret; + + if (!dev || !buf) + return -EINVAL; + + ret =3D mei_cldev_recv(to_mei_cl_device(dev), buf, size); + if (ret < 0) + dev_dbg(dev, "mei_cldev_recv failed. %zd\n", ret); + + return ret; +} + +static const struct i915_gsc_proxy_component_ops mei_gsc_proxy_ops =3D { + .owner =3D THIS_MODULE, + .send =3D mei_gsc_proxy_send, + .recv =3D mei_gsc_proxy_recv, +}; + +static int mei_component_master_bind(struct device *dev) +{ + struct mei_cl_device *cldev =3D to_mei_cl_device(dev); + struct i915_gsc_proxy_component *comp_master =3D mei_cldev_get_drvdata(cl= dev); + + comp_master->ops =3D &mei_gsc_proxy_ops; + comp_master->mei_dev =3D dev; + return component_bind_all(dev, comp_master); +} + +static void mei_component_master_unbind(struct device *dev) +{ + struct mei_cl_device *cldev =3D to_mei_cl_device(dev); + struct i915_gsc_proxy_component *comp_master =3D mei_cldev_get_drvdata(cl= dev); + + component_unbind_all(dev, comp_master); +} + +static const struct component_master_ops mei_component_master_ops =3D { + .bind =3D mei_component_master_bind, + .unbind =3D mei_component_master_unbind, +}; + +/** + * mei_gsc_proxy_component_match - compare function for matching mei. + * + * The function checks if the driver is i915, the subcomponent is SW Pr= oxy + * and the grand parent of proxy and the parent of i915 are the same + * PCH device. + * + * @dev: master device + * @subcomponent: subcomponent to match (I915_COMPONENT_SWPROXY) + * @data: compare data (mei gsc proxy device) + * + * Return: + * * 1 - if components match + * * 0 - otherwise + */ +static int mei_gsc_proxy_component_match(struct device *dev, int subcompon= ent, void *data) +{ + struct device *base =3D data; + + if (!dev || !dev->driver || + strcmp(dev->driver->name, "i915") || + subcomponent !=3D I915_COMPONENT_GSC_PROXY) + return 0; + + base =3D base->parent; + if (!base) /* mei device */ + return 0; + + base =3D base->parent; /* pci device */ + + dev =3D dev->parent; + return (base && dev && dev =3D=3D base); +} + +static int mei_gsc_proxy_probe(struct mei_cl_device *cldev, const struct m= ei_cl_device_id *id) +{ + struct i915_gsc_proxy_component *comp_master; + struct component_match *master_match =3D NULL; + int ret; + + ret =3D mei_cldev_enable(cldev); + if (ret < 0) { + dev_err(&cldev->dev, "mei_cldev_enable Failed. %d\n", ret); + goto enable_err_exit; + } + + comp_master =3D kzalloc(sizeof(*comp_master), GFP_KERNEL); + if (!comp_master) { + ret =3D -ENOMEM; + goto err_exit; + } + + component_match_add_typed(&cldev->dev, &master_match, + mei_gsc_proxy_component_match, &cldev->dev); + if (IS_ERR_OR_NULL(master_match)) { + ret =3D -ENOMEM; + goto err_exit; + } + + mei_cldev_set_drvdata(cldev, comp_master); + ret =3D component_master_add_with_match(&cldev->dev, + &mei_component_master_ops, + master_match); + if (ret < 0) { + dev_err(&cldev->dev, "Master comp add failed %d\n", ret); + goto err_exit; + } + + return 0; + +err_exit: + mei_cldev_set_drvdata(cldev, NULL); + kfree(comp_master); + mei_cldev_disable(cldev); +enable_err_exit: + return ret; +} + +static void mei_gsc_proxy_remove(struct mei_cl_device *cldev) +{ + struct i915_gsc_proxy_component *comp_master =3D mei_cldev_get_drvdata(cl= dev); + int ret; + + component_master_del(&cldev->dev, &mei_component_master_ops); + kfree(comp_master); + mei_cldev_set_drvdata(cldev, NULL); + + ret =3D mei_cldev_disable(cldev); + if (ret) + dev_warn(&cldev->dev, "mei_cldev_disable() failed %d\n", ret); +} + +#define MEI_GUID_GSC_PROXY GUID_INIT(0xf73db04, 0x97ab, 0x4125, \ + 0xb8, 0x93, 0xe9, 0x4, 0xad, 0xd, 0x54, 0x64) + +static struct mei_cl_device_id mei_gsc_proxy_tbl[] =3D { + { .uuid =3D MEI_GUID_GSC_PROXY, .version =3D MEI_CL_VERSION_ANY }, + { } +}; +MODULE_DEVICE_TABLE(mei, mei_gsc_proxy_tbl); + +static struct mei_cl_driver mei_gsc_proxy_driver =3D { + .id_table =3D mei_gsc_proxy_tbl, + .name =3D KBUILD_MODNAME, + .probe =3D mei_gsc_proxy_probe, + .remove =3D mei_gsc_proxy_remove, +}; + +module_mei_cl_driver(mei_gsc_proxy_driver); + +MODULE_AUTHOR("Intel Corporation"); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("MEI GSC PROXY"); --=20 2.38.1