From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874ECC4332F for ; Thu, 22 Dec 2022 15:22:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235612AbiLVPW0 (ORCPT ); Thu, 22 Dec 2022 10:22:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235474AbiLVPWK (ORCPT ); Thu, 22 Dec 2022 10:22:10 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA2A2B262 for ; Thu, 22 Dec 2022 07:22:07 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id m18so5667780eji.5 for ; Thu, 22 Dec 2022 07:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rto2ruxRIV0gCp+iL+wXgXYAL6XHV44X7/ED9ueF8q8=; b=EcbLR463vW5beyZjdtWK2LuffwdXcxlVQtxehWpaYvsrw8h8RcFnXdsOVWho9bJfLy 51AY5x1aGasxXENB0HsUe48z3yvqKyRyNEtpZSFU+j5vPT7VhIIVRLRwgD75MUAmTCKa Fy22nEnyP5R7JlXrWGjZApCGJVnBBLhcmsOaeXMhVM67izZUX51i0kHq4dXmwjqQHW+6 4ksq61POzDz4yLrtdsUkyy9z7v8m4Qx+o818y0Elq3BTjp7KLhgRQBc5/prQsmteso1m afgDl16sd6PM0u1muADqDuvaU0kwzbEJjkYBw4b3H/XE/zrEmNWHONQZzpjTu/TEqaXG nJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rto2ruxRIV0gCp+iL+wXgXYAL6XHV44X7/ED9ueF8q8=; b=Sxib2IzMxDoQCgN+RdmvRzGaaCytkH4difYW+8e66W5ZxNif8yFPobVKb/vZG9ZJWT vUcF/c7y91hbz2XlVsh69dL111P0eN1c/aUA08GrK3uvnxYaXgEvdmgJgvXmN4WxzKzZ tyB3rY5QVHtx+pzlNn39ktnC61jJnggCjJmI/eX4EssjuAwUTEBMlqn6CqMhlpPhDuUM PUpMHUWOZv27OTtNllcpEJ6osnh55YVPo7NQkUvUXwg6W6oldJVBFxQ6jrJBx6N4cTIV gTgog0oHopooJ5kntPQ63wnxYrQkGPamrc8EjX5Q5XgP+QFg3G4dswfgya4Yryoi+GJW wgEQ== X-Gm-Message-State: AFqh2krKt7CKw3BhbWZHe3cWuQ1W7B/vB1ugAmOowP1TH3QE/ayPNWEL KqiuxN6LoNJd9OYAe70vZiaKn0LtuTKKhgQi X-Google-Smtp-Source: AMrXdXtMKnYzLtcc4HEDmKsgmMgdb+ICnOXeq88IyrmUrkF/m21sqp1bnTACpWk3Ikv50c582amQng== X-Received: by 2002:a17:907:8a16:b0:7c1:458b:a947 with SMTP id sc22-20020a1709078a1600b007c1458ba947mr6942883ejc.26.1671722525644; Thu, 22 Dec 2022 07:22:05 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:05 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Paolo Valente , Gabriele Felici , Carmine Zaccagnino Subject: [PATCH V12 1/8] block, bfq: split sync bfq_queues on a per-actuator basis Date: Thu, 22 Dec 2022 16:21:50 +0100 Message-Id: <20221222152157.61789-2-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Single-LUN multi-actuator SCSI drives, as well as all multi-actuator SATA drives appear as a single device to the I/O subsystem [1]. Yet they address commands to different actuators internally, as a function of Logical Block Addressing (LBAs). A given sector is reachable by only one of the actuators. For example, Seagate=E2=80=99s Serial Advanced Technology Attachment (SATA) version contains two actuators and maps the lower half of the SATA LBA space to the lower actuator and the upper half to the upper actuator. Evidently, to fully utilize actuators, no actuator must be left idle or underutilized while there is pending I/O for it. The block layer must somehow control the load of each actuator individually. This commit lays the ground for allowing BFQ to provide such a per-actuator control. BFQ associates an I/O-request sync bfq_queue with each process doing synchronous I/O, or with a group of processes, in case of queue merging. Then BFQ serves one bfq_queue at a time. While in service, a bfq_queue is emptied in request-position order. Yet the same process, or group of processes, may generate I/O for different actuators. In this case, different streams of I/O (each for a different actuator) get all inserted into the same sync bfq_queue. So there is basically no individual control on when each stream is served, i.e., on when the I/O requests of the stream are picked from the bfq_queue and dispatched to the drive. This commit enables BFQ to control the service of each actuator individually for synchronous I/O, by simply splitting each sync bfq_queue into N queues, one for each actuator. In other words, a sync bfq_queue is now associated to a pair (process, actuator). As a consequence of this split, the per-queue proportional-share policy implemented by BFQ will guarantee that the sync I/O generated for each actuator, by each process, receives its fair share of service. This is just a preparatory patch. If the I/O of the same process happens to be sent to different queues, then each of these queues may undergo queue merging. To handle this event, the bfq_io_cq data structure must be properly extended. In addition, stable merging must be disabled to avoid loss of control on individual actuators. Finally, also async queues must be split. These issues are described in detail and addressed in next commits. As for this commit, although multiple per-process bfq_queues are provided, the I/O of each process or group of processes is still sent to only one queue, regardless of the actuator the I/O is for. The forwarding to distinct bfq_queues will be enabled after addressing the above issues. [1] https://www.linaro.org/blog/budget-fair-queueing-bfq-linux-io-scheduler= -optimizations-for-multi-actuator-sata-hard-drives/ Signed-off-by: Gabriele Felici Signed-off-by: Carmine Zaccagnino Signed-off-by: Paolo Valente Reviewed-by: Damien Le Moal --- block/bfq-cgroup.c | 91 ++++++++++++------------ block/bfq-iosched.c | 164 +++++++++++++++++++++++++++++--------------- block/bfq-iosched.h | 51 +++++++++++--- 3 files changed, 199 insertions(+), 107 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index 1b2829e99dad..bd7bf0f8121d 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgroup.c @@ -714,6 +714,46 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_q= ueue *bfqq, bfq_put_queue(bfqq); } =20 +static void bfq_sync_bfqq_move(struct bfq_data *bfqd, + struct bfq_queue *sync_bfqq, + struct bfq_io_cq *bic, + struct bfq_group *bfqg, + unsigned int act_idx) +{ + struct bfq_queue *bfqq; + + if (!sync_bfqq->new_bfqq && !bfq_bfqq_coop(sync_bfqq)) { + /* We are the only user of this bfqq, just move it */ + if (sync_bfqq->entity.sched_data !=3D &bfqg->sched_data) + bfq_bfqq_move(bfqd, sync_bfqq, bfqg); + return; + } + + /* + * The queue was merged to a different queue. Check + * that the merge chain still belongs to the same + * cgroup. + */ + for (bfqq =3D sync_bfqq; bfqq; bfqq =3D bfqq->new_bfqq) + if (bfqq->entity.sched_data !=3D &bfqg->sched_data) + break; + if (bfqq) { + /* + * Some queue changed cgroup so the merge is not valid + * anymore. We cannot easily just cancel the merge (by + * clearing new_bfqq) as there may be other processes + * using this queue and holding refs to all queues + * below sync_bfqq->new_bfqq. Similarly if the merge + * already happened, we need to detach from bfqq now + * so that we cannot merge bio to a request from the + * old cgroup. + */ + bfq_put_cooperator(sync_bfqq); + bfq_release_process_ref(bfqd, sync_bfqq); + bic_set_bfqq(bic, NULL, true, act_idx); + } +} + /** * __bfq_bic_change_cgroup - move @bic to @bfqg. * @bfqd: the queue descriptor. @@ -728,53 +768,20 @@ static void __bfq_bic_change_cgroup(struct bfq_data *= bfqd, struct bfq_io_cq *bic, struct bfq_group *bfqg) { - struct bfq_queue *async_bfqq =3D bic_to_bfqq(bic, false); - struct bfq_queue *sync_bfqq =3D bic_to_bfqq(bic, true); - struct bfq_entity *entity; + unsigned int act_idx; =20 - if (async_bfqq) { - entity =3D &async_bfqq->entity; + for (act_idx =3D 0; act_idx < bfqd->num_actuators; act_idx++) { + struct bfq_queue *async_bfqq =3D bic_to_bfqq(bic, false, act_idx); + struct bfq_queue *sync_bfqq =3D bic_to_bfqq(bic, true, act_idx); =20 - if (entity->sched_data !=3D &bfqg->sched_data) { - bic_set_bfqq(bic, NULL, false); + if (async_bfqq && + async_bfqq->entity.sched_data !=3D &bfqg->sched_data) { + bic_set_bfqq(bic, NULL, false, act_idx); bfq_release_process_ref(bfqd, async_bfqq); } - } =20 - if (sync_bfqq) { - if (!sync_bfqq->new_bfqq && !bfq_bfqq_coop(sync_bfqq)) { - /* We are the only user of this bfqq, just move it */ - if (sync_bfqq->entity.sched_data !=3D &bfqg->sched_data) - bfq_bfqq_move(bfqd, sync_bfqq, bfqg); - } else { - struct bfq_queue *bfqq; - - /* - * The queue was merged to a different queue. Check - * that the merge chain still belongs to the same - * cgroup. - */ - for (bfqq =3D sync_bfqq; bfqq; bfqq =3D bfqq->new_bfqq) - if (bfqq->entity.sched_data !=3D - &bfqg->sched_data) - break; - if (bfqq) { - /* - * Some queue changed cgroup so the merge is - * not valid anymore. We cannot easily just - * cancel the merge (by clearing new_bfqq) as - * there may be other processes using this - * queue and holding refs to all queues below - * sync_bfqq->new_bfqq. Similarly if the merge - * already happened, we need to detach from - * bfqq now so that we cannot merge bio to a - * request from the old cgroup. - */ - bfq_put_cooperator(sync_bfqq); - bfq_release_process_ref(bfqd, sync_bfqq); - bic_set_bfqq(bic, NULL, true); - } - } + if (sync_bfqq) + bfq_sync_bfqq_move(bfqd, sync_bfqq, bic, bfqg, act_idx); } } =20 diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 16f43bbc575a..e889d50147e8 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -377,16 +377,23 @@ static const unsigned long bfq_late_stable_merging = =3D 600; #define RQ_BIC(rq) ((struct bfq_io_cq *)((rq)->elv.priv[0])) #define RQ_BFQQ(rq) ((rq)->elv.priv[1]) =20 -struct bfq_queue *bic_to_bfqq(struct bfq_io_cq *bic, bool is_sync) +struct bfq_queue *bic_to_bfqq(struct bfq_io_cq *bic, bool is_sync, + unsigned int actuator_idx) { - return bic->bfqq[is_sync]; + if (is_sync) + return bic->bfqq[1][actuator_idx]; + + return bic->bfqq[0][actuator_idx]; } =20 static void bfq_put_stable_ref(struct bfq_queue *bfqq); =20 -void bic_set_bfqq(struct bfq_io_cq *bic, struct bfq_queue *bfqq, bool is_s= ync) +void bic_set_bfqq(struct bfq_io_cq *bic, + struct bfq_queue *bfqq, + bool is_sync, + unsigned int actuator_idx) { - struct bfq_queue *old_bfqq =3D bic->bfqq[is_sync]; + struct bfq_queue *old_bfqq =3D bic->bfqq[is_sync][actuator_idx]; =20 /* Clear bic pointer if bfqq is detached from this bic */ if (old_bfqq && old_bfqq->bic =3D=3D bic) @@ -405,7 +412,10 @@ void bic_set_bfqq(struct bfq_io_cq *bic, struct bfq_qu= eue *bfqq, bool is_sync) * we cancel the stable merge if * bic->stable_merge_bfqq =3D=3D bfqq. */ - bic->bfqq[is_sync] =3D bfqq; + if (is_sync) + bic->bfqq[1][actuator_idx] =3D bfqq; + else + bic->bfqq[0][actuator_idx] =3D bfqq; =20 if (bfqq && bic->stable_merge_bfqq =3D=3D bfqq) { /* @@ -678,9 +688,9 @@ static void bfq_limit_depth(blk_opf_t opf, struct blk_m= q_alloc_data *data) { struct bfq_data *bfqd =3D data->q->elevator->elevator_data; struct bfq_io_cq *bic =3D bfq_bic_lookup(data->q); - struct bfq_queue *bfqq =3D bic ? bic_to_bfqq(bic, op_is_sync(opf)) : NULL; int depth; unsigned limit =3D data->q->nr_requests; + unsigned int act_idx; =20 /* Sync reads have full depth available */ if (op_is_sync(opf) && !op_is_write(opf)) { @@ -690,14 +700,25 @@ static void bfq_limit_depth(blk_opf_t opf, struct blk= _mq_alloc_data *data) limit =3D (limit * depth) >> bfqd->full_depth_shift; } =20 - /* - * Does queue (or any parent entity) exceed number of requests that - * should be available to it? Heavily limit depth so that it cannot - * consume more available requests and thus starve other entities. - */ - if (bfqq && bfqq_request_over_limit(bfqq, limit)) - depth =3D 1; + for (act_idx =3D 0; act_idx < bfqd->num_actuators; act_idx++) { + struct bfq_queue *bfqq; + + if (bic) + bfqq =3D bic_to_bfqq(bic, op_is_sync(opf), act_idx); + else + break; =20 + /* + * Does queue (or any parent entity) exceed number of + * requests that should be available to it? Heavily + * limit depth so that it cannot consume more + * available requests and thus starve other entities. + */ + if (bfqq && bfqq_request_over_limit(bfqq, limit)) { + depth =3D 1; + break; + } + } bfq_log(bfqd, "[%s] wr_busy %d sync %d depth %u", __func__, bfqd->wr_busy_queues, op_is_sync(opf), depth); if (depth) @@ -1766,6 +1787,18 @@ static bool bfq_bfqq_higher_class_or_weight(struct b= fq_queue *bfqq, return bfqq_weight > in_serv_weight; } =20 +/* + * Get the index of the actuator that will serve bio. + */ +static unsigned int bfq_actuator_index(struct bfq_data *bfqd, struct bio *= bio) +{ + /* + * Multi-actuator support not complete yet, so always return 0 + * for the moment (to keep incomplete mechanisms off). + */ + return 0; +} + static bool bfq_better_to_idle(struct bfq_queue *bfqq); =20 static void bfq_bfqq_handle_idle_busy_switch(struct bfq_data *bfqd, @@ -2098,7 +2131,7 @@ static void bfq_check_waker(struct bfq_data *bfqd, st= ruct bfq_queue *bfqq, * We reset waker detection logic also if too much time has passed * since the first detection. If wakeups are rare, pointless idling * doesn't hurt throughput that much. The condition below makes sure - * we do not uselessly idle blocking waker in more than 1/64 cases.=20 + * we do not uselessly idle blocking waker in more than 1/64 cases. */ if (bfqd->last_completed_rq_bfqq !=3D bfqq->tentative_waker_bfqq || @@ -2418,7 +2451,8 @@ static bool bfq_bio_merge(struct request_queue *q, st= ruct bio *bio, */ bfq_bic_update_cgroup(bic, bio); =20 - bfqd->bio_bfqq =3D bic_to_bfqq(bic, op_is_sync(bio->bi_opf)); + bfqd->bio_bfqq =3D bic_to_bfqq(bic, op_is_sync(bio->bi_opf), + bfq_actuator_index(bfqd, bio)); } else { bfqd->bio_bfqq =3D NULL; } @@ -3114,7 +3148,7 @@ bfq_merge_bfqqs(struct bfq_data *bfqd, struct bfq_io_= cq *bic, /* * Merge queues (that is, let bic redirect its requests to new_bfqq) */ - bic_set_bfqq(bic, new_bfqq, true); + bic_set_bfqq(bic, new_bfqq, true, bfqq->actuator_idx); bfq_mark_bfqq_coop(new_bfqq); /* * new_bfqq now belongs to at least two bics (it is a shared queue): @@ -4748,11 +4782,8 @@ static struct bfq_queue *bfq_select_queue(struct bfq= _data *bfqd) */ if (bfq_bfqq_wait_request(bfqq) || (bfqq->dispatched !=3D 0 && bfq_better_to_idle(bfqq))) { - struct bfq_queue *async_bfqq =3D - bfqq->bic && bfqq->bic->bfqq[0] && - bfq_bfqq_busy(bfqq->bic->bfqq[0]) && - bfqq->bic->bfqq[0]->next_rq ? - bfqq->bic->bfqq[0] : NULL; + unsigned int act_idx =3D bfqq->actuator_idx; + struct bfq_queue *async_bfqq =3D NULL; struct bfq_queue *blocked_bfqq =3D !hlist_empty(&bfqq->woken_list) ? container_of(bfqq->woken_list.first, @@ -4760,6 +4791,10 @@ static struct bfq_queue *bfq_select_queue(struct bfq= _data *bfqd) woken_list_node) : NULL; =20 + if (bfqq->bic && bfqq->bic->bfqq[0][act_idx] && + bfq_bfqq_busy(bfqq->bic->bfqq[0][act_idx]) && + bfqq->bic->bfqq[0][act_idx]->next_rq) + async_bfqq =3D bfqq->bic->bfqq[0][act_idx]; /* * The next four mutually-exclusive ifs decide * whether to try injection, and choose the queue to @@ -4844,7 +4879,7 @@ static struct bfq_queue *bfq_select_queue(struct bfq_= data *bfqd) icq_to_bic(async_bfqq->next_rq->elv.icq) =3D=3D bfqq->bic && bfq_serv_to_charge(async_bfqq->next_rq, async_bfqq) <=3D bfq_bfqq_budget_left(async_bfqq)) - bfqq =3D bfqq->bic->bfqq[0]; + bfqq =3D bfqq->bic->bfqq[0][act_idx]; else if (bfqq->waker_bfqq && bfq_bfqq_busy(bfqq->waker_bfqq) && bfqq->waker_bfqq->next_rq && @@ -5305,48 +5340,54 @@ static void bfq_exit_bfqq(struct bfq_data *bfqd, st= ruct bfq_queue *bfqq) bfq_release_process_ref(bfqd, bfqq); } =20 -static void bfq_exit_icq_bfqq(struct bfq_io_cq *bic, bool is_sync) +static void bfq_exit_icq_bfqq(struct bfq_io_cq *bic, bool is_sync, + unsigned int actuator_idx) { - struct bfq_queue *bfqq =3D bic_to_bfqq(bic, is_sync); + struct bfq_queue *bfqq =3D bic_to_bfqq(bic, is_sync, actuator_idx); struct bfq_data *bfqd; =20 if (bfqq) bfqd =3D bfqq->bfqd; /* NULL if scheduler already exited */ =20 if (bfqq && bfqd) { - unsigned long flags; - - spin_lock_irqsave(&bfqd->lock, flags); bfq_exit_bfqq(bfqd, bfqq); - bic_set_bfqq(bic, NULL, is_sync); - spin_unlock_irqrestore(&bfqd->lock, flags); + bic_set_bfqq(bic, NULL, is_sync, actuator_idx); } } =20 static void bfq_exit_icq(struct io_cq *icq) { struct bfq_io_cq *bic =3D icq_to_bic(icq); + struct bfq_data *bfqd =3D bic_to_bfqd(bic); + unsigned long flags; + unsigned int act_idx; + /* + * If bfqd and thus bfqd->num_actuators is not available any + * longer, then cycle over all possible per-actuator bfqqs in + * next loop. We rely on bic being zeroed on creation, and + * therefore on its unused per-actuator fields being NULL. + */ + unsigned int num_actuators =3D BFQ_MAX_ACTUATORS; =20 - if (bic->stable_merge_bfqq) { - struct bfq_data *bfqd =3D bic->stable_merge_bfqq->bfqd; + /* + * bfqd is NULL if scheduler already exited, and in that case + * this is the last time these queues are accessed. + */ + if (bfqd) { + spin_lock_irqsave(&bfqd->lock, flags); + num_actuators =3D bfqd->num_actuators; + } =20 - /* - * bfqd is NULL if scheduler already exited, and in - * that case this is the last time bfqq is accessed. - */ - if (bfqd) { - unsigned long flags; + if (bic->stable_merge_bfqq) + bfq_put_stable_ref(bic->stable_merge_bfqq); =20 - spin_lock_irqsave(&bfqd->lock, flags); - bfq_put_stable_ref(bic->stable_merge_bfqq); - spin_unlock_irqrestore(&bfqd->lock, flags); - } else { - bfq_put_stable_ref(bic->stable_merge_bfqq); - } + for (act_idx =3D 0; act_idx < num_actuators; act_idx++) { + bfq_exit_icq_bfqq(bic, true, act_idx); + bfq_exit_icq_bfqq(bic, false, act_idx); } =20 - bfq_exit_icq_bfqq(bic, true); - bfq_exit_icq_bfqq(bic, false); + if (bfqd) + spin_unlock_irqrestore(&bfqd->lock, flags); } =20 /* @@ -5423,23 +5464,25 @@ static void bfq_check_ioprio_change(struct bfq_io_c= q *bic, struct bio *bio) =20 bic->ioprio =3D ioprio; =20 - bfqq =3D bic_to_bfqq(bic, false); + bfqq =3D bic_to_bfqq(bic, false, bfq_actuator_index(bfqd, bio)); if (bfqq) { bfq_release_process_ref(bfqd, bfqq); bfqq =3D bfq_get_queue(bfqd, bio, false, bic, true); - bic_set_bfqq(bic, bfqq, false); + bic_set_bfqq(bic, bfqq, false, bfq_actuator_index(bfqd, bio)); } =20 - bfqq =3D bic_to_bfqq(bic, true); + bfqq =3D bic_to_bfqq(bic, true, bfq_actuator_index(bfqd, bio)); if (bfqq) bfq_set_next_ioprio_data(bfqq, bic); } =20 static void bfq_init_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq, - struct bfq_io_cq *bic, pid_t pid, int is_sync) + struct bfq_io_cq *bic, pid_t pid, int is_sync, + unsigned int act_idx) { u64 now_ns =3D ktime_get_ns(); =20 + bfqq->actuator_idx =3D act_idx; RB_CLEAR_NODE(&bfqq->entity.rb_node); INIT_LIST_HEAD(&bfqq->fifo); INIT_HLIST_NODE(&bfqq->burst_list_node); @@ -5692,7 +5735,7 @@ static struct bfq_queue *bfq_get_queue(struct bfq_dat= a *bfqd, =20 if (bfqq) { bfq_init_bfqq(bfqd, bfqq, bic, current->pid, - is_sync); + is_sync, bfq_actuator_index(bfqd, bio)); bfq_init_entity(&bfqq->entity, bfqg); bfq_log_bfqq(bfqd, bfqq, "allocated"); } else { @@ -6007,7 +6050,8 @@ static bool __bfq_insert_request(struct bfq_data *bfq= d, struct request *rq) * then complete the merge and redirect it to * new_bfqq. */ - if (bic_to_bfqq(RQ_BIC(rq), 1) =3D=3D bfqq) + if (bic_to_bfqq(RQ_BIC(rq), true, + bfq_actuator_index(bfqd, rq->bio)) =3D=3D bfqq) bfq_merge_bfqqs(bfqd, RQ_BIC(rq), bfqq, new_bfqq); =20 @@ -6562,7 +6606,7 @@ bfq_split_bfqq(struct bfq_io_cq *bic, struct bfq_queu= e *bfqq) return bfqq; } =20 - bic_set_bfqq(bic, NULL, true); + bic_set_bfqq(bic, NULL, true, bfqq->actuator_idx); =20 bfq_put_cooperator(bfqq); =20 @@ -6576,7 +6620,8 @@ static struct bfq_queue *bfq_get_bfqq_handle_split(st= ruct bfq_data *bfqd, bool split, bool is_sync, bool *new_queue) { - struct bfq_queue *bfqq =3D bic_to_bfqq(bic, is_sync); + unsigned int act_idx =3D bfq_actuator_index(bfqd, bio); + struct bfq_queue *bfqq =3D bic_to_bfqq(bic, is_sync, act_idx); =20 if (likely(bfqq && bfqq !=3D &bfqd->oom_bfqq)) return bfqq; @@ -6588,7 +6633,7 @@ static struct bfq_queue *bfq_get_bfqq_handle_split(st= ruct bfq_data *bfqd, bfq_put_queue(bfqq); bfqq =3D bfq_get_queue(bfqd, bio, is_sync, bic, split); =20 - bic_set_bfqq(bic, bfqq, is_sync); + bic_set_bfqq(bic, bfqq, is_sync, act_idx); if (split && is_sync) { if ((bic->was_in_burst_list && bfqd->large_burst) || bic->saved_in_large_burst) @@ -7036,8 +7081,10 @@ static int bfq_init_queue(struct request_queue *q, s= truct elevator_type *e) * Our fallback bfqq if bfq_find_alloc_queue() runs into OOM issues. * Grab a permanent reference to it, so that the normal code flow * will not attempt to free it. + * Set zero as actuator index: we will pretend that + * all I/O requests are for the same actuator. */ - bfq_init_bfqq(bfqd, &bfqd->oom_bfqq, NULL, 1, 0); + bfq_init_bfqq(bfqd, &bfqd->oom_bfqq, NULL, 1, 0, 0); bfqd->oom_bfqq.ref++; bfqd->oom_bfqq.new_ioprio =3D BFQ_DEFAULT_QUEUE_IOPRIO; bfqd->oom_bfqq.new_ioprio_class =3D IOPRIO_CLASS_BE; @@ -7056,6 +7103,13 @@ static int bfq_init_queue(struct request_queue *q, s= truct elevator_type *e) =20 bfqd->queue =3D q; =20 + /* + * Multi-actuator support not complete yet, unconditionally + * set to only one actuator for the moment (to keep incomplete + * mechanisms off). + */ + bfqd->num_actuators =3D 1; + INIT_LIST_HEAD(&bfqd->dispatch); =20 hrtimer_init(&bfqd->idle_slice_timer, CLOCK_MONOTONIC, diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 41aa151ccc22..3c6b21b2cd95 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -33,6 +33,14 @@ */ #define BFQ_SOFTRT_WEIGHT_FACTOR 100 =20 +/* + * Maximum number of actuators supported. This constant is used simply + * to define the size of the static array that will contain + * per-actuator data. The current value is hopefully a good upper + * bound to the possible number of actuators of any actual drive. + */ +#define BFQ_MAX_ACTUATORS 8 + struct bfq_entity; =20 /** @@ -227,12 +235,14 @@ struct bfq_ttime { * struct bfq_queue - leaf schedulable entity. * * A bfq_queue is a leaf request queue; it can be associated with an - * io_context or more, if it is async or shared between cooperating - * processes. @cgroup holds a reference to the cgroup, to be sure that it - * does not disappear while a bfqq still references it (mostly to avoid - * races between request issuing and task migration followed by cgroup - * destruction). - * All the fields are protected by the queue lock of the containing bfqd. + * io_context or more, if it is async or shared between cooperating + * processes. Besides, it contains I/O requests for only one actuator + * (an io_context is associated with a different bfq_queue for each + * actuator it generates I/O for). @cgroup holds a reference to the + * cgroup, to be sure that it does not disappear while a bfqq still + * references it (mostly to avoid races between request issuing and + * task migration followed by cgroup destruction). All the fields are + * protected by the queue lock of the containing bfqd. */ struct bfq_queue { /* reference counter */ @@ -397,6 +407,9 @@ struct bfq_queue { * the woken queues when this queue exits. */ struct hlist_head woken_list; + + /* index of the actuator this queue is associated with */ + unsigned int actuator_idx; }; =20 /** @@ -405,8 +418,17 @@ struct bfq_queue { struct bfq_io_cq { /* associated io_cq structure */ struct io_cq icq; /* must be the first member */ - /* array of two process queues, the sync and the async */ - struct bfq_queue *bfqq[2]; + /* + * Matrix of associated process queues: first row for async + * queues, second row sync queues. Each row contains one + * column for each actuator. An I/O request generated by the + * process is inserted into the queue pointed by bfqq[i][j] if + * the request is to be served by the j-th actuator of the + * drive, where i=3D=3D0 or i=3D=3D1, depending on whether the request + * is async or sync. So there is a distinct queue for each + * actuator. + */ + struct bfq_queue *bfqq[2][BFQ_MAX_ACTUATORS]; /* per (request_queue, blkcg) ioprio */ int ioprio; #ifdef CONFIG_BFQ_GROUP_IOSCHED @@ -772,6 +794,13 @@ struct bfq_data { */ unsigned int word_depths[2][2]; unsigned int full_depth_shift; + + /* + * Number of independent actuators. This is equal to 1 in + * case of single-actuator drives. + */ + unsigned int num_actuators; + }; =20 enum bfqq_state_flags { @@ -969,8 +998,10 @@ struct bfq_group { =20 extern const int bfq_timeout; =20 -struct bfq_queue *bic_to_bfqq(struct bfq_io_cq *bic, bool is_sync); -void bic_set_bfqq(struct bfq_io_cq *bic, struct bfq_queue *bfqq, bool is_s= ync); +struct bfq_queue *bic_to_bfqq(struct bfq_io_cq *bic, bool is_sync, + unsigned int actuator_idx); +void bic_set_bfqq(struct bfq_io_cq *bic, struct bfq_queue *bfqq, bool is_s= ync, + unsigned int actuator_idx); struct bfq_data *bic_to_bfqd(struct bfq_io_cq *bic); void bfq_pos_tree_add_move(struct bfq_data *bfqd, struct bfq_queue *bfqq); void bfq_weights_tree_add(struct bfq_queue *bfqq); --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3803C4167B for ; Thu, 22 Dec 2022 15:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235601AbiLVPWX (ORCPT ); Thu, 22 Dec 2022 10:22:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235460AbiLVPWK (ORCPT ); Thu, 22 Dec 2022 10:22:10 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11C812B275 for ; Thu, 22 Dec 2022 07:22:08 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id i9so3376298edj.4 for ; Thu, 22 Dec 2022 07:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GtH7LxX060k0vsDW/XqMPuFbAPOrnd2PVUVe5DSzj+4=; b=SyZ8248IKsxyP4QBOJWJXbUJ6RYDjgmX0jjU+b4JD0NbiHxDy3zTpRuhlPfRRZ3vR7 XUEKgXp2SW1iiPmamluGV5f+F4q4ognbBcWUxjzaYBmlebqf3/QGeyBSOxRDT8uLi/bq HRXbvNaY7GVnt+KoA2dzIGe+divX5xcIG011pCEEmr30J68/jPDBEUnDWT+VluWAr32N tSg0LiaRRGxKpsYbxBLWYFXHRhq2v4+pKchZk8RPDlZ13wzz80sEW6b1ub6TRH8kA7ZQ kptaNfcJs6WST7cVL+FQUOf0mOSWktM/eXFzQJRBUpnJrT1NGUq0OnkfkIpCiU41MumX L9pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GtH7LxX060k0vsDW/XqMPuFbAPOrnd2PVUVe5DSzj+4=; b=ad8HcFk3Fiqr+rm5Tw0Ebz+ukJ9RyAPNWsbmHeSfirzsP6t1u944IW4QRu5gCnHbJP 5/ttmlJmpb5OHSKcOabBGiDHOrdgML9qFs9OBmI3+M6oVWVD+6+Y/xD1zCd7buNyM4KK MBxKmQwF4w4+kYLKdR1UviTh3W/QnQFAq548JTaz9RzZK/8PgpdkpMhztCPEWFZF56UV d/3uZQMJQ05m2OMBBm1XOo3HYixC21TZI/jpEgNdoenCEx4n0m0Xl2ANAvapksU7G7D2 H5748I0UG3l+YeX5CNx5SsTHi+orPyag0h7tsB8D20pc6mfSgxk4hM3wVkAGfts6mXAI vhZQ== X-Gm-Message-State: AFqh2kqpSxdTKTlYT7VhONEtIwJtIOX+sjEejfaInkZp/U9DwmaZKdLw 3nBjal0jR65865rjyimjl8BcLQ== X-Google-Smtp-Source: AMrXdXvXeolkOtf31taEI2hlKfRyGEJ2Z5AswZy2mKZttJpeYh/Dt0BFiDDagIt0SZNVvqGJwe3Y3Q== X-Received: by 2002:a05:6402:1caa:b0:46f:a73d:367c with SMTP id cz10-20020a0564021caa00b0046fa73d367cmr5096496edb.34.1671722526567; Thu, 22 Dec 2022 07:22:06 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:06 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Paolo Valente Subject: [PATCH V12 2/8] block, bfq: forbid stable merging of queues associated with different actuators Date: Thu, 22 Dec 2022 16:21:51 +0100 Message-Id: <20221222152157.61789-3-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If queues associated with different actuators are merged, then control is lost on each actuator. Therefore some actuator may be underutilized, and throughput may decrease. This problem cannot occur with basic queue merging, because the latter is triggered by spatial locality, and sectors for different actuators are not close to each other. Yet it may happen with stable merging. To address this issue, this commit prevents stable merging from occurring among queues associated with different actuators. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index e889d50147e8..437744147829 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5651,9 +5651,13 @@ static struct bfq_queue *bfq_do_or_sched_stable_merg= e(struct bfq_data *bfqd, * it has been set already, but too long ago, then move it * forward to bfqq. Finally, move also if bfqq belongs to a * different group than last_bfqq_created, or if bfqq has a - * different ioprio or ioprio_class. If none of these - * conditions holds true, then try an early stable merge or - * schedule a delayed stable merge. + * different ioprio, ioprio_class or actuator_idx. If none of + * these conditions holds true, then try an early stable merge + * or schedule a delayed stable merge. As for the condition on + * actuator_idx, the reason is that, if queues associated with + * different actuators are merged, then control is lost on + * each actuator. Therefore some actuator may be + * underutilized, and throughput may decrease. * * A delayed merge is scheduled (instead of performing an * early merge), in case bfqq might soon prove to be more @@ -5671,7 +5675,8 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge= (struct bfq_data *bfqd, bfqq->creation_time) || bfqq->entity.parent !=3D last_bfqq_created->entity.parent || bfqq->ioprio !=3D last_bfqq_created->ioprio || - bfqq->ioprio_class !=3D last_bfqq_created->ioprio_class) + bfqq->ioprio_class !=3D last_bfqq_created->ioprio_class || + bfqq->actuator_idx !=3D last_bfqq_created->actuator_idx) *source_bfqq =3D bfqq; else if (time_after_eq(last_bfqq_created->creation_time + bfqd->bfq_burst_interval, --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30472C001B2 for ; Thu, 22 Dec 2022 15:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235631AbiLVPW3 (ORCPT ); Thu, 22 Dec 2022 10:22:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbiLVPWL (ORCPT ); Thu, 22 Dec 2022 10:22:11 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C21B2B254 for ; Thu, 22 Dec 2022 07:22:09 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id gh17so5672860ejb.6 for ; Thu, 22 Dec 2022 07:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OkTG+Xv6K9WYxWiZEZ52myrF/p/fRT0GCFUuoPoncKE=; b=Unq7ibxCQbLpoK68hSt34WroL6omH/UXmBvrrnULYkQaLGl68WEiBTGMOZvVexHe/m uaZPgo4bk5SscgglckZNkZ2nYaeR7Xmn4lYIUvxUYadakCJYexBCdI1F9OmvF5KXJsXQ n+t/EfJ3Qul70tjUTArkEz0ghRLq0QlfOBWnEbDk/rfsZLwaA+GhuEkRPeJpow/rEac1 telfiFjIt/uC8ayH3lYR+6xZHFoEpqqM5nzpwA41lECfJTzlPMT7jfOZsB5AszJIWJQV QA2j+siVmoSKgum/IAnk2CAbBaDK+iFNcuyKP0akins4OUArJXRJIpXrocEQjBZTqB6Q 5ifw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OkTG+Xv6K9WYxWiZEZ52myrF/p/fRT0GCFUuoPoncKE=; b=CwDedrAoczV0j0sJxXEtcYLW4iVhKzzdfeYQqn057WovSiVTIedeKhoER0S297ep+c OpXX4Z7UoGwey2QXk6O5ZQrn3qTL8zXRJ4d015h+u3133Oy7DMyJkJeSjei6rrqrPNbj lkxYGggPtH/+ATrk+zYMfi4osS4QhOWNw71e+YU4EV877b0iJLjEIqkIIqH4fnZfAqVW yeG1j/HDHeckAaqfT91a02hPWav4SaPwDuYJCPGHhygz9CFmDMA9FSD148WdOqvSDNmZ sZ7XqCPmyeo4wegpBOtK/t9LimVOUj2iXAqlSF0hldGZCVN00PzMPvllRLDvbKgpSI57 fePQ== X-Gm-Message-State: AFqh2kpjsle2zcWN562CZzdhSV3htMsF/rQ3y2kSti3LBV/kP/TZdS7o A/3DvZL+euy0DonfSQgYTV4BPA== X-Google-Smtp-Source: AMrXdXtmBEwdBfEEbxhLXa9QQsdIyrIOvfHi69a0KsqU92v4lxP5gBUodtDqFpK7LFU8zxGUG2hDaQ== X-Received: by 2002:a17:907:3445:b0:7ad:c5b7:1c79 with SMTP id ac5-20020a170907344500b007adc5b71c79mr4046382ejc.45.1671722527550; Thu, 22 Dec 2022 07:22:07 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:07 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Paolo Valente , Gianmarco Lusvardi , Giulio Barabino , Emiliano Maccaferri Subject: [PATCH V12 3/8] block, bfq: move io_cq-persistent bfqq data into a dedicated struct Date: Thu, 22 Dec 2022 16:21:52 +0100 Message-Id: <20221222152157.61789-4-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" With a multi-actuator drive, a process may get associated with multiple bfq_queues: one queue for each of the N actuators. So, the bfq_io_cq data structure must be able to accommodate its per-queue persistent information for N queues. Currently it stores this information for just one queue, in several scalar fields. This is a preparatory commit for moving to accommodating persistent information for N queues. In particular, this commit packs all the above scalar fields into a single data structure. Then there is now only one field, in bfq_io_cq, that stores all the above information. This scalar field will then be turned into an array by a following commit. Suggested-by: Damien Le Moal Reviewed-by: Damien Le Moal Signed-off-by: Gianmarco Lusvardi Signed-off-by: Giulio Barabino Signed-off-by: Emiliano Maccaferri Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 138 +++++++++++++++++++++++++------------------- block/bfq-iosched.h | 52 ++++++++++------- 2 files changed, 110 insertions(+), 80 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 437744147829..92ad0ec4efcc 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -395,10 +395,6 @@ void bic_set_bfqq(struct bfq_io_cq *bic, { struct bfq_queue *old_bfqq =3D bic->bfqq[is_sync][actuator_idx]; =20 - /* Clear bic pointer if bfqq is detached from this bic */ - if (old_bfqq && old_bfqq->bic =3D=3D bic) - old_bfqq->bic =3D NULL; - /* * If bfqq !=3D NULL, then a non-stable queue merge between * bic->bfqq and bfqq is happening here. This causes troubles @@ -412,12 +408,18 @@ void bic_set_bfqq(struct bfq_io_cq *bic, * we cancel the stable merge if * bic->stable_merge_bfqq =3D=3D bfqq. */ + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; + + /* Clear bic pointer if bfqq is detached from this bic */ + if (old_bfqq && old_bfqq->bic =3D=3D bic) + old_bfqq->bic =3D NULL; + if (is_sync) bic->bfqq[1][actuator_idx] =3D bfqq; else bic->bfqq[0][actuator_idx] =3D bfqq; =20 - if (bfqq && bic->stable_merge_bfqq =3D=3D bfqq) { + if (bfqq && bfqq_data->stable_merge_bfqq =3D=3D bfqq) { /* * Actually, these same instructions are executed also * in bfq_setup_cooperator, in case of abort or actual @@ -426,9 +428,9 @@ void bic_set_bfqq(struct bfq_io_cq *bic, * did so, we would nest even more complexity in this * function. */ - bfq_put_stable_ref(bic->stable_merge_bfqq); + bfq_put_stable_ref(bfqq_data->stable_merge_bfqq); =20 - bic->stable_merge_bfqq =3D NULL; + bfqq_data->stable_merge_bfqq =3D NULL; } } =20 @@ -1137,38 +1139,40 @@ static void bfq_bfqq_resume_state(struct bfq_queue *bfqq, struct bfq_data *bfqd, struct bfq_io_cq *bic, bool bfq_already_existing) { + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; unsigned int old_wr_coeff =3D 1; bool busy =3D bfq_already_existing && bfq_bfqq_busy(bfqq); =20 - if (bic->saved_has_short_ttime) + if (bfqq_data->saved_has_short_ttime) bfq_mark_bfqq_has_short_ttime(bfqq); else bfq_clear_bfqq_has_short_ttime(bfqq); =20 - if (bic->saved_IO_bound) + if (bfqq_data->saved_IO_bound) bfq_mark_bfqq_IO_bound(bfqq); else bfq_clear_bfqq_IO_bound(bfqq); =20 - bfqq->last_serv_time_ns =3D bic->saved_last_serv_time_ns; - bfqq->inject_limit =3D bic->saved_inject_limit; - bfqq->decrease_time_jif =3D bic->saved_decrease_time_jif; + bfqq->last_serv_time_ns =3D bfqq_data->saved_last_serv_time_ns; + bfqq->inject_limit =3D bfqq_data->saved_inject_limit; + bfqq->decrease_time_jif =3D bfqq_data->saved_decrease_time_jif; =20 - bfqq->entity.new_weight =3D bic->saved_weight; - bfqq->ttime =3D bic->saved_ttime; - bfqq->io_start_time =3D bic->saved_io_start_time; - bfqq->tot_idle_time =3D bic->saved_tot_idle_time; + bfqq->entity.new_weight =3D bfqq_data->saved_weight; + bfqq->ttime =3D bfqq_data->saved_ttime; + bfqq->io_start_time =3D bfqq_data->saved_io_start_time; + bfqq->tot_idle_time =3D bfqq_data->saved_tot_idle_time; /* * Restore weight coefficient only if low_latency is on */ if (bfqd->low_latency) { old_wr_coeff =3D bfqq->wr_coeff; - bfqq->wr_coeff =3D bic->saved_wr_coeff; + bfqq->wr_coeff =3D bfqq_data->saved_wr_coeff; } - bfqq->service_from_wr =3D bic->saved_service_from_wr; - bfqq->wr_start_at_switch_to_srt =3D bic->saved_wr_start_at_switch_to_srt; - bfqq->last_wr_start_finish =3D bic->saved_last_wr_start_finish; - bfqq->wr_cur_max_time =3D bic->saved_wr_cur_max_time; + bfqq->service_from_wr =3D bfqq_data->saved_service_from_wr; + bfqq->wr_start_at_switch_to_srt =3D + bfqq_data->saved_wr_start_at_switch_to_srt; + bfqq->last_wr_start_finish =3D bfqq_data->saved_last_wr_start_finish; + bfqq->wr_cur_max_time =3D bfqq_data->saved_wr_cur_max_time; =20 if (bfqq->wr_coeff > 1 && (bfq_bfqq_in_large_burst(bfqq) || time_is_before_jiffies(bfqq->last_wr_start_finish + @@ -1853,7 +1857,7 @@ static void bfq_bfqq_handle_idle_busy_switch(struct b= fq_data *bfqd, wr_or_deserves_wr =3D bfqd->low_latency && (bfqq->wr_coeff > 1 || (bfq_bfqq_sync(bfqq) && - (bfqq->bic || RQ_BIC(rq)->stably_merged) && + (bfqq->bic || RQ_BIC(rq)->bfqq_data.stably_merged) && (*interactive || soft_rt))); =20 /* @@ -2853,6 +2857,7 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bf= q_queue *bfqq, void *io_struct, bool request, struct bfq_io_cq *bic) { struct bfq_queue *in_service_bfqq, *new_bfqq; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 /* if a merge has already been setup, then proceed with that first */ if (bfqq->new_bfqq) @@ -2874,21 +2879,21 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct = bfq_queue *bfqq, * stable merging) also if bic is associated with a * sync queue, but this bfqq is async */ - if (bfq_bfqq_sync(bfqq) && bic->stable_merge_bfqq && + if (bfq_bfqq_sync(bfqq) && bfqq_data->stable_merge_bfqq && !bfq_bfqq_just_created(bfqq) && time_is_before_jiffies(bfqq->split_time + msecs_to_jiffies(bfq_late_stable_merging)) && time_is_before_jiffies(bfqq->creation_time + msecs_to_jiffies(bfq_late_stable_merging))) { struct bfq_queue *stable_merge_bfqq =3D - bic->stable_merge_bfqq; + bfqq_data->stable_merge_bfqq; int proc_ref =3D min(bfqq_process_refs(bfqq), bfqq_process_refs(stable_merge_bfqq)); =20 /* deschedule stable merge, because done or aborted here */ bfq_put_stable_ref(stable_merge_bfqq); =20 - bic->stable_merge_bfqq =3D NULL; + bfqq_data->stable_merge_bfqq =3D NULL; =20 if (!idling_boosts_thr_without_issues(bfqd, bfqq) && proc_ref > 0) { @@ -2897,10 +2902,10 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct = bfq_queue *bfqq, bfq_setup_merge(bfqq, stable_merge_bfqq); =20 if (new_bfqq) { - bic->stably_merged =3D true; + bfqq_data->stably_merged =3D true; if (new_bfqq->bic) - new_bfqq->bic->stably_merged =3D - true; + new_bfqq->bic->bfqq_data.stably_merged =3D + true; } return new_bfqq; } else @@ -2999,6 +3004,7 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bf= q_queue *bfqq, static void bfq_bfqq_save_state(struct bfq_queue *bfqq) { struct bfq_io_cq *bic =3D bfqq->bic; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 /* * If !bfqq->bic, the queue is already shared or its requests @@ -3008,18 +3014,21 @@ static void bfq_bfqq_save_state(struct bfq_queue *b= fqq) if (!bic) return; =20 - bic->saved_last_serv_time_ns =3D bfqq->last_serv_time_ns; - bic->saved_inject_limit =3D bfqq->inject_limit; - bic->saved_decrease_time_jif =3D bfqq->decrease_time_jif; - - bic->saved_weight =3D bfqq->entity.orig_weight; - bic->saved_ttime =3D bfqq->ttime; - bic->saved_has_short_ttime =3D bfq_bfqq_has_short_ttime(bfqq); - bic->saved_IO_bound =3D bfq_bfqq_IO_bound(bfqq); - bic->saved_io_start_time =3D bfqq->io_start_time; - bic->saved_tot_idle_time =3D bfqq->tot_idle_time; - bic->saved_in_large_burst =3D bfq_bfqq_in_large_burst(bfqq); - bic->was_in_burst_list =3D !hlist_unhashed(&bfqq->burst_list_node); + bfqq_data->saved_last_serv_time_ns =3D bfqq->last_serv_time_ns; + bfqq_data->saved_inject_limit =3D bfqq->inject_limit; + bfqq_data->saved_decrease_time_jif =3D bfqq->decrease_time_jif; + + bfqq_data->saved_weight =3D bfqq->entity.orig_weight; + bfqq_data->saved_ttime =3D bfqq->ttime; + bfqq_data->saved_has_short_ttime =3D + bfq_bfqq_has_short_ttime(bfqq); + bfqq_data->saved_IO_bound =3D bfq_bfqq_IO_bound(bfqq); + bfqq_data->saved_io_start_time =3D bfqq->io_start_time; + bfqq_data->saved_tot_idle_time =3D bfqq->tot_idle_time; + bfqq_data->saved_in_large_burst =3D bfq_bfqq_in_large_burst(bfqq); + bfqq_data->was_in_burst_list =3D + !hlist_unhashed(&bfqq->burst_list_node); + if (unlikely(bfq_bfqq_just_created(bfqq) && !bfq_bfqq_in_large_burst(bfqq) && bfqq->bfqd->low_latency)) { @@ -3032,17 +3041,21 @@ static void bfq_bfqq_save_state(struct bfq_queue *b= fqq) * to bfqq, so that to avoid that bfqq unjustly fails * to enjoy weight raising if split soon. */ - bic->saved_wr_coeff =3D bfqq->bfqd->bfq_wr_coeff; - bic->saved_wr_start_at_switch_to_srt =3D bfq_smallest_from_now(); - bic->saved_wr_cur_max_time =3D bfq_wr_duration(bfqq->bfqd); - bic->saved_last_wr_start_finish =3D jiffies; + bfqq_data->saved_wr_coeff =3D bfqq->bfqd->bfq_wr_coeff; + bfqq_data->saved_wr_start_at_switch_to_srt =3D + bfq_smallest_from_now(); + bfqq_data->saved_wr_cur_max_time =3D + bfq_wr_duration(bfqq->bfqd); + bfqq_data->saved_last_wr_start_finish =3D jiffies; } else { - bic->saved_wr_coeff =3D bfqq->wr_coeff; - bic->saved_wr_start_at_switch_to_srt =3D + bfqq_data->saved_wr_coeff =3D bfqq->wr_coeff; + bfqq_data->saved_wr_start_at_switch_to_srt =3D bfqq->wr_start_at_switch_to_srt; - bic->saved_service_from_wr =3D bfqq->service_from_wr; - bic->saved_last_wr_start_finish =3D bfqq->last_wr_start_finish; - bic->saved_wr_cur_max_time =3D bfqq->wr_cur_max_time; + bfqq_data->saved_service_from_wr =3D + bfqq->service_from_wr; + bfqq_data->saved_last_wr_start_finish =3D + bfqq->last_wr_start_finish; + bfqq_data->saved_wr_cur_max_time =3D bfqq->wr_cur_max_time; } } =20 @@ -5368,6 +5381,7 @@ static void bfq_exit_icq(struct io_cq *icq) * therefore on its unused per-actuator fields being NULL. */ unsigned int num_actuators =3D BFQ_MAX_ACTUATORS; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 /* * bfqd is NULL if scheduler already exited, and in that case @@ -5378,8 +5392,8 @@ static void bfq_exit_icq(struct io_cq *icq) num_actuators =3D bfqd->num_actuators; } =20 - if (bic->stable_merge_bfqq) - bfq_put_stable_ref(bic->stable_merge_bfqq); + if (bfqq_data->stable_merge_bfqq) + bfq_put_stable_ref(bfqq_data->stable_merge_bfqq); =20 for (act_idx =3D 0; act_idx < num_actuators; act_idx++) { bfq_exit_icq_bfqq(bic, true, act_idx); @@ -5570,13 +5584,14 @@ bfq_do_early_stable_merge(struct bfq_data *bfqd, st= ruct bfq_queue *bfqq, { struct bfq_queue *new_bfqq =3D bfq_setup_merge(bfqq, last_bfqq_created); + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 if (!new_bfqq) return bfqq; =20 if (new_bfqq->bic) - new_bfqq->bic->stably_merged =3D true; - bic->stably_merged =3D true; + new_bfqq->bic->bfqq_data.stably_merged =3D true; + bfqq_data->stably_merged =3D true; =20 /* * Reusing merge functions. This implies that @@ -5645,6 +5660,7 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge= (struct bfq_data *bfqd, &bfqd->last_bfqq_created; =20 struct bfq_queue *last_bfqq_created =3D *source_bfqq; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 /* * If last_bfqq_created has not been set yet, then init it. If @@ -5706,7 +5722,7 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge= (struct bfq_data *bfqd, /* * Record the bfqq to merge to. */ - bic->stable_merge_bfqq =3D last_bfqq_created; + bfqq_data->stable_merge_bfqq =3D last_bfqq_created; } } =20 @@ -6627,6 +6643,7 @@ static struct bfq_queue *bfq_get_bfqq_handle_split(st= ruct bfq_data *bfqd, { unsigned int act_idx =3D bfq_actuator_index(bfqd, bio); struct bfq_queue *bfqq =3D bic_to_bfqq(bic, is_sync, act_idx); + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 if (likely(bfqq && bfqq !=3D &bfqd->oom_bfqq)) return bfqq; @@ -6640,12 +6657,12 @@ static struct bfq_queue *bfq_get_bfqq_handle_split(= struct bfq_data *bfqd, =20 bic_set_bfqq(bic, bfqq, is_sync, act_idx); if (split && is_sync) { - if ((bic->was_in_burst_list && bfqd->large_burst) || - bic->saved_in_large_burst) + if ((bfqq_data->was_in_burst_list && bfqd->large_burst) || + bfqq_data->saved_in_large_burst) bfq_mark_bfqq_in_large_burst(bfqq); else { bfq_clear_bfqq_in_large_burst(bfqq); - if (bic->was_in_burst_list) + if (bfqq_data->was_in_burst_list) /* * If bfqq was in the current * burst list before being @@ -6734,6 +6751,7 @@ static struct bfq_queue *bfq_init_rq(struct request *= rq) struct bfq_queue *bfqq; bool new_queue =3D false; bool bfqq_already_existing =3D false, split =3D false; + struct bfq_iocq_bfqq_data *bfqq_data; =20 if (unlikely(!rq->elv.icq)) return NULL; @@ -6757,15 +6775,17 @@ static struct bfq_queue *bfq_init_rq(struct request= *rq) bfqq =3D bfq_get_bfqq_handle_split(bfqd, bic, bio, false, is_sync, &new_queue); =20 + bfqq_data =3D &bic->bfqq_data; + if (likely(!new_queue)) { /* If the queue was seeky for too long, break it apart. */ if (bfq_bfqq_coop(bfqq) && bfq_bfqq_split_coop(bfqq) && - !bic->stably_merged) { + !bfqq_data->stably_merged) { struct bfq_queue *old_bfqq =3D bfqq; =20 /* Update bic before losing reference to bfqq */ if (bfq_bfqq_in_large_burst(bfqq)) - bic->saved_in_large_burst =3D true; + bfqq_data->saved_in_large_burst =3D true; =20 bfqq =3D bfq_split_bfqq(bic, bfqq); split =3D true; diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 3c6b21b2cd95..8e0215b8cc30 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -413,27 +413,9 @@ struct bfq_queue { }; =20 /** - * struct bfq_io_cq - per (request_queue, io_context) structure. - */ -struct bfq_io_cq { - /* associated io_cq structure */ - struct io_cq icq; /* must be the first member */ - /* - * Matrix of associated process queues: first row for async - * queues, second row sync queues. Each row contains one - * column for each actuator. An I/O request generated by the - * process is inserted into the queue pointed by bfqq[i][j] if - * the request is to be served by the j-th actuator of the - * drive, where i=3D=3D0 or i=3D=3D1, depending on whether the request - * is async or sync. So there is a distinct queue for each - * actuator. - */ - struct bfq_queue *bfqq[2][BFQ_MAX_ACTUATORS]; - /* per (request_queue, blkcg) ioprio */ - int ioprio; -#ifdef CONFIG_BFQ_GROUP_IOSCHED - uint64_t blkcg_serial_nr; /* the current blkcg serial */ -#endif +* struct bfq_data - bfqq data unique and persistent for associated bfq_io_= cq +*/ +struct bfq_iocq_bfqq_data { /* * Snapshot of the has_short_time flag before merging; taken * to remember its value while the queue is merged, so as to @@ -488,6 +470,34 @@ struct bfq_io_cq { struct bfq_queue *stable_merge_bfqq; =20 bool stably_merged; /* non splittable if true */ +}; + +/** + * struct bfq_io_cq - per (request_queue, io_context) structure. + */ +struct bfq_io_cq { + /* associated io_cq structure */ + struct io_cq icq; /* must be the first member */ + /* + * Matrix of associated process queues: first row for async + * queues, second row sync queues. Each row contains one + * column for each actuator. An I/O request generated by the + * process is inserted into the queue pointed by bfqq[i][j] if + * the request is to be served by the j-th actuator of the + * drive, where i=3D=3D0 or i=3D=3D1, depending on whether the request + * is async or sync. So there is a distinct queue for each + * actuator. + */ + struct bfq_queue *bfqq[2][BFQ_MAX_ACTUATORS]; + /* per (request_queue, blkcg) ioprio */ + int ioprio; +#ifdef CONFIG_BFQ_GROUP_IOSCHED + uint64_t blkcg_serial_nr; /* the current blkcg serial */ +#endif + + /* persistent data for associated synchronous process queue */ + struct bfq_iocq_bfqq_data bfqq_data; + unsigned int requests; /* Number of requests this process has in flight */ }; =20 --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE355C4332F for ; Thu, 22 Dec 2022 15:22:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235648AbiLVPWe (ORCPT ); Thu, 22 Dec 2022 10:22:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235522AbiLVPWM (ORCPT ); Thu, 22 Dec 2022 10:22:12 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11F342B608 for ; Thu, 22 Dec 2022 07:22:10 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id qk9so5698942ejc.3 for ; Thu, 22 Dec 2022 07:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eoG44HluLpCmNbgKKX6yZYb6s0SS8lxXnvk4jkGjiCA=; b=VEak0lS2kUqn+QEBZaY7zSej6QcRw/OOIsRWysEt3ftS/bwa232gYwgd2AHzqu2teX aBhgwnFU7v+RNvgEYDh890v1fvkCnxtBu4n0y2AaGdjdbzzOfjVjWPuqxTk0qjtztwEk R2Sd/WvBwkqr+2wLyHMbGp31bKwJd5hiZjrPP1P74mCixEjq9QGFSrEWcsalNxHr1cPQ x020AexJn1NEr0hYyOYhnSYxmY5gay33627QyYkutKU+WJE90ixTteLmMReH8LviPZCB R2wK8mKS8R+IkYIdBDLPbPiStAHGKEVk0KwsIEv5P0NLZICrEVP1+aC+Pbzld5t6xSBh GzbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eoG44HluLpCmNbgKKX6yZYb6s0SS8lxXnvk4jkGjiCA=; b=Jh+vwdniaqKDuDKBVa55m0aWZhULpOwCzy9Ct22h1vnEw1e3IS7SCOu9I244SsJSTU 24lod2QqT8UrIMz6jyLMqPrEPKYz9S+bj3M4vHAwBpcgja9NNBy9Ji8yDFXdDjvwjgzr oCVgBDpCEghZ8EMEahmRA5sbcS/ngAPEQzlLYojf/q8fLnfPL8TAG2XmMQQ6k+2qok6i rWPmT49iYA1bbvt8th6iL5WP9iTL7XYjQ+YvUIWBs/zLi1gIfeCpALzd5yHL4Sh2qKC4 zdPmm4gVXLLE6m8D09GH4N/PTzi+I+OSNZ/27Sp03f45Vb6JB7Jas9b0B4h66dTqfugo U7tg== X-Gm-Message-State: AFqh2kqjN6NgHPT+Z12mpU4ou61MA2gI3vFxGJhaaUEAV7J5zIOBYFLf /qfNwORHunEputQd9FABvSIApQ== X-Google-Smtp-Source: AMrXdXvFGBkeXTXS7J5DGFTHbxHp23g9Bc/fRfKUOi1kw+96TZg2th8rEP6s5/GG6kM0aVlaizGHtw== X-Received: by 2002:a17:907:d311:b0:7c4:e7b0:8491 with SMTP id vg17-20020a170907d31100b007c4e7b08491mr5260271ejc.61.1671722528599; Thu, 22 Dec 2022 07:22:08 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:08 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Paolo Valente , Gabriele Felici , Gianmarco Lusvardi , Giulio Barabino , Emiliano Maccaferri Subject: [PATCH V12 4/8] block, bfq: turn bfqq_data into an array in bfq_io_cq Date: Thu, 22 Dec 2022 16:21:53 +0100 Message-Id: <20221222152157.61789-5-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When a bfq_queue Q is merged with another queue, several pieces of information are saved about Q. These pieces are stored in the bfqq_data field in the bfq_io_cq data structure of the process associated with Q. Yet, with a multi-actuator drive, a process may get associated with multiple bfq_queues: one queue for each of the N actuators. Each of these queues may undergo a merge. So, the bfq_io_cq data structure must be able to accommodate the above information for N queues. This commit solves this problem by turning the bfqq_data scalar field into an array of N elements (and by changing code so as to handle this array). This solution is written under the assumption that bfq_queues associated with different actuators cannot be cross-merged. This assumption holds naturally with basic queue merging: the latter is triggered by spatial locality, and sectors for different actuators are not close to each other (apart from the corner case of the last sectors served by a given actuator and the first sectors served by the next actuator). As for stable cross-merging, the assumption here is that it is disabled. Reviewed-by: Damien Le Moal Signed-off-by: Gabriele Felici Signed-off-by: Gianmarco Lusvardi Signed-off-by: Giulio Barabino Signed-off-by: Emiliano Maccaferri Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 100 ++++++++++++++++++++++++++------------------ block/bfq-iosched.h | 12 ++++-- 2 files changed, 67 insertions(+), 45 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 92ad0ec4efcc..a9ac7b6f3b81 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -408,7 +408,7 @@ void bic_set_bfqq(struct bfq_io_cq *bic, * we cancel the stable merge if * bic->stable_merge_bfqq =3D=3D bfqq. */ - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data[actuator_idx]; =20 /* Clear bic pointer if bfqq is detached from this bic */ if (old_bfqq && old_bfqq->bic =3D=3D bic) @@ -1139,9 +1139,10 @@ static void bfq_bfqq_resume_state(struct bfq_queue *bfqq, struct bfq_data *bfqd, struct bfq_io_cq *bic, bool bfq_already_existing) { - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; unsigned int old_wr_coeff =3D 1; bool busy =3D bfq_already_existing && bfq_bfqq_busy(bfqq); + unsigned int a_idx =3D bfqq->actuator_idx; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data[a_idx]; =20 if (bfqq_data->saved_has_short_ttime) bfq_mark_bfqq_has_short_ttime(bfqq); @@ -1822,7 +1823,9 @@ static void bfq_bfqq_handle_idle_busy_switch(struct b= fq_data *bfqd, arrived_in_time =3D ktime_get_ns() <=3D bfqq->ttime.last_end_request + bfqd->bfq_slice_idle * 3; - + unsigned int act_idx =3D bfq_actuator_index(bfqd, rq->bio); + bool bfqq_non_merged_or_stably_merged =3D + bfqq->bic || RQ_BIC(rq)->bfqq_data[act_idx].stably_merged; =20 /* * bfqq deserves to be weight-raised if: @@ -1856,9 +1859,8 @@ static void bfq_bfqq_handle_idle_busy_switch(struct b= fq_data *bfqd, */ wr_or_deserves_wr =3D bfqd->low_latency && (bfqq->wr_coeff > 1 || - (bfq_bfqq_sync(bfqq) && - (bfqq->bic || RQ_BIC(rq)->bfqq_data.stably_merged) && - (*interactive || soft_rt))); + (bfq_bfqq_sync(bfqq) && bfqq_non_merged_or_stably_merged && + (*interactive || soft_rt))); =20 /* * Using the last flag, update budget and check whether bfqq @@ -2832,6 +2834,35 @@ static bool bfq_may_be_close_cooperator(struct bfq_q= ueue *bfqq, static bool idling_boosts_thr_without_issues(struct bfq_data *bfqd, struct bfq_queue *bfqq); =20 +static struct bfq_queue * +bfq_setup_stable_merge(struct bfq_data *bfqd, struct bfq_queue *bfqq, + struct bfq_queue *stable_merge_bfqq, + struct bfq_iocq_bfqq_data *bfqq_data) +{ + int proc_ref =3D min(bfqq_process_refs(bfqq), + bfqq_process_refs(stable_merge_bfqq)); + struct bfq_queue *new_bfqq; + + if (idling_boosts_thr_without_issues(bfqd, bfqq) || + proc_ref =3D=3D 0) + return NULL; + + /* next function will take at least one ref */ + new_bfqq =3D bfq_setup_merge(bfqq, stable_merge_bfqq); + + if (new_bfqq) { + bfqq_data->stably_merged =3D true; + if (new_bfqq->bic) { + unsigned int new_a_idx =3D new_bfqq->actuator_idx; + struct bfq_iocq_bfqq_data *new_bfqq_data =3D + &new_bfqq->bic->bfqq_data[new_a_idx]; + + new_bfqq_data->stably_merged =3D true; + } + } + return new_bfqq; +} + /* * Attempt to schedule a merge of bfqq with the currently in-service * queue or with a close queue among the scheduled queues. Return @@ -2857,7 +2888,8 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bf= q_queue *bfqq, void *io_struct, bool request, struct bfq_io_cq *bic) { struct bfq_queue *in_service_bfqq, *new_bfqq; - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; + unsigned int a_idx =3D bfqq->actuator_idx; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data[a_idx]; =20 /* if a merge has already been setup, then proceed with that first */ if (bfqq->new_bfqq) @@ -2887,29 +2919,15 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct = bfq_queue *bfqq, msecs_to_jiffies(bfq_late_stable_merging))) { struct bfq_queue *stable_merge_bfqq =3D bfqq_data->stable_merge_bfqq; - int proc_ref =3D min(bfqq_process_refs(bfqq), - bfqq_process_refs(stable_merge_bfqq)); =20 /* deschedule stable merge, because done or aborted here */ bfq_put_stable_ref(stable_merge_bfqq); =20 bfqq_data->stable_merge_bfqq =3D NULL; =20 - if (!idling_boosts_thr_without_issues(bfqd, bfqq) && - proc_ref > 0) { - /* next function will take at least one ref */ - struct bfq_queue *new_bfqq =3D - bfq_setup_merge(bfqq, stable_merge_bfqq); - - if (new_bfqq) { - bfqq_data->stably_merged =3D true; - if (new_bfqq->bic) - new_bfqq->bic->bfqq_data.stably_merged =3D - true; - } - return new_bfqq; - } else - return NULL; + return bfq_setup_stable_merge(bfqd, bfqq, + stable_merge_bfqq, + bfqq_data); } } =20 @@ -3004,7 +3022,8 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bf= q_queue *bfqq, static void bfq_bfqq_save_state(struct bfq_queue *bfqq) { struct bfq_io_cq *bic =3D bfqq->bic; - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; + unsigned int a_idx =3D bfqq->actuator_idx; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data[a_idx]; =20 /* * If !bfqq->bic, the queue is already shared or its requests @@ -3015,7 +3034,7 @@ static void bfq_bfqq_save_state(struct bfq_queue *bfq= q) return; =20 bfqq_data->saved_last_serv_time_ns =3D bfqq->last_serv_time_ns; - bfqq_data->saved_inject_limit =3D bfqq->inject_limit; + bfqq_data->saved_inject_limit =3D bfqq->inject_limit; bfqq_data->saved_decrease_time_jif =3D bfqq->decrease_time_jif; =20 bfqq_data->saved_weight =3D bfqq->entity.orig_weight; @@ -5381,7 +5400,7 @@ static void bfq_exit_icq(struct io_cq *icq) * therefore on its unused per-actuator fields being NULL. */ unsigned int num_actuators =3D BFQ_MAX_ACTUATORS; - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; + struct bfq_iocq_bfqq_data *bfqq_data =3D bic->bfqq_data; =20 /* * bfqd is NULL if scheduler already exited, and in that case @@ -5392,10 +5411,10 @@ static void bfq_exit_icq(struct io_cq *icq) num_actuators =3D bfqd->num_actuators; } =20 - if (bfqq_data->stable_merge_bfqq) - bfq_put_stable_ref(bfqq_data->stable_merge_bfqq); - for (act_idx =3D 0; act_idx < num_actuators; act_idx++) { + if (bfqq_data[act_idx].stable_merge_bfqq) + bfq_put_stable_ref(bfqq_data[act_idx].stable_merge_bfqq); + bfq_exit_icq_bfqq(bic, true, act_idx); bfq_exit_icq_bfqq(bic, false, act_idx); } @@ -5582,16 +5601,16 @@ bfq_do_early_stable_merge(struct bfq_data *bfqd, st= ruct bfq_queue *bfqq, struct bfq_io_cq *bic, struct bfq_queue *last_bfqq_created) { + unsigned int a_idx =3D last_bfqq_created->actuator_idx; struct bfq_queue *new_bfqq =3D bfq_setup_merge(bfqq, last_bfqq_created); - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 if (!new_bfqq) return bfqq; =20 if (new_bfqq->bic) - new_bfqq->bic->bfqq_data.stably_merged =3D true; - bfqq_data->stably_merged =3D true; + new_bfqq->bic->bfqq_data[a_idx].stably_merged =3D true; + bic->bfqq_data[a_idx].stably_merged =3D true; =20 /* * Reusing merge functions. This implies that @@ -5660,7 +5679,6 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge= (struct bfq_data *bfqd, &bfqd->last_bfqq_created; =20 struct bfq_queue *last_bfqq_created =3D *source_bfqq; - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; =20 /* * If last_bfqq_created has not been set yet, then init it. If @@ -5722,7 +5740,8 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge= (struct bfq_data *bfqd, /* * Record the bfqq to merge to. */ - bfqq_data->stable_merge_bfqq =3D last_bfqq_created; + bic->bfqq_data[last_bfqq_created->actuator_idx].stable_merge_bfqq =3D + last_bfqq_created; } } =20 @@ -6643,7 +6662,7 @@ static struct bfq_queue *bfq_get_bfqq_handle_split(st= ruct bfq_data *bfqd, { unsigned int act_idx =3D bfq_actuator_index(bfqd, bio); struct bfq_queue *bfqq =3D bic_to_bfqq(bic, is_sync, act_idx); - struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data; + struct bfq_iocq_bfqq_data *bfqq_data =3D &bic->bfqq_data[act_idx]; =20 if (likely(bfqq && bfqq !=3D &bfqd->oom_bfqq)) return bfqq; @@ -6751,7 +6770,7 @@ static struct bfq_queue *bfq_init_rq(struct request *= rq) struct bfq_queue *bfqq; bool new_queue =3D false; bool bfqq_already_existing =3D false, split =3D false; - struct bfq_iocq_bfqq_data *bfqq_data; + unsigned int a_idx =3D bfq_actuator_index(bfqd, bio); =20 if (unlikely(!rq->elv.icq)) return NULL; @@ -6775,17 +6794,16 @@ static struct bfq_queue *bfq_init_rq(struct request= *rq) bfqq =3D bfq_get_bfqq_handle_split(bfqd, bic, bio, false, is_sync, &new_queue); =20 - bfqq_data =3D &bic->bfqq_data; - if (likely(!new_queue)) { /* If the queue was seeky for too long, break it apart. */ if (bfq_bfqq_coop(bfqq) && bfq_bfqq_split_coop(bfqq) && - !bfqq_data->stably_merged) { + !bic->bfqq_data[a_idx].stably_merged) { struct bfq_queue *old_bfqq =3D bfqq; =20 /* Update bic before losing reference to bfqq */ if (bfq_bfqq_in_large_burst(bfqq)) - bfqq_data->saved_in_large_burst =3D true; + bic->bfqq_data[a_idx].saved_in_large_burst =3D + true; =20 bfqq =3D bfq_split_bfqq(bic, bfqq); split =3D true; diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 8e0215b8cc30..5a6f888930ad 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -418,7 +418,7 @@ struct bfq_queue { struct bfq_iocq_bfqq_data { /* * Snapshot of the has_short_time flag before merging; taken - * to remember its value while the queue is merged, so as to + * to remember its values while the queue is merged, so as to * be able to restore it in case of split. */ bool saved_has_short_ttime; @@ -432,7 +432,7 @@ struct bfq_iocq_bfqq_data { u64 saved_tot_idle_time; =20 /* - * Same purpose as the previous fields for the value of the + * Same purpose as the previous fields for the values of the * field keeping the queue's belonging to a large burst */ bool saved_in_large_burst; @@ -495,8 +495,12 @@ struct bfq_io_cq { uint64_t blkcg_serial_nr; /* the current blkcg serial */ #endif =20 - /* persistent data for associated synchronous process queue */ - struct bfq_iocq_bfqq_data bfqq_data; + /* + * Persistent data for associated synchronous process queues + * (one queue per actuator, see field bfqq above). In + * particular, each of these queues may undergo a merge. + */ + struct bfq_iocq_bfqq_data bfqq_data[BFQ_MAX_ACTUATORS]; =20 unsigned int requests; /* Number of requests this process has in flight */ }; --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5E3C4332F for ; Thu, 22 Dec 2022 15:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235718AbiLVPWk (ORCPT ); Thu, 22 Dec 2022 10:22:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235543AbiLVPWO (ORCPT ); Thu, 22 Dec 2022 10:22:14 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 013262B616 for ; Thu, 22 Dec 2022 07:22:11 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id fc4so5594044ejc.12 for ; Thu, 22 Dec 2022 07:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A3zZZMG0A5pdKAAyUaekL8jQDpZ8Qr344X5n0IW3lcw=; b=GxYRj+E72k9tW2Hf+gV4ZANJfxGB+AO6MDrIVNSbNLKiUnO17/98bqnS3AjzYrDHq7 kn+wL1HeYeBSApHqpGl392oSFYdDO0FvsfRZhtO22VZIGa7UM+Z+gncFbHUdj/LAh9+K MUhNkwqRjDFJ91qgJYQ/G0RkYES+ti5+WlZ4qwwKSwaOYto+BlPmNTIUiB3UTOvn4WKq cWUiuSp8FUU1/RjR+LHE/CorVFa4nDR21x6+Fz/AnkerGPSis+fHzjKmuw7iQ+17wKRA Tz47xEjXqes+Gfm/6VFzwr2OVi11J9ZnAF7Gzb/9dVlHhesQFOOfGx1dlGNLxNpMD+95 bK3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A3zZZMG0A5pdKAAyUaekL8jQDpZ8Qr344X5n0IW3lcw=; b=IwFXa3LCcBdXciwkM0yxiNSUGIdWS25wj3cWfK1RjzrMcqtjnbdXuRUlPYIRGlZISP ITg9Pr1LexktA48uDqTe4KRjzBMVB7RaeKVjcTu6N8pcL7Bx4ivwSZXN9nVeRHIzOy7A wKMZc56N9k6QEaEvTUaR264kT49hyRghALqcDcRIh/A+S0LxAJCDyeg6oJy+NBUMq2RK bPT1ahjCaQ+22ua5eD6E2EYI2em4Z+Qkn2X4FRSki6GbDSce1cwZ0W6r8L8q7XF3eIoC Rr+ezk1LQE4THPn7Ia5Qsz+yNEp2ELgY+jU1bdQMr3ikqQJqcNnIZEsbZxAsPjfyW0WQ FChw== X-Gm-Message-State: AFqh2kr+GYalYOvffoussLt5DXZ+3/pg+r6OQuN3nb4DGVxVp15TNeRn CJg8NXUDI0mnV3ITIr5WWfNV+A== X-Google-Smtp-Source: AMrXdXtMUpNyxNI/vG+OfSKNlBvDZevYDJF+EogEHu4okivBB81/U2Lk3UlECyr9a23Us5GjUczycA== X-Received: by 2002:a17:907:72d3:b0:7c0:fd1e:972e with SMTP id du19-20020a17090772d300b007c0fd1e972emr6330108ejc.46.1671722529509; Thu, 22 Dec 2022 07:22:09 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:09 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Davide Zini , Paolo Valente Subject: [PATCH V12 5/8] block, bfq: split also async bfq_queues on a per-actuator basis Date: Thu, 22 Dec 2022 16:21:54 +0100 Message-Id: <20221222152157.61789-6-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Davide Zini Similarly to sync bfq_queues, also async bfq_queues need to be split on a per-actuator basis. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente Signed-off-by: Davide Zini --- block/bfq-iosched.c | 41 +++++++++++++++++++++++------------------ block/bfq-iosched.h | 8 ++++---- 2 files changed, 27 insertions(+), 22 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index a9ac7b6f3b81..f29444d53e6a 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -2624,14 +2624,16 @@ static void bfq_bfqq_end_wr(struct bfq_queue *bfqq) void bfq_end_wr_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg) { - int i, j; - - for (i =3D 0; i < 2; i++) - for (j =3D 0; j < IOPRIO_NR_LEVELS; j++) - if (bfqg->async_bfqq[i][j]) - bfq_bfqq_end_wr(bfqg->async_bfqq[i][j]); - if (bfqg->async_idle_bfqq) - bfq_bfqq_end_wr(bfqg->async_idle_bfqq); + int i, j, k; + + for (k =3D 0; k < bfqd->num_actuators; k++) { + for (i =3D 0; i < 2; i++) + for (j =3D 0; j < IOPRIO_NR_LEVELS; j++) + if (bfqg->async_bfqq[i][j][k]) + bfq_bfqq_end_wr(bfqg->async_bfqq[i][j][k]); + if (bfqg->async_idle_bfqq[k]) + bfq_bfqq_end_wr(bfqg->async_idle_bfqq[k]); + } } =20 static void bfq_end_wr(struct bfq_data *bfqd) @@ -5579,18 +5581,18 @@ static void bfq_init_bfqq(struct bfq_data *bfqd, st= ruct bfq_queue *bfqq, =20 static struct bfq_queue **bfq_async_queue_prio(struct bfq_data *bfqd, struct bfq_group *bfqg, - int ioprio_class, int ioprio) + int ioprio_class, int ioprio, int act_idx) { switch (ioprio_class) { case IOPRIO_CLASS_RT: - return &bfqg->async_bfqq[0][ioprio]; + return &bfqg->async_bfqq[0][ioprio][act_idx]; case IOPRIO_CLASS_NONE: ioprio =3D IOPRIO_BE_NORM; fallthrough; case IOPRIO_CLASS_BE: - return &bfqg->async_bfqq[1][ioprio]; + return &bfqg->async_bfqq[1][ioprio][act_idx]; case IOPRIO_CLASS_IDLE: - return &bfqg->async_idle_bfqq; + return &bfqg->async_idle_bfqq[act_idx]; default: return NULL; } @@ -5763,7 +5765,8 @@ static struct bfq_queue *bfq_get_queue(struct bfq_dat= a *bfqd, bfqg =3D bfq_bio_bfqg(bfqd, bio); if (!is_sync) { async_bfqq =3D bfq_async_queue_prio(bfqd, bfqg, ioprio_class, - ioprio); + ioprio, + bfq_actuator_index(bfqd, bio)); bfqq =3D *async_bfqq; if (bfqq) goto out; @@ -6986,13 +6989,15 @@ static void __bfq_put_async_bfqq(struct bfq_data *b= fqd, */ void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg) { - int i, j; + int i, j, k; =20 - for (i =3D 0; i < 2; i++) - for (j =3D 0; j < IOPRIO_NR_LEVELS; j++) - __bfq_put_async_bfqq(bfqd, &bfqg->async_bfqq[i][j]); + for (k =3D 0; k < bfqd->num_actuators; k++) { + for (i =3D 0; i < 2; i++) + for (j =3D 0; j < IOPRIO_NR_LEVELS; j++) + __bfq_put_async_bfqq(bfqd, &bfqg->async_bfqq[i][j][k]); =20 - __bfq_put_async_bfqq(bfqd, &bfqg->async_idle_bfqq); + __bfq_put_async_bfqq(bfqd, &bfqg->async_idle_bfqq[k]); + } } =20 /* diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 5a6f888930ad..de2b2af643e5 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -980,8 +980,8 @@ struct bfq_group { =20 struct bfq_data *bfqd; =20 - struct bfq_queue *async_bfqq[2][IOPRIO_NR_LEVELS]; - struct bfq_queue *async_idle_bfqq; + struct bfq_queue *async_bfqq[2][IOPRIO_NR_LEVELS][BFQ_MAX_ACTUATORS]; + struct bfq_queue *async_idle_bfqq[BFQ_MAX_ACTUATORS]; =20 struct bfq_entity *my_entity; =20 @@ -998,8 +998,8 @@ struct bfq_group { struct bfq_entity entity; struct bfq_sched_data sched_data; =20 - struct bfq_queue *async_bfqq[2][IOPRIO_NR_LEVELS]; - struct bfq_queue *async_idle_bfqq; + struct bfq_queue *async_bfqq[2][IOPRIO_NR_LEVELS][BFQ_MAX_ACTUATORS]; + struct bfq_queue *async_idle_bfqq[BFQ_MAX_ACTUATORS]; =20 struct rb_root rq_pos_tree; }; --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08ECC4332F for ; Thu, 22 Dec 2022 15:22:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235683AbiLVPWi (ORCPT ); Thu, 22 Dec 2022 10:22:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235525AbiLVPWN (ORCPT ); Thu, 22 Dec 2022 10:22:13 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C680C2B255 for ; Thu, 22 Dec 2022 07:22:10 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id m18so5668304eji.5 for ; Thu, 22 Dec 2022 07:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bhr5qDaT2JKIRy4QvSZClVOncStleytag0NJgoail6A=; b=ePqAcSTv4XFlYItKTMjsdafeWPV1Hl+RIsok1DKy20O+kji7kTZb1NLBcjy8LSb5GO DKVimmhqpbvQvpGX3lkLIcV5qEzhTN+gHlzlVBYTRtwcP4XiiWXeG6OxUO8L6GC5CRjI KXSUPKuyEeqtb7mtcqdXGyalgJiLm3TULo5K6Eu/CX+Jb65fdcRb6YalpGGvyCOX+3km osFRw39wFQnsEu6dv4CBaXwNeRRTtG3Zdy3azOPmX8GjJtg3kdPGAaDByIvcuBetEfzE X/osZqdwjxHbrFjOv4285WvB4hSevd8RHOcvEKmBHli9hHeY3CS26iqJKjryyjcYY1X3 DNxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bhr5qDaT2JKIRy4QvSZClVOncStleytag0NJgoail6A=; b=78dD290lGwrkucI98RS+kS78dJ6+zlSt1xYmZUInMgTl9vAXjGapXCNJBnTi+lPBGD nJvM8cK/awgJaqNeWH65oUGrPlnRYeP8V5wCEkZOoH8+sHmWx6LuhrSGduDFjgYzAi8j pQxO0nLSxXHFjnITIlFKkTvoOGeEvK6b90HGcHNawWMSmBVG16EqjSIR/dzHj1taWdLk +cSwN7YN9FCeMo0wgd0akbd+Az6yj1Ug3OHa3QFBZxlAYHEs1rOBIlrShT+pSSbh7xCz HQjqKBZiJ1r98bAqJIBsFBUDjCASz2TPpvBuI5/L1ebuJytd2a54Bwox53Uv4NwxjOG6 FFGQ== X-Gm-Message-State: AFqh2kqDtdPhzfhy3gUdbWP0z5/k5+UO4/2tjbokqwDTpPjj/LLjeze2 E920ok3c0GBvOlIHqAjf5yZfPg== X-Google-Smtp-Source: AMrXdXtbgI4HP9ON1BOA05QZAkYnwABg7Urk8RYFc/CPmTwTPH+kKnb/ofkilCaMyH68fi7bo6a7Xw== X-Received: by 2002:a17:906:700f:b0:7c1:6bd9:571e with SMTP id n15-20020a170906700f00b007c16bd9571emr4149992ejj.13.1671722530401; Thu, 22 Dec 2022 07:22:10 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:10 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Federico Gavioli , Paolo Valente Subject: [PATCH V12 6/8] block, bfq: retrieve independent access ranges from request queue Date: Thu, 22 Dec 2022 16:21:55 +0100 Message-Id: <20221222152157.61789-7-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Federico Gavioli This patch implements the code to gather the content of the independent_access_ranges structure from the request_queue and copy it into the queue's bfq_data. This copy is done at queue initialization. We copy the access ranges into the bfq_data to avoid taking the queue lock each time we access the ranges. This implementation, however, puts a limit to the maximum independent ranges supported by the scheduler. Such a limit is equal to the constant BFQ_MAX_ACTUATORS. This limit was placed to avoid the allocation of dynamic memory. Reviewed-by: Damien Le Moal Co-developed-by: Rory Chen Signed-off-by: Rory Chen Signed-off-by: Federico Gavioli Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 59 +++++++++++++++++++++++++++++++++++++++------ block/bfq-iosched.h | 8 +++++- 2 files changed, 58 insertions(+), 9 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index f29444d53e6a..1db7fb18f99e 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -1797,10 +1797,25 @@ static bool bfq_bfqq_higher_class_or_weight(struct = bfq_queue *bfqq, */ static unsigned int bfq_actuator_index(struct bfq_data *bfqd, struct bio *= bio) { - /* - * Multi-actuator support not complete yet, so always return 0 - * for the moment (to keep incomplete mechanisms off). - */ + unsigned int i; + sector_t end; + + /* no search needed if one or zero ranges present */ + if (bfqd->num_actuators =3D=3D 1) + return 0; + + /* bio_end_sector(bio) gives the sector after the last one */ + end =3D bio_end_sector(bio) - 1; + + for (i =3D 0; i < bfqd->num_actuators; i++) { + if (end >=3D bfqd->sector[i] && + end < bfqd->sector[i] + bfqd->nr_sectors[i]) + return i; + } + + WARN_ONCE(true, + "bfq_actuator_index: bio sector out of ranges: end=3D%llu\n", + end); return 0; } =20 @@ -7109,6 +7124,8 @@ static int bfq_init_queue(struct request_queue *q, st= ruct elevator_type *e) { struct bfq_data *bfqd; struct elevator_queue *eq; + unsigned int i; + struct blk_independent_access_ranges *ia_ranges =3D q->disk->ia_ranges; =20 eq =3D elevator_alloc(q, e); if (!eq) @@ -7151,12 +7168,38 @@ static int bfq_init_queue(struct request_queue *q, = struct elevator_type *e) =20 bfqd->queue =3D q; =20 + bfqd->num_actuators =3D 1; /* - * Multi-actuator support not complete yet, unconditionally - * set to only one actuator for the moment (to keep incomplete - * mechanisms off). + * If the disk supports multiple actuators, copy independent + * access ranges from the request queue structure. */ - bfqd->num_actuators =3D 1; + spin_lock_irq(&q->queue_lock); + if (ia_ranges) { + /* + * Check if the disk ia_ranges size exceeds the current bfq + * actuator limit. + */ + if (ia_ranges->nr_ia_ranges > BFQ_MAX_ACTUATORS) { + pr_crit("nr_ia_ranges higher than act limit: iars=3D%d, max=3D%d.\n", + ia_ranges->nr_ia_ranges, BFQ_MAX_ACTUATORS); + pr_crit("Falling back to single actuator mode.\n"); + } else { + bfqd->num_actuators =3D ia_ranges->nr_ia_ranges; + + for (i =3D 0; i < bfqd->num_actuators; i++) { + bfqd->sector[i] =3D ia_ranges->ia_range[i].sector; + bfqd->nr_sectors[i] =3D + ia_ranges->ia_range[i].nr_sectors; + } + } + } + + /* Otherwise use single-actuator dev info */ + if (bfqd->num_actuators =3D=3D 1) { + bfqd->sector[0] =3D 0; + bfqd->nr_sectors[0] =3D get_capacity(q->disk); + } + spin_unlock_irq(&q->queue_lock); =20 INIT_LIST_HEAD(&bfqd->dispatch); =20 diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index de2b2af643e5..830dda1f9322 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -814,7 +814,13 @@ struct bfq_data { * case of single-actuator drives. */ unsigned int num_actuators; - + /* + * Disk independent access ranges for each actuator + * in this device. + */ + sector_t sector[BFQ_MAX_ACTUATORS]; + sector_t nr_sectors[BFQ_MAX_ACTUATORS]; + struct blk_independent_access_range ia_ranges[BFQ_MAX_ACTUATORS]; }; =20 enum bfqq_state_flags { --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38309C4332F for ; Thu, 22 Dec 2022 15:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235732AbiLVPXD (ORCPT ); Thu, 22 Dec 2022 10:23:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235423AbiLVPWr (ORCPT ); Thu, 22 Dec 2022 10:22:47 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23FA2CC90 for ; Thu, 22 Dec 2022 07:22:12 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id d20so3436716edn.0 for ; Thu, 22 Dec 2022 07:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tq0lv6gvluRlMDeVyibmzd7tiMAvpGwX0IvIgdqcbIg=; b=qczWrTuk+WeUUT+0umKgQ7NGWr5KYiV5dVt6UvUEcJTe/OAt2eiWZjnTkXN8rLpwMw PSWOuKHupf3GvMID8lAp1GDrVrFvSn2rXLL8BNo8sR5y5ePku9A0rNGRlJRvYE1h8Mnp VY7pPDwgyIzjR7hFRmyMBWCzOVQLdSSlBYTRUoo394CMEAU5lfgmE9oJPDl+sDF/alFr 9rZVfJou3lDVCgz5gu6f9QixnLF92XRPos1GYVS0zBZff+ecG45xE276MEepsV8cncVv gIgYsXQCPsiLAGsCWQPVdWodNKgIZT0pL2cah5isYuz5Eooo7AawLZx39Nb/Ems+HD11 /S5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tq0lv6gvluRlMDeVyibmzd7tiMAvpGwX0IvIgdqcbIg=; b=poF4qQZoDKpi1Sq4bTy5/l5DF6iwoBBR0BnzeDsIl8ky/mp+M5NnWyh6XDf0saDPSV c7QmwAax9IJmdeX3S6dKCTe2kKI+7syKBm/vX++fu0WWEO/S3YX300DlJkP8SBf1DA8p 4wj3/RJ3hllU4y9ZDQeFo/DB+8DI3x5nmfyN0QiATY+pVSMzvHGbqbudr+SosjnGsN9c 9fDCJutmCg3u5YToitvjxaecRBLHEGme/WzEhrB19OG56RJr96NpFwUia1RiIIkB/Auw tEC3V91npOx/JeTMblGsT1k3Og+F533IXFmdPfgujMPapZzc4LreZgqZOMrC5MH6HXPJ +jlA== X-Gm-Message-State: AFqh2krF5wPVfyxEQP/maIgBKMyni8NSgKpKcAiBbWcjdSjpeEmjuLV9 pihJTnepc1MyOpHU0ivQpss4IQ== X-Google-Smtp-Source: AMrXdXs+5GBRCwj95X1guI3fQiKlxwAft2r/MLZ+AjzpBhkal5qB21zCwsLSPEPnxLwkIbKSgHqnoA== X-Received: by 2002:a05:6402:ea0:b0:46f:68d0:76 with SMTP id h32-20020a0564020ea000b0046f68d00076mr4610773eda.34.1671722531325; Thu, 22 Dec 2022 07:22:11 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:11 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Davide Zini , Paolo Valente Subject: [PATCH V12 7/8] block, bfq: inject I/O to underutilized actuators Date: Thu, 22 Dec 2022 16:21:56 +0100 Message-Id: <20221222152157.61789-8-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Davide Zini The main service scheme of BFQ for sync I/O is serving one sync bfq_queue at a time, for a while. In particular, BFQ enforces this scheme when it deems the latter necessary to boost throughput or to preserve service guarantees. Unfortunately, when BFQ enforces this policy, only one actuator at a time gets served for a while, because each bfq_queue contains I/O only for one actuator. The other actuators may remain underutilized. Actually, BFQ may serve (inject) extra I/O, taken from other bfq_queues, in parallel with that of the in-service queue. This injection mechanism may provide the ground for dealing also with the above actuator-underutilization problem. Yet BFQ does not take the actuator load into account when choosing which queue to pick extra I/O from. In addition, BFQ may happen to inject extra I/O only when the in-service queue is temporarily empty. In view of these facts, this commit extends the injection mechanism in such a way that the latter: (1) takes into account also the actuator load; (2) checks such a load on each dispatch, and injects I/O for an underutilized actuator, if there is one and there is I/O for it. To perform the check in (2), this commit introduces a load threshold, currently set to 4. A linear scan of each actuator is performed, until an actuator is found for which the following two conditions hold: the load of the actuator is below the threshold, and there is at least one non-in-service queue that contains I/O for that actuator. If such a pair (actuator, queue) is found, then the head request of that queue is returned for dispatch, instead of the head request of the in-service queue. We have set the threshold, empirically, to the minimum possible value for which an actuator is fully utilized, or close to be fully utilized. By doing so, injected I/O 'steals' as few drive-queue slots as possibile to the in-service queue. This reduces as much as possible the probability that the service of I/O from the in-service bfq_queue gets delayed because of slot exhaustion, i.e., because all the slots of the drive queue are filled with I/O injected from other queues (NCQ provides for 32 slots). This new mechanism also counters actuator underutilization in the case of asymmetric configurations of bfq_queues. Namely if there are few bfq_queues containing I/O for some actuators and many bfq_queues containing I/O for other actuators. Or if the bfq_queues containing I/O for some actuators have lower weights than the other bfq_queues. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente Signed-off-by: Davide Zini --- block/bfq-cgroup.c | 2 +- block/bfq-iosched.c | 136 ++++++++++++++++++++++++++++++++------------ block/bfq-iosched.h | 39 ++++++++++++- block/bfq-wf2q.c | 2 +- 4 files changed, 139 insertions(+), 40 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index bd7bf0f8121d..a6e8da5f5cfd 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgroup.c @@ -708,7 +708,7 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_qu= eue *bfqq, bfq_activate_bfqq(bfqd, bfqq); } =20 - if (!bfqd->in_service_queue && !bfqd->rq_in_driver) + if (!bfqd->in_service_queue && !bfqd->tot_rq_in_driver) bfq_schedule_dispatch(bfqd); /* release extra ref taken above, bfqq may happen to be freed now */ bfq_put_queue(bfqq); diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 1db7fb18f99e..132c5874eefc 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -2263,9 +2263,9 @@ static void bfq_add_request(struct request *rq) * elapsed. */ if (bfqq =3D=3D bfqd->in_service_queue && - (bfqd->rq_in_driver =3D=3D 0 || + (bfqd->tot_rq_in_driver =3D=3D 0 || (bfqq->last_serv_time_ns > 0 && - bfqd->rqs_injected && bfqd->rq_in_driver > 0)) && + bfqd->rqs_injected && bfqd->tot_rq_in_driver > 0)) && time_is_before_eq_jiffies(bfqq->decrease_time_jif + msecs_to_jiffies(10))) { bfqd->last_empty_occupied_ns =3D ktime_get_ns(); @@ -2289,7 +2289,7 @@ static void bfq_add_request(struct request *rq) * will be set in case injection is performed * on bfqq before rq is completed). */ - if (bfqd->rq_in_driver =3D=3D 0) + if (bfqd->tot_rq_in_driver =3D=3D 0) bfqd->rqs_injected =3D false; } } @@ -2654,11 +2654,14 @@ void bfq_end_wr_async_queues(struct bfq_data *bfqd, static void bfq_end_wr(struct bfq_data *bfqd) { struct bfq_queue *bfqq; + int i; =20 spin_lock_irq(&bfqd->lock); =20 - list_for_each_entry(bfqq, &bfqd->active_list, bfqq_list) - bfq_bfqq_end_wr(bfqq); + for (i =3D 0; i < bfqd->num_actuators; i++) { + list_for_each_entry(bfqq, &bfqd->active_list[i], bfqq_list) + bfq_bfqq_end_wr(bfqq); + } list_for_each_entry(bfqq, &bfqd->idle_list, bfqq_list) bfq_bfqq_end_wr(bfqq); bfq_end_wr_async(bfqd); @@ -3615,13 +3618,13 @@ static void bfq_update_peak_rate(struct bfq_data *b= fqd, struct request *rq) * - start a new observation interval with this dispatch */ if (now_ns - bfqd->last_dispatch > 100*NSEC_PER_MSEC && - bfqd->rq_in_driver =3D=3D 0) + bfqd->tot_rq_in_driver =3D=3D 0) goto update_rate_and_reset; =20 /* Update sampling information */ bfqd->peak_rate_samples++; =20 - if ((bfqd->rq_in_driver > 0 || + if ((bfqd->tot_rq_in_driver > 0 || now_ns - bfqd->last_completion < BFQ_MIN_TT) && !BFQ_RQ_SEEKY(bfqd, bfqd->last_position, rq)) bfqd->sequential_samples++; @@ -3886,10 +3889,8 @@ static bool idling_needed_for_service_guarantees(str= uct bfq_data *bfqd, return false; =20 return (bfqq->wr_coeff > 1 && - (bfqd->wr_busy_queues < - tot_busy_queues || - bfqd->rq_in_driver >=3D - bfqq->dispatched + 4)) || + (bfqd->wr_busy_queues < tot_busy_queues || + bfqd->tot_rq_in_driver >=3D bfqq->dispatched + 4)) || bfq_asymmetric_scenario(bfqd, bfqq) || tot_busy_queues =3D=3D 1; } @@ -4660,6 +4661,8 @@ bfq_choose_bfqq_for_injection(struct bfq_data *bfqd) { struct bfq_queue *bfqq, *in_serv_bfqq =3D bfqd->in_service_queue; unsigned int limit =3D in_serv_bfqq->inject_limit; + int i; + /* * If * - bfqq is not weight-raised and therefore does not carry @@ -4691,7 +4694,7 @@ bfq_choose_bfqq_for_injection(struct bfq_data *bfqd) ) limit =3D 1; =20 - if (bfqd->rq_in_driver >=3D limit) + if (bfqd->tot_rq_in_driver >=3D limit) return NULL; =20 /* @@ -4706,11 +4709,12 @@ bfq_choose_bfqq_for_injection(struct bfq_data *bfqd) * (and re-added only if it gets new requests, but then it * is assigned again enough budget for its new backlog). */ - list_for_each_entry(bfqq, &bfqd->active_list, bfqq_list) - if (!RB_EMPTY_ROOT(&bfqq->sort_list) && - (in_serv_always_inject || bfqq->wr_coeff > 1) && - bfq_serv_to_charge(bfqq->next_rq, bfqq) <=3D - bfq_bfqq_budget_left(bfqq)) { + for (i =3D 0; i < bfqd->num_actuators; i++) { + list_for_each_entry(bfqq, &bfqd->active_list[i], bfqq_list) + if (!RB_EMPTY_ROOT(&bfqq->sort_list) && + (in_serv_always_inject || bfqq->wr_coeff > 1) && + bfq_serv_to_charge(bfqq->next_rq, bfqq) <=3D + bfq_bfqq_budget_left(bfqq)) { /* * Allow for only one large in-flight request * on non-rotational devices, for the @@ -4735,22 +4739,69 @@ bfq_choose_bfqq_for_injection(struct bfq_data *bfqd) else limit =3D in_serv_bfqq->inject_limit; =20 - if (bfqd->rq_in_driver < limit) { + if (bfqd->tot_rq_in_driver < limit) { bfqd->rqs_injected =3D true; return bfqq; } } + } + + return NULL; +} + +static struct bfq_queue * +bfq_find_active_bfqq_for_actuator(struct bfq_data *bfqd, int idx) +{ + struct bfq_queue *bfqq; + + if (bfqd->in_service_queue && + bfqd->in_service_queue->actuator_idx =3D=3D idx) + return bfqd->in_service_queue; + + list_for_each_entry(bfqq, &bfqd->active_list[idx], bfqq_list) { + if (!RB_EMPTY_ROOT(&bfqq->sort_list) && + bfq_serv_to_charge(bfqq->next_rq, bfqq) <=3D + bfq_bfqq_budget_left(bfqq)) { + return bfqq; + } + } =20 return NULL; } =20 +/* + * Perform a linear scan of each actuator, until an actuator is found + * for which the following two conditions hold: the load of the + * actuator is below the threshold (see comments on actuator_load_threshold + * for details), and there is a queue that contains I/O for that + * actuator. On success, return that queue. + */ +static struct bfq_queue * +bfq_find_bfqq_for_underused_actuator(struct bfq_data *bfqd) +{ + int i; + + for (i =3D 0 ; i < bfqd->num_actuators; i++) { + if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold) { + struct bfq_queue *bfqq =3D + bfq_find_active_bfqq_for_actuator(bfqd, i); + + if (bfqq) + return bfqq; + } + } + + return NULL; +} + + /* * Select a queue for service. If we have a current queue in service, * check whether to continue servicing it, or retrieve and set a new one. */ static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd) { - struct bfq_queue *bfqq; + struct bfq_queue *bfqq, *inject_bfqq; struct request *next_rq; enum bfqq_expiration reason =3D BFQQE_BUDGET_TIMEOUT; =20 @@ -4772,6 +4823,15 @@ static struct bfq_queue *bfq_select_queue(struct bfq= _data *bfqd) goto expire; =20 check_queue: + /* + * If some actuator is underutilized, but the in-service + * queue does not contain I/O for that actuator, then try to + * inject I/O for that actuator. + */ + inject_bfqq =3D bfq_find_bfqq_for_underused_actuator(bfqd); + if (inject_bfqq && inject_bfqq !=3D bfqq) + return inject_bfqq; + /* * This loop is rarely executed more than once. Even when it * happens, it is much more convenient to re-execute this loop @@ -5127,11 +5187,11 @@ static struct request *__bfq_dispatch_request(struc= t blk_mq_hw_ctx *hctx) =20 /* * We exploit the bfq_finish_requeue_request hook to - * decrement rq_in_driver, but + * decrement tot_rq_in_driver, but * bfq_finish_requeue_request will not be invoked on * this request. So, to avoid unbalance, just start - * this request, without incrementing rq_in_driver. As - * a negative consequence, rq_in_driver is deceptively + * this request, without incrementing tot_rq_in_driver. As + * a negative consequence, tot_rq_in_driver is deceptively * lower than it should be while this request is in * service. This may cause bfq_schedule_dispatch to be * invoked uselessly. @@ -5140,7 +5200,7 @@ static struct request *__bfq_dispatch_request(struct = blk_mq_hw_ctx *hctx) * bfq_finish_requeue_request hook, if defined, is * probably invoked also on this request. So, by * exploiting this hook, we could 1) increment - * rq_in_driver here, and 2) decrement it in + * tot_rq_in_driver here, and 2) decrement it in * bfq_finish_requeue_request. Such a solution would * let the value of the counter be always accurate, * but it would entail using an extra interface @@ -5169,7 +5229,7 @@ static struct request *__bfq_dispatch_request(struct = blk_mq_hw_ctx *hctx) * Of course, serving one request at a time may cause loss of * throughput. */ - if (bfqd->strict_guarantees && bfqd->rq_in_driver > 0) + if (bfqd->strict_guarantees && bfqd->tot_rq_in_driver > 0) goto exit; =20 bfqq =3D bfq_select_queue(bfqd); @@ -5180,7 +5240,8 @@ static struct request *__bfq_dispatch_request(struct = blk_mq_hw_ctx *hctx) =20 if (rq) { inc_in_driver_start_rq: - bfqd->rq_in_driver++; + bfqd->rq_in_driver[bfqq->actuator_idx]++; + bfqd->tot_rq_in_driver++; start_rq: rq->rq_flags |=3D RQF_STARTED; } @@ -6247,7 +6308,7 @@ static void bfq_update_hw_tag(struct bfq_data *bfqd) struct bfq_queue *bfqq =3D bfqd->in_service_queue; =20 bfqd->max_rq_in_driver =3D max_t(int, bfqd->max_rq_in_driver, - bfqd->rq_in_driver); + bfqd->tot_rq_in_driver); =20 if (bfqd->hw_tag =3D=3D 1) return; @@ -6258,7 +6319,7 @@ static void bfq_update_hw_tag(struct bfq_data *bfqd) * sum is not exact, as it's not taking into account deactivated * requests. */ - if (bfqd->rq_in_driver + bfqd->queued <=3D BFQ_HW_QUEUE_THRESHOLD) + if (bfqd->tot_rq_in_driver + bfqd->queued <=3D BFQ_HW_QUEUE_THRESHOLD) return; =20 /* @@ -6269,7 +6330,7 @@ static void bfq_update_hw_tag(struct bfq_data *bfqd) if (bfqq && bfq_bfqq_has_short_ttime(bfqq) && bfqq->dispatched + bfqq->queued[0] + bfqq->queued[1] < BFQ_HW_QUEUE_THRESHOLD && - bfqd->rq_in_driver < BFQ_HW_QUEUE_THRESHOLD) + bfqd->tot_rq_in_driver < BFQ_HW_QUEUE_THRESHOLD) return; =20 if (bfqd->hw_tag_samples++ < BFQ_HW_QUEUE_SAMPLES) @@ -6290,7 +6351,8 @@ static void bfq_completed_request(struct bfq_queue *b= fqq, struct bfq_data *bfqd) =20 bfq_update_hw_tag(bfqd); =20 - bfqd->rq_in_driver--; + bfqd->rq_in_driver[bfqq->actuator_idx]--; + bfqd->tot_rq_in_driver--; bfqq->dispatched--; =20 if (!bfqq->dispatched && !bfq_bfqq_busy(bfqq)) { @@ -6410,7 +6472,7 @@ static void bfq_completed_request(struct bfq_queue *b= fqq, struct bfq_data *bfqd) BFQQE_NO_MORE_REQUESTS); } =20 - if (!bfqd->rq_in_driver) + if (!bfqd->tot_rq_in_driver) bfq_schedule_dispatch(bfqd); } =20 @@ -6541,13 +6603,13 @@ static void bfq_update_inject_limit(struct bfq_data= *bfqd, * conditions to do it, or we can lower the last base value * computed. * - * NOTE: (bfqd->rq_in_driver =3D=3D 1) means that there is no I/O + * NOTE: (bfqd->tot_rq_in_driver =3D=3D 1) means that there is no I/O * request in flight, because this function is in the code * path that handles the completion of a request of bfqq, and, * in particular, this function is executed before - * bfqd->rq_in_driver is decremented in such a code path. + * bfqd->tot_rq_in_driver is decremented in such a code path. */ - if ((bfqq->last_serv_time_ns =3D=3D 0 && bfqd->rq_in_driver =3D=3D 1) || + if ((bfqq->last_serv_time_ns =3D=3D 0 && bfqd->tot_rq_in_driver =3D=3D 1)= || tot_time_ns < bfqq->last_serv_time_ns) { if (bfqq->last_serv_time_ns =3D=3D 0) { /* @@ -6557,7 +6619,7 @@ static void bfq_update_inject_limit(struct bfq_data *= bfqd, bfqq->inject_limit =3D max_t(unsigned int, 1, old_limit); } bfqq->last_serv_time_ns =3D tot_time_ns; - } else if (!bfqd->rqs_injected && bfqd->rq_in_driver =3D=3D 1) + } else if (!bfqd->rqs_injected && bfqd->tot_rq_in_driver =3D=3D 1) /* * No I/O injected and no request still in service in * the drive: these are the exact conditions for @@ -7212,7 +7274,8 @@ static int bfq_init_queue(struct request_queue *q, st= ruct elevator_type *e) bfqd->num_groups_with_pending_reqs =3D 0; #endif =20 - INIT_LIST_HEAD(&bfqd->active_list); + INIT_LIST_HEAD(&bfqd->active_list[0]); + INIT_LIST_HEAD(&bfqd->active_list[1]); INIT_LIST_HEAD(&bfqd->idle_list); INIT_HLIST_HEAD(&bfqd->burst_list); =20 @@ -7257,6 +7320,9 @@ static int bfq_init_queue(struct request_queue *q, st= ruct elevator_type *e) ref_wr_duration[blk_queue_nonrot(bfqd->queue)]; bfqd->peak_rate =3D ref_rate[blk_queue_nonrot(bfqd->queue)] * 2 / 3; =20 + /* see comments on the definition of next field inside bfq_data */ + bfqd->actuator_load_threshold =3D 4; + spin_lock_init(&bfqd->lock); =20 /* diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 830dda1f9322..058af701bbbe 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -590,7 +590,12 @@ struct bfq_data { /* number of queued requests */ int queued; /* number of requests dispatched and waiting for completion */ - int rq_in_driver; + int tot_rq_in_driver; + /* + * number of requests dispatched and waiting for completion + * for each actuator + */ + int rq_in_driver[BFQ_MAX_ACTUATORS]; =20 /* true if the device is non rotational and performs queueing */ bool nonrot_with_queueing; @@ -684,8 +689,13 @@ struct bfq_data { /* maximum budget allotted to a bfq_queue before rescheduling */ int bfq_max_budget; =20 - /* list of all the bfq_queues active on the device */ - struct list_head active_list; + /* + * List of all the bfq_queues active for a specific actuator + * on the device. Keeping active queues separate on a + * per-actuator basis helps implementing per-actuator + * injection more efficiently. + */ + struct list_head active_list[BFQ_MAX_ACTUATORS]; /* list of all the bfq_queues idle on the device */ struct list_head idle_list; =20 @@ -821,6 +831,29 @@ struct bfq_data { sector_t sector[BFQ_MAX_ACTUATORS]; sector_t nr_sectors[BFQ_MAX_ACTUATORS]; struct blk_independent_access_range ia_ranges[BFQ_MAX_ACTUATORS]; + + /* + * If the number of I/O requests queued in the device for a + * given actuator is below next threshold, then the actuator + * is deemed as underutilized. If this condition is found to + * hold for some actuator upon a dispatch, but (i) the + * in-service queue does not contain I/O for that actuator, + * while (ii) some other queue does contain I/O for that + * actuator, then the head I/O request of the latter queue is + * returned (injected), instead of the head request of the + * currently in-service queue. + * + * We set the threshold, empirically, to the minimum possible + * value for which an actuator is fully utilized, or close to + * be fully utilized. By doing so, injected I/O 'steals' as + * few drive-queue slots as possibile to the in-service + * queue. This reduces as much as possible the probability + * that the service of I/O from the in-service bfq_queue gets + * delayed because of slot exhaustion, i.e., because all the + * slots of the drive queue are filled with I/O injected from + * other queues (NCQ provides for 32 slots). + */ + unsigned int actuator_load_threshold; }; =20 enum bfqq_state_flags { diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c index ea4c3d757fdd..7941b6f07391 100644 --- a/block/bfq-wf2q.c +++ b/block/bfq-wf2q.c @@ -493,7 +493,7 @@ static void bfq_active_insert(struct bfq_service_tree *= st, bfq_update_active_tree(node); =20 if (bfqq) - list_add(&bfqq->bfqq_list, &bfqq->bfqd->active_list); + list_add(&bfqq->bfqq_list, &bfqq->bfqd->active_list[bfqq->actuator_idx]); =20 bfq_inc_active_entities(entity); } --=20 2.20.1 From nobody Wed Sep 17 06:42:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019CFC001B2 for ; Thu, 22 Dec 2022 15:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235425AbiLVPW7 (ORCPT ); Thu, 22 Dec 2022 10:22:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235579AbiLVPWS (ORCPT ); Thu, 22 Dec 2022 10:22:18 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC5F2B27E for ; Thu, 22 Dec 2022 07:22:13 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id x22so5628498ejs.11 for ; Thu, 22 Dec 2022 07:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9prY/JmhXfW74Kc/vxfSBhm8Ub6K/Is1u+4OJkmvt/8=; b=hn93Pgz0XGh9MuNVPN+nzpVDPXpHL5yvrKu+5qfdESeOWYAgFtg2OyzNkpMs94WgiC WMcuI8NUgowcSYw8age6bQ0bWNXmSyGTV+eZ6HiVpQL+pml4aNDIHk2YaF2BF5F1iOy7 Fu7u19coZWI858vbn7ivpXUZJ3RJ5+GxBBmGH9rdQySqE7HjqDAellNQA23zT0HBwS0V zBgTSwHwe8Ze2//HnKD0YdvLE8jdG6zz/xaG4sMRMe2QC6k0QMvGwdOWVowZK+/HLZFf v3HBQ7xGpNNxiOlTWsLbFkN78Cjm6XzForEUYxd8jFmRxWLTrqoafNBLhFqQ7Fkqb64j L2tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9prY/JmhXfW74Kc/vxfSBhm8Ub6K/Is1u+4OJkmvt/8=; b=VnvfrkG8jlsRlBphoKMnTM8rBZBFChbp0u3jNi4QD+iCSfJNVz51vpsYO4HF+TT90Q u2L4DuM9ATWhYDYZS6DRm+VrIfRoUH4eYu7QrSUvew6SLoLfKnU6OWb+2ajItyMo/7Ax GyPOD7KzDSbvc5Duw4kCrIQwOJehHy6bQZKjjsku3zMGzltVlshAIwjymD4HkJmkAW5P Ydt5rwb7oDFkIguNqlkHBMopRzQdYZUMDtWV7JM7G0rM0D3RddFrmNLhNCwF1un1rLes vJJVduTB+838A72m5GGXIkOrJA3iE78B7X4BXDGMN/GAPrVvskPzDxMTeSRj3Te/xtz+ VAIw== X-Gm-Message-State: AFqh2kqHtoOGxeyGqQGALpMWJRnFDzruRMhmGGrMrVCU9kPpKExUu6Dn jq8AtP/7VH6mqam9pJFWGy+SYg== X-Google-Smtp-Source: AMrXdXtiCefgdm83WdC0rb7pqHzl4oPGMfPQ11wwOpD/6NtJMaG4smOj62xiA0Bxqekt7g5Zpu9J1Q== X-Received: by 2002:a17:906:8384:b0:838:9aba:6a06 with SMTP id p4-20020a170906838400b008389aba6a06mr4955351ejx.39.1671722532278; Thu, 22 Dec 2022 07:22:12 -0800 (PST) Received: from MBP-di-Paolo.station (net-93-70-85-0.cust.vodafonedsl.it. [93.70.85.0]) by smtp.gmail.com with ESMTPSA id 17-20020a170906201100b007c08439161dsm355670ejo.50.2022.12.22.07.22.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 07:22:11 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Davide Zini , Paolo Valente Subject: [PATCH V12 8/8] block, bfq: balance I/O injection among underutilized actuators Date: Thu, 22 Dec 2022 16:21:57 +0100 Message-Id: <20221222152157.61789-9-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221222152157.61789-1-paolo.valente@linaro.org> References: <20221222152157.61789-1-paolo.valente@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Davide Zini Upon the invocation of its dispatch function, BFQ returns the next I/O request of the in-service bfq_queue, unless some exception holds. One such exception is that there is some underutilized actuator, different from the actuator for which the in-service queue contains I/O, and that some other bfq_queue happens to contain I/O for such an actuator. In this case, the next I/O request of the latter bfq_queue, and not of the in-service bfq_queue, is returned (I/O is injected from that bfq_queue). To find such an actuator, a linear scan, in increasing index order, is performed among actuators. Performing a linear scan entails a prioritization among actuators: an underutilized actuator may be considered for injection only if all actuators with a lower index are currently fully utilized, or if there is no pending I/O for any lower-index actuator that happens to be underutilized. This commits breaks this prioritization and tends to distribute injection uniformly across actuators. This is obtained by adding the following condition to the linear scan: even if an actuator A is underutilized, A is however skipped if its load is higher than that of the next actuator. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente Signed-off-by: Davide Zini --- block/bfq-iosched.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 132c5874eefc..f69dfa659e34 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4771,10 +4771,16 @@ bfq_find_active_bfqq_for_actuator(struct bfq_data *= bfqd, int idx) =20 /* * Perform a linear scan of each actuator, until an actuator is found - * for which the following two conditions hold: the load of the - * actuator is below the threshold (see comments on actuator_load_threshold - * for details), and there is a queue that contains I/O for that - * actuator. On success, return that queue. + * for which the following three conditions hold: the load of the + * actuator is below the threshold (see comments on + * actuator_load_threshold for details) and lower than that of the + * next actuator (comments on this extra condition below), and there + * is a queue that contains I/O for that actuator. On success, return + * that queue. + * + * Performing a plain linear scan entails a prioritization among + * actuators. The extra condition above breaks this prioritization and + * tends to distribute injection uniformly across actuators. */ static struct bfq_queue * bfq_find_bfqq_for_underused_actuator(struct bfq_data *bfqd) @@ -4782,7 +4788,9 @@ bfq_find_bfqq_for_underused_actuator(struct bfq_data = *bfqd) int i; =20 for (i =3D 0 ; i < bfqd->num_actuators; i++) { - if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold) { + if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold && + (i =3D=3D bfqd->num_actuators - 1 || + bfqd->rq_in_driver[i] < bfqd->rq_in_driver[i+1])) { struct bfq_queue *bfqq =3D bfq_find_active_bfqq_for_actuator(bfqd, i); =20 --=20 2.20.1