From nobody Wed Sep 17 10:56:23 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2664CC4332F for ; Wed, 21 Dec 2022 22:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235210AbiLUWgY (ORCPT ); Wed, 21 Dec 2022 17:36:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbiLUWfm (ORCPT ); Wed, 21 Dec 2022 17:35:42 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CB42791A for ; Wed, 21 Dec 2022 14:35:24 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id x188-20020a2531c5000000b00716de19d76bso19080190ybx.19 for ; Wed, 21 Dec 2022 14:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=rRvS/qEVKLhlR8j01uyrpua52IG8ilBz9DVBSxxT9oI=; b=fieL8Kx0iyCLiE2RGXHVoU5rc/29o/vtcjAjGAQuxsLVNa4tBttWUrXDqsAurV5Q6o sjd8FQoGSuITZ3jtJineiMD3A5STI3qSWO3VNtM8OUpdcdd4ZsmpGSCapoeTleR0uqlT 9UwmtVJpjiG+tHwPfP72H3h0d7Fwtb331UBqxztxnenb9C5w5Te4RkjOwTV3U5HmcuMh IR41S9ctzkFuW7sjgDY6GYbSlvtQpySUqtQqSI9Vrr0vOxscBqHUyA8ilZchkqa+tUnu vD9RGAlhi7Zmby3OuY4r2zsVa5FswqnYHxiIkYLLocj/fMqBBnolCj8WIkRuknxyQ9IK nHnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rRvS/qEVKLhlR8j01uyrpua52IG8ilBz9DVBSxxT9oI=; b=ZXlcBzBqhorA8vBS4PLFwltl9XOs935H5SxbOxTQitJt40AVThcwlUthVLDmCRgeJB CC3lU3aK5ofH45KaSuOIN0ZbWblslXdTnt0Htfrt/apjp5uf3q+UxFnVP768i9jOnQkJ iYwV6utEfY/K07/aK24cbIXganw9wFKfbF+Qqn9aJlrwILywITY2txKHqibQMkYqBqH8 fofSDN0O7jgjX9f/K0f03JUQa5BIZ+DZbpihF8MWRYUyqAe1TO7qDU9OhVplq2kHSSEK iOuBNW4cVm3lpy3hGjXqPzf2fyHXPScUpUNh8OnD1L92hsC64Gwt0dqC/ZtHge3wiMht widg== X-Gm-Message-State: AFqh2kp4/gB4QdQCzzFLaZndT11AM84XgUxkxAbjUfMZsY05jJOvnw0g MNgmvX3RXvRr2KFjA/i4838/TQsXi3US X-Google-Smtp-Source: AMrXdXuqqCV9iRu4mi7Iat5os1z1E1nNjJ8R0kdkr8hFe+ERSONYSlDXgDY34TJ8VjfDvAzaQs+YWBN+ClXv X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:62bd:f120:1fd8:1d21]) (user=irogers job=sendgmr) by 2002:a05:6902:4e1:b0:6ee:d8b:747e with SMTP id w1-20020a05690204e100b006ee0d8b747emr307952ybs.523.1671662124196; Wed, 21 Dec 2022 14:35:24 -0800 (PST) Date: Wed, 21 Dec 2022 14:34:18 -0800 In-Reply-To: <20221221223420.2157113-1-irogers@google.com> Message-Id: <20221221223420.2157113-8-irogers@google.com> Mime-Version: 1.0 References: <20221221223420.2157113-1-irogers@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Subject: [PATCH v2 7/9] perf pmu-events: Introduce pmu_metrics_table From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain Cc: Stephane Eranian , Perry Taylor , Caleb Biggers , Ian Rogers Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a metrics table that is just a cast from pmu_events_table. This changes the APIs so that event and metric usage of the underlying table is different. Later changes will separate the tables. This introduction fixes a NO_JEVENTS=3D1 regression on: 68: Parse and process metrics : Ok 70: Event expansion for cgroups : Ok caused by the necessary test metrics not being found. Signed-off-by: Ian Rogers --- tools/perf/arch/arm64/util/pmu.c | 23 ++++++++++- tools/perf/pmu-events/empty-pmu-events.c | 52 ++++++++++++++++++++---- tools/perf/pmu-events/jevents.py | 24 ++++++++--- tools/perf/pmu-events/pmu-events.h | 10 +++-- tools/perf/tests/expand-cgroup.c | 4 +- tools/perf/tests/parse-metric.c | 4 +- tools/perf/tests/pmu-events.c | 5 ++- tools/perf/util/metricgroup.c | 50 +++++++++++------------ tools/perf/util/metricgroup.h | 2 +- tools/perf/util/pmu.c | 9 +++- tools/perf/util/pmu.h | 1 + 11 files changed, 133 insertions(+), 51 deletions(-) diff --git a/tools/perf/arch/arm64/util/pmu.c b/tools/perf/arch/arm64/util/= pmu.c index 477e513972a4..f8ae479a06db 100644 --- a/tools/perf/arch/arm64/util/pmu.c +++ b/tools/perf/arch/arm64/util/pmu.c @@ -19,7 +19,28 @@ const struct pmu_events_table *pmu_events_table__find(vo= id) if (pmu->cpus->nr !=3D cpu__max_cpu().cpu) return NULL; =20 - return perf_pmu__find_table(pmu); + return perf_pmu__find_events_table(pmu); + } + + return NULL; +} + +const struct pmu_metrics_table *pmu_metrics_table__find(void) +{ + struct perf_pmu *pmu =3D NULL; + + while ((pmu =3D perf_pmu__scan(pmu))) { + if (!is_pmu_core(pmu->name)) + continue; + + /* + * The cpumap should cover all CPUs. Otherwise, some CPUs may + * not support some events or have different event IDs. + */ + if (pmu->cpus->nr !=3D cpu__max_cpu().cpu) + return NULL; + + return perf_pmu__find_metrics_table(pmu); } =20 return NULL; diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-even= ts/empty-pmu-events.c index 5572a4d1eddb..d50f60a571dd 100644 --- a/tools/perf/pmu-events/empty-pmu-events.c +++ b/tools/perf/pmu-events/empty-pmu-events.c @@ -278,14 +278,12 @@ int pmu_events_table_for_each_event(const struct pmu_= events_table *table, pmu_ev return 0; } =20 -int pmu_events_table_for_each_metric(const struct pmu_events_table *etable= , pmu_metric_iter_fn fn, - void *data) +int pmu_metrics_table_for_each_metric(const struct pmu_metrics_table *tabl= e, pmu_metric_iter_fn fn, + void *data) { - struct pmu_metrics_table *table =3D (struct pmu_metrics_table *)etable; - for (const struct pmu_metric *pm =3D &table->entries[0]; pm->metric_group= || pm->metric_name; pm++) { - int ret =3D fn(pm, etable, data); + int ret =3D fn(pm, table, data); =20 if (ret) return ret; @@ -293,7 +291,7 @@ int pmu_events_table_for_each_metric(const struct pmu_e= vents_table *etable, pmu_ return 0; } =20 -const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu) +const struct pmu_events_table *perf_pmu__find_events_table(struct perf_pmu= *pmu) { const struct pmu_events_table *table =3D NULL; char *cpuid =3D perf_pmu__getcpuid(pmu); @@ -321,6 +319,34 @@ const struct pmu_events_table *perf_pmu__find_table(st= ruct perf_pmu *pmu) return table; } =20 +const struct pmu_metrics_table *perf_pmu__find_metrics_table(struct perf_p= mu *pmu) +{ + const struct pmu_metrics_table *table =3D NULL; + char *cpuid =3D perf_pmu__getcpuid(pmu); + int i; + + /* on some platforms which uses cpus map, cpuid can be NULL for + * PMUs other than CORE PMUs. + */ + if (!cpuid) + return NULL; + + i =3D 0; + for (;;) { + const struct pmu_events_map *map =3D &pmu_events_map[i++]; + + if (!map->cpuid) + break; + + if (!strcmp_cpuid_str(map->cpuid, cpuid)) { + table =3D &map->metric_table; + break; + } + } + free(cpuid); + return table; +} + const struct pmu_events_table *find_core_events_table(const char *arch, co= nst char *cpuid) { for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; @@ -332,6 +358,17 @@ const struct pmu_events_table *find_core_events_table(= const char *arch, const ch return NULL; } =20 +const struct pmu_metrics_table *find_core_metrics_table(const char *arch, = const char *cpuid) +{ + for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; + tables->arch; + tables++) { + if (!strcmp(tables->arch, arch) && !strcmp_cpuid_str(tables->cpuid, cpui= d)) + return &tables->metric_table; + } + return NULL; +} + int pmu_for_each_core_event(pmu_event_iter_fn fn, void *data) { for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; @@ -350,8 +387,7 @@ int pmu_for_each_core_metric(pmu_metric_iter_fn fn, voi= d *data) for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; tables->arch; tables++) { - int ret =3D pmu_events_table_for_each_metric( - (const struct pmu_events_table *)&tables->metric_table, fn, data); + int ret =3D pmu_metrics_table_for_each_metric(&tables->metric_table, fn,= data); =20 if (ret) return ret; diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jeven= ts.py index 7b9714b25d0a..be2cf8a8779c 100755 --- a/tools/perf/pmu-events/jevents.py +++ b/tools/perf/pmu-events/jevents.py @@ -609,17 +609,19 @@ int pmu_events_table_for_each_event(const struct pmu_= events_table *table, return 0; } =20 -int pmu_events_table_for_each_metric(const struct pmu_events_table *table, +int pmu_metrics_table_for_each_metric(const struct pmu_metrics_table *mtab= le, pmu_metric_iter_fn fn, void *data) { + struct pmu_events_table *table =3D (struct pmu_events_table *)mtab= le; + for (size_t i =3D 0; i < table->length; i++) { struct pmu_metric pm; int ret; =20 decompress_metric(table->entries[i].offset, &pm); if (pm.metric_name) { - ret =3D fn(&pm, table, data); + ret =3D fn(&pm, mtable, data); if (ret) return ret; } @@ -627,7 +629,7 @@ int pmu_events_table_for_each_metric(const struct pmu_e= vents_table *table, return 0; } =20 -const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu) +const struct pmu_events_table *perf_pmu__find_events_table(struct perf_pmu= *pmu) { const struct pmu_events_table *table =3D NULL; char *cpuid =3D perf_pmu__getcpuid(pmu); @@ -654,6 +656,11 @@ const struct pmu_events_table *perf_pmu__find_table(st= ruct perf_pmu *pmu) return table; } =20 +const struct pmu_metrics_table *perf_pmu__find_metrics_table(struct perf_p= mu *pmu) +{ + return (struct pmu_metrics_table *)perf_pmu__find_events_table(pmu= ); +} + const struct pmu_events_table *find_core_events_table(const char *arch, co= nst char *cpuid) { for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; @@ -665,6 +672,11 @@ const struct pmu_events_table *find_core_events_table(= const char *arch, const ch return NULL; } =20 +const struct pmu_metrics_table *find_core_metrics_table(const char *arch, = const char *cpuid) +{ + return (struct pmu_metrics_table *)find_core_events_table(arch, cpu= id); +} + int pmu_for_each_core_event(pmu_event_iter_fn fn, void *data) { for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; @@ -683,7 +695,8 @@ int pmu_for_each_core_metric(pmu_metric_iter_fn fn, voi= d *data) for (const struct pmu_events_map *tables =3D &pmu_events_map[0]; tables->arch; tables++) { - int ret =3D pmu_events_table_for_each_metric(&tables->tabl= e, fn, data); + int ret =3D pmu_metrics_table_for_each_metric( + (struct pmu_metrics_table *)&tables->table= , fn, data); =20 if (ret) return ret; @@ -720,7 +733,8 @@ int pmu_for_each_sys_metric(pmu_metric_iter_fn fn, void= *data) for (const struct pmu_sys_events *tables =3D &pmu_sys_event_tables= [0]; tables->name; tables++) { - int ret =3D pmu_events_table_for_each_metric(&tables->tabl= e, fn, data); + int ret =3D pmu_metrics_table_for_each_metric( + (struct pmu_metrics_table *)&tables->table= , fn, data); =20 if (ret) return ret; diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu= -events.h index e137f3857c03..b7d4a66b8ad2 100644 --- a/tools/perf/pmu-events/pmu-events.h +++ b/tools/perf/pmu-events/pmu-events.h @@ -39,26 +39,30 @@ struct pmu_metric { }; =20 struct pmu_events_table; +struct pmu_metrics_table; =20 typedef int (*pmu_event_iter_fn)(const struct pmu_event *pe, const struct pmu_events_table *table, void *data); =20 typedef int (*pmu_metric_iter_fn)(const struct pmu_metric *pm, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, void *data); =20 int pmu_events_table_for_each_event(const struct pmu_events_table *table, = pmu_event_iter_fn fn, void *data); -int pmu_events_table_for_each_metric(const struct pmu_events_table *table,= pmu_metric_iter_fn fn, +int pmu_metrics_table_for_each_metric(const struct pmu_metrics_table *tabl= e, pmu_metric_iter_fn fn, void *data); =20 -const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu); +const struct pmu_events_table *perf_pmu__find_events_table(struct perf_pmu= *pmu); +const struct pmu_metrics_table *perf_pmu__find_metrics_table(struct perf_p= mu *pmu); const struct pmu_events_table *find_core_events_table(const char *arch, co= nst char *cpuid); +const struct pmu_metrics_table *find_core_metrics_table(const char *arch, = const char *cpuid); int pmu_for_each_core_event(pmu_event_iter_fn fn, void *data); int pmu_for_each_core_metric(pmu_metric_iter_fn fn, void *data); =20 const struct pmu_events_table *find_sys_events_table(const char *name); +const struct pmu_metrics_table *find_sys_metrics_table(const char *name); int pmu_for_each_sys_event(pmu_event_iter_fn fn, void *data); int pmu_for_each_sys_metric(pmu_metric_iter_fn fn, void *data); =20 diff --git a/tools/perf/tests/expand-cgroup.c b/tools/perf/tests/expand-cgr= oup.c index 51fb5f34c1dd..672a27f37060 100644 --- a/tools/perf/tests/expand-cgroup.c +++ b/tools/perf/tests/expand-cgroup.c @@ -180,13 +180,13 @@ static int expand_metric_events(void) struct evlist *evlist; struct rblist metric_events; const char metric_str[] =3D "CPI"; - const struct pmu_events_table *pme_test; + const struct pmu_metrics_table *pme_test; =20 evlist =3D evlist__new(); TEST_ASSERT_VAL("failed to get evlist", evlist); =20 rblist__init(&metric_events); - pme_test =3D find_core_events_table("testarch", "testcpu"); + pme_test =3D find_core_metrics_table("testarch", "testcpu"); ret =3D metricgroup__parse_groups_test(evlist, pme_test, metric_str, false, false, &metric_events); if (ret < 0) { diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metri= c.c index 21b7ac00d798..9fec6040950c 100644 --- a/tools/perf/tests/parse-metric.c +++ b/tools/perf/tests/parse-metric.c @@ -72,7 +72,7 @@ static int __compute_metric(const char *name, struct valu= e *vals, struct rblist metric_events =3D { .nr_entries =3D 0, }; - const struct pmu_events_table *pme_test; + const struct pmu_metrics_table *pme_test; struct perf_cpu_map *cpus; struct runtime_stat st; struct evlist *evlist; @@ -96,7 +96,7 @@ static int __compute_metric(const char *name, struct valu= e *vals, runtime_stat__init(&st); =20 /* Parse the metric into metric_events list. */ - pme_test =3D find_core_events_table("testarch", "testcpu"); + pme_test =3D find_core_metrics_table("testarch", "testcpu"); err =3D metricgroup__parse_groups_test(evlist, pme_test, name, false, false, &metric_events); diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c index c2b3ada57cbc..9f2e385e0991 100644 --- a/tools/perf/tests/pmu-events.c +++ b/tools/perf/tests/pmu-events.c @@ -813,7 +813,8 @@ struct metric { struct metric_ref metric_ref; }; =20 -static int test__parsing_callback(const struct pmu_metric *pm, const struc= t pmu_events_table *table, +static int test__parsing_callback(const struct pmu_metric *pm, + const struct pmu_metrics_table *table, void *data) { int *failures =3D data; @@ -995,7 +996,7 @@ static int metric_parse_fake(const char *metric_name, c= onst char *str) } =20 static int test__parsing_fake_callback(const struct pmu_metric *pm, - const struct pmu_events_table *table __maybe_unused, + const struct pmu_metrics_table *table __maybe_unused, void *data __maybe_unused) { return metric_parse_fake(pm->metric_name, pm->metric_expr); diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index 47fd02af66f1..46314ad571e4 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -457,7 +457,7 @@ struct metricgroup_iter_data { }; =20 static int metricgroup__sys_event_iter(const struct pmu_metric *pm, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, void *data) { struct metricgroup_iter_data *d =3D data; @@ -477,7 +477,7 @@ static int metricgroup__sys_event_iter(const struct pmu= _metric *pm, } =20 static int metricgroup__add_to_mep_groups_callback(const struct pmu_metric= *pm, - const struct pmu_events_table *table __maybe_unused, + const struct pmu_metrics_table *table __maybe_unused, void *vdata) { struct rblist *groups =3D vdata; @@ -488,16 +488,16 @@ static int metricgroup__add_to_mep_groups_callback(co= nst struct pmu_metric *pm, void metricgroup__print(const struct print_callbacks *print_cb, void *prin= t_state) { struct rblist groups; - const struct pmu_events_table *table; + const struct pmu_metrics_table *table; struct rb_node *node, *next; =20 rblist__init(&groups); groups.node_new =3D mep_new; groups.node_cmp =3D mep_cmp; groups.node_delete =3D mep_delete; - table =3D pmu_events_table__find(); + table =3D pmu_metrics_table__find(); if (table) { - pmu_events_table_for_each_metric(table, + pmu_metrics_table_for_each_metric(table, metricgroup__add_to_mep_groups_callback, &groups); } @@ -765,11 +765,11 @@ struct metricgroup_add_iter_data { bool system_wide; struct metric *root_metric; const struct visited_metric *visited; - const struct pmu_events_table *table; + const struct pmu_metrics_table *table; }; =20 static bool metricgroup__find_metric(const char *metric, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, struct pmu_metric *pm); =20 static int add_metric(struct list_head *metric_list, @@ -780,7 +780,7 @@ static int add_metric(struct list_head *metric_list, bool system_wide, struct metric *root_metric, const struct visited_metric *visited, - const struct pmu_events_table *table); + const struct pmu_metrics_table *table); =20 /** * resolve_metric - Locate metrics within the root metric and recursively = add @@ -807,7 +807,7 @@ static int resolve_metric(struct list_head *metric_list, bool system_wide, struct metric *root_metric, const struct visited_metric *visited, - const struct pmu_events_table *table) + const struct pmu_metrics_table *table) { struct hashmap_entry *cur; size_t bkt; @@ -889,7 +889,7 @@ static int __add_metric(struct list_head *metric_list, bool system_wide, struct metric *root_metric, const struct visited_metric *visited, - const struct pmu_events_table *table) + const struct pmu_metrics_table *table) { const struct visited_metric *vm; int ret; @@ -982,7 +982,7 @@ struct metricgroup__find_metric_data { }; =20 static int metricgroup__find_metric_callback(const struct pmu_metric *pm, - const struct pmu_events_table *table __maybe_unused, + const struct pmu_metrics_table *table __maybe_unused, void *vdata) { struct metricgroup__find_metric_data *data =3D vdata; @@ -995,7 +995,7 @@ static int metricgroup__find_metric_callback(const stru= ct pmu_metric *pm, } =20 static bool metricgroup__find_metric(const char *metric, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, struct pmu_metric *pm) { struct metricgroup__find_metric_data data =3D { @@ -1003,7 +1003,7 @@ static bool metricgroup__find_metric(const char *metr= ic, .pm =3D pm, }; =20 - return pmu_events_table_for_each_metric(table, metricgroup__find_metric_c= allback, &data) + return pmu_metrics_table_for_each_metric(table, metricgroup__find_metric_= callback, &data) ? true : false; } =20 @@ -1015,7 +1015,7 @@ static int add_metric(struct list_head *metric_list, bool system_wide, struct metric *root_metric, const struct visited_metric *visited, - const struct pmu_events_table *table) + const struct pmu_metrics_table *table) { int ret =3D 0; =20 @@ -1045,7 +1045,7 @@ static int add_metric(struct list_head *metric_list, } =20 static int metricgroup__add_metric_sys_event_iter(const struct pmu_metric = *pm, - const struct pmu_events_table *table __maybe_unused, + const struct pmu_metrics_table *table __maybe_unused, void *data) { struct metricgroup_add_iter_data *d =3D data; @@ -1105,7 +1105,7 @@ struct metricgroup__add_metric_data { }; =20 static int metricgroup__add_metric_callback(const struct pmu_metric *pm, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, void *vdata) { struct metricgroup__add_metric_data *data =3D vdata; @@ -1143,7 +1143,7 @@ static int metricgroup__add_metric(const char *metric= _name, const char *modifier const char *user_requested_cpu_list, bool system_wide, struct list_head *metric_list, - const struct pmu_events_table *table) + const struct pmu_metrics_table *table) { LIST_HEAD(list); int ret; @@ -1163,7 +1163,7 @@ static int metricgroup__add_metric(const char *metric= _name, const char *modifier * Iterate over all metrics seeing if metric matches either the * name or group. When it does add the metric to the list. */ - ret =3D pmu_events_table_for_each_metric(table, metricgroup__add_metric_= callback, + ret =3D pmu_metrics_table_for_each_metric(table, metricgroup__add_metric= _callback, &data); if (ret) goto out; @@ -1219,7 +1219,7 @@ static int metricgroup__add_metric(const char *metric= _name, const char *modifier static int metricgroup__add_metric_list(const char *list, bool metric_no_g= roup, const char *user_requested_cpu_list, bool system_wide, struct list_head *metric_list, - const struct pmu_events_table *table) + const struct pmu_metrics_table *table) { char *list_itr, *list_copy, *metric_name, *modifier; int ret, count =3D 0; @@ -1429,7 +1429,7 @@ static int parse_groups(struct evlist *perf_evlist, c= onst char *str, bool system_wide, struct perf_pmu *fake_pmu, struct rblist *metric_events_list, - const struct pmu_events_table *table) + const struct pmu_metrics_table *table) { struct evlist *combined_evlist =3D NULL; LIST_HEAD(metric_list); @@ -1577,7 +1577,7 @@ int metricgroup__parse_groups(struct evlist *perf_evl= ist, bool system_wide, struct rblist *metric_events) { - const struct pmu_events_table *table =3D pmu_events_table__find(); + const struct pmu_metrics_table *table =3D pmu_metrics_table__find(); =20 if (!table) return -EINVAL; @@ -1588,7 +1588,7 @@ int metricgroup__parse_groups(struct evlist *perf_evl= ist, } =20 int metricgroup__parse_groups_test(struct evlist *evlist, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, const char *str, bool metric_no_group, bool metric_no_merge, @@ -1601,7 +1601,7 @@ int metricgroup__parse_groups_test(struct evlist *evl= ist, } =20 static int metricgroup__has_metric_callback(const struct pmu_metric *pm, - const struct pmu_events_table *table __maybe_unused, + const struct pmu_metrics_table *table __maybe_unused, void *vdata) { const char *metric =3D vdata; @@ -1617,12 +1617,12 @@ static int metricgroup__has_metric_callback(const s= truct pmu_metric *pm, =20 bool metricgroup__has_metric(const char *metric) { - const struct pmu_events_table *table =3D pmu_events_table__find(); + const struct pmu_metrics_table *table =3D pmu_metrics_table__find(); =20 if (!table) return false; =20 - return pmu_events_table_for_each_metric(table, metricgroup__has_metric_ca= llback, + return pmu_metrics_table_for_each_metric(table, metricgroup__has_metric_c= allback, (void *)metric) ? true : false; } =20 diff --git a/tools/perf/util/metricgroup.h b/tools/perf/util/metricgroup.h index b1f186d0f514..84030321a057 100644 --- a/tools/perf/util/metricgroup.h +++ b/tools/perf/util/metricgroup.h @@ -73,7 +73,7 @@ int metricgroup__parse_groups(struct evlist *perf_evlist, bool system_wide, struct rblist *metric_events); int metricgroup__parse_groups_test(struct evlist *evlist, - const struct pmu_events_table *table, + const struct pmu_metrics_table *table, const char *str, bool metric_no_group, bool metric_no_merge, diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index d627f99b5a63..09014e85203b 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -718,7 +718,12 @@ char *perf_pmu__getcpuid(struct perf_pmu *pmu) =20 __weak const struct pmu_events_table *pmu_events_table__find(void) { - return perf_pmu__find_table(NULL); + return perf_pmu__find_events_table(NULL); +} + +__weak const struct pmu_metrics_table *pmu_metrics_table__find(void) +{ + return perf_pmu__find_metrics_table(NULL); } =20 /* @@ -846,7 +851,7 @@ static void pmu_add_cpu_aliases(struct list_head *head,= struct perf_pmu *pmu) { const struct pmu_events_table *table; =20 - table =3D perf_pmu__find_table(pmu); + table =3D perf_pmu__find_events_table(pmu); if (!table) return; =20 diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 4d8d64209b4b..c1fb70bf6f84 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -230,6 +230,7 @@ void pmu_add_cpu_aliases_table(struct list_head *head, = struct perf_pmu *pmu, =20 char *perf_pmu__getcpuid(struct perf_pmu *pmu); const struct pmu_events_table *pmu_events_table__find(void); +const struct pmu_metrics_table *pmu_metrics_table__find(void); bool pmu_uncore_alias_match(const char *pmu_name, const char *name); void perf_pmu_free_alias(struct perf_pmu_alias *alias); =20 --=20 2.39.0.314.g84b9a713c41-goog