From nobody Wed Sep 17 09:04:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B29D4C4332F for ; Wed, 21 Dec 2022 22:25:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235079AbiLUWZZ (ORCPT ); Wed, 21 Dec 2022 17:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235010AbiLUWZH (ORCPT ); Wed, 21 Dec 2022 17:25:07 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26691275FD for ; Wed, 21 Dec 2022 14:24:37 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id h6-20020a17090aa88600b00223fccff2efso1952006pjq.6 for ; Wed, 21 Dec 2022 14:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BoetL47dMtSYpyhZbJzKl1EqSh6TREkVR0ldKUR5DTE=; b=B2Il06BXZ5r75uO6Eh6VbInYjOxKdKJBrLZcwxld+Hj9NTKOaFJ4tEln9Ebd43HD3V XGsxjryczXGgpPcb9lEHqJHq6iSZOJDDZYCR9sJdtAcozqn8ZhJQBFnBtQAGVb8fs88i tS4KjdO/CHK6ygrF/kxg+BGf1GBeSdrqZz1Bs1DCwuZ4ALwelH4arRjImcrNksCQH0PJ fre2RUTACKiTUUq7uDfxqdnR50CEEj1LXW0xeHx730J4o2IACZ+mv8pTROJWGX0w8D/f digzIkmHy7fIFib/DTm+CSnIbYO09B6k8GNnVK//AhuZ3XugZ2+LvEEfUXboUxjCh8cR TbTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BoetL47dMtSYpyhZbJzKl1EqSh6TREkVR0ldKUR5DTE=; b=McvJXaPR7AYhQJfxx6jqlf+n1gVAK8XRb2FSdVeb2C7ypL/UF/V/FvaKCVv9kXWLtW NTu8H2c1yhngcFUlJGsgE57PpLA5VvP8s2bApJhl5TvCriJAUfZh2612M3mxKbjV/nZO vtlkqFRKolPpc+Qp6wswTRj7sF+T/NERmM7GP1Wd42y4bFVn8BA+tR6seut+0wBSBc8t tjYrfJEjTlFOyd4NunUrsd4INKKG3RL4gXy6p+zy85WtieUcEoo7TNi9Pe4nhA7B+Z3t vEZAoyqABAMubRYMzOjFB+g2BXdLH/QUI118DEcufB4ZDuwjZYTCT8MjgSUDu+t0nqqe JirQ== X-Gm-Message-State: AFqh2krLNWRKdx6zs7+re+LRRtTKtZd7bEbUW0+SYTvz9Twf8yR8eYHI P3iAR8uOovs27LBZfe25QexGWRqKPHwQWQuFS1plVyhuKBJK4RyVMla9TAs1lwswN0YKTUGE1uZ SrD7g0qCiOiRqHP7B5wA/tPrnBBRgNNqOXlCWd6xA5nNhO3JTgXlE6p4MEWsHJw3G7u1enLkr X-Google-Smtp-Source: AMrXdXvcPw/batAzM2ubwgjdBVty+O9txrpne8GQWWnHTUKRra0t6kSK2wryQb6O1CIF9FnsBgLoCAGFiI5U X-Received: from sweer.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:e45]) (user=bgardon job=sendgmr) by 2002:a63:9359:0:b0:478:bc15:bf28 with SMTP id w25-20020a639359000000b00478bc15bf28mr148390pgm.542.1671661477243; Wed, 21 Dec 2022 14:24:37 -0800 (PST) Date: Wed, 21 Dec 2022 22:24:13 +0000 In-Reply-To: <20221221222418.3307832-1-bgardon@google.com> Mime-Version: 1.0 References: <20221221222418.3307832-1-bgardon@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221221222418.3307832-10-bgardon@google.com> Subject: [RFC 09/14] KVM: x86/MMU: Only make pages available on Shadow MMU fault From: Ben Gardon To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Paolo Bonzini , Peter Xu , Sean Christopherson , David Matlack , Vipin Sharma , Nagareddy Reddy , Ben Gardon Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that the Shadow MMU has been factored out of mmu.c and the naming sheme has been cleaned up, it's clear that there's an unnecessary operation in direct_page_fault(). Since the MMU page quota is only applied to the Shadow MMU, there's no point to calling kvm_shadow_mmu_make_pages_available on a fault where the TDP MMU is going to handle installing new TDP PTEs. Signed-off-by: Ben Gardon --- arch/x86/kvm/mmu/mmu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index bacb519ba7b4..568b36de9eeb 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -1469,14 +1469,14 @@ static int direct_page_fault(struct kvm_vcpu *vcpu,= struct kvm_page_fault *fault if (is_page_fault_stale(vcpu, fault, mmu_seq)) goto out_unlock; =20 - r =3D kvm_shadow_mmu_make_pages_available(vcpu); - if (r) - goto out_unlock; - if (is_tdp_mmu_fault) r =3D kvm_tdp_mmu_map(vcpu, fault); - else + else { + r =3D kvm_shadow_mmu_make_pages_available(vcpu); + if (r) + goto out_unlock; r =3D kvm_shadow_mmu_direct_map(vcpu, fault); + } =20 out_unlock: if (is_tdp_mmu_fault) --=20 2.39.0.314.g84b9a713c41-goog