From nobody Wed Sep 17 10:11:45 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE91C4332F for ; Tue, 20 Dec 2022 06:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233095AbiLTGdK (ORCPT ); Tue, 20 Dec 2022 01:33:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232887AbiLTGdD (ORCPT ); Tue, 20 Dec 2022 01:33:03 -0500 Received: from forwardcorp1b.mail.yandex.net (forwardcorp1b.mail.yandex.net [178.154.239.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBD910A9; Mon, 19 Dec 2022 22:33:00 -0800 (PST) Received: from myt5-8800bd68420f.qloud-c.yandex.net (myt5-8800bd68420f.qloud-c.yandex.net [IPv6:2a02:6b8:c12:4615:0:640:8800:bd68]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id AA85C605E7; Tue, 20 Dec 2022 09:32:58 +0300 (MSK) Received: from d-tatianin-nix.yandex-team.ru (unknown [2a02:6b8:b081:a418::1:2]) by myt5-8800bd68420f.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id mWekiF1Qua61-Os7KMsdQ; Tue, 20 Dec 2022 09:32:57 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1671517977; bh=fZ55fK+rBHxzLQTQDzeHsEkqnYvLJhSwxRsEbq74Ca4=; h=Message-Id:Date:Cc:Subject:To:From; b=POTAmd49lFo/yCA7Kr6hv/ZWDI4yh385HgNAVUrAjRCTyCWkIB386e/0LKuYgqMO9 Dh9mLJIrnKfA8D/RWb9sIZ08DGxHgvOs4esWwZl3JjAa6WcEZe5D3JzHJbymZAf46f v4QQJ4eUUJSh8wDVTEM2smuMSloeIFw0KSqofO58= Authentication-Results: myt5-8800bd68420f.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Daniil Tatianin To: Jesse Brandeburg Cc: Daniil Tatianin , Tony Nguyen , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Harshitha Ramamurthy , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] iavf/iavf_main: actually log ->src mask when talking about it Date: Tue, 20 Dec 2022 09:32:46 +0300 Message-Id: <20221220063246.1593327-1-d-tatianin@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This fixes a copy-paste issue where dev_err would log the dst mask even though it is clearly talking about src. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") Signed-off-by: Daniil Tatianin Reviewed-by: Michal Swiatkowski --- drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethe= rnet/intel/iavf/iavf_main.c index c4e451ef7942..adc02adef83a 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter = *adapter, field_flags |=3D IAVF_CLOUD_FIELD_IIP; } else { dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n", - be32_to_cpu(match.mask->dst)); + be32_to_cpu(match.mask->src)); return -EINVAL; } } --=20 2.25.1