From nobody Sun Apr 12 20:03:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E922DC4167B for ; Mon, 19 Dec 2022 17:12:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbiLSRMP (ORCPT ); Mon, 19 Dec 2022 12:12:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231991AbiLSRLy (ORCPT ); Mon, 19 Dec 2022 12:11:54 -0500 X-Greylist: delayed 181 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 19 Dec 2022 09:11:53 PST Received: from box.opentheblackbox.net (box.opentheblackbox.net [IPv6:2600:3c02::f03c:92ff:fee2:82bc]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46B6E1095; Mon, 19 Dec 2022 09:11:53 -0800 (PST) Received: from authenticated-user (box.opentheblackbox.net [172.105.151.37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.opentheblackbox.net (Postfix) with ESMTPSA id 2BB7A3EA50; Mon, 19 Dec 2022 12:11:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pgazz.com; s=mail; t=1671469912; bh=9bYAYnsF3sM0kY4DcqJgvSrfn3Yhvu5t4LsWQCVQ22c=; h=From:To:Cc:Subject:Date:From; b=QkzqOPRUuNa/qGz+0kKM5B8ydrXl9Ytr+JMz6Pmr9P7JxdXWyz4dhM2A5Z8ZqbhCa KYDejVQfMZi9z57C561MkYLMyfB06tnpe+dd5ns5D3vkhZEtm0lngZHyJEeqgC9Ww4 LOmgxxjQEUZ9Kw5aOXcw5DO0FP8tgPuOEFb2jy3Y8g7hjMLql+wjURr9+22toh7WCd bBTultH/RwGwlE3wPqFGKdgDNU/G5BC3J3Ra9bdp+6FuZX7cz+U0VJMXHtxKdxDK5z WBCrkoZIygor8LuvRjNylL8Hcy56hxpBAeBTkSSekg3h8zg/rKfRpJFUcgUxu97kW9 boDnjoZZyTsGA== From: Paul Gazzillo To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Randy Dunlap , Zheng Bin , Yang Yingliang , Suman Ghosh , Subbaraya Sundeep , Sunil Goutham , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Paul Gazzillo Subject: [PATCH] octeontx2_pf: Select NET_DEVLINK when enabling OCTEONTX2_PF Date: Mon, 19 Dec 2022 12:11:28 -0500 Message-Id: <20221219171149.833822-1-paul@pgazz.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does not select NET_DEVLINK while the related OCTEONTX2_AF driver does. This means that when OCTEONTX2_PF is enabled from a default configuration, linker errors will occur due to undefined references to code controlled by NET_DEVLINK. 1. make.cross ARCH=3Dx86_64 defconfig 2. make.cross ARCH=3Dx86_64 menuconfig 3. Enable COMPILE_TEST General setup ---> Compile also drivers which will not load 4. Enable OCTEONTX2_PF Device Drivers ---> Network device support ---> Ethernet driver support ---> Marvell OcteonTX2 NIC Physical Function driver 5. Exit and save configuration. NET_DEVLINK will still be disabled. 6. make.cross ARCH=3Dx86_64 several linker errors, for example, ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_register_dl': otx2_devlink.c:(.text+0x142): undefined reference to `devlink_alloc_ns' This fix adds "select NET_DEVLINK" link to OCTEONTX2_PF's Kconfig specification to match OCTEONTX2_AF. Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entr= y count") Signed-off-by: Paul Gazzillo Reviewed-by: Leon Romanovsky --- v1 -> v2: Added the fixes tag drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/Kconfig b/drivers/net/e= thernet/marvell/octeontx2/Kconfig index 3f982ccf2c85..639893d87055 100644 --- a/drivers/net/ethernet/marvell/octeontx2/Kconfig +++ b/drivers/net/ethernet/marvell/octeontx2/Kconfig @@ -31,6 +31,7 @@ config NDC_DIS_DYNAMIC_CACHING config OCTEONTX2_PF tristate "Marvell OcteonTX2 NIC Physical Function driver" select OCTEONTX2_MBOX + select NET_DEVLINK depends on (64BIT && COMPILE_TEST) || ARM64 depends on PCI depends on PTP_1588_CLOCK_OPTIONAL --=20 2.25.1