From nobody Wed Sep 17 21:13:17 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD598C25B04 for ; Thu, 15 Dec 2022 16:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbiLOQjb (ORCPT ); Thu, 15 Dec 2022 11:39:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbiLOQj0 (ORCPT ); Thu, 15 Dec 2022 11:39:26 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D764D20F50; Thu, 15 Dec 2022 08:39:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91A67B81C0F; Thu, 15 Dec 2022 16:39:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BD6EC433EF; Thu, 15 Dec 2022 16:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671122363; bh=2OPO4m4zGufDKQ8laFBnT5+ykmpwqmAwuJDyZQqQLAs=; h=From:To:Cc:Subject:Date:From; b=cB66ibYY5YG+vvmy4HAotIH2AcVlI5B87zecW1Ia36abgl+C2N+RQx7qZEkLjp5Q9 /uvyeOsuCc5grEphZqY1uC6uBCxqFAszRqpB7cwZvq2wNO/jrrJofbqxeWk5e1Ciil kAZzIsNrupTaJJVRMZvw32WMlLZ5SJJfi6nX/99PuOKBTqo76kaQGudWeSRbO0FK9o n6f9+YlPJXYiJjdr1SvE1OiXvZ4cJoosoNQQPPUKeqv1Ggy0IuN3RQ3cZhKafw8MUq FLBvRCbBQGpnKJDclKd97FUN9lMAKWQbJR45QrzVTq6oPdpdFTVKkFo+fmkyfvJ2TX IvL7UqYa4H4Qw== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Roger Quadros , Siddharth Vadapalli , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: ethernet: ti: am65-cpsw: fix CONFIG_PM #ifdef Date: Thu, 15 Dec 2022 17:39:05 +0100 Message-Id: <20221215163918.611609-1-arnd@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The #ifdef check is incorrect and leads to a warning: drivers/net/ethernet/ti/am65-cpsw-nuss.c:1679:13: error: 'am65_cpsw_nuss_re= move_rx_chns' defined but not used [-Werror=3Dunused-function] 1679 | static void am65_cpsw_nuss_remove_rx_chns(void *data) It's better to remove the #ifdef here and use the modern SYSTEM_SLEEP_PM_OPS() macro instead. Fixes: 24bc19b05f1f ("net: ethernet: ti: am65-cpsw: Add suspend/resume supp= ort") Signed-off-by: Arnd Bergmann Reviewed-by: Alexander Duyck --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/etherne= t/ti/am65-cpsw-nuss.c index 9decb0c7961b..ecbde83b5243 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -2878,7 +2878,6 @@ static int am65_cpsw_nuss_remove(struct platform_devi= ce *pdev) return 0; } =20 -#ifdef CONFIG_PM_SLEEP static int am65_cpsw_nuss_suspend(struct device *dev) { struct am65_cpsw_common *common =3D dev_get_drvdata(dev); @@ -2964,10 +2963,9 @@ static int am65_cpsw_nuss_resume(struct device *dev) =20 return 0; } -#endif /* CONFIG_PM_SLEEP */ =20 static const struct dev_pm_ops am65_cpsw_nuss_dev_pm_ops =3D { - SET_SYSTEM_SLEEP_PM_OPS(am65_cpsw_nuss_suspend, am65_cpsw_nuss_resume) + SYSTEM_SLEEP_PM_OPS(am65_cpsw_nuss_suspend, am65_cpsw_nuss_resume) }; =20 static struct platform_driver am65_cpsw_nuss_driver =3D { --=20 2.35.1