From nobody Thu Sep 18 00:07:19 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B8FC4332F for ; Wed, 14 Dec 2022 22:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbiLNWwF (ORCPT ); Wed, 14 Dec 2022 17:52:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiLNWvy (ORCPT ); Wed, 14 Dec 2022 17:51:54 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09399396FF for ; Wed, 14 Dec 2022 14:51:52 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id n197-20020a25d6ce000000b00702558fba96so1595255ybg.0 for ; Wed, 14 Dec 2022 14:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pP1HscS3NBizlWxdjalcxiOCxdTFFXWst9Um78lFYew=; b=T1vg6NpxLo6/eIwoy3Qed3mwYZrRcOaXUysYifLHaPi+vYhazUnDs6UDkTZlfRIw7V Y5hy6nvWH1kyT8kmze9eEa6nJSZiNVpW3N3UXMgfEqMuN0e25TVhuhO9D7VqOL/r6JiD 44j5nrRtBPJjeCrY/eBcV76Ko9qHQL7Uf12YDUe97/+MP0nkOYsl4soDy9ktZnmEK6x+ JG4eyDx3Gz2L0H7brEud6mnsIZbHYNBVEQ+rFXpJSg7KtZwCH9Hw29QGY6vvNpzSWtha wOUPLTllmlPcjgFW+I/5/U+W1WIJ6SDoiC88ehNVmoHhh1WhKqr8mBzhsap235RbUrOI kVPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pP1HscS3NBizlWxdjalcxiOCxdTFFXWst9Um78lFYew=; b=IdQAkwpWGjMCsGDXWgQCVK7DNfwmE4aFYCZZReCd6KIxCPjg2734u0E0u3XjU9gdMJ hb3mkCzGRIu02arbukxrVxcxXpCPkQl7HW1fI+laV8UtgB1Y/z3HIOJsIHTFDtU3YkxQ fvBgArWT9YZEsvLUr9HjyDLFSR6xEtd8N9OY7o5uyDAKPrEvmF2SpdntTk6sz4n+cS0D sgXcmtSxSRUKOI0r2NcEV4lVIDv+ljrozVlXgw1IdIAcOstW1LYxCkmW4Cd9ibI13qNF i3NLeZ+d15CxWY/m9tGeB/KPtpmNkqGLVbW8Xk8Og3AL6M8wDXcEXbx9y81Kg+OEHdei Sf0A== X-Gm-Message-State: ANoB5plpRAPFeN5AqL2sc54AM6Y2Td+lncIsm/dM6EBzW1MnHzxbgded n7jKAFDxMiTPlrcv0csUtkg2GzIEjklA X-Google-Smtp-Source: AA0mqf7P1hKr2kxnLCk/QZ1080xuaZc9TM+496Hb5ZsvxrM7pi3Lu6mK+r3cvFJ2NP34V6PpPdiHlgQapjM1 X-Received: from yuanchu.svl.corp.google.com ([2620:15c:2d4:203:1311:60bc:9e2a:ab1]) (user=yuanchu job=sendgmr) by 2002:a25:dfc3:0:b0:6f3:2748:7469 with SMTP id w186-20020a25dfc3000000b006f327487469mr55315847ybg.564.1671058311228; Wed, 14 Dec 2022 14:51:51 -0800 (PST) Date: Wed, 14 Dec 2022 14:51:23 -0800 In-Reply-To: <20221214225123.2770216-1-yuanchu@google.com> Mime-Version: 1.0 References: <20221214225123.2770216-1-yuanchu@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221214225123.2770216-3-yuanchu@google.com> Subject: [RFC PATCH 2/2] mm: multi-gen LRU: cgroup working set stats From: Yuanchu Xie To: Johannes Weiner , Michal Hocko , Roman Gushchin , Yu Zhao Cc: Andrew Morton , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Yuanchu Xie Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Expose MGLRU generations as working set stats in cgroupfs as memory.page_idle_age, where we group pages into idle age ranges, and present the number of pages per node per pagetype in each range. This aggregates the time information from MGLRU generations hierarchically. Signed-off-by: Yuanchu Xie --- mm/memcontrol.c | 136 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 136 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 7d2fb3fc4580..86554e17be58 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1655,6 +1655,130 @@ void mem_cgroup_print_oom_meminfo(struct mem_cgroup= *memcg) pr_info("%s", buf); } =20 +#ifdef CONFIG_LRU_GEN +static const unsigned long page_idle_age_ranges[] =3D { + 1, 2, 5, 10, 20, 30, 45, 60, 90, 120, 180, + 240, 360, 480, 720, 960, 1440, 1920, 2880, 3840, -1 +}; + +#define PAGE_IDLE_AGE_NR_RANGES ARRAY_SIZE(page_idle_age_ranges) + +static unsigned int lru_gen_time_to_page_idle_age_range(unsigned long time= stamp) +{ + unsigned int i; + unsigned long gen_age =3D jiffies_to_msecs(jiffies - timestamp) / MSEC_PE= R_SEC; + + for (i =3D 0; i < PAGE_IDLE_AGE_NR_RANGES - 1; ++i) + if (gen_age <=3D page_idle_age_ranges[i]) + return i; + + return PAGE_IDLE_AGE_NR_RANGES - 1; +} + +static void lru_gen_fill_page_idle_age_table(unsigned long *table, + struct lru_gen_struct *lrugen, + int nid) +{ + unsigned long max_seq =3D READ_ONCE(lrugen->max_seq); + unsigned long min_seq[ANON_AND_FILE] =3D { + READ_ONCE(lrugen->min_seq[LRU_GEN_ANON]), + READ_ONCE(lrugen->min_seq[LRU_GEN_FILE]), + }; + unsigned long seq; + unsigned int pagetype; + + /* + * what do we want to do here? + * iterate over all the generations, for each anon and file + */ + + for (pagetype =3D LRU_GEN_ANON; pagetype < ANON_AND_FILE; ++pagetype) { + for (seq =3D min_seq[pagetype]; seq <=3D max_seq; ++seq) { + unsigned int zone; + unsigned int gen =3D lru_gen_from_seq(seq); + unsigned int idle_age =3D lru_gen_time_to_page_idle_age_range( + READ_ONCE(lrugen->timestamps[gen])); + unsigned long page_count =3D 0; + + for (zone =3D 0; zone < MAX_NR_ZONES; ++zone) { + page_count +=3D READ_ONCE( + lrugen->nr_pages[gen][pagetype][zone]); + } + table[pagetype * PAGE_IDLE_AGE_NR_RANGES * + nr_node_ids + + PAGE_IDLE_AGE_NR_RANGES * nid + idle_age] +=3D + page_count; + } + } +} + +static void memory_page_idle_age_print(struct seq_file *m, unsigned long *= table) +{ + static const char *type_str[ANON_AND_FILE] =3D { "anon", "file" }; + unsigned int i, nid, pagetype; + unsigned int lower =3D 0; + + for (i =3D 0; i < PAGE_IDLE_AGE_NR_RANGES; ++i) { + unsigned int upper =3D page_idle_age_ranges[i]; + + for (pagetype =3D LRU_GEN_ANON; pagetype < ANON_AND_FILE; + ++pagetype) { + if (upper =3D=3D -1) + seq_printf(m, "%u-inf %s", lower, + type_str[pagetype]); + else + seq_printf(m, "%u-%u %s", lower, upper, + type_str[pagetype]); + for_each_node_state(nid, N_MEMORY) { + unsigned long page_count =3D table + [pagetype * + PAGE_IDLE_AGE_NR_RANGES * + nr_node_ids + + PAGE_IDLE_AGE_NR_RANGES * nid + + i]; + seq_printf(m, " N%u=3D%lu", nid, page_count); + } + seq_puts(m, "\n"); + } + + lower =3D upper; + } +} + +static int memory_page_idle_age_format(struct mem_cgroup *root, + struct seq_file *m) +{ + struct mem_cgroup *memcg; + unsigned long *table; + + /* + * table contains PAGE_IDLE_AGE_NR_RANGES entries + * per node per pagetype + */ + table =3D kmalloc_array(PAGE_IDLE_AGE_NR_RANGES * nr_node_ids * + ANON_AND_FILE, + sizeof(*table), __GFP_ZERO | GFP_KERNEL); + + if (!table) + return -ENOMEM; + + memcg =3D mem_cgroup_iter(root, NULL, NULL); + do { + int nid; + + for_each_node_state(nid, N_MEMORY) { + struct lru_gen_struct *lrugen =3D + &memcg->nodeinfo[nid]->lruvec.lrugen; + + lru_gen_fill_page_idle_age_table(table, lrugen, nid); + } + } while ((memcg =3D mem_cgroup_iter(root, memcg, NULL))); + + memory_page_idle_age_print(m, table); + return 0; +} +#endif /* CONFIG_LRU_GEN */ + /* * Return the memory (and swap, if configured) limit for a memcg. */ @@ -6571,6 +6695,13 @@ static ssize_t memory_oom_group_write(struct kernfs_= open_file *of, } =20 #ifdef CONFIG_LRU_GEN +static int memory_page_idle_age_show(struct seq_file *m, void *v) +{ + struct mem_cgroup *memcg =3D mem_cgroup_from_seq(m); + + return memory_page_idle_age_format(memcg, m); +} + static int memory_periodic_aging_show(struct seq_file *m, void *v) { unsigned int interval =3D kold_get_interval(); @@ -6724,6 +6855,11 @@ static struct cftype memory_files[] =3D { .write =3D memory_reclaim, }, #ifdef CONFIG_LRU_GEN + { + .name =3D "page_idle_age", + .flags =3D CFTYPE_NS_DELEGATABLE, + .seq_show =3D memory_page_idle_age_show, + }, { .name =3D "periodic_aging", .flags =3D CFTYPE_ONLY_ON_ROOT, --=20 2.39.0.314.g84b9a713c41-goog