From nobody Wed Sep 17 23:49:11 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B660BC4332F for ; Wed, 14 Dec 2022 12:40:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238195AbiLNMkB (ORCPT ); Wed, 14 Dec 2022 07:40:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238370AbiLNMj1 (ORCPT ); Wed, 14 Dec 2022 07:39:27 -0500 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F7EE2183E for ; Wed, 14 Dec 2022 04:38:07 -0800 (PST) Received: from localhost.localdomain (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AE0DE85112; Wed, 14 Dec 2022 13:38:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671021486; bh=abd1MpTy2Dv7NXLZctEyPw0kePkmyEM/uEvzbgu2gpY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=geY+9KKLM0h2RZND9Py7wjG0DwsT68/LnsKJmP7k4omOm3tmyCYT2S1mR2IuRFcRh 3GhfNkhi82QkYov0fRY0Ic4RK6ohZLJHLKRlmFYKoT5mD4k9AoFu/ueH90kfnrBmYq mgpWoXBAJFn5gneZiNZErc38qnUJ8APyE/ltUMiX+GY1HOtWbMqLMFjNCuFRYJxSqI 8nxFCcjgZzkWNy6rdwps9X/neVdSX6Tg4fd0Psywytstk6s132TtZMPXX4FIobcKB8 logZoRTGWjcJVlWT6R1e3pmiYFOrLmNnb7wquV6vBw6hWgUOmY1LeFH1Mg91fww+01 k67UudxYytTTg== From: Lukasz Majewski To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Charles Keepax , Stephen Kitt Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Lukasz Majewski Subject: [PATCH 2/4] ASoC: wm8940: Rewrite code to set proper clocks Date: Wed, 14 Dec 2022 13:37:41 +0100 Message-Id: <20221214123743.3713843-3-lukma@denx.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221214123743.3713843-1-lukma@denx.de> References: <20221214123743.3713843-1-lukma@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Without this change, the wm8940 driver is not working when set_sysclk callback (wm8940_set_dai_sysclk) is called with frequency not listed in the switch clause. This change adjusts this driver to allow non-standard frequency set (just after the boot) being adjusted afterwards by the sound system core code. Moreover, support for internal wm8940's PLL is provided, so it can generate clocks when HOST system is not able to do it. Code in this commit is based on previous change done for wm8974 (SHA1: 51b2bb3f2568e6d9d81a001d38b8d70c2ba4af99). Signed-off-by: Lukasz Majewski --- sound/soc/codecs/wm8940.c | 103 ++++++++++++++++++++++++++++++-------- 1 file changed, 83 insertions(+), 20 deletions(-) diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c index 0b59020d747f..094e74905df9 100644 --- a/sound/soc/codecs/wm8940.c +++ b/sound/soc/codecs/wm8940.c @@ -37,7 +37,9 @@ #include "wm8940.h" =20 struct wm8940_priv { - unsigned int sysclk; + unsigned int mclk; + unsigned int fs; + struct regmap *regmap; }; =20 @@ -387,17 +389,24 @@ static int wm8940_set_dai_fmt(struct snd_soc_dai *cod= ec_dai, return 0; } =20 +static int wm8940_update_clocks(struct snd_soc_dai *dai); static int wm8940_i2s_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) { struct snd_soc_component *component =3D dai->component; + struct wm8940_priv *priv =3D snd_soc_component_get_drvdata(component); u16 iface =3D snd_soc_component_read(component, WM8940_IFACE) & 0xFD9F; u16 addcntrl =3D snd_soc_component_read(component, WM8940_ADDCNTRL) & 0xF= FF1; u16 companding =3D snd_soc_component_read(component, WM8940_COMPANDINGCTL) & 0xFFDF; int ret; =20 + priv->fs =3D params_rate(params); + ret =3D wm8940_update_clocks(dai); + if (ret) + return ret; + /* LoutR control */ if (substream->stream =3D=3D SNDRV_PCM_STREAM_CAPTURE && params_channels(params) =3D=3D 2) @@ -496,7 +505,6 @@ static int wm8940_set_bias_level(struct snd_soc_compone= nt *component, return ret; } } - /* ensure bufioen and biasen */ pwr_reg |=3D (1 << 2) | (1 << 3); /* set vmid to 300k for standby */ @@ -611,24 +619,6 @@ static int wm8940_set_dai_pll(struct snd_soc_dai *code= c_dai, int pll_id, return 0; } =20 -static int wm8940_set_dai_sysclk(struct snd_soc_dai *codec_dai, - int clk_id, unsigned int freq, int dir) -{ - struct snd_soc_component *component =3D codec_dai->component; - struct wm8940_priv *wm8940 =3D snd_soc_component_get_drvdata(component); - - switch (freq) { - case 11289600: - case 12000000: - case 12288000: - case 16934400: - case 18432000: - wm8940->sysclk =3D freq; - return 0; - } - return -EINVAL; -} - static int wm8940_set_dai_clkdiv(struct snd_soc_dai *codec_dai, int div_id, int div) { @@ -653,6 +643,79 @@ static int wm8940_set_dai_clkdiv(struct snd_soc_dai *c= odec_dai, return ret; } =20 +static unsigned int wm8940_get_mclkdiv(unsigned int f_in, unsigned int f_o= ut, + int *mclkdiv) +{ + unsigned int ratio =3D 2 * f_in / f_out; + + if (ratio <=3D 2) { + *mclkdiv =3D WM8940_MCLKDIV_1; + ratio =3D 2; + } else if (ratio =3D=3D 3) { + *mclkdiv =3D WM8940_MCLKDIV_1_5; + } else if (ratio =3D=3D 4) { + *mclkdiv =3D WM8940_MCLKDIV_2; + } else if (ratio <=3D 6) { + *mclkdiv =3D WM8940_MCLKDIV_3; + ratio =3D 6; + } else if (ratio <=3D 8) { + *mclkdiv =3D WM8940_MCLKDIV_4; + ratio =3D 8; + } else if (ratio <=3D 12) { + *mclkdiv =3D WM8940_MCLKDIV_6; + ratio =3D 12; + } else if (ratio <=3D 16) { + *mclkdiv =3D WM8940_MCLKDIV_8; + ratio =3D 16; + } else { + *mclkdiv =3D WM8940_MCLKDIV_12; + ratio =3D 24; + } + + return f_out * ratio / 2; +} + +static int wm8940_update_clocks(struct snd_soc_dai *dai) +{ + struct snd_soc_component *codec =3D dai->component; + struct wm8940_priv *priv =3D snd_soc_component_get_drvdata(codec); + unsigned int fs256; + unsigned int fpll =3D 0; + unsigned int f; + int mclkdiv; + + if (!priv->mclk || !priv->fs) + return 0; + + fs256 =3D 256 * priv->fs; + + f =3D wm8940_get_mclkdiv(priv->mclk, fs256, &mclkdiv); + if (f !=3D priv->mclk) { + /* The PLL performs best around 90MHz */ + fpll =3D wm8940_get_mclkdiv(22500000, fs256, &mclkdiv); + } + + wm8940_set_dai_pll(dai, 0, 0, priv->mclk, fpll); + wm8940_set_dai_clkdiv(dai, WM8940_MCLKDIV, mclkdiv); + + return 0; +} + +static int wm8940_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, + unsigned int freq, int dir) +{ + struct snd_soc_component *codec =3D dai->component; + struct wm8940_priv *priv =3D snd_soc_component_get_drvdata(codec); + + if (dir !=3D SND_SOC_CLOCK_IN) + return -EINVAL; + + priv->mclk =3D freq; + + return wm8940_update_clocks(dai); +} + + #define WM8940_RATES SNDRV_PCM_RATE_8000_48000 =20 #define WM8940_FORMATS (SNDRV_PCM_FMTBIT_S8 | \ --=20 2.20.1