From nobody Wed Sep 17 22:22:15 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B501C4332F for ; Wed, 14 Dec 2022 12:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238341AbiLNMAu (ORCPT ); Wed, 14 Dec 2022 07:00:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237680AbiLNMAM (ORCPT ); Wed, 14 Dec 2022 07:00:12 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1564125C61 for ; Wed, 14 Dec 2022 03:59:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5QQ6-0005u5-Oh; Wed, 14 Dec 2022 12:59:30 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p5QQ5-004SUT-96; Wed, 14 Dec 2022 12:59:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p5QQ5-005122-86; Wed, 14 Dec 2022 12:59:29 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: display: imx: Describe drm binding for fsl,imx-lcdc Date: Wed, 14 Dec 2022 12:59:20 +0100 Message-Id: <20221214115921.1845994-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214115921.1845994-1-u.kleine-koenig@pengutronix.de> References: <20221214115921.1845994-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2164; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=1NIdH+33Goz5fyXKjLETK/Z17qROmoceRqEUPWsk8nw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjmbqOp53HkCUZ8uIMQ5d7zzjETuf54RrPmcDvAeBA kYYh77GJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY5m6jgAKCRDB/BR4rcrsCRTxB/ sGm7y25pSIRQRMeYgeRppp6NUSDQAqlKHR0A5mzul9lUuV17Ou1GGhlnCMkbfVynWYTt12wvYbeDTJ VEOMqfFZK5BMcwrancax3vnGtZaY1E8r88BWlHfcaV1PQ8ygYc8GK5yrziOh0s99BYKM/vo4xXQzol A5NZGzmuXozp/c7FhGmy3CnHn2TKJZH/wvJ0JT1lKbmf/+0clra+qnW2ErDuHQC+NxTKXmgA/u45pj kBoWr5O9kY4VmwS02bpH/oSAjO1xdFJ+vgSiuNPWV4//ze3LXCvh8BY/56hv6iOZltZa4O9/StZX2e GPtwi3z5qdhJBYo1XjeRO/NKTIW04W X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Modify the existing (fb-like) binding to support the drm-like binding in parallel. Signed-off-by: Uwe Kleine-K=C3=B6nig --- .../bindings/display/imx/fsl,imx-lcdc.yaml | 45 ++++++++++++++++++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yam= l b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml index 35a8fff036ca..2a8225b10890 100644 --- a/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml @@ -21,6 +21,9 @@ properties: - fsl,imx25-fb - fsl,imx27-fb - const: fsl,imx21-fb + - items: + - const: fsl,imx25-lcdc + - const: fsl,imx21-lcdc =20 clocks: maxItems: 3 @@ -31,6 +34,9 @@ properties: - const: ahb - const: per =20 + port: + $ref: /schemas/graph.yaml#/properties/port + display: $ref: /schemas/types.yaml#/definitions/phandle =20 @@ -59,17 +65,54 @@ properties: description: LCDC Sharp Configuration Register value. =20 +if: + properties: + compatible: + contains: + enum: + - fsl,imx1-lcdc + - fsl,imx21-lcdc +then: + properties: + display: false + fsl,dmacr: false + fsl,lpccr: false + fsl,lscr1: false + + required: + - port + +else: + properties: + port: false + + required: + - display + required: - compatible - clocks - clock-names - - display - interrupts - reg =20 additionalProperties: false =20 examples: + - | + lcdc@53fbc000 { + compatible =3D "fsl,imx25-lcdc", "fsl,imx21-lcdc"; + reg =3D <0x53fbc000 0x4000>; + interrupts =3D <39>; + clocks =3D <&clks 103>, <&clks 66>, <&clks 49>; + clock-names =3D "ipg", "ahb", "per"; + + port { + parallel_out: endpoint { + remote-endpoint =3D <&panel_in>; + }; + }; + }; - | imxfb: fb@10021000 { compatible =3D "fsl,imx21-fb"; --=20 2.38.1 From nobody Wed Sep 17 22:22:15 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0A5C4332F for ; Wed, 14 Dec 2022 12:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237285AbiLNMAi (ORCPT ); Wed, 14 Dec 2022 07:00:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238338AbiLNMAH (ORCPT ); Wed, 14 Dec 2022 07:00:07 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE8A220F7A for ; Wed, 14 Dec 2022 03:59:35 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5QQ6-0005uQ-Uq; Wed, 14 Dec 2022 12:59:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p5QQ5-004SUW-H3; Wed, 14 Dec 2022 12:59:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p5QQ5-005125-Eq; Wed, 14 Dec 2022 12:59:29 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/2] drm/imx/lcdc: Implement DRM driver for imx21 Date: Wed, 14 Dec 2022 12:59:21 +0100 Message-Id: <20221214115921.1845994-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214115921.1845994-1-u.kleine-koenig@pengutronix.de> References: <20221214115921.1845994-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=22301; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=aLKTGCKHncU5JFwmGiTslfJl5xp3gvqLVITOn4Fnilo=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjmbqS7aLv3jKX974l9VJyVX7McRm9Lw1mHQCXOiAH 8ttWaUyJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY5m6kgAKCRDB/BR4rcrsCcS5B/ wOBiL8pMYnWbJzSLj7V1p0KUnmHYXOK1sRFbd1m50OfC/HlDm4jg1ksnbkrW/RQMhLSGEK7mhB2gI7 g7ST1Zb7p8lVP5frhR+VY8ynRI7DBuz4tdCBnSVEa3H0iBSd454WQ1zxsiyP0C1ELSsTwQ+vUjkB78 qyqbmldsYwODGKP16G+y0WV+lnuPb0zbny33j9vW/wwFiOXPt5zcqEj7j6oV+i+R0lKu8LXNHbPBNp JXmSlzzKcU3gU1HpHVmrbnKiMUQjNKDiA8RM6KKYb2q5B32Y6mrmjkEE1KJ2GtRUwdMwwZL31ynNA7 75/n3IIb7JNoJgFNPeTR6dgIh4ehNA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marian Cichy Add support for the LCD Controller found on i.MX21 and i.MX25. It targets to be a drop in replacement for the imx-fb driver. Signed-off-by: Marian Cichy [ukl: Rebase to v6.1, various smaller fixes] Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/gpu/drm/imx/Kconfig | 7 + drivers/gpu/drm/imx/Makefile | 2 + drivers/gpu/drm/imx/imx-lcdc.c | 610 +++++++++++++++++++++++++++++++++ 3 files changed, 619 insertions(+) create mode 100644 drivers/gpu/drm/imx/imx-lcdc.c diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig index fd5b2471fdf0..af5c6cb8c445 100644 --- a/drivers/gpu/drm/imx/Kconfig +++ b/drivers/gpu/drm/imx/Kconfig @@ -41,3 +41,10 @@ config DRM_IMX_HDMI Choose this if you want to use HDMI on i.MX6. =20 source "drivers/gpu/drm/imx/dcss/Kconfig" + +config DRM_IMX_LCDC + tristate "Freescale i.MX LCDC displays" + depends on DRM && (ARCH_MXC || COMPILE_TEST) + select DRM_KMS_CMA_HELPER + help + Found on i.MX1, i.MX21, i.MX25 and i.MX27. diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile index b644deffe948..1f96de7f15b4 100644 --- a/drivers/gpu/drm/imx/Makefile +++ b/drivers/gpu/drm/imx/Makefile @@ -10,3 +10,5 @@ obj-$(CONFIG_DRM_IMX_LDB) +=3D imx-ldb.o =20 obj-$(CONFIG_DRM_IMX_HDMI) +=3D dw_hdmi-imx.o obj-$(CONFIG_DRM_IMX_DCSS) +=3D dcss/ + +obj-$(CONFIG_DRM_IMX_LCDC) +=3D imx-lcdc.o diff --git a/drivers/gpu/drm/imx/imx-lcdc.c b/drivers/gpu/drm/imx/imx-lcdc.c new file mode 100644 index 000000000000..14d4962cecfd --- /dev/null +++ b/drivers/gpu/drm/imx/imx-lcdc.c @@ -0,0 +1,610 @@ +// SPDX-License-Identifier: GPL-2.0-only +// SPDX-FileCopyrightText: 2020 Marian Cichy + +#include "drm/drm_fourcc.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define IMX21LCDC_LSSAR 0x0000 /* LCDC Screen Start Address Regist= er */ +#define IMX21LCDC_LSR 0x0004 /* LCDC Size Register */ +#define IMX21LCDC_LVPWR 0x0008 /* LCDC Virtual Page Width Register= */ +#define IMX21LCDC_LCPR 0x000C /* LCDC Cursor Position Register */ +#define IMX21LCDC_LCWHB 0x0010 /* LCDC Cursor Width Height and Bli= nk Register*/ +#define IMX21LCDC_LCCMR 0x0014 /* LCDC Color Cursor Mapping Regist= er */ +#define IMX21LCDC_LPCR 0x0018 /* LCDC Panel Configuration Registe= r */ +#define IMX21LCDC_LHCR 0x001C /* LCDC Horizontal Configuration Re= gister */ +#define IMX21LCDC_LVCR 0x0020 /* LCDC Vertical Configuration Regi= ster */ +#define IMX21LCDC_LPOR 0x0024 /* LCDC Panning Offset Register */ +#define IMX21LCDC_LSCR 0x0028 /* LCDC Sharp Configuration Registe= r */ +#define IMX21LCDC_LPCCR 0x002C /* LCDC PWM Contrast Control Regist= er */ +#define IMX21LCDC_LDCR 0x0030 /* LCDC DMA Control Register */ +#define IMX21LCDC_LRMCR 0x0034 /* LCDC Refresh Mode Control Regist= er */ +#define IMX21LCDC_LICR 0x0038 /* LCDC Interrupt Configuration Reg= ister */ +#define IMX21LCDC_LIER 0x003C /* LCDC Interrupt Enable Register */ +#define IMX21LCDC_LISR 0x0040 /* LCDC Interrupt Status Register */ +#define IMX21LCDC_LGWSAR 0x0050 /* LCDC Graphic Window Start Addres= s Register */ +#define IMX21LCDC_LGWSR 0x0054 /* LCDC Graph Window Size Register = */ +#define IMX21LCDC_LGWVPWR 0x0058 /* LCDC Graphic Window Virtual Page= Width Register */ +#define IMX21LCDC_LGWPOR 0x005C /* LCDC Graphic Window Panning Offs= et Register */ +#define IMX21LCDC_LGWPR 0x0060 /* LCDC Graphic Window Position Reg= ister */ +#define IMX21LCDC_LGWCR 0x0064 /* LCDC Graphic Window Control Regi= ster */ +#define IMX21LCDC_LGWDCR 0x0068 /* LCDC Graphic Window DMA Control = Register */ +#define IMX21LCDC_LAUSCR 0x0080 /* LCDC AUS Mode Control Register */ +#define IMX21LCDC_LAUSCCR 0x0084 /* LCDC AUS Mode Cursor Control Reg= ister */ +#define IMX21LCDC_BGLUT 0x0800 /* Background Lookup Table */ +#define IMX21LCDC_GWLUT 0x0C00 /* Graphic Window Lookup Table */ + +#define IMX21LCDC_LCPR_CC0 BIT(30) /* Cursor Control Bit 0 */ +#define IMX21LCDC_LCPR_CC1 BIT(31) /* Cursor Control Bit 1 */ + +/* Values HSYNC, VSYNC and Framesize Register */ +#define IMX21LCDC_LHCR_H_WIDTH(val) (FIELD_PREP(GENMASK(31, 26), (val))) +#define IMX21LCDC_LHCR_H_BPORCH(val) (FIELD_PREP(GENMASK(7, 0), (val))) +#define IMX21LCDC_LHCR_H_FPORCH(val) (FIELD_PREP(GENMASK(15, 8), (val))) + +#define IMX21LCDC_LVCR_V_WIDTH(val) (FIELD_PREP(GENMASK(31, 26), (val))) +#define IMX21LCDC_LVCR_V_BPORCH(val) (FIELD_PREP(GENMASK(7, 0), (val))) +#define IMX21LCDC_LVCR_V_FPORCH(val) (FIELD_PREP(GENMASK(15, 8), (val))) + +#define IMX21LCDC_FRAME_WIDTH(val) (((val) / 16) << 20) +#define IMX21LCDC_FRAME_HEIGHT(val) (val) + +/* Values for LPCR Register */ +#define IMX21LCDC_PCD(val) (FIELD_PREP(GENMASK(5, 0), --(val))) +#define IMX21LCDC_SHARP(val) (FIELD_PREP(GENMASK(6, 6), (val))) +#define IMX21LCDC_SCLKSEL(val) (FIELD_PREP(GENMASK(7, 7), (val))) +#define IMX21LCDC_ACD(val) (FIELD_PREP(GENMASK(14, 8), (val))) +#define IMX21LCDC_ACDSEL(val) (FIELD_PREP(GENMASK(15, 15), (val))) +#define IMX21LCDC_REV_VS(val) (FIELD_PREP(GENMASK(16, 16), (val))) +#define IMX21LCDC_SWAP_SEL(val) (FIELD_PREP(GENMASK(17, 17), (val))) +#define IMX21LCDC_END_SEL(val) (FIELD_PREP(GENMASK(18, 18), (val))) +#define IMX21LCDC_SCLKIDLE(val) (FIELD_PREP(GENMASK(19, 19), (val))) +#define IMX21LCDC_OEPOL(val) (FIELD_PREP(GENMASK(20, 20), (val))) +#define IMX21LCDC_CLKPOL(val) (FIELD_PREP(GENMASK(21, 21), (val))) +#define IMX21LCDC_LPPOL(val) (FIELD_PREP(GENMASK(22, 22), (val))) +#define IMX21LCDC_FLMPOL(val) (FIELD_PREP(GENMASK(23, 23), (val))) +#define IMX21LCDC_PIXPOL(val) (FIELD_PREP(GENMASK(24, 24), (val))) +#define IMX21LCDC_BPIX(val) (FIELD_PREP(GENMASK(27, 25), (val))) +#define IMX21LCDC_PBSIZ(val) (FIELD_PREP(GENMASK(29, 28), (val))) +#define IMX21LCDC_COLOR(val) (FIELD_PREP(GENMASK(30, 30), (val))) +#define IMX21LCDC_TFT(val) (FIELD_PREP(GENMASK(31, 31), (val))) + +#define INTR_EOF BIT(1) /* VBLANK Interrupt Bit */ + +#define BPP_RGB565 0x05 + +#define LCDC_MIN_XRES 64 +#define LCDC_MIN_YRES 64 + +#define LCDC_MAX_XRES 1024 +#define LCDC_MAX_YRES 1024 + +struct imx_lcdc { + struct drm_device drm; + struct drm_simple_display_pipe pipe; + const struct drm_display_mode *mode; + struct drm_connector connector; + struct drm_panel *panel; + struct drm_bridge *bridge; + void __iomem *base; + + struct clk *clk_ipg; + struct clk *clk_ahb; + struct clk *clk_per; +}; + +static const u32 imx_lcdc_formats[] =3D { + DRM_FORMAT_RGB565, +}; + +static inline struct imx_lcdc *drm_to_lcdc(struct drm_device *drm) +{ + return container_of(drm, struct imx_lcdc, drm); +} + +static unsigned int imx_lcdc_get_format(unsigned int drm_format) +{ + unsigned int bpp; + + switch (drm_format) { + default: + DRM_WARN("Format not supported - fallback to RGB565\n"); + fallthrough; + case DRM_FORMAT_RGB565: + bpp =3D BPP_RGB565; + break; + } + + return bpp; +} + +static int imx_lcdc_connector_get_modes(struct drm_connector *connector) +{ + struct imx_lcdc *lcdc =3D drm_to_lcdc(connector->dev); + + if (lcdc->panel) + return drm_panel_get_modes(lcdc->panel, connector); + + return 0; +} + +static const struct drm_connector_helper_funcs imx_lcdc_connector_hfuncs = =3D { + .get_modes =3D imx_lcdc_connector_get_modes, +}; + +static const struct drm_connector_funcs imx_lcdc_connector_funcs =3D { + .reset =3D drm_atomic_helper_connector_reset, + .fill_modes =3D drm_helper_probe_single_connector_modes, + .destroy =3D drm_connector_cleanup, + .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, +}; + +static void imx_lcdc_update_hw_registers(struct drm_simple_display_pipe *p= ipe, + struct drm_plane_state *old_state, + bool mode_set) +{ + struct drm_crtc *crtc =3D &pipe->crtc; + struct drm_plane_state *new_state =3D pipe->plane.state; + struct drm_framebuffer *fb =3D new_state->fb; + struct imx_lcdc *lcdc =3D drm_to_lcdc(pipe->crtc.dev); + unsigned int bpp; + unsigned int lvcr; /* LVCR-Register value */ + unsigned int lhcr; /* LHCR-Register value */ + unsigned int framesize; + dma_addr_t addr; + + addr =3D drm_fb_dma_get_gem_addr(fb, new_state, 0); + /* The LSSAR register specifies the LCD screen start address (SSA). */ + writel(addr, lcdc->base + IMX21LCDC_LSSAR); + + if (!mode_set) + return; + + /* Disable PER clock to make register write possible */ + if (old_state && old_state->crtc && old_state->crtc->enabled) + clk_disable_unprepare(lcdc->clk_per); + + /* Framesize */ + framesize =3D IMX21LCDC_FRAME_WIDTH(crtc->mode.hdisplay); + framesize |=3D IMX21LCDC_FRAME_HEIGHT(crtc->mode.vdisplay); + writel(framesize, lcdc->base + IMX21LCDC_LSR); + + /* HSYNC */ + lhcr =3D IMX21LCDC_LHCR_H_FPORCH(crtc->mode.hsync_start - crtc->mode.hdis= play - 1); + lhcr |=3D IMX21LCDC_LHCR_H_WIDTH(crtc->mode.hsync_end - crtc->mode.hsync_= start - 1); + lhcr |=3D IMX21LCDC_LHCR_H_BPORCH(crtc->mode.htotal - crtc->mode.hsync_en= d - 3); + writel(lhcr, lcdc->base + IMX21LCDC_LHCR); + + /* VSYNC */ + lvcr =3D IMX21LCDC_LVCR_V_FPORCH(crtc->mode.vsync_start - crtc->mode.vdis= play); + lvcr |=3D IMX21LCDC_LVCR_V_WIDTH(crtc->mode.vsync_end - crtc->mode.vsync_= start); + lvcr |=3D IMX21LCDC_LVCR_V_BPORCH(crtc->mode.vtotal - crtc->mode.vsync_en= d); + writel(lvcr, lcdc->base + IMX21LCDC_LVCR); + + bpp =3D imx_lcdc_get_format(fb->format->format); + writel(readl(lcdc->base + IMX21LCDC_LPCR) | IMX21LCDC_BPIX(bpp), + lcdc->base + IMX21LCDC_LPCR); + + /* Virtual Page Width */ + writel(new_state->fb->pitches[0] / 4, lcdc->base + IMX21LCDC_LVPWR); + + /* Enable PER clock */ + if (new_state->crtc->enabled) + clk_prepare_enable(lcdc->clk_per); +} + +static void imx_lcdc_pipe_enable(struct drm_simple_display_pipe *pipe, + struct drm_crtc_state *crtc_state, + struct drm_plane_state *plane_state) +{ + int ret; + int clk_div; + int bpp; + struct imx_lcdc *lcdc =3D drm_to_lcdc(pipe->crtc.dev); + struct drm_display_mode *mode =3D &pipe->crtc.mode; + struct drm_display_info *disp_info =3D &pipe->connector->display_info; + const int hsync_pol =3D (mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : 1; + const int vsync_pol =3D (mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : 1; + const int data_enable_pol =3D + (disp_info->bus_flags & DRM_BUS_FLAG_DE_HIGH) ? 0 : 1; + const int clk_pol =3D + (disp_info->bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE) ? 0 : 1; + + drm_panel_prepare(lcdc->panel); + + clk_div =3D DIV_ROUND_CLOSEST_ULL(clk_get_rate(lcdc->clk_per), + mode->clock * 1000); + bpp =3D imx_lcdc_get_format(plane_state->fb->format->format); + + writel(IMX21LCDC_PCD(clk_div) | IMX21LCDC_LPPOL(hsync_pol) | IMX21LCDC_FL= MPOL(vsync_pol) | + IMX21LCDC_OEPOL(data_enable_pol) | IMX21LCDC_TFT(1) | IMX21LCDC_CO= LOR(1) | + IMX21LCDC_PBSIZ(3) | IMX21LCDC_BPIX(bpp) | IMX21LCDC_SCLKSEL(1) | + IMX21LCDC_PIXPOL(0) | IMX21LCDC_CLKPOL(clk_pol), + lcdc->base + IMX21LCDC_LPCR); + + /* 0px panning offset */ + writel(0x00000000, lcdc->base + IMX21LCDC_LPOR); + + /* disable hardware cursor */ + writel(readl(lcdc->base + IMX21LCDC_LCPR) & ~(IMX21LCDC_LCPR_CC0 | IMX21L= CDC_LCPR_CC1), + lcdc->base + IMX21LCDC_LCPR); + + ret =3D clk_prepare_enable(lcdc->clk_ipg); + if (ret) { + dev_err(pipe->crtc.dev->dev, "Cannot enable ipg clock: %pe\n", ERR_PTR(r= et)); + return; + } + ret =3D clk_prepare_enable(lcdc->clk_ahb); + if (ret) { + dev_err(pipe->crtc.dev->dev, "Cannot enable ahb clock: %pe\n", ERR_PTR(r= et)); + clk_disable_unprepare(lcdc->clk_ipg); + return; + } + + imx_lcdc_update_hw_registers(pipe, NULL, true); + drm_panel_enable(lcdc->panel); + + /* Enable VBLANK Interrupt */ + writel(INTR_EOF, lcdc->base + IMX21LCDC_LIER); +} + +static void imx_lcdc_pipe_disable(struct drm_simple_display_pipe *pipe) +{ + struct imx_lcdc *lcdc =3D drm_to_lcdc(pipe->crtc.dev); + struct drm_panel *panel =3D lcdc->panel; + struct drm_crtc *crtc =3D &lcdc->pipe.crtc; + struct drm_pending_vblank_event *event; + + drm_panel_disable(panel); + + clk_disable_unprepare(lcdc->clk_ahb); + clk_disable_unprepare(lcdc->clk_ipg); + + if (pipe->crtc.enabled) + clk_disable_unprepare(lcdc->clk_per); + + drm_panel_unprepare(panel); + + spin_lock_irq(&lcdc->drm.event_lock); + event =3D crtc->state->event; + if (event) { + crtc->state->event =3D NULL; + drm_crtc_send_vblank_event(crtc, event); + } + spin_unlock_irq(&lcdc->drm.event_lock); + + /* Disable VBLANK Interrupt */ + writel(0, lcdc->base + IMX21LCDC_LIER); +} + +static int imx_lcdc_check_mode_change(struct drm_display_mode *new_mode, + struct drm_display_mode *old_mode) +{ + if (old_mode->hdisplay !=3D new_mode->hdisplay || + old_mode->vdisplay !=3D new_mode->vdisplay) + return true; + return false; +} + +static int imx_lcdc_pipe_check(struct drm_simple_display_pipe *pipe, + struct drm_plane_state *plane_state, + struct drm_crtc_state *crtc_state) +{ + const struct drm_display_mode *mode =3D &crtc_state->mode; + + if ((mode->hdisplay < LCDC_MIN_XRES || mode->hdisplay > LCDC_MAX_XRES) || + (mode->vdisplay < LCDC_MIN_YRES || mode->vdisplay > LCDC_MAX_YRES) || + (mode->hdisplay & 0x10)) { /* must be multiple of 16 */ + DRM_ERROR("unsupported display mode (%u x %u)\n", + mode->hdisplay, mode->vdisplay); + return -EINVAL; + } + + crtc_state->mode_changed =3D imx_lcdc_check_mode_change(&crtc_state->mode, + &pipe->crtc.state->mode); + + return 0; +} + +static void imx_lcdc_pipe_update(struct drm_simple_display_pipe *pipe, + struct drm_plane_state *old_state) +{ + struct drm_crtc *crtc =3D &pipe->crtc; + struct drm_pending_vblank_event *event =3D crtc->state->event; + struct drm_plane_state *new_state =3D pipe->plane.state; + struct drm_framebuffer *fb =3D new_state->fb; + struct drm_framebuffer *old_fb =3D old_state->fb; + struct drm_crtc *old_crtc =3D old_state->crtc; + bool mode_changed =3D false; + + if (old_fb && old_fb->format !=3D fb->format) + mode_changed =3D true; + else if (old_crtc !=3D crtc) + mode_changed =3D true; + + imx_lcdc_update_hw_registers(pipe, old_state, mode_changed); + + if (event) { + crtc->state->event =3D NULL; + + spin_lock_irq(&crtc->dev->event_lock); + + if (crtc->state->active && drm_crtc_vblank_get(crtc) =3D=3D 0) + drm_crtc_arm_vblank_event(crtc, event); + else + drm_crtc_send_vblank_event(crtc, event); + + spin_unlock_irq(&crtc->dev->event_lock); + } +} + +static const struct drm_simple_display_pipe_funcs imx_lcdc_pipe_funcs =3D { + .enable =3D imx_lcdc_pipe_enable, + .disable =3D imx_lcdc_pipe_disable, + .check =3D imx_lcdc_pipe_check, + .update =3D imx_lcdc_pipe_update, + .prepare_fb =3D drm_gem_simple_display_pipe_prepare_fb, +}; + +static const struct drm_mode_config_funcs imx_lcdc_mode_config_funcs =3D { + .fb_create =3D drm_gem_fb_create_with_dirty, + .atomic_check =3D drm_atomic_helper_check, + .atomic_commit =3D drm_atomic_helper_commit, +}; + +static const struct drm_mode_config_helper_funcs imx_lcdc_mode_config_help= ers =3D { + .atomic_commit_tail =3D drm_atomic_helper_commit_tail_rpm, +}; + +static void imx_lcdc_release(struct drm_device *drm) +{ + struct imx_lcdc *lcdc =3D drm_to_lcdc(drm); + + drm_kms_helper_poll_fini(drm); + kfree(lcdc); +} + +DEFINE_DRM_GEM_DMA_FOPS(imx_lcdc_drm_fops); + +static struct drm_driver imx_lcdc_drm_driver =3D { + .driver_features =3D DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, + .fops =3D &imx_lcdc_drm_fops, + DRM_GEM_DMA_DRIVER_OPS_VMAP, + .release =3D imx_lcdc_release, + .name =3D "imx-lcdc", + .desc =3D "i.MX LCDC driver", + .date =3D "20200716", +}; + +static const struct of_device_id imx_lcdc_of_dev_id[] =3D { + { + .compatible =3D "fsl,imx21-lcdc", + }, + { + .compatible =3D "fsl,imx25-lcdc", + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, imx_lcdc_of_dev_id); + +static irqreturn_t irq_handler(int irq, void *arg) +{ + struct imx_lcdc *lcdc =3D (struct imx_lcdc *)arg; + struct drm_crtc *crtc =3D &lcdc->pipe.crtc; + unsigned int status; + + status =3D readl(lcdc->base + IMX21LCDC_LISR); + + if (status & INTR_EOF) { + drm_crtc_handle_vblank(crtc); + return IRQ_HANDLED; + } + + return IRQ_NONE; +} + +static int imx_lcdc_probe(struct platform_device *pdev) +{ + struct imx_lcdc *lcdc; + struct drm_device *drm; + int irq; + int ret; + struct device *dev =3D &pdev->dev; + + lcdc =3D devm_drm_dev_alloc(&pdev->dev, &imx_lcdc_drm_driver, + struct imx_lcdc, drm); + if (!lcdc) + return -ENOMEM; + + drm =3D &lcdc->drm; + + lcdc->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(lcdc->base)) { + dev_err(dev, "Cannot get IO memory\n"); + return PTR_ERR(lcdc->base); + } + + /* Panel */ + ret =3D drm_of_find_panel_or_bridge(dev->of_node, 0, 0, &lcdc->panel, &lc= dc->bridge); + if (ret) { + if (ret !=3D -EPROBE_DEFER) + dev_err(dev, "Failed to find panel or bridge: %pe", ERR_PTR(ret)); + return ret; + } + + /* Get Clocks */ + lcdc->clk_ipg =3D devm_clk_get(dev, "ipg"); + if (IS_ERR(lcdc->clk_ipg)) { + dev_err(dev, "Failed to get %s clk: %pe\n", "ipg", + lcdc->clk_ipg); + return PTR_ERR(lcdc->clk_ipg); + } + + lcdc->clk_ahb =3D devm_clk_get(dev, "ahb"); + if (IS_ERR(lcdc->clk_ahb)) { + dev_err(dev, "Failed to get %s clk: %pe\n", "ahb", + lcdc->clk_ahb); + return PTR_ERR(lcdc->clk_ahb); + } + + lcdc->clk_per =3D devm_clk_get(dev, "per"); + if (IS_ERR(lcdc->clk_per)) { + dev_err(dev, "Failed to get %s clk: %pe\n", "per", + lcdc->clk_per); + return PTR_ERR(lcdc->clk_per); + } + + ret =3D dma_set_mask_and_coherent(drm->dev, DMA_BIT_MASK(32)); + if (ret) { + dev_err(drm->dev, "Cannot set DMA Mask\n"); + return ret; + } + + /* Modeset init */ + drm_mode_config_init(drm); + + /* CRTC, Plane, Encoder */ + ret =3D drm_simple_display_pipe_init(drm, &lcdc->pipe, &imx_lcdc_pipe_fun= cs, imx_lcdc_formats, + ARRAY_SIZE(imx_lcdc_formats), NULL, &lcdc->connector); + if (ret < 0) { + dev_err(drm->dev, "Cannot setup simple display pipe\n"); + return ret; + } + + ret =3D drm_vblank_init(drm, drm->mode_config.num_crtc); + if (ret < 0) { + dev_err(drm->dev, "Failed to initialize vblank\n"); + return ret; + } + + if (lcdc->bridge) { + ret =3D drm_simple_display_pipe_attach_bridge(&lcdc->pipe, + lcdc->bridge); + if (ret) { + dev_err(drm->dev, "Cannot connect bridge: %pe\n", + ERR_PTR(ret)); + return ret; + } + } + + /* Connector */ + drm_connector_helper_add(&lcdc->connector, &imx_lcdc_connector_hfuncs); + drm_connector_init(drm, &lcdc->connector, &imx_lcdc_connector_funcs, + DRM_MODE_CONNECTOR_DPI); + + /* + * The LCDC controller does not have an enable bit. The + * controller starts directly when the clocks are enabled. + * If the clocks are enabled when the controller is not yet + * programmed with proper register values (enabled at the + * bootloader, for example) then it just goes into some undefined + * state. + * To avoid this issue, let's enable and disable LCDC IPG, + * PER and AHB clock so that we force some kind of 'reset' + * to the LCDC block. + */ + + ret =3D clk_prepare_enable(lcdc->clk_ipg); + if (ret) { + dev_err(dev, "Cannot enable ipg clock\n"); + return ret; + } + clk_disable_unprepare(lcdc->clk_ipg); + + ret =3D clk_prepare_enable(lcdc->clk_per); + if (ret) { + dev_err(dev, "Cannot enable per clock\n"); + return ret; + } + clk_disable_unprepare(lcdc->clk_per); + + ret =3D clk_prepare_enable(lcdc->clk_ahb); + if (ret) { + dev_err(dev, "Cannot enable ahb clock\n"); + return ret; + } + clk_disable_unprepare(lcdc->clk_ahb); + + drm->mode_config.min_width =3D LCDC_MIN_XRES; + drm->mode_config.max_width =3D LCDC_MAX_XRES; + drm->mode_config.min_height =3D LCDC_MIN_YRES; + drm->mode_config.max_height =3D LCDC_MAX_YRES; + drm->mode_config.preferred_depth =3D 16; + drm->mode_config.funcs =3D &imx_lcdc_mode_config_funcs; + drm->mode_config.helper_private =3D &imx_lcdc_mode_config_helpers; + + drm_mode_config_reset(drm); + + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) { + ret =3D irq; + return ret; + } + + ret =3D devm_request_irq(dev, irq, irq_handler, 0, "imx-lcdc", lcdc); + if (ret < 0) { + dev_err(drm->dev, "Failed to install IRQ handler\n"); + return ret; + } + + platform_set_drvdata(pdev, drm); + + ret =3D drm_dev_register(&lcdc->drm, 0); + if (ret) { + dev_err(dev, "Cannot register device\n"); + return ret; + } + + drm_fbdev_generic_setup(drm, 0); + + return 0; +} + +static int imx_lcdc_remove(struct platform_device *pdev) +{ + struct imx_lcdc *lcdc =3D drm_to_lcdc(platform_get_drvdata(pdev)); + + drm_dev_unregister(&lcdc->drm); + drm_atomic_helper_shutdown(&lcdc->drm); + + return 0; +} + +static void imx_lcdc_shutdown(struct platform_device *pdev) +{ + drm_atomic_helper_shutdown(platform_get_drvdata(pdev)); +} + +static struct platform_driver imx_lcdc_driver =3D { + .driver =3D { + .name =3D "imx-lcdc", + .of_match_table =3D imx_lcdc_of_dev_id, + }, + .probe =3D imx_lcdc_probe, + .remove =3D imx_lcdc_remove, + .shutdown =3D imx_lcdc_shutdown, +}; +module_platform_driver(imx_lcdc_driver); + +MODULE_AUTHOR("Marian Cichy "); +MODULE_DESCRIPTION("Freescale i.MX LCDC driver"); +MODULE_LICENSE("GPL"); --=20 2.38.1