From nobody Thu Sep 18 00:01:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B12EC10F1B for ; Wed, 14 Dec 2022 02:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236540AbiLNCwI (ORCPT ); Tue, 13 Dec 2022 21:52:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237143AbiLNCwD (ORCPT ); Tue, 13 Dec 2022 21:52:03 -0500 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F337726AFE for ; Tue, 13 Dec 2022 18:51:35 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VXGK2Xz_1670986274; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VXGK2Xz_1670986274) by smtp.aliyun-inc.com; Wed, 14 Dec 2022 10:51:33 +0800 From: Jiapeng Chong To: jani.nikula@linux.intel.com Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH v3] drm/i915: Remove unnecessary doc from static engine_init_common() Date: Wed, 14 Dec 2022 10:51:12 +0800 Message-Id: <20221214025112.104595-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function engine_init_common() has changed to static and we don't need doc comment in the static function. No functional modification involved. drivers/gpu/drm/i915/gt/intel_engine_cs.c:1306: warning: expecting prototyp= e for intel_engines_init_common(). Prototype was for engine_init_common() i= nstead. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D3442 Fixes: 019bf277634a ("drm/i915: Pull out some more common engine init code") Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v3: -Modify the commit message and add a "Fixes:" tag. drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i9= 15/gt/intel_engine_cs.c index c33e0d72d670..7c29b1504ae7 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1291,17 +1291,6 @@ create_kernel_context(struct intel_engine_cs *engine) &kernel, "kernel_context"); } =20 -/** - * intel_engines_init_common - initialize cengine state which might requir= e hw access - * @engine: Engine to initialize. - * - * Initializes @engine@ structure members shared between legacy and execli= sts - * submission modes which do require hardware access. - * - * Typcally done at later stages of submission mode specific engine setup. - * - * Returns zero on success or an error code on failure. - */ static int engine_init_common(struct intel_engine_cs *engine) { struct intel_context *ce; --=20 2.20.1.7.g153144c