From nobody Mon Feb 9 13:36:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEB0C4332F for ; Mon, 12 Dec 2022 23:19:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233987AbiLLXTg (ORCPT ); Mon, 12 Dec 2022 18:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233935AbiLLXTV (ORCPT ); Mon, 12 Dec 2022 18:19:21 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D00E1C415 for ; Mon, 12 Dec 2022 15:19:19 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id h7so13918660wrs.6 for ; Mon, 12 Dec 2022 15:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bvkJAcgJd+O1FIUzh+r0Wnbdw1Lb08jZRkvuJ8XN8TY=; b=JGnYa8+7d/o82h3CkSTwWBNT2WOmN5Bse7D6Nl0iJvbPtBOTZ9DnMYdlYnv8TgmH1S MbkRKhHcE3mV6Nu8KQNtd11TPdgKJARXkE4+wXaEnRqjcljlY/zlGD8lxgxSQrHjrMye WPpN7PS+TQvS8Xq0XGe504hZ/UAPIgSGB9M567NN5jRHiyCoUd0kHisZD3hDAydYCXhJ rXnicHOKaR38fl41vXXK4tQVeA90QIGC9k4QAhBcPvmkj3568B/VB+9BVAfOifTXkkzx 28pfXdi6P3POo6y8AQF5UdeIIBowuSQwJyWEK3qUKmT+ZJmXM+p5kUqLwsto8jIuzj0x YB7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bvkJAcgJd+O1FIUzh+r0Wnbdw1Lb08jZRkvuJ8XN8TY=; b=aLsqeNQqNOTYqtRXGeZh0pIeK6ARDek+6hUg3hILWoNXHUaKaBKvq1+D58MdTmGWU5 1eLpYi7HsjjH6p0U+Jf7XfJ3VSlh/9O6OSNlB7D483QJmbzVIrDfoZOJqHT97nOArO7c U5wb5VV7wbTmInrPrOqHaqMLa2vwxWtym5VhPlSG10i3dIbseepl5ZaKv24WZqVY30r1 o3+537Je4Blcd3rjEhSAoQXBMj7877B2dEQMaRAX16Wl7Cs2jJow+DzrwwS0CtWEPEah djNwxG81uip/7EQwrYEbJ/776n5+kDN3dFkldHx+o4flo9pO2822E+eHW84AtTGlLz1i dhqA== X-Gm-Message-State: ANoB5plJkb2ANG+fXSHtKrlAeRnjAWuwWTaHfUS5/QJPLIFj6G0paGgp FIHQg+QG/BRxPK4lh8hobpk= X-Google-Smtp-Source: AA0mqf6T3Z+l+rvgecLkN4HkVOlppRVpArk5LtUos5GLDVpZetZp90BoeWYjXV8H1txrOSaaJuwM0Q== X-Received: by 2002:a5d:44c7:0:b0:242:187f:ed44 with SMTP id z7-20020a5d44c7000000b00242187fed44mr11112478wrr.68.1670887157912; Mon, 12 Dec 2022 15:19:17 -0800 (PST) Received: from localhost.localdomain (host-79-41-27-125.retail.telecomitalia.it. [79.41.27.125]) by smtp.gmail.com with ESMTPSA id v3-20020a5d6103000000b002423edd7e50sm9964304wrt.32.2022.12.12.15.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:19:17 -0800 (PST) From: "Fabio M. De Francesco" To: Evgeniy Dushistov , Al Viro , Ira Weiny , linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH v2 3/3] fs/ufs: Replace kmap() with kmap_local_page() Date: Tue, 13 Dec 2022 00:19:06 +0100 Message-Id: <20221212231906.19424-4-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221212231906.19424-1-fmdefrancesco@gmail.com> References: <20221212231906.19424-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as the mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap=E2=80=99s pool wraps and it might block when the mapping space is fully utilized until a slot becomes available. With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and still valid. Since its use in fs/ufs is safe everywhere, it should be preferred. Therefore, replace kmap() with kmap_local_page() in fs/ufs. kunmap_local() requires the mapping address, so return that address from ufs_get_page() to be used in ufs_put_page(). Suggested-by: Al Viro Suggested-by: Ira Weiny Signed-off-by: Fabio M. De Francesco --- fs/ufs/dir.c | 75 ++++++++++++++++++++++++++++++++-------------------- 1 file changed, 46 insertions(+), 29 deletions(-) diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index d1cbb48e5d52..f83071a74bef 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c @@ -61,9 +61,9 @@ static int ufs_commit_chunk(struct page *page, loff_t pos= , unsigned len) return err; } =20 -static inline void ufs_put_page(struct page *page) +static inline void ufs_put_page(struct page *page, void *page_addr) { - kunmap(page); + kunmap((void *)((unsigned long)page_addr & PAGE_MASK)); put_page(page); } =20 @@ -76,7 +76,7 @@ ino_t ufs_inode_by_name(struct inode *dir, const struct q= str *qstr) de =3D ufs_find_entry(dir, qstr, &page); if (de) { res =3D fs32_to_cpu(dir->i_sb, de->d_ino); - ufs_put_page(page); + ufs_put_page(page, de); } return res; } @@ -99,18 +99,17 @@ void ufs_set_link(struct inode *dir, struct ufs_dir_ent= ry *de, ufs_set_de_type(dir->i_sb, de, inode->i_mode); =20 err =3D ufs_commit_chunk(page, pos, len); - ufs_put_page(page); + ufs_put_page(page, de); if (update_times) dir->i_mtime =3D dir->i_ctime =3D current_time(dir); mark_inode_dirty(dir); } =20 =20 -static bool ufs_check_page(struct page *page) +static bool ufs_check_page(struct page *page, char *kaddr) { struct inode *dir =3D page->mapping->host; struct super_block *sb =3D dir->i_sb; - char *kaddr =3D page_address(page); unsigned offs, rec_len; unsigned limit =3D PAGE_SIZE; const unsigned chunk_mask =3D UFS_SB(sb)->s_uspi->s_dirblksize - 1; @@ -185,21 +184,30 @@ static bool ufs_check_page(struct page *page) return false; } =20 +/* + * Calls to ufs_get_page()/ufs_put_page() must be nested according to the + * rules documented in kmap_local_page()/kunmap_local(). + * + * NOTE: ufs_find_entry() and ufs_dotdot() act as calls to ufs_get_page() + * and must be treated accordingly for nesting purposes. + */ static void *ufs_get_page(struct inode *dir, unsigned long n, struct page = **page) { + char *kaddr; + struct address_space *mapping =3D dir->i_mapping; *page =3D read_mapping_page(mapping, n, NULL); if (!IS_ERR(*page)) { - kmap(*page); + kaddr =3D kmap_local_page(*page); if (unlikely(!PageChecked(*page))) { - if (!ufs_check_page(*page)) + if (!ufs_check_page(*page, kaddr)) goto fail; } } - return page_address(*page); + return kaddr; =20 fail: - ufs_put_page(*page); + ufs_put_page(*page, kaddr); return ERR_PTR(-EIO); } =20 @@ -225,6 +233,13 @@ ufs_next_entry(struct super_block *sb, struct ufs_dir_= entry *p) fs16_to_cpu(sb, p->d_reclen)); } =20 +/* + * Calls to ufs_get_page()/ufs_put_page() must be nested according to the + * rules documented in kmap_local_page()/kunmap_local(). + * + * ufs_dotdot() acts as a call to ufs_get_page() and must be treated + * accordingly for nesting purposes. + */ struct ufs_dir_entry *ufs_dotdot(struct inode *dir, struct page **p) { struct ufs_dir_entry *de =3D ufs_get_page(dir, 0, p); @@ -236,12 +251,15 @@ struct ufs_dir_entry *ufs_dotdot(struct inode *dir, s= truct page **p) } =20 /* - * ufs_find_entry() + * Finds an entry in the specified directory with the wanted name. It retu= rns a + * pointer to the directory's entry. The page in which the entry was found= is + * in the res_page out parameter. The page is returned mapped and unlocked. + * The entry is guaranteed to be valid. * - * finds an entry in the specified directory with the wanted name. It - * returns the page in which the entry was found, and the entry itself - * (as a parameter - res_dir). Page is returned mapped and unlocked. - * Entry is guaranteed to be valid. + * On Success ufs_put_page() should be called on *res_page. + * + * ufs_find_entry() acts as a call to ufs_get_page() and must be treated + * accordingly for nesting purposes. */ struct ufs_dir_entry *ufs_find_entry(struct inode *dir, const struct qstr = *qstr, struct page **res_page) @@ -280,7 +298,7 @@ struct ufs_dir_entry *ufs_find_entry(struct inode *dir,= const struct qstr *qstr, goto found; de =3D ufs_next_entry(sb, de); } - ufs_put_page(page); + ufs_put_page(page, kaddr); } if (++n >=3D npages) n =3D 0; @@ -358,7 +376,7 @@ int ufs_add_link(struct dentry *dentry, struct inode *i= node) de =3D (struct ufs_dir_entry *) ((char *) de + rec_len); } unlock_page(page); - ufs_put_page(page); + ufs_put_page(page, kaddr); } BUG(); return -EINVAL; @@ -388,7 +406,7 @@ int ufs_add_link(struct dentry *dentry, struct inode *i= node) mark_inode_dirty(dir); /* OFFSET_CACHE */ out_put: - ufs_put_page(page); + ufs_put_page(page, kaddr); return err; out_unlock: unlock_page(page); @@ -466,13 +484,13 @@ ufs_readdir(struct file *file, struct dir_context *ct= x) ufs_get_de_namlen(sb, de), fs32_to_cpu(sb, de->d_ino), d_type)) { - ufs_put_page(page); + ufs_put_page(page, kaddr); return 0; } } ctx->pos +=3D fs16_to_cpu(sb, de->d_reclen); } - ufs_put_page(page); + ufs_put_page(page, kaddr); } return 0; } @@ -483,10 +501,10 @@ ufs_readdir(struct file *file, struct dir_context *ct= x) * previous entry. */ int ufs_delete_entry(struct inode *inode, struct ufs_dir_entry *dir, - struct page * page) + struct page *page) { struct super_block *sb =3D inode->i_sb; - char *kaddr =3D page_address(page); + char *kaddr =3D (char *)((unsigned long)dir & PAGE_MASK); unsigned int from =3D offset_in_page(dir) & ~(UFS_SB(sb)->s_uspi->s_dirbl= ksize - 1); unsigned int to =3D offset_in_page(dir) + fs16_to_cpu(sb, dir->d_reclen); loff_t pos; @@ -525,7 +543,7 @@ int ufs_delete_entry(struct inode *inode, struct ufs_di= r_entry *dir, inode->i_ctime =3D inode->i_mtime =3D current_time(inode); mark_inode_dirty(inode); out: - ufs_put_page(page); + ufs_put_page(page, kaddr); UFSD("EXIT\n"); return err; } @@ -549,8 +567,7 @@ int ufs_make_empty(struct inode * inode, struct inode *= dir) goto fail; } =20 - kmap(page); - base =3D (char*)page_address(page); + base =3D kmap_local_page(page); memset(base, 0, PAGE_SIZE); =20 de =3D (struct ufs_dir_entry *) base; @@ -567,7 +584,7 @@ int ufs_make_empty(struct inode * inode, struct inode *= dir) de->d_reclen =3D cpu_to_fs16(sb, chunk_size - UFS_DIR_REC_LEN(1)); ufs_set_de_namlen(sb, de, 2); strcpy (de->d_name, ".."); - kunmap(page); + kunmap_local(base); =20 err =3D ufs_commit_chunk(page, 0, chunk_size); fail: @@ -583,9 +600,9 @@ int ufs_empty_dir(struct inode * inode) struct super_block *sb =3D inode->i_sb; struct page *page =3D NULL; unsigned long i, npages =3D dir_pages(inode); + char *kaddr; =20 for (i =3D 0; i < npages; i++) { - char *kaddr; struct ufs_dir_entry *de; =20 kaddr =3D ufs_get_page(inode, i, &page); @@ -618,12 +635,12 @@ int ufs_empty_dir(struct inode * inode) } de =3D ufs_next_entry(sb, de); } - ufs_put_page(page); + ufs_put_page(page, kaddr); } return 1; =20 not_empty: - ufs_put_page(page); + ufs_put_page(page, kaddr); return 0; } =20 --=20 2.38.1