From nobody Thu Sep 18 02:47:29 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F2FC001B2 for ; Sun, 11 Dec 2022 22:36:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbiLKWgG (ORCPT ); Sun, 11 Dec 2022 17:36:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbiLKWgE (ORCPT ); Sun, 11 Dec 2022 17:36:04 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18A1B647A; Sun, 11 Dec 2022 14:36:00 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EA8331BF203; Sun, 11 Dec 2022 22:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1670798159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0KOJ4zXaURWQnHMs6xWhQytHCPi+wcBSN7++KVZzNTo=; b=WsR+8U2YYoaDuVTH9ziqyRgpeTA8yZytk7/aT645Mgxo/vWm5ULpphN7rc/EMia058f0fc o0vr0grLYLQeQAFEjiMoyWyfXfTnzQZE8n+Ms3v9wYsMt0PgPa5In+wySB4cFnlI9UgAge 073viXQIRhy/3ZIVmv/e7QTK+CNE9SbbXw7pkIv92W/70JqlAtmq5i+CzhcGEf+9dZ7FNc ao8+ouCN4+tEBTqrWsXvMJe4QDB/Kpi0+pLrEabAXjnXYYwCPYVrW0Y6rOKtdUqH55yW7t 1MPam4omzWoarxbYesoXHHulK/64DbtRpLgxrn/WD9905ihN0+LjxVosPZ9noA== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni , Michael McCormick Cc: Janne Terho , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: pcf85063: fix pcf85063_clkout_control Date: Sun, 11 Dec 2022 23:35:53 +0100 Message-Id: <20221211223553.59955-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Alexandre Belloni pcf85063_clkout_control reads the wrong register but then update the correct one. Reported-by: Janne Terho Fixes: 8c229ab6048b ("rtc: pcf85063: Add pcf85063 clkout control to common = clock framework") Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85063.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 99f9cc57c7b3..754e03984f98 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -424,7 +424,7 @@ static int pcf85063_clkout_control(struct clk_hw *hw, b= ool enable) unsigned int buf; int ret; =20 - ret =3D regmap_read(pcf85063->regmap, PCF85063_REG_OFFSET, &buf); + ret =3D regmap_read(pcf85063->regmap, PCF85063_REG_CTRL2, &buf); if (ret < 0) return ret; buf &=3D PCF85063_REG_CLKO_F_MASK; --=20 2.38.1