From nobody Mon Apr 13 08:23:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF8BEC4332F for ; Thu, 8 Dec 2022 13:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbiLHNJQ (ORCPT ); Thu, 8 Dec 2022 08:09:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbiLHNJM (ORCPT ); Thu, 8 Dec 2022 08:09:12 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D1BB2BB29 for ; Thu, 8 Dec 2022 05:09:11 -0800 (PST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NSZGB2xRYz15NBp; Thu, 8 Dec 2022 21:08:18 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 8 Dec 2022 21:09:08 +0800 From: Yuan Can To: , , , CC: Subject: [PATCH v2] mfd: sm501: Fix error handling in sm501_base_init() Date: Thu, 8 Dec 2022 13:06:40 +0000 Message-ID: <20221208130640.74125-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A problem about modprobe sm501 failed is triggered with the following log given: [ 4919.196338] Error: Driver 'sm501' is already registered, aborting... insmod: ERROR: could not insert module sm501.ko: Device or resource busy The reason is that sm501_base_init() returns pci_register_driver() directly without checking its return value, if pci_register_driver() failed, it returns without unregistering sm501_plat_driver, resulting the sm501 can never be installed later. A simple call graph is shown as below: sm501_base_init() platform_driver_register() # sm501_plat_driver are registered pci_register_driver() driver_register() bus_add_driver() priv =3D kzalloc(...) # OOM happened # return without unregister sm501_plat_driver Fix by calling platform_driver_unregister() when pci_register_driver() returns error. Fixes: 158abca5f699 ("mfd: fix sm501 section mismatches") Signed-off-by: Yuan Can Acked-for-MFD-by: Lee Jones --- Changes in v2: - Add Lee Jones's acked-by drivers/mfd/sm501.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 3ac4508a6742..c1efa040e94e 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1726,7 +1726,13 @@ static int __init sm501_base_init(void) if (ret < 0) return ret; =20 - return pci_register_driver(&sm501_pci_driver); + ret =3D pci_register_driver(&sm501_pci_driver); + if (ret) { + platform_driver_unregister(&sm501_plat_driver); + return ret; + } + + return 0; } =20 static void __exit sm501_base_exit(void) --=20 2.17.1