From nobody Thu Sep 18 09:59:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA443C4708E for ; Wed, 7 Dec 2022 07:52:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbiLGHwn (ORCPT ); Wed, 7 Dec 2022 02:52:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbiLGHwk (ORCPT ); Wed, 7 Dec 2022 02:52:40 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F403AA185; Tue, 6 Dec 2022 23:52:38 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NRqJP4cf9z5BNS0; Wed, 7 Dec 2022 15:52:37 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2B77qTYw072323; Wed, 7 Dec 2022 15:52:29 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 7 Dec 2022 15:52:31 +0800 (CST) Date: Wed, 7 Dec 2022 15:52:31 +0800 (CST) X-Zmail-TransId: 2af96390463f7919a463 X-Mailer: Zmail v1.0 Message-ID: <202212071552316472938@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , Subject: =?UTF-8?B?W1BBVENIXSBpaW86IG1hZ25ldG9tZXRlcjogbWFnMzExMDogQ29udmVydCB0byB1c2Ugc3lzZnNfZW1pdF9hdCgpwqBBUEk=?= X-MAIL: mse-fl1.zte.com.cn 2B77qTYw072323 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 63904645.002 by FangMail milter! X-FangMail-Envelope: 1670399557/4NRqJP4cf9z5BNS0/63904645.002/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63904645.002/4NRqJP4cf9z5BNS0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/iio/magnetometer/mag3110.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/mag3110.c b/drivers/iio/magnetometer/= mag3110.c index 661176a885ad..6dcc68093535 100644 --- a/drivers/iio/magnetometer/mag3110.c +++ b/drivers/iio/magnetometer/mag3110.c @@ -121,8 +121,7 @@ static ssize_t mag3110_show_int_plus_micros(char *buf, size_t len =3D 0; while (n-- > 0) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, - "%d.%06d ", vals[n][0], vals[n][1]); + len +=3D sysfs_emit_at(buf, len, "%d.%06d ", vals[n][0], vals[n][1]); /* replace trailing space by newline */ buf[len - 1] =3D '\n'; --=20 2.25.1