From nobody Thu Sep 18 10:02:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6089CC352A1 for ; Wed, 7 Dec 2022 07:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbiLGHv0 (ORCPT ); Wed, 7 Dec 2022 02:51:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbiLGHvP (ORCPT ); Wed, 7 Dec 2022 02:51:15 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C71230554; Tue, 6 Dec 2022 23:51:14 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NRqGm6Y0Qz8R03d; Wed, 7 Dec 2022 15:51:12 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B77oxMU075141; Wed, 7 Dec 2022 15:50:59 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 7 Dec 2022 15:51:01 +0800 (CST) Date: Wed, 7 Dec 2022 15:51:01 +0800 (CST) X-Zmail-TransId: 2af9639045e552c97201 X-Mailer: Zmail v1.0 Message-ID: <202212071551017192888@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , Subject: =?UTF-8?B?W1BBVENIXSBpaW86IG1hZ25ldG9tZXRlcjogaG1jNTg0MzogQ29udmVydCB0byB1c2Ugc3lzZnNfZW1pdF9hdCgpwqBBUEk=?= X-MAIL: mse-fl2.zte.com.cn 2B77oxMU075141 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.137.novalocal with ID 639045F0.001 by FangMail milter! X-FangMail-Envelope: 1670399472/4NRqGm6Y0Qz8R03d/639045F0.001/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 639045F0.001/4NRqGm6Y0Qz8R03d Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen Reviewed-by: Andy Shevchenko --- drivers/iio/magnetometer/hmc5843_core.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetom= eter/hmc5843_core.c index c5521d61da29..134f6045e24a 100644 --- a/drivers/iio/magnetometer/hmc5843_core.c +++ b/drivers/iio/magnetometer/hmc5843_core.c @@ -274,9 +274,9 @@ ssize_t hmc5843_show_samp_freq_avail(struct device *dev, int i; for (i =3D 0; i < data->variant->n_regval_to_samp_freq; i++) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, - "%d.%d ", data->variant->regval_to_samp_freq[i][0], - data->variant->regval_to_samp_freq[i][1]); + len +=3D sysfs_emit_at(buf, len, "%d.%d ", + data->variant->regval_to_samp_freq[i][0], + data->variant->regval_to_samp_freq[i][1]); /* replace trailing space by newline */ buf[len - 1] =3D '\n'; @@ -335,8 +335,7 @@ static ssize_t hmc5843_show_scale_avail(struct device *= dev, int i; for (i =3D 0; i < data->variant->n_regval_to_nanoscale; i++) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, - "0.%09d ", data->variant->regval_to_nanoscale[i]); + len +=3D sysfs_emit_at(buf, len, "0.%09d ", data->variant->regval_to_nan= oscale[i]); /* replace trailing space by newline */ buf[len - 1] =3D '\n'; --=20 2.25.1