From nobody Thu Sep 18 10:01:07 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BACFC47089 for ; Wed, 7 Dec 2022 07:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbiLGHmJ (ORCPT ); Wed, 7 Dec 2022 02:42:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229814AbiLGHly (ORCPT ); Wed, 7 Dec 2022 02:41:54 -0500 Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E76E2CE30; Tue, 6 Dec 2022 23:41:53 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4NRq400Hg9z4y0ty; Wed, 7 Dec 2022 15:41:52 +0800 (CST) Received: from xaxapp03.zte.com.cn ([10.88.40.52]) by mse-fl1.zte.com.cn with SMTP id 2B77faks058631; Wed, 7 Dec 2022 15:41:36 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 7 Dec 2022 15:41:38 +0800 (CST) Date: Wed, 7 Dec 2022 15:41:38 +0800 (CST) X-Zmail-TransId: 2af9639043b27d9844c1 X-Mailer: Zmail v1.0 Message-ID: <202212071541387812582@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , Subject: =?UTF-8?B?W1BBVENIXSBpaW86IGxpZ2h0OiBiaDE3NTA6IENvbnZlcnQgdG8gdXNlIHN5c2ZzX2VtaXRfYXQoKSBBUEk=?= X-MAIL: mse-fl1.zte.com.cn 2B77faks058631 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.251.13.novalocal with ID 639043C0.000 by FangMail milter! X-FangMail-Envelope: 1670398912/4NRq400Hg9z4y0ty/639043C0.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 639043C0.000/4NRq400Hg9z4y0ty Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/iio/light/bh1750.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c index 390c5b3ad4f6..ab682865885d 100644 --- a/drivers/iio/light/bh1750.c +++ b/drivers/iio/light/bh1750.c @@ -194,8 +194,7 @@ static ssize_t bh1750_show_int_time_available(struct de= vice *dev, const struct bh1750_chip_info *chip_info =3D data->chip_info; for (i =3D chip_info->mtreg_min; i <=3D chip_info->mtreg_max; i +=3D chip= _info->inc) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "0.%06d ", - chip_info->mtreg_to_usec * i); + len +=3D sysfs_emit_at(buf, len, "0.%06d ", chip_info->mtreg_to_usec * i= ); buf[len - 1] =3D '\n'; --=20 2.25.1