From nobody Fri Dec 19 08:05:33 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D588C47090 for ; Tue, 6 Dec 2022 11:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235218AbiLFL5y (ORCPT ); Tue, 6 Dec 2022 06:57:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234345AbiLFL5o (ORCPT ); Tue, 6 Dec 2022 06:57:44 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C2A05FFE for ; Tue, 6 Dec 2022 03:57:41 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id vp12so5582732ejc.8 for ; Tue, 06 Dec 2022 03:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AsKoU9M+5cIpcCQPCOg/6Uvu2CSKHlAbnecsoPfhR2A=; b=S8E2gky0aD2LAAceaAf9+51yBgoDUwQ456G2qknYvpGcW+Lv1KIaqhFMZFAwnCxkyl mqYFr3NvLPQUJM8f5uQ+00DHBz5y9cw1EVN21AE5Mjg5n3j7GYGERfWykh5L5Q+epIrS iRxkfKU1jo2HLqGNC0K/ZUG7PbJrUxn1NPFJ3kYKaMlf9FWHnFPyI/IVhDDJ8pBX+9KJ Md/wa6c/nTFApV5QUcks/mV7ntMyjveqvnvIMgZDZRn9561Tktlawkq1bDl25OYYgGZn fs/oPsxBMD1bx1vwI/U1Op25szWAu96FHguNXJ4Fm36Zu2+t+1keu7i0nCwFSSiw7HZ1 RAcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AsKoU9M+5cIpcCQPCOg/6Uvu2CSKHlAbnecsoPfhR2A=; b=bN2BSVucIph+NQpJNlrBjwuWU4KQ7KPKKw3e1+gsAsxkpbepFi1/uCac4ToJYcvE0a arTntu5994Gw6jzaLksK/xfOUFLX5vhRNEVHSBjSNBsNys+BEGHKkzg0Mele9NJLa1aJ 6RFfyFVmzxoQ3LOzEpGLy/J3rtl5nR98RG1suxvI8+UYWcqUTHF+l8mhD6VJ6/Ohzkv7 BuHs7fJvNNdkHodNfRCE5A9BiPYs4JdpWiCPd7MPT+bQLqEDuN8Hhv5OXU/oLjgJ1RGO i7ZRmv/mpATjtuhigRa7G1QnnnUVwydKCkSjzJN53vUhJUkOjrBaiOxwmZBG8NvT6O/i Lrhg== X-Gm-Message-State: ANoB5pkaAJPYKY17ybzcW7JmzsBJVQQ+PZ/JSsaGuJ7GoTu+vcGBS1mn RRy/R3Y8oRqf7p98XOLNavJ7xw== X-Google-Smtp-Source: AA0mqf5EGw2ZYPiRp+1wOueTLChciZ1I3gaAecnWP7Tl3f1EVPz2ufk8vb8tJCbslJ98ULsN9W9cyA== X-Received: by 2002:a17:906:6acc:b0:78d:b371:16e5 with SMTP id q12-20020a1709066acc00b0078db37116e5mr58056102ejs.456.1670327860866; Tue, 06 Dec 2022 03:57:40 -0800 (PST) Received: from blmsp.fritz.box ([2001:4091:a245:805c:8713:84e4:2a9e:cbe8]) by smtp.gmail.com with ESMTPSA id ky20-20020a170907779400b007c0ac4e6b6esm6472076ejc.143.2022.12.06.03.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 03:57:40 -0800 (PST) From: Markus Schneider-Pargmann To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Wolfgang Grandegger Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH v2 06/11] can: m_can: Batch acknowledge transmit events Date: Tue, 6 Dec 2022 12:57:23 +0100 Message-Id: <20221206115728.1056014-7-msp@baylibre.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221206115728.1056014-1-msp@baylibre.com> References: <20221206115728.1056014-1-msp@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Transmit events from the txe fifo can be batch acknowledged by acknowledging the last read txe fifo item. This will save txe_count writes which is important for peripheral chips. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index a0ae543d418c..5572a6b3b94c 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1013,7 +1013,9 @@ static int m_can_echo_tx_event(struct net_device *dev) u32 txe_count =3D 0; u32 m_can_txefs; u32 fgi =3D 0; + int ack_fgi =3D -1; int i =3D 0; + int err =3D 0; unsigned int msg_mark; =20 struct m_can_classdev *cdev =3D netdev_priv(dev); @@ -1028,28 +1030,29 @@ static int m_can_echo_tx_event(struct net_device *d= ev) /* Get and process all sent elements */ for (i =3D 0; i < txe_count; i++) { u32 txe, timestamp =3D 0; - int err; =20 /* get message marker, timestamp */ err =3D m_can_txe_fifo_read(cdev, fgi, 4, &txe); if (err) { netdev_err(dev, "TXE FIFO read returned %d\n", err); - return err; + break; } =20 msg_mark =3D FIELD_GET(TX_EVENT_MM_MASK, txe); timestamp =3D FIELD_GET(TX_EVENT_TXTS_MASK, txe) << 16; =20 - /* ack txe element */ - m_can_write(cdev, M_CAN_TXEFA, FIELD_PREP(TXEFA_EFAI_MASK, - fgi)); + ack_fgi =3D fgi; fgi =3D (++fgi >=3D cdev->mcfg[MRAM_TXE].num ? 0 : fgi); =20 /* update stats */ m_can_tx_update_stats(cdev, msg_mark, timestamp); } =20 - return 0; + if (ack_fgi !=3D -1) + m_can_write(cdev, M_CAN_TXEFA, FIELD_PREP(TXEFA_EFAI_MASK, + ack_fgi)); + + return err; } =20 static irqreturn_t m_can_isr(int irq, void *dev_id) --=20 2.38.1