From nobody Thu Sep 18 13:14:21 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73026C352A1 for ; Tue, 6 Dec 2022 09:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233925AbiLFJcZ (ORCPT ); Tue, 6 Dec 2022 04:32:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232554AbiLFJcS (ORCPT ); Tue, 6 Dec 2022 04:32:18 -0500 Received: from mx.swemel.ru (mx.swemel.ru [95.143.211.150]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C96A1D0CB; Tue, 6 Dec 2022 01:32:17 -0800 (PST) From: Denis Arefev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1670319133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oCm3OMZIxqZDVn064joCmMPgJl8SxdgvibLxjtPgDRU=; b=DS94TmjNMU2BFTBVqyYOH3lkLVGzP9hJzb/sgawSRJT87V5TWsNIyLhkcEwO2xcWM00wFW Ni39B6aoijZqlmnyFgSVoCDx5pz+hcx2CMvZffTDu1VLVZzN0e03VpDcRXAZBlKZiFYRXF p47FCC3wBoDb7UMvfrNqsWiZobD0qjA= To: David Sterba Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, trufanov@swemel.ru, vfh@swemel.ru Subject: [PATCH] file: Added pointer check Date: Tue, 6 Dec 2022 12:32:13 +0300 Message-Id: <20221206093213.29050-1-arefev@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return value of a function 'affs_bread' is dereferenced at file.c:970 without checking for null, but it is usually checked for this function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- fs/affs/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/affs/file.c b/fs/affs/file.c index d91b0133d95d..4566fa767f65 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -963,6 +963,8 @@ affs_truncate(struct inode *inode) =20 while (ext_key) { ext_bh =3D affs_bread(sb, ext_key); + if (!ext_bh) + break; size =3D AFFS_SB(sb)->s_hashsize; if (size > blkcnt - blk) size =3D blkcnt - blk; --=20 2.25.1