From nobody Thu Sep 18 13:18:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F619C352A1 for ; Tue, 6 Dec 2022 07:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231590AbiLFHpi (ORCPT ); Tue, 6 Dec 2022 02:45:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiLFHpa (ORCPT ); Tue, 6 Dec 2022 02:45:30 -0500 Received: from mail.nfschina.com (unknown [124.16.136.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2BBEA11C14; Mon, 5 Dec 2022 23:45:28 -0800 (PST) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 9B1DB1E80D0E; Tue, 6 Dec 2022 15:41:10 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 67sWBfMGm1OG; Tue, 6 Dec 2022 15:41:08 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: liqiong@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 64DCD1E80D57; Tue, 6 Dec 2022 15:41:07 +0800 (CST) From: Li Qiong To: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, kernel-janitors@vger.kernel.org, coreteam@netfilter.org, Yu Zhe , Li Qiong Subject: [PATCH v2] netfilter: add a 'default' case to 'switch (tuplehash->tuple.xmit_type)' Date: Tue, 6 Dec 2022 15:44:14 +0800 Message-Id: <20221206074414.12208-1-liqiong@nfschina.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221202070331.10865-1-liqiong@nfschina.com> References: <20221202070331.10865-1-liqiong@nfschina.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add a 'default' case in case return a uninitialized value of ret. Signed-off-by: Li Qiong --- v2: Add 'default' case instead of initializing 'ret'. --- net/netfilter/nf_flow_table_ip.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table= _ip.c index b350fe9d00b0..19efba1e51ef 100644 --- a/net/netfilter/nf_flow_table_ip.c +++ b/net/netfilter/nf_flow_table_ip.c @@ -421,6 +421,10 @@ nf_flow_offload_ip_hook(void *priv, struct sk_buff *sk= b, if (ret =3D=3D NF_DROP) flow_offload_teardown(flow); break; + default: + WARN_ON_ONCE(1); + ret =3D NF_DROP; + break; } =20 return ret; @@ -682,6 +686,10 @@ nf_flow_offload_ipv6_hook(void *priv, struct sk_buff *= skb, if (ret =3D=3D NF_DROP) flow_offload_teardown(flow); break; + default: + WARN_ON_ONCE(1); + ret =3D NF_DROP; + break; } =20 return ret; --=20 2.11.0