From nobody Thu Sep 18 12:51:00 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337FCC47089 for ; Mon, 5 Dec 2022 22:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233828AbiLEWcu (ORCPT ); Mon, 5 Dec 2022 17:32:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233500AbiLEWcj (ORCPT ); Mon, 5 Dec 2022 17:32:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E7A6A18D; Mon, 5 Dec 2022 14:32:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 40256B8159B; Mon, 5 Dec 2022 22:32:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A51E1C433D7; Mon, 5 Dec 2022 22:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670279554; bh=twc81D3fz7hgH5I0d5mqqU6YSPMlz+/dTZIQZDfy3pY=; h=From:To:Cc:Subject:Date:From; b=LmerRZV1yaSepemQWm8AsmqLnoTj4/lTY0q34Yb/8YKlo5a8O8Xk1+5bQfheq+sRw DbOyfO088yMPdTdQuZL6bKyMArPbJVC68puDWA6Z+AHF1lGfwl0FYQq/eyV3tsW6AV TQ5yibbN3XqA2dC9Yy4xptxyNfc28Z7VtRy/Yrihy9X03K+szly0SMw6ZKwLoI3BKN xD3HVB6YMlXJ+oszsN3RJRUyq2SJQPQHzjLuw3vMzyZ+clEY5GFuwRpt0QkG2YAG24 FicPqbbd2MiV6tOkvUvWeX7eGIdx5sacqW2YKsToy4vt5Kd7ZrARpXafeD9Gfsm3AG ACoDPBW/nfdJA== From: Bjorn Helgaas To: Frederic Barrat , Andrew Donnellan Cc: Arnd Bergmann , Greg Kroah-Hartman , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH] cxl: Remove unnecessary cxl_pci_window_alignment() Date: Mon, 5 Dec 2022 16:32:31 -0600 Message-Id: <20221205223231.1268085-1-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Bjorn Helgaas cxl_pci_window_alignment() is referenced only via the struct pci_controller_ops.window_alignment function pointer, and only in the powerpc implementation of pcibios_window_alignment(). pcibios_window_alignment() defaults to returning 1 if the function pointer is NULL, which is the same was what cxl_pci_window_alignment() does. cxl_pci_window_alignment() is unnecessary, so remove it. No functional change intended. Signed-off-by: Bjorn Helgaas Acked-by: Frederic Barrat --- drivers/misc/cxl/vphb.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c index 1264253cc07b..6332db8044bd 100644 --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -67,12 +67,6 @@ static void cxl_pci_disable_device(struct pci_dev *dev) } } =20 -static resource_size_t cxl_pci_window_alignment(struct pci_bus *bus, - unsigned long type) -{ - return 1; -} - static void cxl_pci_reset_secondary_bus(struct pci_dev *dev) { /* Should we do an AFU reset here ? */ @@ -200,7 +194,6 @@ static struct pci_controller_ops cxl_pci_controller_ops= =3D .enable_device_hook =3D cxl_pci_enable_device_hook, .disable_device =3D cxl_pci_disable_device, .release_device =3D cxl_pci_disable_device, - .window_alignment =3D cxl_pci_window_alignment, .reset_secondary_bus =3D cxl_pci_reset_secondary_bus, .setup_msi_irqs =3D cxl_setup_msi_irqs, .teardown_msi_irqs =3D cxl_teardown_msi_irqs, --=20 2.25.1