From nobody Fri Apr 17 10:42:05 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9FAC4321E for ; Fri, 2 Dec 2022 12:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233280AbiLBMKV (ORCPT ); Fri, 2 Dec 2022 07:10:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233096AbiLBMKT (ORCPT ); Fri, 2 Dec 2022 07:10:19 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E9A3C6E0 for ; Fri, 2 Dec 2022 04:09:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669982968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QDs0C2fmxqmYDWtpSHD/g/vXtX88DZ2gNF8Y6fio0uk=; b=UJ9lAdM4NVBdvGXkmh68QNIoClp/8Nfcy/vNtG63sZFmsSRQzsvJyGzblDD2oynyHz5OIF E60wz0F43au+YyxCT9tzNxWhQWn978N3M6uSwtP9zYI8Vak50HJJp4Hcy8r8ATQBwLdcPR bKLC+u6+m5NgpuV6vAG+qKNz0/7GD9g= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-422-AAoeAptbM5u8UosBRi2QyA-1; Fri, 02 Dec 2022 07:09:27 -0500 X-MC-Unique: AAoeAptbM5u8UosBRi2QyA-1 Received: by mail-qt1-f200.google.com with SMTP id s14-20020a05622a1a8e00b00397eacd9c1aso17622107qtc.21 for ; Fri, 02 Dec 2022 04:09:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QDs0C2fmxqmYDWtpSHD/g/vXtX88DZ2gNF8Y6fio0uk=; b=c9TeAramYPsAB+aa89rK452P16GpID3WmFb2Ab+nDdyjPeRGKtmP0KXrJc3Bud/PS0 8onPmVW+BlSN6bBiXOGuxyGvonvqpP9uxSkKW/mMA2HqEynlITk5lZOux7g5vJPwx+QG QQbGr7jNF04cwDfNFwDnv6Z3CM/O6kxQQ8tIlHeD0T2CPqsshYwaoPmD7TXF3WJ71XSd LefCb0pWlFUxlKDfjQnWhdwVQ4k7jIrJUhkvlWCuzI61Or2JnFfAodGm2/FbKlbxfgwL U/EnHbXeUCjLDJyi9r+O9dnSvTjmSIaFkG/u8KAeSLUfmA/lBz3l0wRgGPsl4p7Q6IX4 qpfA== X-Gm-Message-State: ANoB5pkHqaXq8ppqbpLDGIi+q1Qf3p8WWk5dUEM5nGY2bpJWyWoWSvNY KJ2cfLLNsLzABVf7pUnQRA7WchxLPFPCPdCoaego0OnLvA4Yjij9LoBgbG2PWfigLEuZXSGFtVG bh97V6TO8ic3UH5B38p6ZXVHk X-Received: by 2002:a05:620a:1905:b0:6fa:6636:a7b0 with SMTP id bj5-20020a05620a190500b006fa6636a7b0mr45631027qkb.55.1669982967000; Fri, 02 Dec 2022 04:09:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf5YjcswExkGO5i/b6YuVbtoxUr2ScSuUSv0DFJoBnnNxIWpoRhXwG58o2w4w5CQEhpadbF0RQ== X-Received: by 2002:a05:620a:1905:b0:6fa:6636:a7b0 with SMTP id bj5-20020a05620a190500b006fa6636a7b0mr45631006qkb.55.1669982966736; Fri, 02 Dec 2022 04:09:26 -0800 (PST) Received: from x1.redhat.com (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id f21-20020a05620a409500b006b953a7929csm5515218qko.73.2022.12.02.04.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 04:09:26 -0800 (PST) From: Brian Masney To: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_shazhuss@quicinc.com, psodagud@quicinc.com, ahalaney@redhat.com, echanude@redhat.com Subject: [PATCH v3] arm64: dts: qcom: sa8540p-ride: enable PCIe support Date: Fri, 2 Dec 2022 07:09:18 -0500 Message-Id: <20221202120918.2252647-1-bmasney@redhat.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the vreg_l11a, pcie3a, pcie3a_phy, and tlmm nodes that are necessary in order to get PCIe working on the QDrive3. This patch also increases the width of the ranges property for the PCIe switch that's found on this platform. Note that this change requires the latest trustzone (TZ) firmware that's available from Qualcomm as of November 2022. If this is used against a board with the older firmware, then the board will go into ramdump mode when PCIe is probed on startup. The ranges property is overridden in this sa8540p-ride.dts file since this is what's used to describe the QDrive3 variant with dual SoCs. There's another variant of this board that only has a single SoC where this change is not applicable, and hence why this specific change was not done in sa8540p.dtsi. These changes were derived from various patches that Qualcomm delivered to Red Hat in a downstream kernel. Signed-off-by: Brian Masney Tested-by: Andrew Halaney Tested-by: Shazad Hussain --- Changes since v2: - Dropped regulator-allow-set-load (Bjorn) - Updated first member of ranges property to match downstream: s/0x32200000/0x40200000/ (Andrew) Changes since v1: - Add -state and -pins suffixes to tlmm (Krzysztof) This patch depends on the following series that hasn't made it's way into linux-next yet: [PATCH v10 0/2] arm64: dts: qcom: add dts for sa8540p-ride board https://lore.kernel.org/lkml/20221118025158.16902-1-quic_ppareek@quicinc.co= m/ I can't find the specific TZ firmware version that we have so that's why I included the date instead. arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 53 +++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dt= s/qcom/sa8540p-ride.dts index a5f87a8629d6..a638e3784543 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -51,6 +51,13 @@ vreg_l7a: ldo7 { regulator-initial-mode =3D ; }; =20 + vreg_l11a: ldo11 { + regulator-name =3D "vreg_l11a"; + regulator-min-microvolt =3D <880000>; + regulator-max-microvolt =3D <880000>; + regulator-initial-mode =3D ; + }; + vreg_l13a: ldo13 { regulator-name =3D "vreg_l13a"; regulator-min-microvolt =3D <3072000>; @@ -139,6 +146,27 @@ vreg_l8g: ldo8 { }; }; =20 +&pcie3a { + ranges =3D <0x01000000 0x0 0x40200000 0x0 0x40200000 0x0 0x100000>, + <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x20000000>, + <0x03000000 0x6 0x00000000 0x6 0x00000000 0x2 0x00000000>; + + perst-gpios =3D <&tlmm 151 GPIO_ACTIVE_LOW>; + wake-gpios =3D <&tlmm 56 GPIO_ACTIVE_HIGH>; + + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pcie3a_default>; + + status =3D "okay"; +}; + +&pcie3a_phy { + vdda-phy-supply =3D <&vreg_l11a>; + vdda-pll-supply =3D <&vreg_l3a>; + + status =3D "okay"; +}; + &qup2 { status =3D "okay"; }; @@ -158,6 +186,31 @@ &remoteproc_nsp1 { status =3D "okay"; }; =20 +&tlmm { + pcie3a_default: pcie3a-default-state { + perst-pins { + pins =3D "gpio151"; + function =3D "gpio"; + drive-strength =3D <2>; + bias-pull-down; + }; + + clkreq-pins { + pins =3D "gpio150"; + function =3D "pcie3a_clkreq"; + drive-strength =3D <2>; + bias-pull-up; + }; + + wake-pins { + pins =3D "gpio56"; + function =3D "gpio"; + drive-strength =3D <2>; + bias-pull-up; + }; + }; +}; + &ufs_mem_hc { reset-gpios =3D <&tlmm 228 GPIO_ACTIVE_LOW>; =20 --=20 2.38.1