From nobody Thu Sep 18 21:41:45 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E39AC3A5A7 for ; Fri, 2 Dec 2022 02:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbiLBCmY (ORCPT ); Thu, 1 Dec 2022 21:42:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbiLBCmV (ORCPT ); Thu, 1 Dec 2022 21:42:21 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CCFD11FA for ; Thu, 1 Dec 2022 18:42:20 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NNcfg35Hrz4xVnn; Fri, 2 Dec 2022 10:42:19 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B22g3kg039926; Fri, 2 Dec 2022 10:42:03 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Fri, 2 Dec 2022 10:42:04 +0800 (CST) Date: Fri, 2 Dec 2022 10:42:04 +0800 (CST) X-Zmail-TransId: 2af9638965fcffffffff86bec3ce X-Mailer: Zmail v1.0 Message-ID: <202212021042043546303@zte.com.cn> Mime-Version: 1.0 From: To: , Cc: , , , Subject: =?UTF-8?B?W1BBVENIIGxpbnV4LW5leHQgdjJdIHB4YTogUmVtb3ZlIGRldl9lcnIoKSBhZnRlciBwbGF0Zm9ybV9nZXRfaXJxKCk=?= X-MAIL: mse-fl2.zte.com.cn 2B22g3kg039926 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 6389660B.000 by FangMail milter! X-FangMail-Envelope: 1669948939/4NNcfg35Hrz4xVnn/6389660B.000/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6389660B.000/4NNcfg35Hrz4xVnn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: zhang songyi There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. Signed-off-by: zhang songyi Reviewed-by: Lubomir Rintel --- drivers/soc/pxa/ssp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index 93449fb3519e..bd029e838241 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev) } ssp->irq =3D platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - } if (dev->of_node) { const struct of_device_id *id =3D --=20 2.15.2