From nobody Thu Sep 18 23:14:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCB3C47088 for ; Thu, 1 Dec 2022 05:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbiLAFvV (ORCPT ); Thu, 1 Dec 2022 00:51:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbiLAFvR (ORCPT ); Thu, 1 Dec 2022 00:51:17 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 23504A6B45; Wed, 30 Nov 2022 21:51:15 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 070FBD6E; Wed, 30 Nov 2022 21:51:22 -0800 (PST) Received: from a077893.blr.arm.com (unknown [10.162.43.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 935B93F73D; Wed, 30 Nov 2022 21:51:11 -0800 (PST) From: Anshuman Khandual To: linux-kernel@vger.kernel.org Cc: james.clark@arm.com, Anshuman Khandual , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org Subject: [PATCH] perf/core: Reset remaining bits in perf_clear_branch_entry_bitfields() Date: Thu, 1 Dec 2022 11:21:03 +0530 Message-Id: <20221201055103.302019-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" perf_clear_branch_entry_bitfields() resets all struct perf_branch_entry bit fields before capturing branch records. This resets remaining bit fields except 'new_type', which is valid only when 'type' is PERF_BR_EXTEND_ABI. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: linux-perf-users@vger.kernel.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual Reviewed-by: James Clark --- This applies on v6.1-rc6 'perf_branch_entry.new_type' can remain uninitialized as explained earlier. Also there is no PERF_BR_NEW_UNKNOWN to spare, because 'perf_branch_entry. new_type' enumeration starts at PERF_BR_NEW_FAULT_ALGN, to save a position for the extended branch types instead. include/linux/perf_event.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 0031f7b4d9ab..c97b5f6f77a4 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1110,8 +1110,9 @@ static inline void perf_clear_branch_entry_bitfields(= struct perf_branch_entry *b br->in_tx =3D 0; br->abort =3D 0; br->cycles =3D 0; - br->type =3D 0; + br->type =3D PERF_BR_UNKNOWN; br->spec =3D PERF_BR_SPEC_NA; + br->priv =3D PERF_BR_PRIV_UNKNOWN; br->reserved =3D 0; } =20 --=20 2.25.1