From nobody Fri Sep 19 02:38:33 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54093C4321E for ; Wed, 30 Nov 2022 08:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236672AbiK3Ipt (ORCPT ); Wed, 30 Nov 2022 03:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236924AbiK3IpV (ORCPT ); Wed, 30 Nov 2022 03:45:21 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F95630F58; Wed, 30 Nov 2022 00:45:15 -0800 (PST) Received: from ykarpov.intra.ispras.ru (unknown [10.10.2.71]) by mail.ispras.ru (Postfix) with ESMTPSA id 7867A40D403D; Wed, 30 Nov 2022 08:45:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 7867A40D403D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1669797911; bh=r3Rg2YhNmfjZGaScA5OcxaOz3tJEP+T11CxUAPtKqrI=; h=From:To:Cc:Subject:Date:From; b=hpkfxYnEjSReIcIiVajn4hcK9ueNnjTwjcBMwyyLcH2d2JVxpcir1hX6UbqGcZ+FU xnIAYlSTYc2dj6/fddzRKpFupf/qZpbwweZHBbWkJasQdHk7pRoKwOuHZWRmAeA+Xa rvuXQOSRN537ymkTDz1fh8AFggEIQBkUGtSe4aRU= From: Yuri Karpov To: Andrew Lunn Cc: Yuri Karpov , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] net: dsa: fix NULL pointer dereference in seq_match() Date: Wed, 30 Nov 2022 11:44:31 +0300 Message-Id: <20221130084431.3299054-1-YKarpov@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" ptp_parse_header() result is not checked in seq_match() that can lead to NULL pointer dereferense. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c6fe0ad2c349 ("net: dsa: mv88e6xxx: add rx/tx timestamping support") Signed-off-by: Yuri Karpov Reviewed-by: Pavan Chebbi --- drivers/net/dsa/mv88e6xxx/hwtstamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/hwtstamp.c b/drivers/net/dsa/mv88e6x= xx/hwtstamp.c index 331b4ca089ff..97f30795a2bb 100644 --- a/drivers/net/dsa/mv88e6xxx/hwtstamp.c +++ b/drivers/net/dsa/mv88e6xxx/hwtstamp.c @@ -246,7 +246,7 @@ static int seq_match(struct sk_buff *skb, u16 ts_seqid) =20 hdr =3D ptp_parse_header(skb, type); =20 - return ts_seqid =3D=3D ntohs(hdr->sequence_id); + return hdr ? ts_seqid =3D=3D ntohs(hdr->sequence_id) : 0; } =20 static void mv88e6xxx_get_rxts(struct mv88e6xxx_chip *chip, --=20 2.34.1