From nobody Sat Sep 21 07:53:06 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA67C4321E for ; Wed, 30 Nov 2022 07:53:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234230AbiK3Hxi (ORCPT ); Wed, 30 Nov 2022 02:53:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234221AbiK3Hxg (ORCPT ); Wed, 30 Nov 2022 02:53:36 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEDB513E3C; Tue, 29 Nov 2022 23:53:34 -0800 (PST) Received: from kwepemi500014.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NMWdw2Ht0zRpfP; Wed, 30 Nov 2022 15:52:52 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by kwepemi500014.china.huawei.com (7.221.188.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 30 Nov 2022 15:53:31 +0800 From: Qiheng Lin To: , CC: , , , , Qiheng Lin Subject: [PATCH] media: platform: mtk-mdp3: Fix return value check in mdp_probe() Date: Wed, 30 Nov 2022 16:13:12 +0800 Message-ID: <20221130081312.35523-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500014.china.huawei.com (7.221.188.232) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In case of error, the function mtk_mutex_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver") Signed-off-by: Qiheng Lin --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers= /media/platform/mediatek/mdp3/mtk-mdp3-core.c index c413e59d4286..7a2d992dd842 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c @@ -207,8 +207,8 @@ static int mdp_probe(struct platform_device *pdev) } for (i =3D 0; i < MDP_PIPE_MAX; i++) { mdp->mdp_mutex[i] =3D mtk_mutex_get(&mm_pdev->dev); - if (!mdp->mdp_mutex[i]) { - ret =3D -ENODEV; + if (IS_ERR(mdp->mdp_mutex[i])) { + ret =3D PTR_ERR(mdp->mdp_mutex[i]); goto err_return; } } --=20 2.32.0