From nobody Fri Sep 19 03:48:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E45C433FE for ; Tue, 29 Nov 2022 19:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236718AbiK2TUD (ORCPT ); Tue, 29 Nov 2022 14:20:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236780AbiK2TTM (ORCPT ); Tue, 29 Nov 2022 14:19:12 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 051456D48F for ; Tue, 29 Nov 2022 11:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XJfb607OEPZzj5jgkFphMZxTPqxtnHJHM51G7bS3xhg=; b=NHeNnfajuJj9RKYJuLwf++m+ogVpTx5mJDmSLqyL7XYR/Sv/A8mIz8XsTQlKwTWAcwC8L5 tMJKHInbAvfNrr0xxTdaa88NpD4bqf3cgKpPG+SlGkoBYqtCAlbq9OrAHuYzYK1wmkiCp5 mMJ22m4Cwp4riY9CkZMFeJsyHG6w47c= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 07/26] drm: mxsfb: Define and use generic PM ops Date: Tue, 29 Nov 2022 19:17:14 +0000 Message-Id: <20221129191733.137897-8-paul@crapouillou.net> In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a "struct dev_pm_ops" that can be used by this driver, instead of using custom PM callbacks with the same behaviour. v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an exported dev_pm_ops. Signed-off-by: Paul Cercueil Reviewed-by: Marek Vasut --- Cc: Marek Vasut Cc: Stefan Agner Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsf= b_drv.c index 810edea0a31e..c63d2eb3b379 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -398,25 +398,7 @@ static void mxsfb_shutdown(struct platform_device *pde= v) drm_atomic_helper_shutdown(drm); } =20 -#ifdef CONFIG_PM_SLEEP -static int mxsfb_suspend(struct device *dev) -{ - struct drm_device *drm =3D dev_get_drvdata(dev); - - return drm_mode_config_helper_suspend(drm); -} - -static int mxsfb_resume(struct device *dev) -{ - struct drm_device *drm =3D dev_get_drvdata(dev); - - return drm_mode_config_helper_resume(drm); -} -#endif - -static const struct dev_pm_ops mxsfb_pm_ops =3D { - SET_SYSTEM_SLEEP_PM_OPS(mxsfb_suspend, mxsfb_resume) -}; +DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(mxsfb_pm_ops); =20 static struct platform_driver mxsfb_platform_driver =3D { .probe =3D mxsfb_probe, @@ -425,7 +407,7 @@ static struct platform_driver mxsfb_platform_driver =3D= { .driver =3D { .name =3D "mxsfb", .of_match_table =3D mxsfb_dt_ids, - .pm =3D &mxsfb_pm_ops, + .pm =3D pm_sleep_ptr(&mxsfb_pm_ops), }, }; =20 --=20 2.35.1