From nobody Fri Sep 19 09:21:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273E2C4332F for ; Fri, 25 Nov 2022 13:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbiKYN2F (ORCPT ); Fri, 25 Nov 2022 08:28:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiKYN2B (ORCPT ); Fri, 25 Nov 2022 08:28:01 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABB0F20F5B; Fri, 25 Nov 2022 05:27:59 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 60B861F8D5; Fri, 25 Nov 2022 13:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669382878; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gHRjihEIn9Cp9Gu2BUUhHxdO/VDWVhUBtMD1MJ0iOIA=; b=VJ7+sL5VxdP0Kdv+71iYChbm3Xgags4EH2dQMXSrDfRum4ZI0ZTE3KHvmil3QzsF0EWSX9 N0UgobqVTlvEoszJNbDMCbhzShLGHZrXyUptpitxev36DyiGhuYb8GAv9e06k/MjACy3IU tzJl9Ol7Ibqj24Yv4t6kzZD1cKGaCxM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669382878; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gHRjihEIn9Cp9Gu2BUUhHxdO/VDWVhUBtMD1MJ0iOIA=; b=iiSLh3Kq4T1LNO9fmIfIGGidAxQuvXCR4VBaMO1rvCAGb/WVG1BOHnD0T7KV1d+I/41YRj eO/Fwwgx3HQrbUCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 201561361C; Fri, 25 Nov 2022 13:27:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gkZBBt7CgGP3TAAAMHmgww (envelope-from ); Fri, 25 Nov 2022 13:27:58 +0000 Date: Fri, 25 Nov 2022 14:27:56 +0100 From: Jean Delvare To: linux-serial@vger.kernel.org Cc: LKML , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Greg Kroah-Hartman Subject: [PATCH] serial: liteuart: drop obsolete dependency on COMPILE_TEST Message-ID: <20221125142756.3e51a28d@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues. Signed-off-by: Jean Delvare Cc: Karol Gugala Cc: Mateusz Holenko Cc: Gabriel Somlo Cc: Joel Stanley Cc: Greg Kroah-Hartman Acked-by: Gabriel Somlo --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-6.0.orig/drivers/tty/serial/Kconfig +++ linux-6.0/drivers/tty/serial/Kconfig @@ -1519,7 +1519,7 @@ config SERIAL_MILBEAUT_USIO_CONSOLE config SERIAL_LITEUART tristate "LiteUART serial port support" depends on HAS_IOMEM - depends on OF || COMPILE_TEST + depends on OF depends on LITEX || COMPILE_TEST select SERIAL_CORE help --=20 Jean Delvare SUSE L3 Support