From nobody Fri Mar 29 10:57:21 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A955AC433FE for ; Thu, 24 Nov 2022 14:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbiKXOoH (ORCPT ); Thu, 24 Nov 2022 09:44:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiKXOoE (ORCPT ); Thu, 24 Nov 2022 09:44:04 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E25ECCDC; Thu, 24 Nov 2022 06:44:02 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E5E5021AA9; Thu, 24 Nov 2022 14:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669301040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RSDxCIZj7tP6iDUeSK5bmzG9DBH4ukrgrNleI3RTxE4=; b=laECmwk+hSEsA59l592NOPSYuVa6/2QEtY41YRV6ec4hGKFiawqycHJQ8JkarnS3kdA639 LPIRjVQSjEn5ByBYHfXtuDbks6+hYSK+O34nVEffb9wdSS8K4ncai8RxlbChZZAomeqbOz 7FWhyUKdmozAxUsvyUo63FuNfFMagoE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669301040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RSDxCIZj7tP6iDUeSK5bmzG9DBH4ukrgrNleI3RTxE4=; b=tMRinWGU3xkK1Sk9EQfROj8VNADPWQdWoqbiOsBhN2hxBK4nqfbGdc1a3svnJxTlfTYKld SUIRhrYNPEB7c9CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B8F4513488; Thu, 24 Nov 2022 14:44:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hUWGKzCDf2OtUAAAMHmgww (envelope-from ); Thu, 24 Nov 2022 14:44:00 +0000 Date: Thu, 24 Nov 2022 15:43:59 +0100 From: Jean Delvare To: linux-rtc@vger.kernel.org, LKML Cc: Alessandro Zummo , Alexandre Belloni Subject: [PATCH] rtc: isl12026: drop obsolete dependency on COMPILE_TEST Message-ID: <20221124154359.039be06c@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues. Signed-off-by: Jean Delvare Cc: Alessandro Zummo Cc: Alexandre Belloni --- drivers/rtc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-6.0.orig/drivers/rtc/Kconfig +++ linux-6.0/drivers/rtc/Kconfig @@ -432,7 +432,7 @@ config RTC_DRV_ISL12022 =20 config RTC_DRV_ISL12026 tristate "Intersil ISL12026" - depends on OF || COMPILE_TEST + depends on OF help If you say yes here you get support for the Intersil ISL12026 RTC chip. --=20 Jean Delvare SUSE L3 Support