From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DE3C4332F for ; Tue, 22 Nov 2022 20:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234760AbiKVUMx (ORCPT ); Tue, 22 Nov 2022 15:12:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234753AbiKVUMq (ORCPT ); Tue, 22 Nov 2022 15:12:46 -0500 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B96326452 for ; Tue, 22 Nov 2022 12:12:38 -0800 (PST) Received: from NTHCCAS01.nuvoton.com (NTHCCAS01.nuvoton.com [10.1.8.28]) by maillog.nuvoton.com (Postfix) with ESMTP id 534581C81189; Wed, 23 Nov 2022 04:12:37 +0800 (CST) Received: from NTHCCAS03.nuvoton.com (10.1.20.28) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 23 Nov 2022 04:12:37 +0800 Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCCAS03.nuvoton.com (10.1.20.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1847.3; Wed, 23 Nov 2022 04:12:36 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Wed, 23 Nov 2022 04:12:36 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id BDD6363A1B; Tue, 22 Nov 2022 22:12:35 +0200 (IST) From: Tomer Maimon To: , , , , , , , , , , , , , , , CC: , , , Tomer Maimon Subject: [PATCH v1 1/2] dt-binding: soc: nuvoton: Add NPCM BPC LPC documentation Date: Tue, 22 Nov 2022 22:12:31 +0200 Message-ID: <20221122201232.107065-2-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20221122201232.107065-1-tmaimon77@gmail.com> References: <20221122201232.107065-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post Code (BPC). The NPCM BPC monitoring two configurable I/O addresses written by the host on Low Pin Count (LPC) bus. Signed-off-by: Tomer Maimon --- .../bindings/soc/nuvoton/npcm-lpc-bpc.yaml | 112 ++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/nuvoton/npcm-lpc-= bpc.yaml diff --git a/Documentation/devicetree/bindings/soc/nuvoton/npcm-lpc-bpc.yam= l b/Documentation/devicetree/bindings/soc/nuvoton/npcm-lpc-bpc.yaml new file mode 100644 index 000000000000..2c8e66546891 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/nuvoton/npcm-lpc-bpc.yaml @@ -0,0 +1,112 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/nuvoton/npcm-lpc-bpc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton Low Pin Count (LPC) Bus Controller + +maintainers: + - Tomer Maimon + +description: + The Low Pin Count (LPC) is a low bandwidth bus that is used to connect + peripherals around the CPU and to replace the Industry Standard Architec= ture + (ISA) bus. + + The Nuvoton NPCM LPC bus is a bridge of host CPU to a several of periphe= ral + devices. + +properties: + compatible: + items: + - enum: + - nuvoton,npcm750-lpc + - nuvoton,npcm845-lpc + - const: simple-mfd + - const: syscon + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: true + +patternProperties: + "^lpc_bpc@[0-9a-f]+$": + type: object + additionalProperties: false + + description: + Nuvoton BMC NPCM BIOS Post Code (BPC) monitoring two configurable I/O + addresses written by the host on the Low Pin Count (LPC) bus, the ca= pure + data stored in 128-word FIFO. + + NPCM BPC supports capture double words, when using capture + double word only I/O address 1 is monitored. + + properties: + compatible: + items: + - enum: + - nuvoton,npcm750-lpc-bpc + - nuvoton,npcm845-lpc-bpc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + nuvoton,monitor-ports: + $ref: /schemas/types.yaml#/definitions/uint32-array + description:=20 + Contain monitor I/O addresses, at least one monitor I/O address=20 + required. + + nuvoton,bpc-en-dwcapture: + description: If present, Enable capture double words support. + type: boolean + + required: + - compatible + - reg + - interrupts + - nuvoton,monitor-ports + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - ranges + +additionalProperties: + type: object + +examples: + - | + #include + #include + + lpc: lpc@f0007000 { + compatible =3D "nuvoton,npcm750-lpc", "simple-mfd", "syscon"; + reg =3D <0xf0007000 0x1000>; + + #address-cells =3D <1>; + #size-cells =3D <1>; + ranges =3D <0x0 0xf0007000 0x1000>; + + lpc_snoop: lpc-snoop@40 { + compatible =3D "nuvoton,npcm750-lpc-bpc"; + reg =3D <0x40 0x20>; + interrupts =3D ; + nuvoton,monitor-ports =3D <0x80>; + }; + }; +... --=20 2.33.0 From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C3CC433FE for ; Tue, 22 Nov 2022 20:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234797AbiKVUNB (ORCPT ); Tue, 22 Nov 2022 15:13:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234719AbiKVUMr (ORCPT ); Tue, 22 Nov 2022 15:12:47 -0500 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BA46E6544 for ; Tue, 22 Nov 2022 12:12:38 -0800 (PST) Received: from NTHCCAS04.nuvoton.com (NTHCCAS04.nuvoton.com [10.1.8.29]) by maillog.nuvoton.com (Postfix) with ESMTP id D38C71C8125F; Wed, 23 Nov 2022 04:12:37 +0800 (CST) Received: from NTHCCAS03.nuvoton.com (10.1.20.28) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 23 Nov 2022 04:12:37 +0800 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCCAS03.nuvoton.com (10.1.20.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 23 Nov 2022 04:12:37 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS01.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2375.7 via Frontend Transport; Wed, 23 Nov 2022 04:12:37 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 4474B63A20; Tue, 22 Nov 2022 22:12:36 +0200 (IST) From: Tomer Maimon To: , , , , , , , , , , , , , , , CC: , , , Tomer Maimon Subject: [PATCH v1 2/2] soc: nuvoton: add NPCM LPC BPC driver Date: Tue, 22 Nov 2022 22:12:32 +0200 Message-ID: <20221122201232.107065-3-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20221122201232.107065-1-tmaimon77@gmail.com> References: <20221122201232.107065-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add Nuvoton BMC NPCM LPC BIOS post code (BPC) driver. The NPCM BPC monitoring two configurable I/O address written by the host on the Low Pin Count (LPC) bus. Signed-off-by: Tomer Maimon --- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/nuvoton/Kconfig | 24 ++ drivers/soc/nuvoton/Makefile | 3 + drivers/soc/nuvoton/npcm-lpc-bpc.c | 396 +++++++++++++++++++++++++++++ 5 files changed, 425 insertions(+) create mode 100644 drivers/soc/nuvoton/Kconfig create mode 100644 drivers/soc/nuvoton/Makefile create mode 100644 drivers/soc/nuvoton/npcm-lpc-bpc.c diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig index e461c071189b..f17764a7e588 100644 --- a/drivers/soc/Kconfig +++ b/drivers/soc/Kconfig @@ -15,6 +15,7 @@ source "drivers/soc/ixp4xx/Kconfig" source "drivers/soc/litex/Kconfig" source "drivers/soc/mediatek/Kconfig" source "drivers/soc/microchip/Kconfig" +source "drivers/soc/nuvoton/Kconfig" source "drivers/soc/pxa/Kconfig" source "drivers/soc/qcom/Kconfig" source "drivers/soc/renesas/Kconfig" diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index 69ba6508cf2c..9f9250685485 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -20,6 +20,7 @@ obj-$(CONFIG_SOC_XWAY) +=3D lantiq/ obj-$(CONFIG_LITEX_SOC_CONTROLLER) +=3D litex/ obj-y +=3D mediatek/ obj-y +=3D microchip/ +obj-y +=3D nuvoton/ obj-y +=3D pxa/ obj-y +=3D amlogic/ obj-y +=3D qcom/ diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig new file mode 100644 index 000000000000..9f92b8380f2a --- /dev/null +++ b/drivers/soc/nuvoton/Kconfig @@ -0,0 +1,24 @@ +# SPDX-License-Identifier: GPL-2.0-only + +if ARCH_NPCM || COMPILE_TEST + +menu "NUVOTON SoC drivers" + +config NPCM_LPC_BPC + tristate "NPCM LPC BIOS Post Code support" + depends on (ARCH_NPCM || COMPILE_TEST) + help + Provides a NPCM driver to control the LPC BIOS Post Code + interface which allows the BMC to monitoring and save + the data written by the host to an arbitrary LPC I/O port. + +config NPCM_PCI_MBOX + tristate "NPCM PCI Mailbox Controller" + depends on (ARCH_NPCM || COMPILE_TEST) && REGMAP && MFD_SYSCON + help + Expose the NPCM BMC PCI MBOX registers found on Nuvoton SOCs + to userspace. + +endmenu + +endif diff --git a/drivers/soc/nuvoton/Makefile b/drivers/soc/nuvoton/Makefile new file mode 100644 index 000000000000..b44b044ca335 --- /dev/null +++ b/drivers/soc/nuvoton/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_NPCM_LPC_BPC) +=3D npcm-lpc-bpc.o +obj-$(CONFIG_NPCM_PCI_MBOX) +=3D npcm-pci-mbox.o diff --git a/drivers/soc/nuvoton/npcm-lpc-bpc.c b/drivers/soc/nuvoton/npcm-= lpc-bpc.c new file mode 100644 index 000000000000..42ac94f9ddf9 --- /dev/null +++ b/drivers/soc/nuvoton/npcm-lpc-bpc.c @@ -0,0 +1,396 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2020 Nuvoton Technology corporation. + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define DEVICE_NAME "npcm-lpc-bpc" + +#define NUM_BPC_CHANNELS 2 +#define DW_PAD_SIZE 3 + +/* BIOS POST Code FIFO Registers */ +#define NPCM_BPCFA2L_REG 0x2 //BIOS POST Code FIFO Address 2 LSB +#define NPCM_BPCFA2M_REG 0x4 //BIOS POST Code FIFO Address 2 MSB +#define NPCM_BPCFEN_REG 0x6 //BIOS POST Code FIFO Enable +#define NPCM_BPCFSTAT_REG 0x8 //BIOS POST Code FIFO Status +#define NPCM_BPCFDATA_REG 0xA //BIOS POST Code FIFO Data +#define NPCM_BPCFMSTAT_REG 0xC //BIOS POST Code FIFO Miscellaneous Status +#define NPCM_BPCFA1L_REG 0x10 //BIOS POST Code FIFO Address 1 LSB +#define NPCM_BPCFA1M_REG 0x12 //BIOS POST Code FIFO Address 1 MSB + +/* BIOS regiser data */ +#define FIFO_IOADDR1_ENABLE 0x80 +#define FIFO_IOADDR2_ENABLE 0x40 + +/* BPC interface package and structure definition */ +#define BPC_KFIFO_SIZE 0x400 + +/* BPC regiser data */ +#define FIFO_DATA_VALID 0x80 +#define FIFO_OVERFLOW 0x20 +#define FIFO_READY_INT_ENABLE 0x8 +#define FIFO_DWCAPTURE 0x4 +#define FIFO_ADDR_DECODE 0x1 + +/* Host Reset */ +#define HOST_RESET_INT_ENABLE 0x10 +#define HOST_RESET_CHANGED 0x40 + +struct npcm_bpc_channel { + struct npcm_bpc *data; + struct kfifo fifo; + wait_queue_head_t wq; + bool host_reset; + struct miscdevice miscdev; +}; + +struct npcm_bpc { + void __iomem *base; + struct device *dev; + int irq; + bool en_dwcap; + struct npcm_bpc_channel ch[NUM_BPC_CHANNELS]; +}; + +static struct npcm_bpc_channel *npcm_file_to_ch(struct file *file) +{ + return container_of(file->private_data, struct npcm_bpc_channel, + miscdev); +} + +static ssize_t npcm_bpc_read(struct file *file, char __user *buffer, + size_t count, loff_t *ppos) +{ + struct npcm_bpc_channel *chan =3D npcm_file_to_ch(file); + struct npcm_bpc *lpc_bpc =3D chan->data; + unsigned int copied; + int cond_size =3D 1; + int ret =3D 0; + + if (lpc_bpc->en_dwcap) + cond_size =3D 3; + + if (kfifo_len(&chan->fifo) < cond_size) { + if (file->f_flags & O_NONBLOCK) + return -EAGAIN; + + ret =3D wait_event_interruptible + (chan->wq, kfifo_len(&chan->fifo) > cond_size); + if (ret =3D=3D -ERESTARTSYS) + return -EINTR; + } + + ret =3D kfifo_to_user(&chan->fifo, buffer, count, &copied); + + return ret ? ret : copied; +} + +static __poll_t npcm_bpc_poll(struct file *file, struct poll_table_struct = *pt) +{ + struct npcm_bpc_channel *chan =3D npcm_file_to_ch(file); + __poll_t mask =3D 0; + + poll_wait(file, &chan->wq, pt); + if (!kfifo_is_empty(&chan->fifo)) + mask |=3D POLLIN; + + if (chan->host_reset) { + mask |=3D POLLHUP; + chan->host_reset =3D false; + } + + return mask; +} + +static const struct file_operations npcm_bpc_fops =3D { + .owner =3D THIS_MODULE, + .read =3D npcm_bpc_read, + .poll =3D npcm_bpc_poll, + .llseek =3D noop_llseek, +}; + +static irqreturn_t npcm_bpc_irq(int irq, void *arg) +{ + struct npcm_bpc *lpc_bpc =3D arg; + u8 fifo_st, host_st, data; + bool isr_flag =3D false; + u8 last_addr_bit =3D 0; + u8 padzero[3] =3D {0}; + u8 addr_index =3D 0; + + fifo_st =3D ioread8(lpc_bpc->base + NPCM_BPCFSTAT_REG); + while (FIFO_DATA_VALID & fifo_st) { + /* If dwcapture enabled only channel 0 (FIFO 0) used */ + if (!lpc_bpc->en_dwcap) + addr_index =3D fifo_st & FIFO_ADDR_DECODE; + else + last_addr_bit =3D fifo_st & FIFO_ADDR_DECODE; + + /* Read data from FIFO to clear interrupt */ + data =3D ioread8(lpc_bpc->base + NPCM_BPCFDATA_REG); + if (kfifo_is_full(&lpc_bpc->ch[addr_index].fifo)) + kfifo_skip(&lpc_bpc->ch[addr_index].fifo); + kfifo_put(&lpc_bpc->ch[addr_index].fifo, data); + if (fifo_st & FIFO_OVERFLOW) + dev_warn(lpc_bpc->dev, "BIOS Post Codes FIFO Overflow\n"); + + fifo_st =3D ioread8(lpc_bpc->base + NPCM_BPCFSTAT_REG); + if (lpc_bpc->en_dwcap && last_addr_bit) { + if ((fifo_st & FIFO_ADDR_DECODE) || + ((FIFO_DATA_VALID & fifo_st) =3D=3D 0)) { + while (kfifo_avail(&lpc_bpc->ch[addr_index].fifo) < DW_PAD_SIZE) + kfifo_skip(&lpc_bpc->ch[addr_index].fifo); + kfifo_in(&lpc_bpc->ch[addr_index].fifo, + padzero, DW_PAD_SIZE); + } + } + isr_flag =3D true; + } + + host_st =3D ioread8(lpc_bpc->base + NPCM_BPCFMSTAT_REG); + if (host_st & HOST_RESET_CHANGED) { + iowrite8(HOST_RESET_CHANGED, + lpc_bpc->base + NPCM_BPCFMSTAT_REG); + lpc_bpc->ch[addr_index].host_reset =3D true; + isr_flag =3D true; + } + + if (isr_flag) { + wake_up_interruptible(&lpc_bpc->ch[addr_index].wq); + return IRQ_HANDLED; + } + + return IRQ_NONE; +} + +static int npcm_bpc_config_irq(struct npcm_bpc *lpc_bpc, + struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + int rc; + + lpc_bpc->irq =3D platform_get_irq(pdev, 0); + if (lpc_bpc->irq < 0) { + dev_err(dev, "get IRQ failed\n"); + return lpc_bpc->irq; + } + + rc =3D devm_request_irq(dev, lpc_bpc->irq, + npcm_bpc_irq, IRQF_SHARED, + DEVICE_NAME, lpc_bpc); + if (rc < 0) { + dev_warn(dev, "Unable to request IRQ %d\n", lpc_bpc->irq); + return rc; + } + + return 0; +} + +static int npcm_enable_bpc(struct npcm_bpc *lpc_bpc, struct device *dev, + int channel, u16 lpc_port) +{ + u8 addr_en, reg_en; + int err; + + init_waitqueue_head(&lpc_bpc->ch[channel].wq); + + err =3D kfifo_alloc(&lpc_bpc->ch[channel].fifo, BPC_KFIFO_SIZE, + GFP_KERNEL); + if (err) + return err; + + lpc_bpc->ch[channel].miscdev.minor =3D MISC_DYNAMIC_MINOR; + lpc_bpc->ch[channel].miscdev.name =3D + devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME, channel); + lpc_bpc->ch[channel].miscdev.fops =3D &npcm_bpc_fops; + lpc_bpc->ch[channel].miscdev.parent =3D dev; + err =3D misc_register(&lpc_bpc->ch[channel].miscdev); + if (err) + return err; + + lpc_bpc->ch[channel].data =3D lpc_bpc; + lpc_bpc->ch[channel].host_reset =3D false; + + /* Enable LPC snoop channel at requested port */ + switch (channel) { + case 0: + addr_en =3D FIFO_IOADDR1_ENABLE; + iowrite8((u8)lpc_port & 0xFF, + lpc_bpc->base + NPCM_BPCFA1L_REG); + iowrite8((u8)(lpc_port >> 8), + lpc_bpc->base + NPCM_BPCFA1M_REG); + break; + case 1: + addr_en =3D FIFO_IOADDR2_ENABLE; + iowrite8((u8)lpc_port & 0xFF, + lpc_bpc->base + NPCM_BPCFA2L_REG); + iowrite8((u8)(lpc_port >> 8), + lpc_bpc->base + NPCM_BPCFA2M_REG); + break; + default: + return -EINVAL; + } + + if (lpc_bpc->en_dwcap) + addr_en =3D FIFO_DWCAPTURE; + + /* + * Enable FIFO Ready Interrupt, FIFO Capture of I/O addr, + * and Host Reset + */ + reg_en =3D ioread8(lpc_bpc->base + NPCM_BPCFEN_REG); + iowrite8(reg_en | addr_en | FIFO_READY_INT_ENABLE | + HOST_RESET_INT_ENABLE, lpc_bpc->base + NPCM_BPCFEN_REG); + + return 0; +} + +static void npcm_disable_bpc(struct npcm_bpc *lpc_bpc, int channel) +{ + u8 reg_en; + + switch (channel) { + case 0: + reg_en =3D ioread8(lpc_bpc->base + NPCM_BPCFEN_REG); + if (lpc_bpc->en_dwcap) + iowrite8(reg_en & ~FIFO_DWCAPTURE, + lpc_bpc->base + NPCM_BPCFEN_REG); + else + iowrite8(reg_en & ~FIFO_IOADDR1_ENABLE, + lpc_bpc->base + NPCM_BPCFEN_REG); + break; + case 1: + reg_en =3D ioread8(lpc_bpc->base + NPCM_BPCFEN_REG); + iowrite8(reg_en & ~FIFO_IOADDR2_ENABLE, + lpc_bpc->base + NPCM_BPCFEN_REG); + break; + default: + return; + } + + if (!(reg_en & (FIFO_IOADDR1_ENABLE | FIFO_IOADDR2_ENABLE))) + iowrite8(reg_en & + ~(FIFO_READY_INT_ENABLE | HOST_RESET_INT_ENABLE), + lpc_bpc->base + NPCM_BPCFEN_REG); + + kfifo_free(&lpc_bpc->ch[channel].fifo); + misc_deregister(&lpc_bpc->ch[channel].miscdev); +} + +static int npcm_bpc_probe(struct platform_device *pdev) +{ + struct npcm_bpc *lpc_bpc; + struct device_node *np; + struct device *dev; + u32 port; + int err; + + dev =3D &pdev->dev; + + lpc_bpc =3D devm_kzalloc(dev, sizeof(*lpc_bpc), GFP_KERNEL); + if (!lpc_bpc) + return -ENOMEM; + + np =3D pdev->dev.parent->of_node; + if (!of_device_is_compatible(np, "nuvoton,npcm750-lpc") && + !of_device_is_compatible(np, "nuvoton,npcm845-lpc")) { + dev_err(dev, "unsupported LPC device binding\n"); + return -ENODEV; + } + + lpc_bpc->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(lpc_bpc->base)) + return PTR_ERR(lpc_bpc->base); + + dev_set_drvdata(&pdev->dev, lpc_bpc); + + err =3D of_property_read_u32_index(dev->of_node, "nuvoton,monitor-ports", + 0, &port); + if (err) { + dev_err(dev, "no monitor ports configured\n"); + return -ENODEV; + } + + lpc_bpc->en_dwcap =3D + of_property_read_bool(dev->of_node, "nuvoton,bpc-en-dwcapture"); + + lpc_bpc->dev =3D dev; + + err =3D npcm_bpc_config_irq(lpc_bpc, pdev); + if (err) + return err; + + err =3D npcm_enable_bpc(lpc_bpc, dev, 0, port); + if (err) { + dev_err(dev, "Enable BIOS post code I/O port 0 failed\n"); + return err; + } + + /* + * Configuration of second BPC channel port is optional + * Double-Word Capture ignoring address 2 + */ + if (!lpc_bpc->en_dwcap) { + if (of_property_read_u32_index(dev->of_node, + "nuvoton,monitor-ports", 1, + &port) =3D=3D 0) { + err =3D npcm_enable_bpc(lpc_bpc, dev, 1, port); + if (err) { + dev_err(dev, "Enable BIOS post code I/O port 1 failed, disable I/O por= t 0\n"); + npcm_disable_bpc(lpc_bpc, 0); + return err; + } + } + } + + pr_info("NPCM BIOS Post Code probe\n"); + + return err; +} + +static int npcm_bpc_remove(struct platform_device *pdev) +{ + struct npcm_bpc *lpc_bpc =3D dev_get_drvdata(&pdev->dev); + u8 reg_en; + + reg_en =3D ioread8(lpc_bpc->base + NPCM_BPCFEN_REG); + + if (reg_en & FIFO_IOADDR1_ENABLE) + npcm_disable_bpc(lpc_bpc, 0); + if (reg_en & FIFO_IOADDR2_ENABLE) + npcm_disable_bpc(lpc_bpc, 1); + + return 0; +} + +static const struct of_device_id npcm_bpc_match[] =3D { + { .compatible =3D "nuvoton,npcm750-lpc-bpc" }, + { .compatible =3D "nuvoton,npcm845-lpc-bpc" }, + { }, +}; + +static struct platform_driver npcm_bpc_driver =3D { + .driver =3D { + .name =3D DEVICE_NAME, + .of_match_table =3D npcm_bpc_match, + }, + .probe =3D npcm_bpc_probe, + .remove =3D npcm_bpc_remove, +}; + +module_platform_driver(npcm_bpc_driver); + +MODULE_DEVICE_TABLE(of, npcm_bpc_match); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Tomer Maimon "); +MODULE_DESCRIPTION("NPCM LPC BIOS post code monitoring device driver"); --=20 2.33.0