From nobody Wed Apr 15 23:30:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C59C433FE for ; Tue, 22 Nov 2022 12:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233034AbiKVMGR (ORCPT ); Tue, 22 Nov 2022 07:06:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232588AbiKVMGO (ORCPT ); Tue, 22 Nov 2022 07:06:14 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13B052FFE1 for ; Tue, 22 Nov 2022 04:06:13 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NGjdK0qYLzmVvB; Tue, 22 Nov 2022 20:05:41 +0800 (CST) Received: from huawei.com (10.175.100.227) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 20:06:10 +0800 From: Shang XiaoJing To: , , , CC: Subject: [PATCH] comedi: drivers: pcl730: Fix potential memory leak in pcl730_attach() Date: Tue, 22 Nov 2022 20:04:28 +0800 Message-ID: <20221122120428.25069-1-shangxiaojing@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.100.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pcl730_attach() calls comedi_request_region() and won't release the resource allocated by alloc_resource() when pcl730_attach() failed latter. Add release_region() to prevent memory leak. Fixes: 6f9aa29b47f6 ("staging: comedi: pcl730: use comedi_request_region()") Signed-off-by: Shang XiaoJing --- drivers/comedi/drivers/pcl730.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/pcl730.c b/drivers/comedi/drivers/pcl73= 0.c index d2733cd5383d..c463de8a14e1 100644 --- a/drivers/comedi/drivers/pcl730.c +++ b/drivers/comedi/drivers/pcl730.c @@ -274,8 +274,14 @@ static int pcl730_attach(struct comedi_device *dev, return ret; =20 ret =3D comedi_alloc_subdevices(dev, board->n_subdevs); - if (ret) + if (ret) { + if (dev->iobase && dev->iolen) { + release_region(dev->iobase, dev->iolen); + dev->iobase =3D 0; + dev->iolen =3D 0; + } return ret; + } =20 subdev =3D 0; =20 --=20 2.17.1