From nobody Wed Apr 15 23:30:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A218C4332F for ; Tue, 22 Nov 2022 09:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232991AbiKVJ2d (ORCPT ); Tue, 22 Nov 2022 04:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232672AbiKVJ20 (ORCPT ); Tue, 22 Nov 2022 04:28:26 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2349E2792E for ; Tue, 22 Nov 2022 01:28:25 -0800 (PST) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NGf3K2pZLzqSQ0; Tue, 22 Nov 2022 17:24:29 +0800 (CST) Received: from dggpemm500013.china.huawei.com (7.185.36.172) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 17:28:23 +0800 Received: from ubuntu1804.huawei.com (10.67.175.36) by dggpemm500013.china.huawei.com (7.185.36.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 17:28:23 +0800 From: Chen Zhongjin To: , CC: , , Subject: [PATCH] fs/ntfs3: Fix leaked mount_options if fill_super failed Date: Tue, 22 Nov 2022 17:25:18 +0800 Message-ID: <20221122092518.231347-1-chenzhongjin@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.36] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500013.china.huawei.com (7.185.36.172) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" '9b75450d6c58 ("fs/ntfs3: Fix memory leak if fill_super failed")' Previous patch fixed leaked sbi when fill_super failed but forgot to put mount_options and left it leaked as kmemleak reported: unreferenced object 0xffff888107c353c0 (size 32): backtrace: [<00000000cf2c8c32>] kmalloc_trace+0x27/0x110 [<000000000184a864>] ntfs_init_fs_context+0x4c/0x540 [ntfs3] [<000000008ded85aa>] alloc_fs_context+0x50e/0x940 [<00000000c225e601>] path_mount+0x747/0x1930 [<000000007bf15a5f>] do_mount+0xf3/0x110 ... unreferenced object 0xffff888101fdc2d0 (size 8): backtrace: [<00000000d0cba437>] __kmalloc_node_track_caller+0x4c/0x1c0 [<00000000923513f8>] kmemdup_nul+0x37/0xb0 [<000000007a9b98ed>] vfs_parse_fs_string+0xc5/0x150 [<00000000afbd0594>] generic_parse_monolithic+0x140/0x1c0 [<00000000e97e814e>] path_mount+0xf09/0x1930 [<000000007bf15a5f>] do_mount+0xf3/0x110 ... Fixes: 610f8f5a7baf ("fs/ntfs3: Use new api for mounting") Signed-off-by: Chen Zhongjin --- fs/ntfs3/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 47012c9bf505..c0e45f170701 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -1281,6 +1281,7 @@ static int ntfs_fill_super(struct super_block *sb, st= ruct fs_context *fc) * Free resources here. * ntfs_fs_free will be called with fc->s_fs_info =3D NULL */ + put_mount_options(sbi->options); put_ntfs(sbi); sb->s_fs_info =3D NULL; =20 --=20 2.17.1