From nobody Fri Apr 17 10:23:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD4BC433FE for ; Sun, 20 Nov 2022 03:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiKTDDc (ORCPT ); Sat, 19 Nov 2022 22:03:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbiKTDD0 (ORCPT ); Sat, 19 Nov 2022 22:03:26 -0500 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FFCFB4073; Sat, 19 Nov 2022 19:03:25 -0800 (PST) Received: by mail-qv1-xf35.google.com with SMTP id k2so4808103qvo.1; Sat, 19 Nov 2022 19:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7dgDVBDG6kzNE0blQ38U8xpFqH7Lw5NDB8g90LgKm+A=; b=EI54pAD+yJy7v+Mc23XDBveyc3bFPpAJ6zNKS6GDjG1jtjGaruNQte+4PV0tHwUaot noQXn1NkMcjfcyU20nKhR/gfVYvSHSdGUw+8f5nYg/mKzDeSpH4RXI+50Qllsa68NafZ +KdGCCjj7RtWVeMI1TSUt0dYO4vBe21t0SaKwXJoMWn9gzVQ5BXNX8xuN77oCTe/Bb8L omaQ+y3YIh8WaNrtKoX2hej9/LDlNuxqKO5sfdH0z15otjILrbtfEdL03ByR7HZaIuYY pRi6Pm5V/Ok9znogEOB3Bpo9iRZu6UdDMUVAxE7ZNhHOcDK3CB/spUCGF4BOsBnDkvsY C5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7dgDVBDG6kzNE0blQ38U8xpFqH7Lw5NDB8g90LgKm+A=; b=z3woHmJHEAumZqqeJHBtAzH+L+fgJeqalo/OjOGh1k224hdiU+p1zw1s/ge6Hbgcv5 U3f/7aJnY/4/99GFD3YlsRVbwY+bUdiMf2VGXu5F5mxXFffy9nZmspjrEsZNlcegCjfe jRYLOuCwRqedVZ7UQstz+BOmItD6JwZCTtfbae6Pmdcvnn5L3XhKIAmEhy7+bVRdFAWo ocmDqma5rypwsrkc/xJ8qAUJWowIcA9WgvF2XTSnnyFcpfWhg6d7NIJG+ctICzdNkvFN zSDbynrwj66qpJkNN06bGfN87bUnqEJi4eRkmLxhrJtYd5tRc75R5koqbJTNNh7EhwUc BcjA== X-Gm-Message-State: ANoB5pkUwrXOsihMkO+mxMh7ODDSo71Qzq96AcPjfILIIpf74LwKVKXh /KgGSr/vfJgKq5Mb5Wosgdk= X-Google-Smtp-Source: AA0mqf5G/cKxHVeXYjxJ/6dJ80KVaF8PojHDWBvTH12a05gNqFaILG/pt5n07XyeKn/b9pIwWh4IfQ== X-Received: by 2002:a0c:cdc6:0:b0:4c6:9069:97d3 with SMTP id a6-20020a0ccdc6000000b004c6906997d3mr10671736qvn.106.1668913404706; Sat, 19 Nov 2022 19:03:24 -0800 (PST) Received: from shaak.. (modemcable055.92-163-184.mc.videotron.ca. [184.163.92.55]) by smtp.gmail.com with ESMTPSA id u8-20020ac80508000000b0039cc47752casm4522423qtg.77.2022.11.19.19.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Nov 2022 19:03:24 -0800 (PST) From: Liam Beguin To: Liam Beguin , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: [PATCH v1 1/4] clk: lmk04832: declare variables as const when possible Date: Sat, 19 Nov 2022 22:02:54 -0500 Message-Id: <20221120030257.531153-2-liambeguin@gmail.com> X-Mailer: git-send-email 2.37.1.223.g6a475b71f8c4 In-Reply-To: <20221120030257.531153-1-liambeguin@gmail.com> References: <20221120030257.531153-1-liambeguin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following warning reported by the kernel test robot. cppcheck possible warnings: (new ones prefixed by >>, may not real problem= s) >> drivers/clk/clk-lmk04832.c:357:15: warning: Variable 'pll2_p' can be de= clared with const [constVariable] unsigned int pll2_p[] =3D {8, 2, 2, 3, 4, 5, 6, 7}; Reported-by: kernel test robot Link: https://lore.kernel.org/all/202203312017.5YW13Jr4-lkp@intel.com/ Signed-off-by: Liam Beguin --- drivers/clk/clk-lmk04832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index f416f8bc2898..9d18fd23bea0 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -371,7 +371,7 @@ static unsigned long lmk04832_vco_recalc_rate(struct cl= k_hw *hw, unsigned long prate) { struct lmk04832 *lmk =3D container_of(hw, struct lmk04832, vco); - unsigned int pll2_p[] =3D {8, 2, 2, 3, 4, 5, 6, 7}; + const unsigned int pll2_p[] =3D {8, 2, 2, 3, 4, 5, 6, 7}; unsigned int pll2_n, p, pll2_r; unsigned int pll2_misc; unsigned long vco_rate; @@ -633,7 +633,7 @@ static int lmk04832_register_vco(struct lmk04832 *lmk) =20 static int lmk04832_clkout_set_ddly(struct lmk04832 *lmk, int id) { - int dclk_div_adj[] =3D {0, 0, -2, -2, 0, 3, -1, 0}; + const int dclk_div_adj[] =3D {0, 0, -2, -2, 0, 3, -1, 0}; unsigned int sclkx_y_ddly =3D 10; unsigned int dclkx_y_ddly; unsigned int dclkx_y_div; --=20 2.37.1.223.g6a475b71f8c4 From nobody Fri Apr 17 10:23:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE166C4332F for ; Sun, 20 Nov 2022 03:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbiKTDDi (ORCPT ); Sat, 19 Nov 2022 22:03:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbiKTDD2 (ORCPT ); Sat, 19 Nov 2022 22:03:28 -0500 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E609B4071; Sat, 19 Nov 2022 19:03:26 -0800 (PST) Received: by mail-qt1-x835.google.com with SMTP id a27so5500198qtw.10; Sat, 19 Nov 2022 19:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e5y5SYwuSDLQh4zh9qXh26loAgAEz0UdAAjWmFJDPZA=; b=k6Ujwuh+Eqstr/7J8LWSr3KYFnxzJsemkS3ajM5CSU3VxSzzS4Aw24FNkMRO9nSmf4 RPmJrAlvHGn9aYQO+CKp68DaoO3FvPfJrsY2q/MEe358X93du+icRDr4p26hUL0An/nn 6xEkZEWTKYf2f1NbGc3G+yQivwPJ7XFZiV2CnnOYG8oi0/OMxVeruegfxnOK+ORP1nCm /s/HjPHrV617AGFNumYjcb/HLRIW3PdX8H+YIv+upSUYqyDKgWzOAGnzlOj28MqTFyfV 9Pb46tQ55VatN1slAnb1IFumY2a9cXaZD/6wpeM9Ajwy1ETkf43yAwmBws4MOEbrAYXw vZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e5y5SYwuSDLQh4zh9qXh26loAgAEz0UdAAjWmFJDPZA=; b=UryWTNrKZNmMmvA5BUkIRYMimcpIyi7T3FQo6DZwH0GiLdgyXDdlEYWWRAHjsO0+qs 8HTcstmq7oAsWB5vgxBXupSdLeThOuHOpLRO3VOYFPWC2uUxH/QrZZksF2/Zl+vtB9Uc oJrGCgU2Jr5RPQmrTHOJEMo/v2vEqY4ey0M8VeOiDOBkBcu8+6r3eNczGIfBd5HAFHb5 Ikbm6LHEp95v6r70IEp4Fj2OB3H9p0hR5BHy3J3EG0xtYPn0HRcoQgv69J4YntBCAvZf TqD9tOYAl+j7xGhR/emzKJPMYSPSnG8CZr0BJKp0BWuZc0X6qs8gifI8bqAYIqrX8KqN 5m/w== X-Gm-Message-State: ANoB5pmA0OQVx/krfQq3A2xYcgpSXAiDQ2cTCZzZtojCe/Y4nCO3GyN1 CDfGEtP/sgIWEdo5Dh+EHrw= X-Google-Smtp-Source: AA0mqf6VkNKkZa0DC3muw2lCH7lnwgg1OK8EfeXvZUQnkJjaa1USibl4Bq84PwJN/2yegWq1KgZqfw== X-Received: by 2002:ac8:5e95:0:b0:3a5:50c6:bdc6 with SMTP id r21-20020ac85e95000000b003a550c6bdc6mr12631443qtx.370.1668913405609; Sat, 19 Nov 2022 19:03:25 -0800 (PST) Received: from shaak.. (modemcable055.92-163-184.mc.videotron.ca. [184.163.92.55]) by smtp.gmail.com with ESMTPSA id u8-20020ac80508000000b0039cc47752casm4522423qtg.77.2022.11.19.19.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Nov 2022 19:03:25 -0800 (PST) From: Liam Beguin To: Liam Beguin , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/4] clk: lmk04832: drop unnecessary semicolons Date: Sat, 19 Nov 2022 22:02:55 -0500 Message-Id: <20221120030257.531153-3-liambeguin@gmail.com> X-Mailer: git-send-email 2.37.1.223.g6a475b71f8c4 In-Reply-To: <20221120030257.531153-1-liambeguin@gmail.com> References: <20221120030257.531153-1-liambeguin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Semicolons on the closing brace of a function definition are unnecessary, remove them. Signed-off-by: Liam Beguin --- drivers/clk/clk-lmk04832.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index 9d18fd23bea0..3a5961fe604d 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -282,7 +282,7 @@ static bool lmk04832_regmap_rd_regs(struct device *dev,= unsigned int reg) default: return false; }; -}; +} =20 static bool lmk04832_regmap_wr_regs(struct device *dev, unsigned int reg) { @@ -305,7 +305,7 @@ static bool lmk04832_regmap_wr_regs(struct device *dev,= unsigned int reg) default: return false; }; -}; +} =20 static const struct regmap_config regmap_config =3D { .name =3D "lmk04832", @@ -403,7 +403,7 @@ static unsigned long lmk04832_vco_recalc_rate(struct cl= k_hw *hw, pll2_misc)) * pll2_n * pll2_p[p] / pll2_r; =20 return vco_rate; -}; +} =20 /** * lmk04832_check_vco_ranges - Check requested VCO frequency against VCO r= anges @@ -509,7 +509,7 @@ static long lmk04832_vco_round_rate(struct clk_hw *hw, = unsigned long rate, return -EINVAL; =20 return vco_rate; -}; +} =20 static int lmk04832_vco_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long prate) @@ -568,7 +568,7 @@ static int lmk04832_vco_set_rate(struct clk_hw *hw, uns= igned long rate, =20 return regmap_write(lmk->regmap, LMK04832_REG_PLL2_N_2, FIELD_GET(0x0000ff, n)); -}; +} =20 static const struct clk_ops lmk04832_vco_ops =3D { .is_enabled =3D lmk04832_vco_is_enabled, @@ -1063,7 +1063,7 @@ static unsigned long lmk04832_dclk_recalc_rate(struct= clk_hw *hw, rate =3D DIV_ROUND_CLOSEST(prate, dclk_div); =20 return rate; -}; +} =20 static long lmk04832_dclk_round_rate(struct clk_hw *hw, unsigned long rate, unsigned long *prate) @@ -1085,7 +1085,7 @@ static long lmk04832_dclk_round_rate(struct clk_hw *h= w, unsigned long rate, return -EINVAL; =20 return dclk_rate; -}; +} =20 static int lmk04832_dclk_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long prate) @@ -1147,7 +1147,7 @@ static int lmk04832_dclk_set_rate(struct clk_hw *hw, = unsigned long rate, dev_err(lmk->dev, "SYNC sequence failed\n"); =20 return ret; -}; +} =20 static const struct clk_ops lmk04832_dclk_ops =3D { .is_enabled =3D lmk04832_dclk_is_enabled, @@ -1551,6 +1551,7 @@ static void lmk04832_remove(struct spi_device *spi) clk_disable_unprepare(lmk->oscin); of_clk_del_provider(spi->dev.of_node); } + static const struct spi_device_id lmk04832_id[] =3D { { "lmk04832", LMK04832 }, {} --=20 2.37.1.223.g6a475b71f8c4 From nobody Fri Apr 17 10:23:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78755C4332F for ; Sun, 20 Nov 2022 03:03:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbiKTDDe (ORCPT ); Sat, 19 Nov 2022 22:03:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiKTDD2 (ORCPT ); Sat, 19 Nov 2022 22:03:28 -0500 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84BE0B4818; Sat, 19 Nov 2022 19:03:27 -0800 (PST) Received: by mail-qv1-xf36.google.com with SMTP id k2so4808146qvo.1; Sat, 19 Nov 2022 19:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w3ZLtBm0Tp52wW3OyBwZ0ioH8NSv4clGJ5jYAcXM5gw=; b=XHDKLERdcxFQ0lj0gT0uZxwu/30BC7yb/XW6E+bvfB5MqpvtemUHXVenGrZ/H8UD8m P1D8qSou4V8iZ/nb82QcjeYKIQWDT3DfuC+lUH0clTpnLTtZ4EhRuIuK/gerPGMoENER lxA5ixluy2/+I+nE1skdJ4Mcj1rgCAkz8ELXA31uWvdxWyRMNekFpvN0xg5Ajkm5kKNX 2AtLgk4zTjPCLoAFwVQfqdNf83tkROZSvy0PNgHd9UdQ7bnDahNs3v1zEPxCLC0CuvyD 0k696xdq77fINUaDo773/xsFooXsdiwyhXW7DdRlQRnqQtj9naoYVpIMvVsmEoaegfRg 1rSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w3ZLtBm0Tp52wW3OyBwZ0ioH8NSv4clGJ5jYAcXM5gw=; b=yhnxrqdSspYGKCnrpWlfx3cVnuDqDGoLnjZlWS6geSwF/n+u9q+ClIB9wFed0hvPGW TrThGYDh3uLMhNShGIijNqhEKuVY2Q+lCuh3cjOY8eKeB3ax/1PcOkuuxvx1FPoBEtZY Hrov7tj9OuFfZFwRY4uscJ09rDQ8JDtQA0sP0aJOnlBCWRFLKujVccaUPEz09vFGv0Sc TTmUALTGcyQctJ7CPoE2/YGQAyGRfDtnyNW+M7Fk3kJ9gOFnNIyG11kS+h1oKrfnAnMP wqo81+vB1B8gL33aCoJf/rGAhM0NDjCz32WYdAPOhlqJ0LBgz9+kxq3gUTDc7avn49i1 eyfA== X-Gm-Message-State: ANoB5pnPWQ9Ww5NmZj/XoWYsvuw3PsD0ZKKMuJIOy0ZEK39+hxq2RjZy 4BYemWYSg7yvAPP1Ls5AHbRfRbKu5qE= X-Google-Smtp-Source: AA0mqf4m7Lsl7R1/c+qcevJF27vxxJNFNsEdhENVdw12h2UnaJTbrRt2vFdFr6ld4C5IWuljGIdplQ== X-Received: by 2002:ad4:5343:0:b0:4b1:8165:58da with SMTP id v3-20020ad45343000000b004b1816558damr12706647qvs.30.1668913406515; Sat, 19 Nov 2022 19:03:26 -0800 (PST) Received: from shaak.. (modemcable055.92-163-184.mc.videotron.ca. [184.163.92.55]) by smtp.gmail.com with ESMTPSA id u8-20020ac80508000000b0039cc47752casm4522423qtg.77.2022.11.19.19.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Nov 2022 19:03:26 -0800 (PST) From: Liam Beguin To: Liam Beguin , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: [PATCH v1 3/4] clk: lmk04832: drop superfluous #include Date: Sat, 19 Nov 2022 22:02:56 -0500 Message-Id: <20221120030257.531153-4-liambeguin@gmail.com> X-Mailer: git-send-email 2.37.1.223.g6a475b71f8c4 In-Reply-To: <20221120030257.531153-1-liambeguin@gmail.com> References: <20221120030257.531153-1-liambeguin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" iwyu warnings: (new ones prefixed by >>) >> drivers/clk/clk-lmk04832.c:15:1: iwyu: warning: superfluous #include >> drivers/clk/clk-lmk04832.c:20:1: iwyu: warning: superfluous #include Reported-by: kernel test robot Link: https://lore.kernel.org/all/202107110620.926Sm95z-lkp@intel.com/ Signed-off-by: Liam Beguin --- drivers/clk/clk-lmk04832.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index 3a5961fe604d..7e01370fb6d4 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -12,12 +12,10 @@ #include #include #include -#include #include #include #include #include -#include #include #include =20 --=20 2.37.1.223.g6a475b71f8c4 From nobody Fri Apr 17 10:23:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CB2C433FE for ; Sun, 20 Nov 2022 03:03:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229482AbiKTDDm (ORCPT ); Sat, 19 Nov 2022 22:03:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiKTDDa (ORCPT ); Sat, 19 Nov 2022 22:03:30 -0500 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41FD2B4823; Sat, 19 Nov 2022 19:03:28 -0800 (PST) Received: by mail-qt1-x82a.google.com with SMTP id a27so5500215qtw.10; Sat, 19 Nov 2022 19:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ecmtg8Xz1vo78RX1IEc/ka9eYTVT7RxfN8Rs3E8/0cY=; b=g2uGY9p5ZdSLTLsXOhHdUd2vdjxbsAfaQPLrYP/r7kpXa9ON0jSONjY1n+mhNMl/A1 BtuX3Sr6Cxrz0PnlzAgHXk+HKtbe3NqHDWulqObV5JUY7QSYRd+p55aGqQyX1tGPbNsl G1HnKevwRSY2mQo05/1xUVOgTuPtyNfBGQRl9JatpjTQg4HtpvOBcmVOsR5dc0yocEA6 YK8fujpmscdbONh0IfdPPQMbTGeJNuP+39soAVgVznt33g7+uwoXiDWk8mOdsMAmDIpx kDxqfPiOBPVi7rD9K3gUcgldmpzq8nNoNNMvHZofJSDUl7SA6y/fSoErkcOcXkfhw9g4 ytlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ecmtg8Xz1vo78RX1IEc/ka9eYTVT7RxfN8Rs3E8/0cY=; b=uLPXTDbff9QNKC+8eD/WE0IdAGPWtkwex6I3wKjEifDmECavzzm26jlGrKTdcAAS// xUrriJGv4VoC2SmmE1bv7c3VYQckAoo+6oatGr2E/97KDkQwa6ao6cFCAesyeVxWfM+e 1zVJpDDrHQVeQFYxeWL54u5pwx9+yvw7RZB4dc2QD6+CmRgsDbi4hDrTnqAO6vt8+PZr QuNGBbDk5JSH2B86lndRrLgktzK4NAP2118wHVMqkxMA4W4DkwfJ636qwO4IvWwrWX8Q jlTaP2m4h3uCxcX/b45ycogvEiXaH2FoHUU3OOI1Mb1Y6CvS5HTjeqBrGBCbLb6bUY8j OjaQ== X-Gm-Message-State: ANoB5pmMYv6leJ5Ysb4TSITRYeIK4Hdu0YTVYm1Fg1HH40v6beveRNdG wRbjE4xnsqs5nyGJoP99/D4= X-Google-Smtp-Source: AA0mqf6LQqwRM7kBSkQmtdPhpc0QfAcgBntu0c160jXag+6d6vSVgHQN9+PE7mk+8gHwagCB3zi7Zw== X-Received: by 2002:ac8:5c03:0:b0:3a5:3979:23f0 with SMTP id i3-20020ac85c03000000b003a5397923f0mr12599783qti.216.1668913407408; Sat, 19 Nov 2022 19:03:27 -0800 (PST) Received: from shaak.. (modemcable055.92-163-184.mc.videotron.ca. [184.163.92.55]) by smtp.gmail.com with ESMTPSA id u8-20020ac80508000000b0039cc47752casm4522423qtg.77.2022.11.19.19.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Nov 2022 19:03:26 -0800 (PST) From: Liam Beguin To: Liam Beguin , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 4/4] clk: lmk04832: fix kernel-doc warnings Date: Sat, 19 Nov 2022 22:02:57 -0500 Message-Id: <20221120030257.531153-5-liambeguin@gmail.com> X-Mailer: git-send-email 2.37.1.223.g6a475b71f8c4 In-Reply-To: <20221120030257.531153-1-liambeguin@gmail.com> References: <20221120030257.531153-1-liambeguin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix syntax generating the following kernel-doc warnings: drivers/clk/clk-lmk04832.c:189: warning: cannot understand function prototy= pe: 'struct lmk04832_device_info ' drivers/clk/clk-lmk04832.c:193: warning: Function parameter or member 'pid'= not described in 'lmk04832_device_info' drivers/clk/clk-lmk04832.c:193: warning: Function parameter or member 'mask= rev' not described in 'lmk04832_device_info' drivers/clk/clk-lmk04832.c:193: warning: Function parameter or member 'num_= channels' not described in 'lmk04832_device_info' drivers/clk/clk-lmk04832.c:193: warning: Function parameter or member 'vco0= _range' not described in 'lmk04832_device_info' drivers/clk/clk-lmk04832.c:193: warning: Function parameter or member 'vco1= _range' not described in 'lmk04832_device_info' drivers/clk/clk-lmk04832.c:420: warning: No description found for return va= lue of 'lmk04832_check_vco_ranges' drivers/clk/clk-lmk04832.c:459: warning: No description found for return va= lue of 'lmk04832_calc_pll2_params' Signed-off-by: Liam Beguin --- drivers/clk/clk-lmk04832.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index 7e01370fb6d4..57485356de4c 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -175,14 +175,14 @@ enum lmk04832_device_types { }; =20 /** - * lmk04832_device_info - Holds static device information that is specific= to - * the chip revision + * struct lmk04832_device_info - Holds static device information that is + * specific to the chip revision * - * pid: Product Identifier - * maskrev: IC version identifier - * num_channels: Number of available output channels (clkout count) - * vco0_range: {min, max} of the VCO0 operating range (in MHz) - * vco1_range: {min, max} of the VCO1 operating range (in MHz) + * @pid: Product Identifier + * @maskrev: IC version identifier + * @num_channels: Number of available output channels (clkout count) + * @vco0_range: {min, max} of the VCO0 operating range (in MHz) + * @vco1_range: {min, max} of the VCO1 operating range (in MHz) */ struct lmk04832_device_info { u16 pid; @@ -412,7 +412,7 @@ static unsigned long lmk04832_vco_recalc_rate(struct cl= k_hw *hw, * The LMK04832 has 2 internal VCO, each with independent operating ranges. * Use the device_info structure to determine which VCO to use based on ra= te. * - * Returns VCO_MUX value or negative errno. + * Returns: VCO_MUX value or negative errno. */ static int lmk04832_check_vco_ranges(struct lmk04832 *lmk, unsigned long r= ate) { @@ -449,7 +449,7 @@ static int lmk04832_check_vco_ranges(struct lmk04832 *l= mk, unsigned long rate) * * VCO =3D OSCin * 2 * PLL2_N * PLL2_P / PLL2_R * - * Returns vco rate or negative errno. + * Returns: vco rate or negative errno. */ static long lmk04832_calc_pll2_params(unsigned long prate, unsigned long r= ate, unsigned int *n, unsigned int *p, --=20 2.37.1.223.g6a475b71f8c4