From nobody Wed Apr 15 19:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BE9C433FE for ; Thu, 17 Nov 2022 16:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239976AbiKQQAm (ORCPT ); Thu, 17 Nov 2022 11:00:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233179AbiKQQAe (ORCPT ); Thu, 17 Nov 2022 11:00:34 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E47E92D7 for ; Thu, 17 Nov 2022 08:00:33 -0800 (PST) Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C16BA1056; Thu, 17 Nov 2022 17:00:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700832; bh=n9ynhpvE53d3DCniGxgFDJ475k0hql5R70rDpcyDJxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SSTy3PdldKbcq8IWLceXcm5WjdtdV/nOZ5QfeVQQorJiFWqjP8MVE7WyllL+DJNmP wE4UfHnKnB++iPrcSLCj3bDW1G3DtHVqj1iDB/lrM7CC12u14gI6bzk8cb/8O8C2t5 fI/YHGqVNM5uxbcnVxKRxwjjkqoK9t4t0ToCE8yE= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Dan Carpenter , Greg Kroah-Hartman , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 1/3] Revert "staging: mmal-vchiq: Avoid use of bool in structures" Date: Thu, 17 Nov 2022 21:30:13 +0530 Message-Id: <20221117160015.344528-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117160015.344528-1-umang.jain@ideasonboard.com> References: <20221117160015.344528-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This reverts commit 640e77466e69d9c28de227bc76881f5501f532ca. In commit 7967656ffbfa ("coding-style: Clarify the expectations around bool") the check to dis-allow bool structure members was removed from checkpatch.pl. It promotes bool structure members to store boolean values. This enhances code readability. Signed-off-by: Umang Jain --- .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 12 ++++++------ .../staging/vc04_services/vchiq-mmal/mmal-vchiq.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index cb921c94996a..4abb6178cb9f 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -863,9 +863,9 @@ static int port_info_get(struct vchiq_mmal_instance *in= stance, goto release_msg; =20 if (rmsg->u.port_info_get_reply.port.is_enabled =3D=3D 0) - port->enabled =3D 0; + port->enabled =3D false; else - port->enabled =3D 1; + port->enabled =3D true; =20 /* copy the values out of the message */ port->handle =3D rmsg->u.port_info_get_reply.port_handle; @@ -1304,7 +1304,7 @@ static int port_disable(struct vchiq_mmal_instance *i= nstance, if (!port->enabled) return 0; =20 - port->enabled =3D 0; + port->enabled =3D false; =20 ret =3D port_action_port(instance, port, MMAL_MSG_PORT_ACTION_TYPE_DISABLE); @@ -1359,7 +1359,7 @@ static int port_enable(struct vchiq_mmal_instance *in= stance, if (ret) goto done; =20 - port->enabled =3D 1; + port->enabled =3D true; =20 if (port->buffer_cb) { /* send buffer headers to videocore */ @@ -1531,7 +1531,7 @@ int vchiq_mmal_port_connect_tunnel(struct vchiq_mmal_= instance *instance, pr_err("failed disconnecting src port\n"); goto release_unlock; } - src->connected->enabled =3D 0; + src->connected->enabled =3D false; src->connected =3D NULL; } =20 @@ -1799,7 +1799,7 @@ int vchiq_mmal_component_disable(struct vchiq_mmal_in= stance *instance, =20 ret =3D disable_component(instance, component); if (ret =3D=3D 0) - component->enabled =3D 0; + component->enabled =3D false; =20 mutex_unlock(&instance->vchiq_mutex); =20 diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.h index 6006e29232b3..70eda6cac1c6 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h @@ -48,7 +48,7 @@ typedef void (*vchiq_mmal_buffer_cb)( int status, struct mmal_buffer *buffer); =20 struct vchiq_mmal_port { - u32 enabled:1; + bool enabled:1; u32 handle; u32 type; /* port type, cached to use on port info set */ u32 index; /* port index, cached to use on port info set */ @@ -83,7 +83,7 @@ struct vchiq_mmal_port { =20 struct vchiq_mmal_component { u32 in_use:1; - u32 enabled:1; + bool enabled:1; u32 handle; /* VideoCore handle for component */ u32 inputs; /* Number of input ports */ u32 outputs; /* Number of output ports */ --=20 2.38.1 From nobody Wed Apr 15 19:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F34C4332F for ; Thu, 17 Nov 2022 16:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234609AbiKQQAr (ORCPT ); Thu, 17 Nov 2022 11:00:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239654AbiKQQAl (ORCPT ); Thu, 17 Nov 2022 11:00:41 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0765913D44 for ; Thu, 17 Nov 2022 08:00:38 -0800 (PST) Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 03B7D133C; Thu, 17 Nov 2022 17:00:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700837; bh=JDyW2hzBjXtCPuLRQW6K0nYPrFiaE+Knjz7OMb7YeCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GbhODj6iiGEgRSu9rTpEpm8hgEd04o/j8lstv9znuQDIJM2AvFkXQ2CTme/Xs3UDu SNdRsGlOAahqsWbNNDdRy8FiQHtm7BmLzgT/z2XrDG5b/i1kS9vFj4i08zGGKeBYG3 EnJQbychWK4/Bhx/s1njWyVuUdemz9L2kljwIOjI= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Dan Carpenter , Greg Kroah-Hartman , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 2/3] vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use Date: Thu, 17 Nov 2022 21:30:14 +0530 Message-Id: <20221117160015.344528-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117160015.344528-1-umang.jain@ideasonboard.com> References: <20221117160015.344528-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In commit 7967656ffbfa ("coding-style: Clarify the expectations around bool") the check to dis-allow bool structure members was removed from checkpatch.pl. It promotes bool structure members to store boolean values. This enhances code readability. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 6 +++--- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 4abb6178cb9f..294b184d4a49 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1648,7 +1648,7 @@ int vchiq_mmal_component_init(struct vchiq_mmal_insta= nce *instance, for (idx =3D 0; idx < VCHIQ_MMAL_MAX_COMPONENTS; idx++) { if (!instance->component[idx].in_use) { component =3D &instance->component[idx]; - component->in_use =3D 1; + component->in_use =3D true; break; } } @@ -1724,7 +1724,7 @@ int vchiq_mmal_component_init(struct vchiq_mmal_insta= nce *instance, destroy_component(instance, component); unlock: if (component) - component->in_use =3D 0; + component->in_use =3D false; mutex_unlock(&instance->vchiq_mutex); =20 return ret; @@ -1747,7 +1747,7 @@ int vchiq_mmal_component_finalise(struct vchiq_mmal_i= nstance *instance, =20 ret =3D destroy_component(instance, component); =20 - component->in_use =3D 0; + component->in_use =3D false; =20 mutex_unlock(&instance->vchiq_mutex); =20 diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.h index 70eda6cac1c6..c5be86b0479d 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h @@ -82,7 +82,7 @@ struct vchiq_mmal_port { }; =20 struct vchiq_mmal_component { - u32 in_use:1; + bool in_use:1; bool enabled:1; u32 handle; /* VideoCore handle for component */ u32 inputs; /* Number of input ports */ --=20 2.38.1 From nobody Wed Apr 15 19:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21A8C4332F for ; Thu, 17 Nov 2022 16:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233502AbiKQQBC (ORCPT ); Thu, 17 Nov 2022 11:01:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239989AbiKQQAp (ORCPT ); Thu, 17 Nov 2022 11:00:45 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DA1538A8 for ; Thu, 17 Nov 2022 08:00:43 -0800 (PST) Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CC745929; Thu, 17 Nov 2022 17:00:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700842; bh=1DYpqsXvXsGG5IOvxeeijtQCtN/gvWpP1KZhKnLeIbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Swk4StMfC87C4+EHNtHps8Zsm2j+XMV36WOhsHH2IDlV0p4FtZWLFnZh30co8Uk3+ TqZolGoofnEbvlq7GVz/B1koaxITxDxKocWiklCxhMTXfbWerF19KP1SL44gEeGDOM 669rva9SqVKPAJetExlV5w9KTLO6YrdgwGxUHNzI= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Dan Carpenter , Greg Kroah-Hartman , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 3/3] vc04_services: bcm2835-camera: Use bool values for mmal_fmt.remove_padding Date: Thu, 17 Nov 2022 21:30:15 +0530 Message-Id: <20221117160015.344528-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117160015.344528-1-umang.jain@ideasonboard.com> References: <20221117160015.344528-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" struct mmal_fmt.remove_padding is defined as a boolean type hence, use boolean values for it instead of 0/1 integers. This enhances code readability. Signed-off-by: Umang Jain --- .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index fd456d1f7061..797ebe2a973a 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -87,21 +87,21 @@ static struct mmal_fmt formats[] =3D { .depth =3D 12, .mmal_component =3D COMP_CAMERA, .ybbp =3D 1, - .remove_padding =3D 1, + .remove_padding =3D true, }, { .fourcc =3D V4L2_PIX_FMT_YUYV, .mmal =3D MMAL_ENCODING_YUYV, .depth =3D 16, .mmal_component =3D COMP_CAMERA, .ybbp =3D 2, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_RGB24, .mmal =3D MMAL_ENCODING_RGB24, .depth =3D 24, .mmal_component =3D COMP_CAMERA, .ybbp =3D 3, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_JPEG, .flags =3D V4L2_FMT_FLAG_COMPRESSED, @@ -109,7 +109,7 @@ static struct mmal_fmt formats[] =3D { .depth =3D 8, .mmal_component =3D COMP_IMAGE_ENCODE, .ybbp =3D 0, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_H264, .flags =3D V4L2_FMT_FLAG_COMPRESSED, @@ -117,7 +117,7 @@ static struct mmal_fmt formats[] =3D { .depth =3D 8, .mmal_component =3D COMP_VIDEO_ENCODE, .ybbp =3D 0, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_MJPEG, .flags =3D V4L2_FMT_FLAG_COMPRESSED, @@ -125,63 +125,63 @@ static struct mmal_fmt formats[] =3D { .depth =3D 8, .mmal_component =3D COMP_VIDEO_ENCODE, .ybbp =3D 0, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_YVYU, .mmal =3D MMAL_ENCODING_YVYU, .depth =3D 16, .mmal_component =3D COMP_CAMERA, .ybbp =3D 2, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_VYUY, .mmal =3D MMAL_ENCODING_VYUY, .depth =3D 16, .mmal_component =3D COMP_CAMERA, .ybbp =3D 2, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_UYVY, .mmal =3D MMAL_ENCODING_UYVY, .depth =3D 16, .mmal_component =3D COMP_CAMERA, .ybbp =3D 2, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_NV12, .mmal =3D MMAL_ENCODING_NV12, .depth =3D 12, .mmal_component =3D COMP_CAMERA, .ybbp =3D 1, - .remove_padding =3D 1, + .remove_padding =3D true, }, { .fourcc =3D V4L2_PIX_FMT_BGR24, .mmal =3D MMAL_ENCODING_BGR24, .depth =3D 24, .mmal_component =3D COMP_CAMERA, .ybbp =3D 3, - .remove_padding =3D 0, + .remove_padding =3D false, }, { .fourcc =3D V4L2_PIX_FMT_YVU420, .mmal =3D MMAL_ENCODING_YV12, .depth =3D 12, .mmal_component =3D COMP_CAMERA, .ybbp =3D 1, - .remove_padding =3D 1, + .remove_padding =3D true, }, { .fourcc =3D V4L2_PIX_FMT_NV21, .mmal =3D MMAL_ENCODING_NV21, .depth =3D 12, .mmal_component =3D COMP_CAMERA, .ybbp =3D 1, - .remove_padding =3D 1, + .remove_padding =3D true, }, { .fourcc =3D V4L2_PIX_FMT_BGR32, .mmal =3D MMAL_ENCODING_BGRA, .depth =3D 32, .mmal_component =3D COMP_CAMERA, .ybbp =3D 4, - .remove_padding =3D 0, + .remove_padding =3D false, }, }; =20 @@ -1147,7 +1147,7 @@ static int mmal_setup_components(struct bcm2835_mmal_= dev *dev, struct vchiq_mmal_port *port =3D NULL, *camera_port =3D NULL; struct vchiq_mmal_component *encode_component =3D NULL; struct mmal_fmt *mfmt =3D get_format(f); - u32 remove_padding; + bool remove_padding; =20 if (!mfmt) return -EINVAL; --=20 2.38.1